4488 Commits (3.0.4)

Author	SHA1	Message	Date
Javier Jaramago Fernández	64b16172c7	Change 'COM_STMT_EXECUTE' params length decoding ... According to MySQL protocol, variable length strings are encoded using length encoded integers. For reference, see: - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_com_stmt_execute.html - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_basic_dt_integers.html#a_protocol_type_int2 The protocol specifies that values greater than 2^24 (16777216) should be encoded using '0xFE + 8-byte integer'. Yet, in reality MySQL ignores the upper section of these 8-byte integers, treating them effectively like '4-bytes'. For the sake of compatibility this commit changes the decoding behavior for 'COM_STMT_EXECUTE' to match MySQL one. This different is subtle but important, since in practice MySQL itself doesn't use the '8 bytes' from the field. This means that connectors that are compatible with MySQL could find issues when sending these packets through ProxySQL (like NodeJS 'mysql2' connector which writes the 8-bytes as a 4-bytes duplication, motivating these changes), situation that could result in rejection due to malformed packet detection (or crashes/invalid handling in the worse case scenario). The previous decoding function is now renamed into 'mysql_decode_length_ll' to honor MySQL naming 'net_field_length_ll'. For now, this protocol change is limited to 'COM_STMT_EXECUTE'.	6 months ago
Javier Jaramago Fernández	e35973b226	Add boundary checks in 'MySQL_Protocol::get_binds_from_pkt' ... These checks should prevent crashes when packets are received holding invalid lengths in the processed params.	6 months ago
René Cannaò	4fa3bf6a91	Merge pull request #5191 from sysown/v3.0-fix_proclist_use_after_free ... Fix heap-after-use between `PROXYSQL INTERNAL SESSION` and `SHOW PROCESSLIST`	6 months ago
René Cannaò	dfd46fee4b	Merge pull request #5150 from proton-lisandro-pin/ignore_min_gtid ... Implement a `ignore_min_gtid_annotation` global variable, fix memory leak/overflow in `min_gtid` annotation handler.	6 months ago
René Cannaò	8be91071ef	Merge pull request #5190 from sysown/v3.0_default_interface_global_var_5189 ... Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	6 months ago
René Cannaò	c06e15fd74	Merge pull request #5192 from sysown/v3.0_add_delay_watchdog ... Improved PgSQL/MySQL Thread Watchdog Unit Test	6 months ago
Rene Cannao	f803a1d419	Increase sid on caching_sha2 full authentication ... caching_sha2_password full authentication is a complex task that requires a lot of packets being sent and forth between client and server (ProxySQL in this case). Every packet needs to have an increased sequence ID (sid) according to protocol. ProxySQL was incorrectly forgetting to increase the sid when requesting a full authentication. For some clients this is not a problem, while other clients will consider the incorrect sid a serious issue and abort the connection. This commit ensures that sid is correctly increased when requesting caching_sha2_password full authentication.	6 months ago
Lisandro Pin	6cb522283d	Implement a ignore_min_gtid_annotation global variable for ProxySQL ... When true, all `min_gtid` query annotations are ignored; see https://proxysql.com/documentation/query-annotations/ for details. This is useful on ProxySQL setups with multiple layers, where some layers mandate GTID-based routing while others don't.	6 months ago
Rahim Kanji	48928ce04e	Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	6 months ago
Rahim Kanji	86c17f04d7	Replace single sleep with looped delay for simulated watchdog test	6 months ago
Rahim Kanji	3c79800a45	Add delay - WatchDog test	6 months ago
Javier Jaramago Fernández	4b28bb6ced	Fix heap-after-use between 'PROXYSQL INTERNAL SESSION' and 'SHOW PROCESSLIST' ... Missing query cleanup in 'PROXYSQL INTERNAL SESSION' could lead to invalid memory accesses during 'SHOW PROCESSLIST' sessions scan.	6 months ago
René Cannaò	4a6ba68357	Merge pull request #5173 from sysown/v3.0_admin_cmd_5170 ... Resolved issues with PROXYSQL PAUSE/RESUME/STOP/START	6 months ago
René Cannaò	a44dee127d	Merge pull request #5174 from sysown/v3.0_optimise_extended_query_response ... Removed unnecessary writeout()	6 months ago
Javier Jaramago Fernández	2668de77c2	Fix compilation warning for 'strncpy' due string truncation ... As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	6 months ago
Javier Jaramago Fernández	c0978f9371	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' (PgSQL) ... Accesses by 'stats___pgsql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	6 months ago
Javier Jaramago Fernández	67624b8569	Fix compilation warning for 'strncpy' due string truncation ... As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	6 months ago
Javier Jaramago Fernández	639f9d0c74	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' ... Accesses by 'stats___mysql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	6 months ago
Wazir Ahmed	8d1b5b597c	Revert "gtid: Refactor reconnect logic & prevent events_count reset" ... This reverts commit 0a70fd515f.	6 months ago
Rahim Kanji	8291361bc1	Removed unnecessary writeout()	6 months ago
Rahim Kanji	38befb845f	Fixed PROXYSQL STOP	6 months ago
Rahim Kanji	67d383de4e	Resolved issues with admin PROXYSQL PAUSE/RESUME commands	6 months ago
René Cannaò	5018cb66d9	Merge pull request #5168 from sysown/v3.0-debug_log_pass ... Allow to dump passwords used during auth in debug builds	6 months ago
René Cannaò	c6cbce34b1	Merge pull request #5117 from wazir-ahmed/gtid-reconn ... gtid: Refactor reconnect logic & prevent `events_count` reset	6 months ago
René Cannaò	360646b7d5	Merge pull request #5165 from sysown/crash-sqlite-max-len ... processlist: Prevent crash due to SQLITE_TOOBIG	6 months ago
Wazir Ahmed	5219d4be93	processlist: Prevent crash due to SQLITE_TOOBIG ... - Add new mysql/pgsql variable `processlist_max_query_length`. - Min: 1K - Max: 32M - Default: 2M - Truncate current query based on the configuration before inserting into `stats_*_processlist` tables. - Refactor/fix code related to other processlist configurations. 1. `session_idle_show_processlist` value was not updated in `ProxySQL_Admin.variables`. 2. Pass processlist config as an argument to `MySQL_Threads_Handler::SQL3_Processlist` instead of using thread-local variables. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	6 months ago
René Cannaò	7022833213	Merge pull request #5163 from sysown/v3.0_assert_to_warning ... verify_server_variables() -> Change assert to warning + Various improvements	6 months ago
Javier Jaramago Fernández	4304b995a3	Improve debug message with context dump (passwords) during auth handshake ... This message is dump with each call to 'process_pkt_handshake_response' printing the updated context. When the verbosity value for module 'debug_mysql_protocol' is >= 5, the stored and client supplied passwords will be dumped in HEX format, for values < 5, the passwords will be masked.	6 months ago
René Cannaò	436bcccc62	Merge pull request #5158 from sysown/v3.0.3-makefiles_cleanup ... V3.0.3 makefiles cleanup	6 months ago
Miro Stauder	d020f577b2	reduce duplication in makefiles, use include for common stuff	6 months ago
René Cannaò	562e98d551	Merge pull request #5130 from wazir-ahmed/stats-schema ... Remove `stats` schema name from the query in stats user session	6 months ago
Rahim Kanji	ed20d09b8a	Replaced std::get_if with std::visit	6 months ago
Rahim Kanji	91c674495a	Few fixes	6 months ago
René Cannaò	ccf72b606c	Merge pull request #5134 from wazir-ahmed/mysqldump ... Improve `mysqldump` compatibility	6 months ago
René Cannaò	3b4369bba9	Merge pull request #5113 from wazir-ahmed/load-from-config-validation ... Add validation for `LOAD * FROM CONFIG`	6 months ago
René Cannaò	9c7111d9e6	Merge pull request #5085 from wazir-ahmed/intercept-ssl-version ... Handle `SHOW STATUS LIKE 'Ssl_version'` in ProxySQL without any backend	6 months ago
Rahim Kanji	288b0da189	verify_server_variables -> Change assert to warning	6 months ago
Keith Brings	e4745f8ea0	Revert "Include "information_schema_stats_expiry" as a known setting"	6 months ago
René Cannaò	ecad6f9249	Merge pull request #5160 from sysown/v3.0_disable_pgsql_prometheus_5159 ... Separate Query Cache Metrics for MySQL and PostgreSQL & Disable Prometheus Metrics for PostgreSQL	6 months ago
René Cannaò	abafaccbc0	Merge pull request #5156 from sysown/v3.0_pgsql_stat_activity_issue_4682 ... Add backend_pid and backend_state to stats_pgsql_processlist and create stats_pgsql_stat_activity view	6 months ago
René Cannaò	73c15ba3ef	Merge pull request #5153 from sysown/v3.0_transaction_alias_support_5152 ... Add support for PostgreSQL transaction command aliases and ROLLBACK AND CHAIN	6 months ago
René Cannaò	01862a247a	Merge pull request #5149 from sysown/v3.0_track_search_path_param_5148 ... Add search_path parameter to tracked ProxySQL variables list - PgSQL	6 months ago
René Cannaò	413b0121a1	Merge pull request #5146 from sysown/v3.0_parameter_status_case_sensitive_issue_5145 ... Fix incorrect ParameterStatus key casing for DateStyle, TimeZone, and IntervalStyle	6 months ago
René Cannaò	42f6d9d74f	Merge pull request #5144 from sysown/v3.0_datestyle-parser-tweak ... Align DateStyle parsing with PostgreSQL	6 months ago
René Cannaò	2c9cea0014	Merge pull request #5143 from sysown/v3.0_fix-describe-portal-nodata-empty-query ... Fix: return NoData for Describe (Portal) before Execute on empty statement	6 months ago
René Cannaò	c5a0a0011f	Merge pull request #5137 from sysown/v3.0_pgsql_query_cancel_terminate_issue_5136 ... Implement Backend Query Cancellation and Backend Termination for PostgreSQL	6 months ago
René Cannaò	e5aba4db42	Merge pull request #5154 from sysown/v3.0.3-upgrade_deps ... V3.0.3 upgrade deps	6 months ago
Rahim Kanji	cb2062c1d1	Few fixes	6 months ago
Keith Brings	aaefac0ca4	Merge pull request #5142 from sysown/v3.0_bind_fmt_bug_fix_5140 ... Fixed: Invalid UTF-8 byte sequence error (0xff) when relaying text parameter followed by null parameter [Extended Query]	6 months ago
Keith Brings	9382dec4eb	Merge pull request #5129 from Confushion/include_settings_information_schema_stats_expiry ... Include "information_schema_stats_expiry" as a known setting	6 months ago