3879 Commits (2.6.6)

Author	SHA1	Message	Date
René Cannaò	bd7bd3571b	Merge pull request #4629 from sysown/v2.x-4628 ... Removing trailing semicolon from `USE` #4628	2 years ago
René Cannaò	c76dda60d5	Add check before trying to remove trailing spaces or semicolon	2 years ago
René Cannaò	645963af8e	Removing trailing semicolon from `USE` #4628 ... Trailing semicolon are now removed. This commit also ensure that an error is returned if `USE` is part of a multi-statement.	2 years ago
René Cannaò	58fa5ee5ec	Use uppercase in stats_mysql_query_digest.digest ... This fixes a regression introduced in 14ba7475d4 . Up to ProxySQL 2.5.1 , stats_mysql_query_digest.digest was uppercase . From ProxySQL 2.5.2 to 2.6.4 it became lowercase . This because we switched from: sprintf(... 0x16llX ...) to: ostringstream ... << "0x" << std::hex ...	2 years ago
Javier Jaramago Fernández	851a8850bc	Fix regression on 'COM_CHANGE_USER' for 'mysql_native_password' - Closes #4589 ... Fixes handing of 'COM_CHANGE_USER' for 'mysql_native_password' when using hashed user passwords.	2 years ago
René Cannaò	a52fd0b859	Merge pull request #4620 from sysown/v2.x-fix_connpool_metrics_init_val ... Fix value on first fetch for connpool prometheus metrics	2 years ago
René Cannaò	4edee6914c	Merge pull request #4619 from sysown/v2.x-fix_change_user_assert ... Fix assert for `COM_CHANGE_USER` packets with hashed password for 'caching_sha2_password'	2 years ago
Javier Jaramago Fernández	50a95d4080	Fix value on first fetch for connpool prometheus metrics ... The initial value for metrics using 'p_update_connection_pool_update_*' helpers were missing. This only affects to the first metrics fetch, during the metric creation on the internal maps, subsequent fetches will find the already created metric and updated the value properly. As real counters are internal, this doesn't affect the correctness of the value in subsequent fetches.	2 years ago
Javier Jaramago Fernández	8a93882d1d	Fix assert on COM_CHANGE_USER with hashed pass for 'caching_sha2_password' ... For now, we always reply with an auth failure until 'Auth Switch Support' is added for 'caching_sha2_password'.	2 years ago
Javier Jaramago Fernández	e1f99e8bea	Make logging of Galera nodes status conditional to 'mysql-hostgroup_manager_verbose' - Closes #4612	2 years ago
Chrysanthemum Swingler	87711456a5	Update Prometheus HELP statement for proxysql_connpool_conns_status	2 years ago
René Cannaò	1f4b0889dd	Merge pull request #4602 from sysown/v2.x-backend_conns_ssl_err_clear ... Fix SSL error queue cleanup for backend conns	2 years ago
Rene Cannao	c049c9268c	Cleanup code from previous commits	2 years ago
Rene Cannao	9f0af17249	Improved USE query parsing	2 years ago
Rene Cannao	eedb3978bf	WIP: improved USE query parsing	2 years ago
Rene Cannao	95fa15cdf9	Better parsing of USE queries sent with COM_QUERY #4598	2 years ago
Javier Jaramago Fernández	f3ea2e613e	Fix SSL error queue cleanup for backend conns ... The SSL error queue wasn't cleanup after an SSL related error took place in a backend connection. This would result in the propagation of the error to other conns handled by the thread, which could result in: - Incorrect destruction of connections in conn-pool. - Invalid error propagation to clients. This is a consequence of 'libmariadbclient' not performing a cleanup of this queue by itself. The situation got mitigated since the library **does** perform a cleanup of such queue during connect phase ('auth_caching_sha2_client|auth_sha256_client'), and ProxySQL does a cleanup of this queue during frontend SSL traffic.	2 years ago
Javier Jaramago Fernández	f260e2ee9f	Fix 'mysqld_error.h' include using deps path	2 years ago
Javier Jaramago Fernández	b91b6b8f9f	Add list of special permitted variables tracking errors - Closes #4591 ... This list hold tracking errors that in practice are equivalent to ER_UNKNOWN_SYSTEM_VARIABLE and that we want to handle in the same way.	2 years ago
Javier Jaramago Fernández	130d3fe04a	Issue warning when time interval variable gets rounded ... Variables specifying timing intervals, like 'stats_mysql_connections', may get rounded to the closer, valid time interval. Now a warning is issued for making the user aware of this rounding operation.	2 years ago
Javier Jaramago Fernández	05f7c42f9e	Improve context on 'MYSQL_OPT_NONBLOCK' for SSL connections	2 years ago
Javier Jaramago Fernández	eeaae2e758	Make 'proxy_debug_func' saves/restore 'errno' ... Several calls inside 'proxy_debug_func' (specially if database logging is enabled) could alter 'errno', which could influence error handling.	2 years ago
Javier Jaramago Fernández	d424e4f8a9	Replace commented 'proxy_info' with 'proxy_debug' in 'read_from_net'	2 years ago
Javier Jaramago Fernández	a0b947250f	Remove old commented code from 'read_from_net'	2 years ago
Javier Jaramago Fernández	ccfca5a3f9	Fix busy-wait on client SSL connection ... Errors and EOF returned by 'recv' are now properly handled, isolated from the return value ('r') from the later and conditional 'SSL_read'. Previously, a busy loop was possible in the following scenario: 1. A client connection was closed, leading to a return of 0 by 'recv', and 'errno' to be set with 'EAGAIN'. 2. Error handling is performed taking into account a never performed call to 'SSL_read' (as if this '0' was a result for this call). 3. The call to 'SSL_get_error' returns with 'SSL_ERROR_SYSCALL', as a result of using this invalid param of '0' (which for 'SSL_read' would mean non-retryable error), and the non-reset 'errno' would still be 'EAGAIN'. 4. This would create the illusion of an interrupted read. So a new read is tried again, while in reality the socket is closed. This busy loop will continue until 'POLLHUP' is received when we attempt to write back to the client and a 'RST' is received as a response.	2 years ago
René Cannaò	3ce6f99cfc	Merge pull request #4578 from nielsvogell/aws_auto-discovery_patch ... Disabling AWS RDS topology auto-discovery by default	2 years ago
Rene Cannao	29383c7d47	Initialize all_modules_started also for release	2 years ago
Niels Vogell	89a3247959	Adding a null-check on a MySQL query result and avoiding redundant string initialization	2 years ago
René Cannaò	9c3c6ca5a3	Check POLLHUP if unable to read anything from network ... This solves a possible infinite loop that arises after commit e81895e . Commit e81895e prevents closing connections in case of temporary failures, but on the other side it doesn't allow to close faulty connections.	2 years ago
Niels Vogell	7290f0bfb2	Fix a mixup in the default value of monitoring_read_only_interval	2 years ago
René Cannaò	e81895ed16	Improve stability in SSL connection getting SSL_ERROR_SYSCALL ... In case SSL connections get SSL_ERROR_SYSCALL , ERR_get_error() is called to verify if it is possible to perform again a call.	2 years ago
René Cannaò	01bb6e9a08	PRAGMA journal_mode=OFF on debug database ... PRAGMA journal_mode=OFF should drastically reduce CPU overhead	2 years ago
Niels Vogell	1b2982f5ab	Adding additional checks to only process discovered servers from an AWS RDS Multi-AZ DB Cluster	2 years ago
Niels Vogell	8154f4b330	Disable AWS RDS topology discovery by default with 0 as special value for the discovery interval	2 years ago
René Cannaò	d0ff320f86	Merge pull request #4561 from sysown/v2.6.x-update_to_openssl_3.3.1 ... update OpenSSL to v 3.3.1	2 years ago
René Cannaò	25f02a33ce	Merge pull request #4496 from sysown/v2.6.x-freebsd_fixes ... various FreeBSD related fixes	2 years ago
René Cannaò	bbd3d9f46a	Merge pull request #4570 from sysown/v2.x-4567 ... Fix memory leak during 'SAVE MYSQL USERS FROM RUNTIME' - Closes #4567	2 years ago
Javier Jaramago Fernández	f4b9d7b93d	Fix several overflows in 'ProxySQL_Cluster::pull_*' ops - Closes #4572	2 years ago
Javier Jaramago Fernández	188faae40d	Remove old commented/outdated code on 'ProxySQL_Admin'	2 years ago
Javier Jaramago Fernández	58778464b9	Fix memory leak during 'SAVE MYSQL USERS FROM RUNTIME' - Closes #4567	2 years ago
Miro Stauder	e7c336e12f	update OpenSSL to v 3.3.1	2 years ago
Javier Jaramago Fernández	9470923e6f	Fix assert on 'ldap' variables checksum computation	2 years ago
Javier Jaramago Fernández	7ec6e143d6	Merge pull request #4555 from joshuahunt/johunt/clear-ssl-error-queue-on-shutdown ... Clear SSL error queue on shutdown	2 years ago
René Cannaò	f7c0382f71	Merge pull request #4554 from sysown/v2.x-digest_spaces_fix ... Fix spaces removal on digests with control chars	2 years ago
Miro Stauder	6807d3a481	use local includes - libconfig	2 years ago
Miro Stauder	8394fd444e	use local includes - prometheus	2 years ago
Miro Stauder	7695c42534	use local include - openssl	2 years ago
Josh Hunt	2e4ef165fb	Clear SSL error queue on shutdown ... SSL_shutdown can return an error and if it is not cleared it will be left on the thread's error queue since they are thread local causing unrelated connections running on the same thread to be incorrectly terminated. Clear the error queue now if SSL_shutdown returns an error to keep us from impacting other connections.	2 years ago
Javier Jaramago Fernández	cf525c5b30	Fix typo on 'mysql_query_digest_and_first_comment_one_it' doc	2 years ago
Javier Jaramago Fernández	bee33cfc41	Fix spaces removal on digests with control chars ... Compression of multiple spaces into one should apply to every character that is considered a space by `is_space_char`.	2 years ago