5192 Commits (fe898113248735245cc0231c4e99dc4e740b644d)

Author	SHA1	Message	Date
Rene Cannao	fe89811324	fix(lib): eliminate remaining lib compiler warnings ... - Fix snprintf truncation in MySQL_Monitor ConsumerThread (%.15s for 16-byte buffer) - Mark unused safe_update_peer_info in ProxySQL_Cluster with __attribute__((unused)) - Remove unused start_time in GenAI_Thread::generate_embeddings - Remove unused now_iso() in Discovery_Schema	1 month ago
Rene Cannao	41956b8f4a	fix: eliminate macro redefinition, member init reorder, and format warnings ... - Remove duplicate MCP_QUERY_RULES/RUNTIME_MCP_QUERY_RULES macros from inside #ifdef PROXYSQLGENAI block (newer schema outside wins) - Fix member initialization order in MySQL_Tool_Handler and ProxySQL_MCP_Server constructors to match declaration order - Use %ld with (long) cast in LLM_Clients log macros to handle both int (literal 0) and long (http_code) arguments	1 month ago
Rene Cannao	2c4cc0c0d4	fix(lib): eliminate compiler warnings in core library files ... - Fix sign-compare warnings in ProxySQL_RESTAPI_Server (size_t vs int) - Remove duplicate itostr macro in Base_HostGroups_Manager, MySQL_HostGroups_Manager, PgSQL_HostGroups_Manager (already in proxysql_macros.h) - Mark unused 'thr' variable in Base_Thread::run_SetAllSession_ToProcess0 - Remove redundant query_no_space_alloc_size in Admin_Handler (use query_length directly) - Fix string literal to char* assignment in MySQL_HostGroups_Manager	1 month ago
Rene Cannao	9d8b7b0367	fix(lib): replace deprecated MD5_* API with EVP in PgSQL_Protocol ... OpenSSL 3.0 deprecated MD5_Init/MD5_Update/MD5_Final. Use EVP_MD_CTX family instead, following the same pattern as MySQL_encode.cpp.	1 month ago
René Cannaò	f7ee5cd028	Merge pull request #5614 from sysown/v3.0-pgsql-monitor-reschedule-on-interval-change ... fix(pgsql-monitor): clamp next_*_at on LOAD PGSQL VARIABLES TO RUNTIME	1 month ago
Rene Cannao	4bd2f95e5b	fix(pgsql-monitor): add proxy_debug logging and clean up test variable ... - Add proxy_debug(PROXY_DEBUG_MONITOR, 5) calls when clamping fires, so the fix is observable in debug logs. Follows existing pattern from nearby scheduling debug output. - Rename original_monitor_username to monitor_username and clarify it is for diagnostic logging only, since the variable is no longer used for restore after the credential change was removed.	1 month ago
Rene Cannao	e0a96d380e	chore: fix stale rembed reference and simplify test Makefile ... - Remove stale comment reference to rembed in AI_Features_Manager.cpp - Remove redundant ifeq/else/endif in anomaly_detection-t target (both branches identical after libsqlite_rembed.a removal)	1 month ago
Rene Cannao	3bcc1dd43f	build: drop libsqlite_rembed.a from src/lib link order	1 month ago
Rene Cannao	886f09c211	chore(sqlite): remove dead-code sqlite-rembed hook pointer ... proxy_sqlite3_rembed_init was declared unconditionally as NULL with a TODO comment ("Fix sqlite-rembed header inclusion and assign the function pointer properly") and never reassigned anywhere in the tree. The sole caller in Admin_Bootstrap::__bootstrap was null-guarded, so the sqlite-rembed auto-extension was never registered at runtime in any build tier, stable or GENAI. This commit removes the pointer, its extern declaration, and the null-guarded call. No runtime behavior changes; subsequent commits remove the build-system wiring and the Rust toolchain dependency that existed solely to produce libsqlite_rembed.a.	1 month ago
Rene Cannao	30be016be5	fix(pgsql-monitor): clamp next_*_at on LOAD PGSQL VARIABLES TO RUNTIME ... Closes the pgsql-servers_ssl_params-t portion of sysown/proxysql#5610. This is the final of four tests from the flake tracking issue. ## Problem 1 — the scheduler caching bug (lib/PgSQL_Monitor.cpp) `pgsql-servers_ssl_params-t` subtests 32 ("Monitor SSL counter increased with use_ssl=1 and no per-server row") and 34 ("Monitor per-server: SSL OK counter resumes advancing after removing the per-server row") were failing deterministically on v3.0. Both expected `PgSQL_Monitor_ssl_connections_OK` to increase within a few seconds of: SET pgsql-monitor_connect_interval=2000; LOAD PGSQL VARIABLES TO RUNTIME; UPDATE pgsql_servers SET use_ssl=1; LOAD PGSQL SERVERS TO RUNTIME; but the counter stayed at 0. Root cause is state caching in the pgsql monitor scheduler loop (`PgSQL_monitor_scheduler_thread()`): T=0 proxysql starts with default pgsql-monitor_connect_interval =120000. The first scheduler tick schedules an initial connect check; compute_next_intvs() sets next_connect_at = T + 120000 ms = T + 120 seconds. T+<30s> test does SET connect_interval=2000 + LOAD PGSQL VARIABLES TO RUNTIME. fetch_updated_conf() starts returning the new 2000 value, but next_connect_at still points at T+120000 because compute_next_intvs() only updates next_<type>_at when the corresponding task type has fired. T+<35s> test reads ssl_connections_OK at the end of its 5-second wait. Counter still 0 because the next scheduled connect check is ~85 seconds in the future. The scheduler is working correctly; what's missing is a bridge between "runtime variables were just refreshed" and "next_<type>_at should reflect the refreshed (shorter) intervals". Fix: in the scheduler loop, track whether the variable version bumped this iteration, and if so, clamp each next_<type>_at down to cur_intv_start + new_interval whenever the refreshed interval would schedule the next check sooner than the currently-cached value. The clamp is one-way (we never push next_<type>_at FURTHER into the future, because growing the interval should not delay an already- imminent check), idempotent, and safe against interval=0 (disabled) which is left to compute_next_intvs() to set to ULONG_MAX. Applied to all four monitor task types: ping, connect, readonly, repl_lag. Same class of bug affected all of them; fixing only connect would leave analogous latent issues for any test that changes the other intervals at runtime. Verified with the raw experiment before committing: configure monitor/monitor + interval=2000 + use_ssl=1 + LOAD, observe counter ticking at the 2-second cadence within 1-2 seconds of LOAD. Before fix: counter stuck at 0 for ~2 minutes (until the cached 120 s interval naturally elapses). ## Problem 2 — test's hardcoded wrong credentials (pgsql-servers_ssl_params-t.cpp) With the scheduler fix alone, the test was still failing because its main() was doing: SET pgsql-monitor_username='postgres'; SET pgsql-monitor_password='postgres'; on the assumption that the backend had a postgres user with password "postgres". But the actual test infra (test/infra/docker-pgsql16-single) RANDOMIZES `POSTGRES_PASSWORD` on every container startup — e.g. `POSTGRES_PASSWORD=05e792e51d`. Hardcoded 'postgres' never matched, so every monitor connect failed with: FATAL: password authentication failed for user "postgres" which increments connect_check_ERR instead of ssl_connections_OK. After the scheduler fix, these auth failures fired every 2 seconds instead of every 120 seconds — but they were still failures, so the counter never advanced. Fix: remove the username/password switch entirely. The default monitor/monitor user is already configured in the infra's pg_hba.conf and authenticates successfully (I verified this manually via `docker exec psql 'host=... user=monitor password=monitor sslmode=require'` from both inside and outside the proxysql container). The corresponding "restore original values" block is also removed since there's nothing to restore. ## Local verification 3 consecutive runs of the full pgsql-servers_ssl_params-t test in legacy-g4 infra with the patched proxysql + patched test binary: attempt 1: PASS attempt 2: PASS attempt 3: PASS === pgsql-servers_ssl_params-t: 3/3 pass === Subtest-level confirmation from the final attempt's TAP log: # Original monitor: user=monitor interval=120000 ms # Initial PgSQL_Monitor_ssl_connections_OK: 33 # After PgSQL_Monitor_ssl_connections_OK: 36 <- +3 in 5 s ok 32 - Monitor SSL counter increased with use_ssl=1 and no per-server row # With TLSv1 per-server pin, ssl OK before wait: 39 # With TLSv1 per-server pin, ssl OK after wait: 39 (delta=0) ok 33 - Monitor per-server: SSL OK counter does NOT advance when per-server row pins ssl_protocol_version_range to TLSv1 # After cleanup, ssl OK recovered from 41 to 44 <- +3 in 5 s ok 34 - Monitor per-server: SSL OK counter resumes advancing after removing the per-server row All three monitor-SSL subtests now exercise the real code path (SSL handshake happening, counter incrementing, per-server pin blocking SSL as designed) instead of observing a no-op. ## Side effect on pgsql-ssl_keylog-t subtest 7 Subtest 7 of pgsql-ssl_keylog-t was marked as SKIP in PR #5612 because it tripped on the same "pgsql monitor isn't making SSL connections" symptom. With this fix merged, the skip's runtime condition (`lines_before_monitor == lines_after_monitor`) will evaluate to false once the monitor is actually producing SSL handshakes, and the test will fall into the `ok(...)` branch automatically. No separate change to that test is needed — the skip was defensive and is dead code after this fix. ## Why mysql monitor is not touched here This fix is scoped to the pgsql monitor scheduler only. The mysql monitor is a different file (lib/MySQL_Monitor.cpp) with a different scheduling architecture (per-thread timers, not a centralized scheduler). If the same class of bug exists there, it would need a separate patch - out of scope for this PR.	1 month ago
René Cannaò	669ab91494	Merge pull request #5594 from sysown/v3.0-lint ... lint + static analysis: clang-tidy and cppcheck fixes	2 months ago
Rene Cannao	76251a78dc	fix: resolve invalidFunctionArg in get_current_query - use size_t cast	2 months ago
Rene Cannao	24e56d4dd1	fix: SonarCloud issues - explicit ctors, sprintf->snprintf	2 months ago
Rene Cannao	a82224f1ef	fix: PR review feedback - double-free, end comments, dead code ... - Fix double-free bug in free_account_details() (lib/MySQL_Authentication.cpp) - Fix trailing #endif comments in 5 files to match guard names - Rename __SIZE -> SIZE_ in LDAP_USER_FIELD_IDX enum - Remove dead code: Query_Processor_Output ctor now calls init()	2 months ago
Rene Cannao	d5ffcba695	fix: cppcheck deeper analysis - invalidLifetime and arrayIndexOutOfBounds ... - Fix invalidLifetime: look up pointer from map after insertion, not before - Fix arrayIndexOutOfBounds: add bounds check before array access	2 months ago
Rene Cannao	bf9030ecb7	fix: remaining cppcheck printf and null pointer issues ... - Fix wrongPrintfScanfArgNum: remove extra args in 4 sprintf calls - Fix nullPointer: add GloMTH check, add null checks for strdup args - All high-risk cppcheck warnings now resolved	2 months ago
Rene Cannao	5ccb715e57	fix: cppcheck fixes - printf formats, null checks, copy operators ... - Fix invalidPrintfArgType: %d->%u for hid, %u->%d for use_ssl - Fix nullPointerRedundantCheck: replace assert with continue - Add deleted copy ctor/operator= to KillArgs and MySQL_Session - Fix invalidFunctionArg: add query_len > 3 check before memcpy	2 months ago
Rene Cannao	a51fe19e3f	fix: delete copy operations in 4 classes (Group_Replication_Info, Galera_Info, AWS_Aurora_Info, MySQL_Errors_stats)	2 months ago
Rene Cannao	b5617c0c18	fix: initialize all members in Query_Info constructor	2 months ago
Rene Cannao	7e1a78fd6b	lint: fix reserved identifiers and include guards ... - Rename __HGM_TABLES_SIZE -> HGM_TABLES_SIZE_ (Base/MySQL/PgSQL HGM) - Rename __TYPE_SIZE -> TYPE_SIZE_ (Base/MySQL/PgSQL HGM) - Fix include guard defines: __PROXYSQL_* -> PROXYSQL_* - Fix include guard comments: __CLASS_* -> PROXYSQL_*_H (29 files) - Add uint8_t underlying type to small enums	2 months ago
Rene Cannao	9bdfb8b1cd	lint: optimize enum types and fix reserved identifiers in Query_Cache, admin, thread, debug ... performance-enum-size fixes: - p_qc_counter, p_qc_gauge: add uint8_t (7 and 2 values) - p_admin_counter, p_admin_gauge, p_admin_dyn_counter, p_admin_dyn_gauge: add uint8_t - p_debug_dyn_counter: add uint8_t (2 values) bugprone-reserved-identifier fixes: - Rename __size -> SIZE_ in all metric enums - Update std::array size references across multiple files - Update prometheus_helpers.h template parameter names and comments Files changed: - Query_Cache.h - proxysql_admin.h - MySQL_Thread.h - proxysql_debug.h - prometheus_helpers.h (template changes) - debug.cpp (usage update)	2 months ago
Rene Cannao	f1826cf206	lint: fix reserved identifier in member variables ... Rename __active -> active_, __frontend -> frontend_, __backend -> backend_ in authentication and hostgroups classes to comply with C++ reserved identifier rules. Includes updates to: - MySQL_Authentication.hpp - ClickHouse_Authentication.hpp - PgSQL_Authentication.h - MySQL_HostGroups_Manager.h - Base_HostGroups_Manager.h - Corresponding .cpp files	2 months ago
Rene Cannao	ac0f9304b0	fix: address code review findings for pgsql cluster sync ... 1. Remove dead declarations and implementations: PullOperationConfig, pull_from_peer_unified, fetch_query_with_metrics, compute_*_checksum, ScopedChar* wrappers, and all safe_* memory helpers (-690 lines) 2. Document mutex sharing: pgsql pull functions intentionally reuse MySQL mutexes since pulls are sequential in the monitoring thread 3. Fix variable shadowing: rename local 'error' to 'exec_error' in Admin_Handler.cpp pgsql_servers_v2 fallback to avoid shadowing the outer error variable 4. Fix misleading debug message in process_component_checksum: the else branch fires when peer checksum is unchanged, not different 5. Fix indentation in ProxySQL_Admin.cpp (3 lines with double-tab) and Admin_FlushVariables.cpp (NULL-guard block with extra indent)	2 months ago
Rene Cannao	80ff2242e6	merge: resolve v3.0 conflict and add pgsql_servers_ssl_params cluster sync ... v3.0 added pgsql_servers_ssl_params table. Integrate into pgsql cluster sync path: - Add CLUSTER_QUERY_PGSQL_SERVERS_SSL_PARAMS to Admin_Handler interception block alongside other pgsql cluster queries - Add ssl_params fetch query to pull_pgsql_servers_v2_from_peer - Add update_pgsql_servers_ssl_params() for applying synced data - Update convert_pgsql_servers_resultsets to handle 5 result sets - Include ssl_params in v2 checksum computation (4 tables)	2 months ago
René Cannaò	7f14beedc1	Merge pull request #5583 from sysown/v3.0_pgsql_ssl_backend_5582 ... Per-server SSL parameters for PostgreSQL backends	2 months ago
René Cannaò	1a8e4ed918	Merge pull request #5567 from sysown/v3.0_pgsql_sslkeylog_5281 ... Add SSL/TLS traffic decryption for PostgreSQL backend connections	2 months ago
René Cannaò	f713d78e41	Merge pull request #5554 from sysown/copilot/add-flag-choose-ipv4-or-ipv6 ... Add `mysql-resolution_family` to control IPv4/IPv6 hostname resolution	2 months ago
Rene Cannao	0e1ea6a734	Address code review feedback for mysql-resolution_family ... - Add documentation comments to MySQL_Resolution.h explaining NULL fallback behavior for all three helper functions - Initialize mysql_thread___resolution_family to "system" in MySQL_Thread constructor to prevent NULL before first refresh_variables() call - Add explanatory comment in mysql_resolution_unit-t.cpp documenting the DNS cache bypass limitation for future contributors Review: #5554	2 months ago
Rahim Kanji	76acb1e3e8	feat: add cluster query support for pgsql_servers_ssl_params ... - Define CLUSTER_QUERY_PGSQL_SERVERS_SSL_PARAMS macro for remote node fetch - Add Admin_Handler interception so cluster peers can query the table - Add pgsql_servers_ssl_params to get_current_pgsql_table() lookup - Checksum computation was already in place via CUCFT1 in commit()	2 months ago
Rene Cannao	b60635f1c5	fix: address critical bugs and add missing test coverage for PGSQL cluster sync ... Critical bug fixes: - Add NULL check after execute_statement in flush_GENERIC_variables__checksum__database_to_runtime to prevent segfault when SQLite returns NULL resultset - Add NULL checks after mysql_store_result in all pgsql pull functions to prevent dereference of nullptr from OOM or protocol errors - Add proxy_error logging for double-NULL fallthrough in Admin_Handler pgsql query rules when both get_current_query_rules_inner() and get_current_query_rules() return NULL - Check execute_statement error output for pgsql_servers_v2 fallback query to detect schema corruption or disk failures instead of silently using empty results - Add NULL guards for MYSQL_ROW fields in update_pgsql_users to prevent atoll(NULL) undefined behavior on corrupted peer responses Test coverage additions: - Add check_pgsql_variables_sync: end-to-end test for pgsql variable propagation - Add check_diffs_before_sync_disabled: verify diffs_before_sync=0 prevents sync - Add SHUNNED and OFFLINE_SOFT server test cases to verify status handling - SHUNNED servers verified as mapped to ONLINE in runtime by cluster sync	2 months ago
René Cannaò	5d47c05351	fix: close MYSQL handle unconditionally in cluster pull cleanup paths ... When creds.user.size() is 0, mysql_real_connect is never called so conn->net.pvio remains NULL. The cleanup code checked pvio before calling mysql_close, skipping it and leaking the MYSQL handle allocated by mysql_init. mysql_close is safe to call on an initialized-but-not-connected handle, so remove the pvio guard. Affects all pull_*_from_peer functions (MySQL and PgSQL) and the monitor thread exit path.	2 months ago
René Cannaò	93eabfc7bc	fix: address code review issues in PostgreSQL cluster sync ... - Fix fetch_and_store incrementing success counter on failure - Fix sqlite3_stmt leak in pull_pgsql_variables_from_peer (use RAII) - Convert get_peer_to_sync_pgsql_query_rules and _servers_v2 to unified framework delegates (fixes atomic data race on .load()) - Merge dual scan loops in set_checksums to respect enabled_check - Remove spurious "deprecated" label from new checksum_pgsql_variables - Replace sprintf with snprintf in pgsql diffs_before_sync getters - Fix indentation on cluster_pgsql_variables blocks - Fix TAP plan mismatch: replace MYSQL_QUERY with inline mysql_query - Fix trivially-true table accessibility assertions - Add mysql_close on failed connect in test - Move test_cluster_sync_pgsql-t to legacy-g5 group	2 months ago
Rahim Kanji	e68f8bb74a	refactor: simplify pgsql_servers_ssl_params schema and pre-parse TLS range ... - Drop ssl_capath and ssl_cipher columns (no libpq equivalents) - Pre-parse ssl_protocol_version_range into ssl_min/max_protocol_version at construction time instead of on every backend connection - Fix Servers_SslParams 3-arg delegating constructor - Update tests, docs, and all consumers (Connection, Monitor, Kill, Admin)	2 months ago
René Cannaò	8a61232517	fix: decouple MySQL and PostgreSQL checksum/sync controls ... Two bugs in the PostgreSQL cluster sync admin variables: 1. Cross-protocol coupling (critical): Disabling a MySQL checksum flag (e.g. SET admin-checksum_mysql_query_rules='false') incorrectly zeroed out the corresponding PostgreSQL cluster sync threshold (cluster_pgsql_query_rules_diffs_before_sync). An operator disabling MySQL checksums would unexpectedly halt PostgreSQL cluster sync. Fix: MySQL checksum setters now only affect MySQL sync thresholds. The warning messages no longer mention pgsql side effects. 2. Single-gate for all pgsql modules (operational limitation): All four PostgreSQL cluster sync thresholds (cluster_pgsql_{query_rules,servers,users,variables}_diffs_before_sync) were gated by a single flag (checksum_pgsql_variables). This meant you could not independently control checksum computation per-module. By contrast, MySQL has per-module flags (checksum_mysql_query_rules, checksum_mysql_servers, checksum_mysql_users, checksum_mysql_variables). Fix: Add three new per-module admin variables: - admin-checksum_pgsql_query_rules - admin-checksum_pgsql_servers - admin-checksum_pgsql_users Each gates only its corresponding cluster_*_diffs_before_sync setter, mirroring the MySQL pattern. The existing admin-checksum_pgsql_variables now only gates cluster_pgsql_variables_diffs_before_sync. Disabling admin-checksum_pgsql_variables no longer cascades to zero out query_rules/servers/users sync thresholds. Files changed: - include/proxysql_admin.h: Add checksum_pgsql_query_rules, checksum_pgsql_servers, checksum_pgsql_users to checksum_variables struct. - lib/ProxySQL_Admin.cpp: Add variable names, constructor defaults, get/set handlers for new flags. Update diffs_before_sync guards to use per-module flags. Remove pgsql zeroing from MySQL checksum setters. Fix checksum_pgsql_variables setter to only affect pgsql variables sync threshold.	2 months ago
Rene Cannao	a7db1eb4a8	fix: correct 'Not syncing' log message variable name for V2 modules ... The DIFFS_BEFORE_SYNC_FORMAT log message used module_name directly to construct the admin variable name, producing incorrect names like 'admin-cluster_mysql_servers_v2_diffs_before_sync' (doesn't exist). The actual variable is 'admin-cluster_mysql_servers_diffs_before_sync'. Add sync_var_suffix field to ChecksumModuleInfo so V2 modules (mysql_servers_v2, pgsql_servers_v2) can specify the correct variable name suffix. This fixes test_cluster_sync-t log regex checks that verify sync-disable behavior.	2 months ago
Rene Cannao	47758a468d	merge: resolve groups.json conflict with v3.0 ... Take v3.0's groups.json as base (legacy-gN naming, mysql84-gN groups, new test entries) and add test_cluster_sync_pgsql-t from this branch. Drop duplicate pgsql_admin_metacmds-t (already exists as pgsql-admin_metacmds-t in v3.0).	2 months ago
Rahim Kanji	93d0ddf477	fix: add pgsql_servers_ssl_params to tablenames vector and fix monitor fallback ... - Add pgsql_servers_ssl_params to pgsql_servers_tablenames so SAVE/LOAD PGSQL SERVERS TO/FROM DISK correctly persists and restores SSL params. - Fix monitor SSL fallback to use per-server params directly (empty fields omitted) instead of per-field fallback to globals, matching the backend connection behavior.	2 months ago
Rahim Kanji	6d3ce36de4	feat: apply per-server SSL params in PgSQL backend kill connections	2 months ago
Rahim Kanji	fec7c12a35	feat: apply per-server SSL params in PgSQL monitor connections	2 months ago
Rahim Kanji	1b2df514fd	feat: apply per-server SSL params in PgSQL backend connections	2 months ago
Rahim Kanji	516fa468ba	feat: add admin load/save/dump for pgsql_servers_ssl_params	2 months ago
Rahim Kanji	5ad511568a	feat: add pgsql_servers_ssl_params table definitions and admin bootstrap	2 months ago
Rahim Kanji	05e3ed4351	feat: add PgSQLServers_SslParams class with map, generate, get, and commit integration	2 months ago
René Cannaò	7510d8073a	Merge pull request #5553 from sysown/fix/5539-ffto-default-by-tier ... Disable FFTO by default in 3.1.x, keep enabled in 4.0.x	2 months ago
René Cannaò	3659ba85fb	Merge branch 'v3.0' into advisory/com-stmt-send-long-data-fix-1 ... Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	151169da9b	Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	b94c855d4c	Merge branch 'v3.0' into advisory-fix-1 ... Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	fa6ebcdcc9	Merge commit from fork ... Fix PROXY protocol v1 address overflow	2 months ago
René Cannaò	419cd7608b	Merge commit from fork ... Fix COM_STMT_CLOSE short packet handling	2 months ago
René Cannaò	7a574a537a	Merge commit from fork ... Validate COM_CHANGE_USER packet bounds	2 months ago