proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	fbf5f2d762	Improve wait_timeout warning messages with detailed connection information Enhance logging clarity: - Replace generic IP address with detailed connection info including IP and port - Use client_myds->addr.addr and client_myds->addr.port for precise identification - Improve debuggability of timeout clamping and enforcement warnings The warning messages now provide complete connection details, making it easier to identify and troubleshoot timeout-related issues in ProxySQL logs.	4 months ago
Rene Cannao	dc4694d656	Refactor idle session scanning and improve test precision Code improvements: - Extract SESS_TO_SCAN_idle_thread constant to header file for better maintainability - Replace magic number 128 with named constant in idle_thread_to_kill_idle_sessions() - Improve code readability and consistency in session scanning logic Test enhancements: - Add mysql-poll_timeout configuration for more precise timeout testing - Reduce test sleep times to 13 seconds for faster test execution - Add diagnostic messages to clearly show timeout configurations in test output - Ensure tests properly validate timeout enforcement with precise timing The changes improve code maintainability and make tests more reliable and faster while maintaining accurate timeout validation.	4 months ago
Rene Cannao	0c5e75a064	Fix wait_timeout timeout calculations and add proper newline characters Key improvements: - Fix timeout comparison in MySQL_Thread::idle_thread_to_kill_idle_sessions() to prevent underflow - Use effective wait_timeout (minimum of global and session values) for idle timeout calculations - Add proper newline characters to proxy_warning messages for consistent log formatting - Increase test sleep times to account for global timeout enforcement - Fix session timeout test durations to properly test timeout behavior Technical changes: - Replace broken min_idle calculation with proper effective wait_timeout logic - Add std::min() usage to determine effective timeout from global and session values - Ensure warning messages end with newline characters for proper log formatting - Update test sleep durations to ensure proper timeout testing Resolves potential timeout calculation bugs and ensures consistent timeout enforcement behavior.	4 months ago
Rene Cannao	df515f91fa	session: Add wait_timeout to proxysql internal session JSON - Include wait_timeout value in session JSON output for monitoring/debugging - Provides visibility into client-configured timeout values	4 months ago
Rene Cannao	0a9dc9dd29	session: Add input validation for client wait_timeout with silent clamping - Add range validation for client SET wait_timeout commands - Implement clamping between 1 second (1000ms) and 20 days (1,728,000,000ms) - Add warning messages when values are clamped due to ProxySQL limits - Maintain MySQL compatibility by accepting larger values than global config - Fix signed/unsigned comparison warning in wait_timeout assignment - Ensures client applications don't break while enforcing safety limits	4 months ago
Rene Cannao	86cc7cd3da	session: Fix wait_timeout member variable declaration and usage - Add wait_timeout member variable declaration to Base_Session class - Fix constructor initialization to use this->wait_timeout - Fix assignment in handler to properly scope member variable - Resolves compilation error for wait_timeout functionality	4 months ago
René Cannaò	588b0a0ae6	Merge branch 'v3.0' into v3.0_wait_timeout Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	9a55e97429	docs: Add comprehensive Doxygen documentation for GTID refactoring - Document addGtidInterval() function with parameter details and reconnection behavior - Add documentation for readall() method explaining robust error handling - Document connect_cb() and reader_cb() callbacks with resource management details - Document generate_mysql_gtid_executed_tables() with multi-phase process explanation - Focus on functionality, thread safety, and performance improvements - Provide clear parameter descriptions and return value semantics	4 months ago
Wazir Ahmed	50c60284e6	gtid: Refactor reconnect logic & prevent `events_count` reset - This patch was originally added by commit `0a70fd5` and reverted by `8d1b5b5`, prior to the release of `v3.0.3`. - The following issues are addressed in this update, - Fix for `use-after-free` issue which occured during CI test. - Fix for deadlock issue between `GTID_syncer` and `MySQL_Worker`. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Rene Cannao	ee824c0b97	Removing debugging code	5 months ago
Rene Cannao	3329a671e5	Add extensive documentation for fast forward grace close feature	5 months ago
Rene Cannao	ae93966603	Add TAP test for fast forward grace close feature - Rename and modify test to use MySQL C API mysql_binlog_* functions - Implement throttled binlog reading with 5 iterations (no limit, 2s, 5s, 20s, 60s targets) - Add diagnostics for debugging binlog fetch issues - Set RPL options for file, position, server_id, and non-blocking flag - Update Makefile to compile with MySQL client library	5 months ago
Rene Cannao	44aa606caa	Implement fast forward grace close feature to prevent data loss Problem: In fast forward mode, ProxySQL forwards packets directly from client to backend without buffering them. If the backend connection closes unexpectedly (e.g., due to server crash, network failure, or other issues), ProxySQL immediately closes the client session. This can result in data loss because the client may have sent additional data that hasn't been fully transmitted yet, as ProxySQL does not wait for the output buffers to drain. Solution: Implement a configurable grace period for session closure in fast forward mode. When the backend closes unexpectedly, instead of closing the session immediately, ProxySQL waits for a configurable timeout (fast_forward_grace_close_ms, default 5000ms) to allow any pending client output data to be sent. During this grace period: - If the client output buffers become empty, the session closes gracefully. - If the timeout expires, the session closes anyway to prevent indefinite hanging. Changes: - Added global variable mysql_thread___fast_forward_grace_close_ms (0-3600000ms) - Added session flags: backend_closed_in_fast_forward, fast_forward_grace_start_time - Added data stream flag: defer_close_due_to_fast_forward - Modified MySQL_Data_Stream::read_from_net() to detect backend EOF and initiate grace close if client buffers are not empty - Modified MySQL_Session::handler() FAST_FORWARD case to implement grace close logic with timeout and buffer checks - Added extensive inline documentation explaining the feature and its mechanics This prevents data loss in fast forward scenarios while maintaining bounded session lifetime.	5 months ago
Javier Jaramago Fernández	64b16172c7	Change 'COM_STMT_EXECUTE' params length decoding According to MySQL protocol, variable length strings are encoded using length encoded integers. For reference, see: - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_com_stmt_execute.html - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_basic_dt_integers.html#a_protocol_type_int2 The protocol specifies that values greater than 2^24 (16777216) should be encoded using '0xFE + 8-byte integer'. Yet, in reality MySQL ignores the upper section of these 8-byte integers, treating them effectively like '4-bytes'. For the sake of compatibility this commit changes the decoding behavior for 'COM_STMT_EXECUTE' to match MySQL one. This different is subtle but important, since in practice MySQL itself doesn't use the '8 bytes' from the field. This means that connectors that are compatible with MySQL could find issues when sending these packets through ProxySQL (like NodeJS 'mysql2' connector which writes the 8-bytes as a 4-bytes duplication, motivating these changes), situation that could result in rejection due to malformed packet detection (or crashes/invalid handling in the worse case scenario). The previous decoding function is now renamed into 'mysql_decode_length_ll' to honor MySQL naming 'net_field_length_ll'. For now, this protocol change is limited to 'COM_STMT_EXECUTE'.	5 months ago
Javier Jaramago Fernández	e35973b226	Add boundary checks in 'MySQL_Protocol::get_binds_from_pkt' These checks should prevent crashes when packets are received holding invalid lengths in the processed params.	5 months ago
René Cannaò	4fa3bf6a91	Merge pull request #5191 from sysown/v3.0-fix_proclist_use_after_free Fix heap-after-use between `PROXYSQL INTERNAL SESSION` and `SHOW PROCESSLIST`	5 months ago
René Cannaò	dfd46fee4b	Merge pull request #5150 from proton-lisandro-pin/ignore_min_gtid Implement a `ignore_min_gtid_annotation` global variable, fix memory leak/overflow in `min_gtid` annotation handler.	5 months ago
René Cannaò	8be91071ef	Merge pull request #5190 from sysown/v3.0_default_interface_global_var_5189 Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	5 months ago
René Cannaò	c06e15fd74	Merge pull request #5192 from sysown/v3.0_add_delay_watchdog Improved PgSQL/MySQL Thread Watchdog Unit Test	5 months ago
Rene Cannao	f803a1d419	Increase sid on caching_sha2 full authentication caching_sha2_password full authentication is a complex task that requires a lot of packets being sent and forth between client and server (ProxySQL in this case). Every packet needs to have an increased sequence ID (sid) according to protocol. ProxySQL was incorrectly forgetting to increase the sid when requesting a full authentication. For some clients this is not a problem, while other clients will consider the incorrect sid a serious issue and abort the connection. This commit ensures that sid is correctly increased when requesting caching_sha2_password full authentication.	5 months ago
Lisandro Pin	6cb522283d	Implement a ignore_min_gtid_annotation global variable for ProxySQL When true, all `min_gtid` query annotations are ignored; see https://proxysql.com/documentation/query-annotations/ for details. This is useful on ProxySQL setups with multiple layers, where some layers mandate GTID-based routing while others don't.	5 months ago
Rahim Kanji	48928ce04e	Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	5 months ago
Rahim Kanji	86c17f04d7	Replace single sleep with looped delay for simulated watchdog test	5 months ago
Rahim Kanji	3c79800a45	Add delay - WatchDog test	5 months ago
Javier Jaramago Fernández	4b28bb6ced	Fix heap-after-use between 'PROXYSQL INTERNAL SESSION' and 'SHOW PROCESSLIST' Missing query cleanup in 'PROXYSQL INTERNAL SESSION' could lead to invalid memory accesses during 'SHOW PROCESSLIST' sessions scan.	5 months ago
René Cannaò	4a6ba68357	Merge pull request #5173 from sysown/v3.0_admin_cmd_5170 Resolved issues with PROXYSQL PAUSE/RESUME/STOP/START	6 months ago
René Cannaò	a44dee127d	Merge pull request #5174 from sysown/v3.0_optimise_extended_query_response Removed unnecessary writeout()	6 months ago
Javier Jaramago Fernández	2668de77c2	Fix compilation warning for 'strncpy' due string truncation As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	6 months ago
Javier Jaramago Fernández	c0978f9371	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' (PgSQL) Accesses by 'stats___pgsql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	6 months ago
Javier Jaramago Fernández	67624b8569	Fix compilation warning for 'strncpy' due string truncation As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	6 months ago
Javier Jaramago Fernández	639f9d0c74	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' Accesses by 'stats___mysql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	6 months ago
Wazir Ahmed	8d1b5b597c	Revert "gtid: Refactor reconnect logic & prevent events_count reset" This reverts commit `0a70fd515f`.	6 months ago
Rahim Kanji	8291361bc1	Removed unnecessary writeout()	6 months ago
Rahim Kanji	38befb845f	Fixed PROXYSQL STOP	6 months ago
Rahim Kanji	67d383de4e	Resolved issues with admin PROXYSQL PAUSE/RESUME commands	6 months ago
René Cannaò	5018cb66d9	Merge pull request #5168 from sysown/v3.0-debug_log_pass Allow to dump passwords used during auth in debug builds	6 months ago
René Cannaò	c6cbce34b1	Merge pull request #5117 from wazir-ahmed/gtid-reconn gtid: Refactor reconnect logic & prevent `events_count` reset	6 months ago
René Cannaò	360646b7d5	Merge pull request #5165 from sysown/crash-sqlite-max-len processlist: Prevent crash due to SQLITE_TOOBIG	6 months ago
Wazir Ahmed	5219d4be93	processlist: Prevent crash due to SQLITE_TOOBIG - Add new mysql/pgsql variable `processlist_max_query_length`. - Min: 1K - Max: 32M - Default: 2M - Truncate current query based on the configuration before inserting into `stats_*_processlist` tables. - Refactor/fix code related to other processlist configurations. 1. `session_idle_show_processlist` value was not updated in `ProxySQL_Admin.variables`. 2. Pass processlist config as an argument to `MySQL_Threads_Handler::SQL3_Processlist` instead of using thread-local variables. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	6 months ago
René Cannaò	7022833213	Merge pull request #5163 from sysown/v3.0_assert_to_warning verify_server_variables() -> Change assert to warning + Various improvements	6 months ago
Javier Jaramago Fernández	4304b995a3	Improve debug message with context dump (passwords) during auth handshake This message is dump with each call to 'process_pkt_handshake_response' printing the updated context. When the verbosity value for module 'debug_mysql_protocol' is >= 5, the stored and client supplied passwords will be dumped in HEX format, for values < 5, the passwords will be masked.	6 months ago
René Cannaò	436bcccc62	Merge pull request #5158 from sysown/v3.0.3-makefiles_cleanup V3.0.3 makefiles cleanup	6 months ago
Miro Stauder	d020f577b2	reduce duplication in makefiles, use include for common stuff	6 months ago
René Cannaò	562e98d551	Merge pull request #5130 from wazir-ahmed/stats-schema Remove `stats` schema name from the query in stats user session	6 months ago
Rahim Kanji	ed20d09b8a	Replaced std::get_if with std::visit	6 months ago
Rahim Kanji	91c674495a	Few fixes	6 months ago
René Cannaò	ccf72b606c	Merge pull request #5134 from wazir-ahmed/mysqldump Improve `mysqldump` compatibility	6 months ago
René Cannaò	3b4369bba9	Merge pull request #5113 from wazir-ahmed/load-from-config-validation Add validation for `LOAD * FROM CONFIG`	6 months ago
René Cannaò	9c7111d9e6	Merge pull request #5085 from wazir-ahmed/intercept-ssl-version Handle `SHOW STATUS LIKE 'Ssl_version'` in ProxySQL without any backend	6 months ago
Rahim Kanji	288b0da189	verify_server_variables -> Change assert to warning	6 months ago

1 2 3 4 5 ...

4505 Commits (fbf5f2d76249be36b04ff7aaab2af4b4e31bb6b8)