proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	253d098653	security: fix SQL injection vulnerabilities in SQLite catalog queries Address Gemini Code Assist review feedback on PR #5386: 1. Discovery_Schema::resolve_run_id - Replace string concatenation with replace_str escaping with proper parameterized queries using sqlite3_prepare_v2 and sqlite3_bind_* functions. 2. PgSQL_Static_Harvester - Remove unsafe escape_sql_string() function and replace its usages with: - New lookup_object_id() helper using parameterized queries - Parameterized UPDATE statements in harvest_view_definitions() These changes ensure complete protection against SQL injection for the catalog database, following the pattern already used in create_run().	3 months ago
Rene Cannao	9685cdaa4b	mcp discovery: enforce target-scoped run model and add protocol-aware static harvesting (mysql+pgsql) Refactor the MCP query/discovery stack to remove prototype-era MySQL-only assumptions and make discovery/catalog semantics explicitly target-scoped. This commit is intentionally not backward compatible with legacy single-target catalog metadata. Key implementation details: - Discovery_Schema: - runs table now stores target_id, protocol, and server_version - resolve_run_id() now requires target_id and resolves schemas within target scope - create_run() now records target/protocol/server version - added legacy schema detection + destructive catalog table rebuild when old runs layout is found - fixed resultset lifetime/escaping issues in target-aware run resolution - New PostgreSQL static harvester: - added PgSQL_Static_Harvester class and build wiring - harvests schemas/objects/columns/indexes/fks/view definitions into Discovery_Schema - maps pg metadata to object_id-based insert APIs used by Discovery_Schema - Query_Tool_Handler: - constructor simplified to catalog_path only (no mcp-mysql_* runtime ctor deps) - discovery.run_static now requires target_id and dispatches protocol-aware harvester at runtime - catalog., agent.run_start, and llm. tool contracts now require target_id when resolving run_id - all run_id resolution call sites switched to resolve_run_id(target_id, ...) - list_schemas catalog query now scoped by target_id via runs join - digest logging path now resolves run_id in target context - ProxySQL_MCP_Server: - updated Query_Tool_Handler construction to new signature - Docs updated: - added explicit target_id scoping guidance for discovery/catalog/agent/llm workflows - clarified protocol-aware routing and noted legacy examples still present in large script docs Build validation: - Recompiled changed objects with PROXYSQLGENAI=1: - Query_Tool_Handler.oo - Discovery_Schema.oo - PgSQL_Static_Harvester.oo - ProxySQL_MCP_Server.oo	3 months ago

Author

SHA1

Message

Date

Rene Cannao

253d098653

security: fix SQL injection vulnerabilities in SQLite catalog queries

Address Gemini Code Assist review feedback on PR #5386:

1. Discovery_Schema::resolve_run_id - Replace string concatenation with
   replace_str escaping with proper parameterized queries using
   sqlite3_prepare_v2 and sqlite3_bind_* functions.

2. PgSQL_Static_Harvester - Remove unsafe escape_sql_string() function
   and replace its usages with:
   - New lookup_object_id() helper using parameterized queries
   - Parameterized UPDATE statements in harvest_view_definitions()

These changes ensure complete protection against SQL injection for the
catalog database, following the pattern already used in create_run().

Rene Cannao

9685cdaa4b

mcp discovery: enforce target-scoped run model and add protocol-aware static harvesting (mysql+pgsql)

Refactor the MCP query/discovery stack to remove prototype-era MySQL-only assumptions and make discovery/catalog semantics explicitly target-scoped. This commit is intentionally not backward compatible with legacy single-target catalog metadata.

Key implementation details:
- Discovery_Schema:
  - runs table now stores target_id, protocol, and server_version
  - resolve_run_id() now requires target_id and resolves schemas within target scope
  - create_run() now records target/protocol/server version
  - added legacy schema detection + destructive catalog table rebuild when old runs layout is found
  - fixed resultset lifetime/escaping issues in target-aware run resolution
- New PostgreSQL static harvester:
  - added PgSQL_Static_Harvester class and build wiring
  - harvests schemas/objects/columns/indexes/fks/view definitions into Discovery_Schema
  - maps pg metadata to object_id-based insert APIs used by Discovery_Schema
- Query_Tool_Handler:
  - constructor simplified to catalog_path only (no mcp-mysql_* runtime ctor deps)
  - discovery.run_static now requires target_id and dispatches protocol-aware harvester at runtime
  - catalog.*, agent.run_start, and llm.* tool contracts now require target_id when resolving run_id
  - all run_id resolution call sites switched to resolve_run_id(target_id, ...)
  - list_schemas catalog query now scoped by target_id via runs join
  - digest logging path now resolves run_id in target context
- ProxySQL_MCP_Server:
  - updated Query_Tool_Handler construction to new signature
- Docs updated:
  - added explicit target_id scoping guidance for discovery/catalog/agent/llm workflows
  - clarified protocol-aware routing and noted legacy examples still present in large script docs

Build validation:
- Recompiled changed objects with PROXYSQLGENAI=1:
  - Query_Tool_Handler.oo
  - Discovery_Schema.oo
  - PgSQL_Static_Harvester.oo
  - ProxySQL_MCP_Server.oo

2 Commits (f55e0a47a433662fa35525b5bebf7fd63ec30ea7)