proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	7e49c41975	Address review feedback on server selection (PR #5508 ) - Fix truncation: use uint64_t modulo instead of unsigned int cast when computing target from total_weight (prevents skewed selection when total_weight > UINT_MAX) - Remove unused #include <cstdlib> - Add docstring note about max_latency_us=0 semantics: in production this means "use thread default", this extraction treats it as "no limit" — callers should resolve defaults before populating the struct - Remove trailing "fix" comment from test	3 months ago
René Cannaò	dba1294585	Extract server selection algorithm into pure functions (Phase 3.4, #5492 ) New files: - include/ServerSelection.h: ServerCandidate struct (lightweight, no MySrvC dependency) + is_candidate_eligible() + select_server_from_candidates() - lib/ServerSelection.cpp: implementations ServerCandidate decouples selection logic from connection pool: contains only weight, status, connections, latency, and replication lag — no MySQL_Connection pointers or pool objects. Selection algorithm: 1. Filter candidates by eligibility (ONLINE, below max_connections, within latency/lag thresholds) 2. Weighted random selection using seeded LCG (deterministic for testing, avoids polluting global srand() state) Uses its own ServerSelectionStatus enum to avoid pulling in proxysql_structs.h and its entire dependency chain.	3 months ago

Author

SHA1

Message

Date

René Cannaò

7e49c41975

Address review feedback on server selection (PR #5508 )

- Fix truncation: use uint64_t modulo instead of unsigned int cast
  when computing target from total_weight (prevents skewed selection
  when total_weight > UINT_MAX)
- Remove unused #include <cstdlib>
- Add docstring note about max_latency_us=0 semantics: in production
  this means "use thread default", this extraction treats it as "no
  limit" — callers should resolve defaults before populating the struct
- Remove trailing "fix" comment from test

René Cannaò

dba1294585

Extract server selection algorithm into pure functions (Phase 3.4, #5492 )

New files:
- include/ServerSelection.h: ServerCandidate struct (lightweight, no
  MySrvC dependency) + is_candidate_eligible() + select_server_from_candidates()
- lib/ServerSelection.cpp: implementations

ServerCandidate decouples selection logic from connection pool:
contains only weight, status, connections, latency, and replication
lag — no MySQL_Connection pointers or pool objects.

Selection algorithm:
1. Filter candidates by eligibility (ONLINE, below max_connections,
   within latency/lag thresholds)
2. Weighted random selection using seeded LCG (deterministic for testing,
   avoids polluting global srand() state)

Uses its own ServerSelectionStatus enum to avoid pulling in
proxysql_structs.h and its entire dependency chain.

2 Commits (f31488831cb41f63e8fee1ca90b65bdc7affed3f)