proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	7f14beedc1	Merge pull request #5583 from sysown/v3.0_pgsql_ssl_backend_5582 Per-server SSL parameters for PostgreSQL backends	2 months ago
René Cannaò	1a8e4ed918	Merge pull request #5567 from sysown/v3.0_pgsql_sslkeylog_5281 Add SSL/TLS traffic decryption for PostgreSQL backend connections	2 months ago
René Cannaò	b771e4f6eb	Merge branch 'v3.0' into v3.0_ci_min_proxysql_version_5561 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rahim Kanji	49553cfb0b	fix: support one-sided TLS version ranges and warn on malformed input parse_tls_version() silently discarded partially-specified ranges like "TLSv1.2-" or "-TLSv1.3", leaving both min and max empty. This meant the user's intent (e.g. "at least TLSv1.2") was lost without any indication. Now one-sided ranges set the specified bound and leave the other side to libpq defaults. A bare "-" logs a proxy_warning.	2 months ago
René Cannaò	f713d78e41	Merge pull request #5554 from sysown/copilot/add-flag-choose-ipv4-or-ipv6 Add `mysql-resolution_family` to control IPv4/IPv6 hostname resolution	2 months ago
Rahim Kanji	ca75d563e9	test: add cluster query integration test for pgsql_servers_ssl_params Tests the PROXY_SELECT cluster query via MySQL admin port: - Inserts SSL params via PgSQL admin, loads to runtime - Connects to MySQL admin port and executes the cluster query - Verifies returned row has correct hostname, ssl_ca, and ssl_protocol_version_range values	2 months ago
Rene Cannao	0e1ea6a734	Address code review feedback for mysql-resolution_family - Add documentation comments to MySQL_Resolution.h explaining NULL fallback behavior for all three helper functions - Initialize mysql_thread___resolution_family to "system" in MySQL_Thread constructor to prevent NULL before first refresh_variables() call - Add explanatory comment in mysql_resolution_unit-t.cpp documenting the DNS cache bypass limitation for future contributors Review: #5554	2 months ago
René Cannaò	7ce2043b61	Merge branch 'v3.0' into v3.0-ci_84_mysql84 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rahim Kanji	e68f8bb74a	refactor: simplify pgsql_servers_ssl_params schema and pre-parse TLS range - Drop ssl_capath and ssl_cipher columns (no libpq equivalents) - Pre-parse ssl_protocol_version_range into ssl_min/max_protocol_version at construction time instead of on every backend connection - Fix Servers_SslParams 3-arg delegating constructor - Update tests, docs, and all consumers (Connection, Monitor, Kill, Admin)	2 months ago
Rene Cannao	9671a414a3	ci: comprehensive CI workflow and infrastructure fixes Workflow trigger chain fix: - All 24 test workflows now trigger on CI-builds completion instead of CI-trigger completion, ensuring build artifacts are available before tests start New test group workflows: - Add CI-legacy-g1, CI-legacy-g3, CI-legacy-g5 - Add CI-mysql84-g1 through CI-mysql84-g5 - All use the generic ci-taptests-groups.yml reusable workflow groups.json linter: - Add lint_groups_json.py enforcing compact one-line-per-entry format - Add CI-lint-groups-json.yml workflow triggered on groups.json changes - Reformat groups.json to comply with documented format Makefile fixes: - Fix $(error) call with unescaped ')' that broke all docker-compose builds since Release 3.0.8 - Fix CURVER extraction regex to handle 'v' prefix from git describe CI-taptests-pgsql-cluster rewrite: - Replace old jenkins-build-scripts with Unified CI infrastructure - Use ensure-infras.bash + run-tests-isolated.bash Infrastructure improvements: - Add --hostname test-runner to test-runner container for cross-container DNS resolution - Pass TAP_PGSQL_SYNC_REPLICA_PORT through to test container - Default TAP_PGSQL_SYNC_REPLICA_PORT=6042 when cluster nodes active	2 months ago
Rahim Kanji	4b2334e493	test: enable SQLite URI parsing in unit-test harness Calls sqlite3_config(SQLITE_CONFIG_URI, 1) at the top of test_globals_init(), mirroring src/main.cpp. Without this, SQLite3DB::open("file:mem_mydb?mode=memory", ...) used by both HostGroups Manager constructors falls back to literal-filename behavior in unit tests and creates a stray on-disk file in the test cwd instead of an in-memory database. The daemon already sets this flag before any component is constructed; the test harness now does the same.	2 months ago
Rahim Kanji	4e23078db3	test: rename pgsql servers SSL params TAP test and register tests in groups.json Renames test/tap/tests/pgsql-pgsql_servers_ssl_params-t.cpp to pgsql-servers_ssl_params-t.cpp to drop the duplicated "pgsql-" prefix, updates the @file header to match, and registers both the integration test and the existing pgsql_servers_ssl_params_unit-t in test/tap/groups/groups.json so CI actually runs them. The integration test joins the same group set used by other PgSQL admin/SSL tests (legacy-g4 and the four mysql--g4 variants); the unit test joins unit-tests-g1 alongside the other pgsql__unit-t entries.	2 months ago
Rahim Kanji	67101b715a	test: add TAP integration tests for pgsql_servers_ssl_params	2 months ago
Rahim Kanji	f31488831c	test: add unit tests for pgsql_servers_ssl_params	2 months ago
Wazir Ahmed	fa772c40b0	CI: Fix `infra-mysql57-binlog` setup - Fix infra-mysql57-binlog setup - Rework `docker-orchestrator-post.bash` based on infra-mysql57 orchestrator script - Add `testuser` to ProxySQL infra config - Fix multi-group cleanup - Rename the `GROUPS` variable in `destroy-multi-group.bash` to avoid the Bash special variable collision - Stop tracking CI-generated artifacts - Remove `test_cluster_sync.cnf` and `test-scripts/deps/mysqlbinlog` from git index - Ignore `test-scripts/deps/` directory Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rene Cannao	78c8a3d5e3	Fail fast in purge-trigger setup if connection or stmt fails Address review feedback: instead of silently continuing when the purge-trigger reconnect/prepare/deallocate fails, return false immediately with a diagnostic message.	2 months ago
Rene Cannao	3296ed5a07	Moving test_cluster_sync_mysql_servers-t from legacy-g3 to legacy-g5	2 months ago
Rene Cannao	26c5a25724	Fix read_only test assuming default_hostgroup=0 The test configures mysql_servers with writer_hostgroup=0 and reader_hostgroup=1, but the CI infrastructure sets users' default_hostgroup to 1300. When the test opens a proxy connection and runs BEGIN, ProxySQL routes to hostgroup 1300 which has no servers, causing a 10s timeout. Fix by setting default_hostgroup=0 for the test user at the start of each scenario.	2 months ago
Rene Cannao	1261d18a95	Fix SHOW WARNINGS test to work with MySQL 5.7 CAST('abc' AS DOUBLE) is MySQL 8.0+ syntax and fails on the legacy test group which uses MySQL 5.7. Use CAST('abc' AS SIGNED) instead, which produces a truncation warning on all MySQL versions. Fixes regression from PR #5548.	2 months ago
Rene Cannao	9098992f82	Fix timing issue in PgSQL prepared statement purge test The purge verification in test 1 was checking the statement count immediately after creating statements. The purge mechanism has a 1-second minimum interval between attempts and only removes statements with ref_count_client == 0. Fix by closing the connection (dropping refcounts), waiting 3 seconds, then triggering a new refcount change to invoke the purge before checking.	2 months ago
Rene Cannao	fe5a819051	Add 3 missing tests to groups.json Register newly compiled test binaries that were missing from groups.json, causing check_groups.py to block CI runs: - gtid_server_data_unit-t → unit-tests-g1 - test_ffto_mysql_errors-t → legacy-g4, mysql84-g4 - test_ffto_pgsql_error_stats-t → legacy-g4, mysql84-g4	2 months ago
René Cannaò	3659ba85fb	Merge branch 'v3.0' into advisory/com-stmt-send-long-data-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	151169da9b	Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	b94c855d4c	Merge branch 'v3.0' into advisory-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	fa6ebcdcc9	Merge commit from fork Fix PROXY protocol v1 address overflow	2 months ago
René Cannaò	419cd7608b	Merge commit from fork Fix COM_STMT_CLOSE short packet handling	2 months ago
René Cannaò	7a574a537a	Merge commit from fork Validate COM_CHANGE_USER packet bounds	2 months ago
Rahim Kanji	f2bd222145	Fixed compilation issue	2 months ago
Rahim Kanji	e7ee68dda5	Add SSL/TLS traffic decryption for PostgreSQL backend connections (#5281 ) Extends the existing NSS keylog-based SSL decryption to PostgreSQL backend connections by patching libpq with a global PQsetSSLKeyLogCallback() API. When admin-ssl_keylog_file is configured, TLS secrets from all PgSQL backend SSL handshakes are written to the keylog file in NSS Key Log Format, enabling traffic decryption with Wireshark/tshark. Approach: - Patch libpq with global callback following the PQsslKeyPassHook pattern - Single startup call covers all backend paths (regular, monitor, kill, harvester) - No new admin variables — existing admin-ssl_keylog_file covers PgSQL backends - Zero changes to ProxySQL PgSQL connection code Includes 9 integration tests (pgsql-ssl_keylog-t) and user guide updates.	2 months ago
Rahim Kanji	625e068412	Add @proxysql_min_version tag support for version-aware test execution Skip tests that require a newer ProxySQL version than the one being tested, preventing false-positive CI failures across v3.0.x/v3.1.x/4.0.x branches. Tagged 19 FFTO/TSDB tests (>=3.1) and 46 GenAI/MCP/AI tests (>=4.0) in groups.json. Tests without a tag run on all versions.	2 months ago
Rahim Kanji	6090537bd1	Merge remote-tracking branch 'v3.0' into v3.0-ci_84_mysql84	2 months ago
Rahim Kanji	af445f9405	Move cluster TAP tests from legacy-g3 to legacy-g5 Move test_cluster1-t, test_cluster_sync_mysql_servers-t, and test_gtid_forwarding-t to legacy-g5	2 months ago
Rene Cannao	499896e44b	Address PR review feedback for test_binlog_dump_multi_backend_crash - Move wait_timeout mutation after hostgroup discovery skip check so early returns don't leave backend state modified (Copilot review) - Add precondition assertion verifying connections exist in both writer and reader hostgroups before sending COM_BINLOG_DUMP, using ConnOK pool stats (CodeRabbit review)	2 months ago
Rene Cannao	b2f4b4f9a0	Fix crash when COM_BINLOG_DUMP received with idle backends from other hostgroups (#5556 ) When a session has backend connections to multiple hostgroups and receives COM_BINLOG_DUMP, GPFC_Replication_SwitchToFastForward() transitions the session to FAST_FORWARD mode but only manages the active backend. Idle backends from other hostgroups remain in the session's mybes array with async_state_machine==ASYNC_IDLE. If MySQL's wait_timeout closes one of these idle connections, the resulting POLLIN event causes handler() to be called with ASYNC_IDLE, which has no case in the switch and hits assert(0). Fix: Clean up idle backends from other hostgroups during the FAST_FORWARD transition in GPFC_Replication_SwitchToFastForward(). These connections will never be used again, so they are destroyed immediately. Includes a regression test (test_binlog_dump_multi_backend_crash-t) that: - Sets up two hostgroups with query rules routing SELECTs to reader HG - Creates backend connections to both hostgroups on one session - Sends COM_BINLOG_DUMP to enter FAST_FORWARD mode - Waits for wait_timeout to close the idle backend - Verifies ProxySQL does not crash	2 months ago
Rahim Kanji	0b0e634f0f	Add test_cluster_sync-t to mysql84-g5 group	2 months ago
copilot-swe-agent[bot]	bc843a1a25	test: cover mysql resolution family helper cases Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/7d0ebed6-886c-4e06-add5-d74b44eced4a Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	2 months ago
copilot-swe-agent[bot]	4a93861c6c	feat: add mysql resolution_family setting Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/7d0ebed6-886c-4e06-add5-d74b44eced4a Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	2 months ago
Rahim Kanji	d3b88c57f0	Enable local_infile on mysql84 backend servers MySQL 8.4 defaults local_infile to OFF. Tests using LOAD DATA LOCAL INFILE (test_unsupported_queries) fail without it.	2 months ago
Rahim Kanji	bf85d1735a	Remove pgsql FFTO tests from mysql84-g4	2 months ago
Rahim Kanji	4f9ab49e7a	Fix hardcoded hostgroups in TAP tests for mysql84 Tests were using hardcoded hostgroup 0/1 or 30 instead of the mysql84 infra hostgroups (WHG=2900, RHG=2901), causing timeouts and failures. - test_read_only_actions_offline_hard_servers: read WHG/RHG from TAP_MYSQL8_BACKEND_HG env var instead of hardcoding 0/1 - Remove hardcoded TAP_MYSQL8_BACKEND_HG=30 from per-test .env files (test_sqlite3_pass_exts, test_auth_methods, reg_test_4935) so the value comes from the infra .env - Source infra .env from mysql84/env.sh using WORKSPACE to export TAP test variables into the proxysql-tester.py subprocess (sh-safe, no BASH_SOURCE dependency)	2 months ago
René Cannaò	d0625dc243	Merge pull request #5549 from sysown/v3.0-CodeCov0325 Add 32 unit test files (2963 assertions) and CI workflow improvements	2 months ago
Rene Cannao	6d6015a203	fix: align MCP Bearer token test with case-insensitive implementation The test expected lowercase 'bearer' to be rejected, but the implementation uses strncasecmp() per RFC 7235 (auth-scheme is case-insensitive). Update test to expect true for lowercase prefix.	2 months ago
René Cannaò	2fcc5729ee	Merge pull request #5548 from yuji-hatakeyama/5306-fix_show_warnings_with_comment Fix #5306 - SHOW WARNINGS with inline comments incorrectly sets warning_count	2 months ago
René Cannaò	e067683f4e	Merge pull request #5545 from sysown/feat/ffto-error-recording feat(ffto): record error details from fast-forward sessions	2 months ago
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	4fb7aac73f	fix: restore groups.json to compact one-line-per-entry format Previous commits inadvertently reformatted groups.json with Python's json.dump(indent=2), breaking the compact format required by test/tap/groups/README.md. The correct format is one entry per line with compact arrays so grep works for quick lookups.	2 months ago
Rahim Kanji	8a811ab6a1	Add test_com_binlog_dump_enables_fast_forward-t to mysql84-binlog-g1 Add test_binlog_fast_forward-t to mysql84-binlog-g2 (failing, need to investigate)	2 months ago
Rahim Kanji	d70805d359	Handle utf8/utf8mb3 charset equivalence in test_set_collation MySQL 8.4 reports 'utf8mb3' where older versions report 'utf8'. Add charset_equiv() to treat both names and their collations (e.g. utf8_general_ci vs utf8mb3_general_ci) as equivalent so the test passes on both MySQL 5.7 and 8.4 backends.	2 months ago
Rahim Kanji	2d840faa7f	Remove hardcoded root credentials from reg_test_4935-caching_sha2-t env	2 months ago
Rahim Kanji	50e0bcf0ad	Expand infra-mysql84 ProxySQL config for full TAP test coverage Add missing users (root, testuser, sbtest2-8, ssluser) needed by various TAP tests. Enable event logging, audit logging, Prometheus RESTAPI, debug filters, and SSL keylog to match the test expectations that were previously only configured for the legacy infra.	2 months ago

1 2 3 4 5 ...

2216 Commits (f1a78f81aff2a03cd677f397ff48dedc7b79ee95)