259 Commits (ea3cc7a32c492a715c9850fa7e9671d1548f80ca)

Author	SHA1	Message	Date
Rene Cannao	2a7bddca28	MySrvC: rename server_backoff_time to session_track_backoff_until, gate hot-path read ... Context ------- PR #5166 introduced a per-'MySrvC' atomic timestamp that prevents the server from being chosen for new connections for a 30-second window. The timestamp is written in exactly one place, 'MySQL_Session::handle_session_track_capabilities()', and only when 'mysql-session_track_variables' is in ENFORCED mode and the backend is missing 'CLIENT_SESSION_TRACKING' or 'CLIENT_DEPRECATE_EOF'. The field was originally named 'server_backoff_time' and its only semantics were that ENFORCED-mode capability mismatches temporarily exclude the server from selection. Two issues with the original shape: 1. The name does not hint that the scope is session-tracking capability enforcement. A reader of 'MyHGC::get_random_MySrvC' or 'MySQL_Thread::get_MyConn_local' had no way to tell that this field is tied to one specific feature and not, say, a generic health backoff. 2. The atomic load was unconditional in both hot selection loops. Even though the atomic is relaxed (effectively a 'mov' on x86), per-iteration atomic reads inhibit hoisting and CSE that the compiler can otherwise apply to thread-local integer reads. 'get_random_MySrvC' runs the loop over every server in the hostgroup on every backend-connection acquisition, so this is the sort of place where small per-iteration costs accumulate. Changes ------- * Rename the field: MySrvC::server_backoff_time -> MySrvC::session_track_backoff_until Naming it after the feature makes it obvious that the field is specific to session-tracking enforcement and should not be overloaded for unrelated purposes (e.g. connect errors, monitor failures). If a future change needs a generic backoff mechanism, a new field -- or a rename at that point -- keeps intent clear rather than piggy-backing on this one silently. * Gate the atomic load on mode: In both 'MyHGC::get_random_MySrvC()' (lib/MyHGC.cpp) and 'MySQL_Thread::get_MyConn_local()' (lib/MySQL_Thread.cpp), the relaxed load is skipped entirely when 'mysql_thread___session_track_variables' is not ENFORCED. In 'get_MyConn_local' the check is computed once before the loop; in 'get_random_MySrvC' the check is inside the loop but is a thread-local int read, which is free. Correctness note: switching out of ENFORCED at runtime makes any stale 'session_track_backoff_until' values in the pool immediately ignored, which is the desired behavior -- servers rejected while ENFORCED was active become eligible again the moment the operator relaxes the mode, matching how ProxySQL handles other runtime-variable-dependent state. No explicit reset is required. * Updated the field documentation in include/MySQL_HostGroups_Manager.h with the monotonic-timestamp unit, the list of sites that read/write it, the explicit scope (ENFORCED mode only), and the reset policy (no explicit reset; deadline ages out by comparison against curtime). No functional change for DISABLED / OPTIONAL configurations (the default for all installations). ENFORCED mode behaviour is unchanged.	1 month ago
Wazir Ahmed	f815b77812	fix: make server_backoff_time atomic ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	1 month ago
Wazir Ahmed	885712c679	Merge branch 'v3.0' into session-track-system-variable	1 month ago
Wazir Ahmed	1e069fbc11	Merge 'v3.0' into feature/gtid-range-update	1 month ago
Rene Cannao	a51fe19e3f	fix: delete copy operations in 4 classes (Group_Replication_Info, Galera_Info, AWS_Aurora_Info, MySQL_Errors_stats)	2 months ago
Rene Cannao	7e1a78fd6b	lint: fix reserved identifiers and include guards ... - Rename __HGM_TABLES_SIZE -> HGM_TABLES_SIZE_ (Base/MySQL/PgSQL HGM) - Rename __TYPE_SIZE -> TYPE_SIZE_ (Base/MySQL/PgSQL HGM) - Fix include guard defines: __PROXYSQL_* -> PROXYSQL_* - Fix include guard comments: __CLASS_* -> PROXYSQL_*_H (29 files) - Add uint8_t underlying type to small enums	2 months ago
Rene Cannao	5513f735e6	lint: replace NULL with nullptr in header files ... modernize-use-nullptr: replace NULL with nullptr for type-safe null pointer constants. This is a C++11 modernization that improves type safety. Files changed: - Base_HostGroups_Manager.h - ClickHouse_Authentication.hpp - MySQL_HostGroups_Manager.h - MySQL_LDAP_Authentication.hpp - MySQL_Monitor.hpp - MySQL_Session.h - PgSQL_Error_Helper.h - PgSQL_HostGroups_Manager.h - PgSQL_Session.h	2 months ago
Rene Cannao	b531326c82	lint: optimize enum underlying types and fix reserved identifiers ... performance-enum-size fixes: - p_mysql_error_type: add uint8_t underlying type (2 values) - p_hg_dyn_gauge: add uint8_t underlying type (5 values) - p_hg_dyn_counter: add uint8_t underlying type (9 values) bugprone-reserved-identifier fixes: - Rename __size -> SIZE_ in metric enums to avoid reserved identifier (names starting with __ are reserved in C++) - Update all std::array size references using these enum values	2 months ago
Rene Cannao	f1826cf206	lint: fix reserved identifier in member variables ... Rename __active -> active_, __frontend -> frontend_, __backend -> backend_ in authentication and hostgroups classes to comply with C++ reserved identifier rules. Includes updates to: - MySQL_Authentication.hpp - ClickHouse_Authentication.hpp - PgSQL_Authentication.h - MySQL_HostGroups_Manager.h - Base_HostGroups_Manager.h - Corresponding .cpp files	2 months ago
Rene Cannao	54e9de7cb3	lint: fix reserved identifier in enum size sentinels ... Rename ROS__SIZE -> ROS_SIZE_, RLS__SIZE -> RLS_SIZE_, etc. to avoid the reserved identifier pattern (double underscore at start or in name).	2 months ago
Rene Cannao	4810f1f05b	lint: fix reserved identifier in include guards ... Replace __CLASS_* and ____CLASS_* patterns with PROXYSQL_*_H to comply with the C++ standard where identifiers starting with __ are reserved in the global namespace. Also fixes: - ____CLASS_STANDARD_MYSQL_THREAD_H -> PROXYSQL_STANDARD_MYSQL_THREAD_H - ____CLASS_STANDARD_PGSQL_THREAD_H -> PROXYSQL_STANDARD_PGSQL_THREAD_H - __CLASS_PROXYSQL_POLL -> PROXYSQL_POLL_H (added _H for consistency)	2 months ago
Rene Cannao	413584f0fb	lint: fix unsigned-to-signed cast in MySrvConnList::find_idx ... Use static_cast<int> instead of C-style cast for clarity and to avoid unsigned->signed narrowing warnings while preserving the -1 sentinel.	2 months ago
Rahim Kanji	7fa0e82bd7	fix: move SSL params classes to standalone header to resolve circular includes ... Servers_SslParams, MySQLServers_SslParams, and PgSQLServers_SslParams are now in Servers_SslParams.h with minimal dependencies (<string> only). This avoids the circular include issue between cpp.h, mysql_connection.h, and Base_HostGroups_Manager.h that caused incomplete type errors.	2 months ago
Rahim Kanji	619c084cab	refactor: MySQLServers_SslParams now derives from Servers_SslParams	2 months ago
Wazir Ahmed	adec09b25a	chore(gtid): use consistent naming and remove unused code ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Lisandro Pin	96f1b44412	Parse GTID ranges on proxysql_mysqlbinlog update messages. ... This PR adds full support for ranges in `proxysql_mysqlbinlog` update messages, while also improving efficiency when dealing with GTID gaps for any given UUID. Single GTID updates are transparently supported, so older `proxysql_mysqlbinlog` version will continue to work with newer ProxySQL releases. See https://github.com/sysown/proxysql_mysqlbinlog/issues/33 for details.	2 months ago
René Cannaò	80f9c1a079	Merge branch 'v3.0' into session-track-system-variable ... Signed-off-by: René Cannaò <rene@proxysql.com>	3 months ago
René Cannaò	e94f9281ce	feat: add friend declaration for MetricsCollector to access MyHostGroups ... Allow the WebUI monitoring MetricsCollector to access the private MyHostGroups member of Base_HostGroups_Manager for thread-safe iteration through configured servers.	3 months ago
Wazir Ahmed	f0ac86c317	Enable session tracking based on server capabilities ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
René Cannaò	f9575b7ee9	Addressing minor issue on Readyset Monitoring ... - Renamed ReadySet to Readyset - fixed incorrect status variable - added missing newlines	1 year ago
René Cannaò	d641ca89be	First POC for integration with ReadySet ... Monitor is able to detect if a backend is a ReadySet server, and it enables special monitoring. The special monitoring hacks replication lag checks: a ReadySet server is "monitored for replication lag" , but it has a special query and a special handler. The query for check is "SHOW READYSET STATUS" , and the `Status` line is processed: * Online: the backend is configured as ONLINE * Maintenance* : the backend is configured as OFFLINE_SOFT * anything else, or failed check: SHUNNED A new monitor table is also added: `readyset_status_log` . It has a similar structure of `mysql_server_replication_lag_log` , but instead of storing `repl_lag` (replication lag) the full output of `SHOW READYSET STATUS` is saved as a JSON (that can be queried using `JSON_EXTRACT()`	1 year ago
René Cannaò	e88692c172	Deprecate read_only_action() ... This function is not in used anymore	1 year ago
Javier Jaramago Fernández	25c6cf9dff	Fix 'nlohmann::json' type forwarding	2 years ago
Javier Jaramago Fernández	d516ca5e84	Merge branch 'v2.x_postgres' of https://github.com/sysown/proxysql_postgresql into v2.x-postgres_dual_password	2 years ago
Javier Jaramago Fernández	bbda0a86eb	Add initial impl for dual-password support	2 years ago
Rahim Kanji	e939cf088e	Added 'stats_pgsql_errors' and 'stats_pgsql_errors_reset' tables	2 years ago
Rene Cannao	404c5e70f3	More template for Hostgroup Managers	2 years ago
Rene Cannao	4236d20ed6	Initial work on template for HostGroups_Manager	2 years ago
Rene Cannao	e2362a9ed1	Removed reference to MHM_PTHREAD_MUTEX	2 years ago
Rene Cannao	0a391bd587	Some code cleanup	2 years ago
Rene Cannao	a593f215d1	Creating BaseHGC (Base HostGroup Container)	2 years ago
Rene Cannao	cf61603375	Creating BaseSrvList ... Template for MySrvList and PgSQL_SrvList . This is an initial commit to start merging the two Hostgoup Managers	2 years ago
Rahim Kanji	d3e9c9c85a	Merge remote-tracking branch 'remotes/Master/v2.x' into v2.x_proxysql_postgres_merge	2 years ago
Miro Stauder	565848c4a0	use local includes - prometheus	2 years ago
Miro Stauder	8394fd444e	use local includes - prometheus	2 years ago
René Cannaò	cdfcfdce94	Merge pull request #4528 from sysown/v2.x_monitor_slave_lag_when_null_4521 ... Introduced new HG attribute 'monitor_slave_lag_when_null' which takes precedence over 'mysql_thread_monitor_slave_lag_when_null'	2 years ago
René Cannaò	fde8ace076	Removed json.hpp from include files ... This seems to speedup compile time, and also lead to smaller binary	2 years ago
René Cannaò	c9326564c0	Minor changes to try to optimize compiling	2 years ago
Rahim Kanji	407fa7fb6a	Fixed a Typo	2 years ago
Rahim Kanji	648c3ab61d	* Improved handling for cases where seconds_behind_master is null or negative	2 years ago
Rahim Kanji	c7cf5ba344	Removed MySrvStatus class	2 years ago
Rahim Kanji	828ee01cdc	Replaced monotonic_time() with time()	2 years ago
Rahim Kanji	40068b122a	Addeda new attribute called 'monitor_slave_lag_when_null' in hostgroup settings, which takes precedence over 'mysql_thread_monitor_slave_lag_when_null' if both are configured.	2 years ago
Rahim Kanji	e4fd764d86	Added is_locked flag within '#ifdef DEBUG' conditional block	2 years ago
René Cannaò	38c6c2ac7b	Merge branch 'v2.x-main' into v2.x_postgres_240422 ... Merged main ProxySQL code up to commit 959c629	2 years ago
Rahim Kanji	a081695ae9	* Solved few warnings ... * Enforced explicit conversion of MySrvStatus	2 years ago
Rahim Kanji	42c8bb83c6	Few fixes	2 years ago
Rahim Kanji	eb09e6766b	Merge remote-tracking branch 'Master/v2.x' into v2.x_hostgroup_online_servers ... # Conflicts: # lib/MySQL_HostGroups_Manager.cpp	2 years ago
Rahim Kanji	8c92f9292a	A hostgroup can now be configured to have a maximum number of online servers simultaneously. Once this limit is reached, any new connections attempting to access the connection pool will be denied, and existing connections will gradually be reassigned to the available connection pool until the number of online servers is reduced to meet or fall below the specified maximum.	2 years ago
René Cannaò	e7aa5ff4c5	Split of MySQL_HostGroups_Manager.cpp into multiple files ... First commit to split MySQL_HostGroups_Manager.cpp into multiple files. More to split.	2 years ago