5023 Commits (e582973ff8e7a6aebccf69e9b2da0bdd2d4e2d0d)

Author	SHA1	Message	Date
Rahim Kanji	9ab9787c91	Addressed AI review feedback	2 months ago
Rahim Kanji	0ed5879df6	Added two more query handling	2 months ago
Rahim Kanji	2046d92b70	Merge remote-tracking branch 'v3.0' into v3.0_pgsql_meta_command_describe_table	2 months ago
René Cannaò	9d921bdda3	Merge pull request #5444 from sysown/v3.0_unify-PR-5433-5442 ... Unify PR#5433 & 5442	2 months ago
Rahim Kanji	ca45405942	Merge remote-tracking branch 'Master/v3.0-moveInfra' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	2 months ago
Rahim Kanji	8e047398ce	Change memcpy to memmove which correctly handles overlapping memory regions.	2 months ago
Rahim Kanji	4cb14109d4	Fixed error message	2 months ago
Wazir Ahmed	fc12e9a6ab	Add protocol label to connpool Prometheus metrics ... MySQL and PgSQL share the same metric family names for connection pool metrics. Since they have independent hostgroup ID namespaces, add a protocol label to distinguish metrics from each module. **Affected metrics:** - `proxysql_connpool_conns` - `proxysql_connpool_conns_total` - `proxysql_connpool_conns_queries_total` - `proxysql_connpool_conns_latency_us` - `proxysql_connpool_conns_status` - `proxysql_connpool_data_bytes_total` Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rahim Kanji	7c6664e308	Three malformed cases now rejected in 'options': ... 1. Token doesn't start with -c or -- 2. No = after key 3. Empty key	2 months ago
Rahim Kanji	8249fead6b	Fix options parameter parsing to reject unescaped spaces ... The parse_options() function now properly validates the options connection parameter to detect and reject unescaped spaces in values, matching PostgreSQL's behavior.	2 months ago
Rahim Kanji	000a9794e4	Don't short-circuit in pipeline mode, fall through to backend execution	2 months ago
Rahim Kanji	5810978e4e	Unify ABORT and ROLLBACK command parsing ... Remove separate early-return handling for ABORT that was bypassing parse_rollback(). Treat ABORT as a synonym of ROLLBACK.	2 months ago
René Cannaò	4d58ce473e	Merge pull request #5435 from sysown/v3.0-ci_fix0301 ... Fix tests for isolated CI environment and enhance diagnostics	2 months ago
Rahim Kanji	abb66cc19f	Addressed AI review feeback	2 months ago
Rene Cannao	6b9918fdcc	chore: refine guard structures and fix indentation ... - Fixed indentation for TSDB methods in include/proxysql_admin.h. - Refined PROXYSQLTSDB guard structure in lib/Admin_FlushVariables.cpp. - Cleaned up indentation and redundant code in lib/ProxySQL_RESTAPI_Server.cpp. - Ensured consistent formatting across modified files.	2 months ago
Rene Cannao	17225e8e23	fix: resolve syntax error in ProxySQL_Statistics.cpp and verify build stability across tiers ... - Fixed a mismatched #endif and closing brace in ProxySQL_Statistics::disk_upgrade_mysql_connections. - Verified build stability for all three tiers (base, v3.1, v4.0) with clean builds.	2 months ago
Rene Cannao	6b46b26931	chore: implement PR review feedback for release tier system ... - Makefile: normalized GIT_VERSION by stripping 'v' prefix before arithmetic. - Makefile: corrected .PHONY declaration for build_deps_debug_default. - Admin Handler: properly guarded TSDB commands to return error when disabled. - REST API: removed redundant nested guards inside tsdb_resource class. - Statistics: implemented rigorous input validation for set_variable. - Statistics: added return value checks and rollback logic for TSDB migrations. - Statistics: implemented bounded concurrency (batching) for backend probes. - FFTO: implemented cumulative buffer limit enforcement in MySQL and PgSQL. - FFTO: ensured initial packet capture in PgSQL_Session by early initialization. - FFTO: improved reassembly buffer compaction logic. - Headers: default-initialized ffto_bypassed to false. - Code cleanup: merged redundant PROXYSQLFFTO guards.	2 months ago
Rene Cannao	c2f678a9de	feat: implement release tiers and feature guards for v3.0, v3.1, and v4.0 ... This commit introduces a structured release tier system controlled by environment variables, allowing three distinct ProxySQL versions to be built from the same codebase while maintaining a clear upgrade path. Key Changes: - Tier 1 (v3.0.x Stable): Default build including bug fixes and core enhancements. - Tier 2 (v3.1.x Innovative): Enabled via PROXYSQL31=1. Adds FFTO and TSDB. - Tier 3 (v4.0.x AI/MCP): Enabled via PROXYSQLGENAI=1. Adds the AI stack. Implementation Details: - Makefile: Implemented dynamic versioning logic that increments the minor version for v3.1 and the major version for v4.0. Added tier documentation. - Feature Guards: Introduced PROXYSQLFFTO and PROXYSQLTSDB guards across ProxySQL_Admin, ProxySQL_Statistics, REST API, and HTTP server. - FFTO: Guarded Fast Forward Traffic Observer in MySQL and PgSQL sessions, including thread-local variables and configuration parameters. - TSDB: Guarded the entire Time Series Database subsystem, including SQLite table definitions, background loops, and REST API endpoints. - Build Fixes: * Fixed 'proxy_debug_func' linkage by adding extern "C" and moving the definition outside of DEBUG guards to ensure non-debug builds link correctly. * Corrected misplaced/nested DEBUG and PROXYSQLFFTO guards. * Verified build stability for all tiers (unset, PROXYSQL31=1, PROXYSQLGENAI=1).	2 months ago
Rahim Kanji	e84433159b	Merge remote-tracking branch 'v3.0' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	2 months ago
Rene Cannao	ff1398ead5	fix: plumb real hostgroup_id for pgsql replication lag monitoring ... - Add hostgroup_id to mon_srv_t and ext_srvs.\n- Update fetch_updated_conf queries to return hostgroup_id.\n- Use real hostgroup_id in replication_lag_action call.	2 months ago
Rene Cannao	1911b02157	feat: temporarily disable pgsql monitor replication lag group_by_host	2 months ago
René Cannaò	16f8837e0d	Merge branch 'v3.0' into v3.0-pgsql_monitor_repl_lag ... Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	c4fc60bdb0	fix: address security and logic issues in PostgreSQL replication lag monitoring ... - Fix SQL injection in pt-heartbeat query concatenation.\n- Fix copy-paste errors between mysql_thread_ and pgsql_thread_ variables.\n- Restore monitor_replication_lag_group_by_host logic.	2 months ago
Rene Cannao	cf1fd5cb35	Admin: Add support for loading sqliteserver variables from config file ... Previously, sqliteserver variables (e.g., sqliteserver-mysql_ifaces) were not loaded from the configuration file during startup or via the LOAD SQLITESERVER VARIABLES FROM CONFIG command. This fix adds: - LOAD SQLITESERVER VARIABLES FROM CONFIG command handling in Admin_Handler - sqliteserver variables loading during bootstrap in Admin_Bootstrap	2 months ago
Rahim Kanji	96bc668735	Fix pipeline mode transaction state handling and SET/RESET/DISCARD support ... Addresses issues with PostgreSQL Extended Query Protocol (Pipeline mode) in ProxySQL: Transaction State Handler Migration: - Moved handle_transaction_state() from PgSQL_Session::RequestEnd() to PgSQL_Session::handler() - Now called only for client queries (PROCESSING_QUERY/PROCESSING_STMT_EXECUTE) - Prevents internal SET commands from triggering transaction logic incorrectly - Added transaction state reset at 7 locations for clean connection pool return SET/RESET/DISCARD Pipeline Mode Support (lib/PgSQL_Session.cpp): - SET statements now execute properly in pipeline mode via RunQuery() - RESET ALL and DISCARD ALL blocked with proper error messages in pipeline mode - Added startup parameter mismatch detection for RESET with locked hostgroup	2 months ago
Rahim Kanji	aca91c3bd2	Optimize PgSQL_Protocol::generate_ok_packet to use direct buffer writes ... Replace format-specifier based PG_pkt helper methods (write_CommandComplete, write_ParameterStatus, write_ReadyForQuery) with direct buffer writes using put_char(), put_uint32(), and put_string().	2 months ago
Rahim Kanji	5dd27500f3	Addressed AI review feedback	2 months ago
Rahim Kanji	742ff05ecc	Fix PostgreSQL transaction state management for pipeline mode ... Move transaction state tracking from RequestEnd to connection handler to enable proper binary pipeline mode support: - Call handle_transaction_state() at ASYNC_QUERY_END/ASYNC_STMT_EXECUTE_END in PgSQL_Connection instead of RequestEnd - Add reset_state() calls in 7 locations to prevent stale state: * Session reset * Connection detach (finishQuery) * Error handlers (4 paths) * Base session housekeeping - Refactor destructor to use reset_state() Fixes transaction state tracking in pipeline mode where connections can be returned to pool mid-transaction.	2 months ago
Rahim Kanji	4d86e6949c	Add defensive null guard before reading PSarrayIN->len	2 months ago
Rahim Kanji	c309facaa2	Fixed typo	2 months ago
Rahim Kanji	ed8890b6a5	Added bounds checking for Describe and Close messages to prevent reads beyond packet boundaries	2 months ago
Rahim Kanji	8c9af56f38	Address AI review feedback	2 months ago
Rahim Kanji	83d16f3c22	Fix buffer handling in PostgreSQL admin session handler ... Improve error handling in admin_session_handler when processing PostgreSQL query packets: * Fix potential underflow in query_length calculation when handling very small packets (< 2 bytes) * Fix NULL pointer dereference in strcasecmp when query_no_space is not initialized due to early packet validation failures	2 months ago
Rahim Kanji	05b5821fbc	Fix integer underflow in PostgreSQL query packet handling and null terminator checking ... * Add validation to reject packets smaller than 6 bytes before processing * Add null terminator check	2 months ago
Rahim Kanji	d71090864f	Improve startup packet parsing ... Replace strlen() with memchr() to safely search for null terminators within buffer bounds. If no null terminator is found, treat the packet as malformed and break out of the processing loop.	2 months ago
Rahim Kanji	03ad2c3aae	Fix underallocation for undersized PostgreSQL packets ... The buffer2array() function could allocate less than 5 bytes for a packet when pkgsize was malformed to be smaller than the header size. This violated PostgreSQL protocol assumptions that packets are always >= 5 bytes. Ensure minimum allocation of sizeof(header) bytes regardless of the claimed packet size in the header.	2 months ago
Javier Jaramago Fernández	ff729a657e	chore: disable 'pt-heartbeat' in 'PgSQL_Threads_Handler::get_variable' ... This isn't for functional purposes, just for consistency in reporting the motivation for disabling the feature in the codebase.	2 months ago
Wazir Ahmed	5421a382ab	fix: Load TSDB variables from disk during startup ... - TSDB variables stored on disk were not being loaded into runtime during startup. Add the missing `flush_tsdb_variables___database_to_runtime()` and invoke it during init. - Inline the existing load/save wrappers in the header as thin delegations to the underlying flush functions Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Wazir Ahmed	1684d30725	fix: Refresh Prometheus metrics before TSDB sampling ... - `tsdb_sampler_loop()` calls `registry->Collect()` without refreshing module metrics, causing stale metric values to be stored in the TSDB. - Added `update_modules_metrics()` call before `Collect()` in the sampler. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
René Cannaò	148dfb2af3	Merge pull request #5423 from sysown/v3.0-genai_keys ... v3.0-genai_keys: GenAI live validations, LLM bridge tests, and portability fix	2 months ago
Rene Cannao	cffd980bb9	fix: Conditionally include sys/eventfd.h only on Linux ... Add #ifdef __linux__ guard around sys/eventfd.h include to fix compilation on non-Linux platforms.	2 months ago
Javier Jaramago Fernández	a4ea3b2174	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-pgsql_monitor_repl_lag	2 months ago
Javier Jaramago Fernández	4103d69979	feat: disable 'pt-heartbeat' support for PostgreSQL ... The feature has been disabled until 'pt-heartbeat' support for PostgreSQL is fixed. See https://perconadev.atlassian.net/browse/PT-2030.	2 months ago
Rahim Kanji	866c3593bb	Set query retries for PostgreSQL extended query protocol operations ... Add query_retries_on_failure configuration for PARSE, DESCRIBE, and EXECUTE operations in PostgreSQL extended query protocol.	2 months ago
Rahim Kanji	27119169e4	Reset extended query frame if an unsupported message type is received	2 months ago
Rahim Kanji	7a062a3444	Add PgSQL notice handling in reset session paths ... Register the PostgreSQL notice handler during reset session operations. Previously, the handler was not set in this path, which could result in unhandled backend notices.	2 months ago
Rahim Kanji	1ffb4f13ac	Fix PostgreSQL resync error detection ... Add flush() call in resync_start() for immediate socket error detection instead of deferring to event loop	2 months ago
Wazir Ahmed	daa0b2037e	fix: Use consistent value representation in MCP query rules ... `mcp_query_rules` and `runtime_mcp_query_rules` uses different representations for the same fields, causing the web UI to always report config differences even after loading to runtime. - Use `-1` sentinel for nullable int fields (`flagOUT`, `timeout_ms`, `log`) so `NULL` values from main are preserved when written to runtime, following the `MySQL QP_rule_t` pattern. - Serialize `re_modifiers` bitmask back to `VARCHAR` (`1→"CASELESS"`) to match the format used in main table - Update `evaluate_mcp_query_rules()` to handle tri-state log field Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Wazir Ahmed	c05bc66655	fix: MCP variables overwritten due to incorrect flush logic ... `flush_mcp_variables___runtime_to_database()` ignores the `replace` parameter. The prepared statement is hardcoded to `REPLACE INTO`, so even when callers pass `replace=false` (e.g. `GenericRefreshStatistics`), the function overwrites values in memory config with stale runtime values. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rene Cannao	f29a326ca0	Fix QueryDigestTopK heap comparator semantics	2 months ago