proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	6e9abed581	Fix timezone parsing to support 3-component IANA names and hyphens This commit fixes a parsing error in the MySQL SET statement parser that occurred when processing `SET time_zone` statements with: 1. Three-component IANA timezone names (e.g., America/Argentina/Buenos_Aires) 2. Timezone names containing hyphens (e.g., America/Port-au-Prince) Previously, the regex pattern `(?:\w+/\w+)` only matched 2-component timezone names and did not support hyphens. This caused parsing errors logged as: "[ERROR] Unable to parse query. If correct, report it as a bug: SET time_zone=\"America/Argentina/Buenos_Aires\";" When multiplexing is enabled, this bug causes timestamps to be incorrectly written to the database. Changes: - Updated timezone regex from `(?:\w+/\w+)` to `(?:[\w-]+(?:/[\w-]+){1,2})` - Supports 2-3 components: Area/Location or Area/Country/Location - Supports hyphens in component names (e.g., Port-au-Prince) - Added comprehensive Doxygen documentation for timezone parsing - Extended TAP test cases with new timezone formats Note: Bare words like 'SYSTEM' and 'UTC' were already supported via other patterns in the parser (vp2 pattern for word matching). Fixes: #4993 Related: gemini-code-assist review comments	2 months ago
Rahim Kanji	f9232ae50d	Merge remote-tracking branch 'Master/v3.0' into v3.0_session_parameter_tracking	12 months ago
Rahim Kanji	a2b28383cf	Added missing files	1 year ago

Author

SHA1

Message

Date

Rene Cannao

6e9abed581

Fix timezone parsing to support 3-component IANA names and hyphens

This commit fixes a parsing error in the MySQL SET statement parser that
occurred when processing `SET time_zone` statements with:

1. Three-component IANA timezone names (e.g., America/Argentina/Buenos_Aires)
2. Timezone names containing hyphens (e.g., America/Port-au-Prince)

Previously, the regex pattern `(?:\w+/\w+)` only matched 2-component
timezone names and did not support hyphens. This caused parsing errors
logged as:
  "[ERROR] Unable to parse query. If correct, report it as a bug:
   SET time_zone=\"America/Argentina/Buenos_Aires\";"

When multiplexing is enabled, this bug causes timestamps to be incorrectly
written to the database.

Changes:
- Updated timezone regex from `(?:\w+/\w+)` to `(?:[\w-]+(?:/[\w-]+){1,2})`
  - Supports 2-3 components: Area/Location or Area/Country/Location
  - Supports hyphens in component names (e.g., Port-au-Prince)
- Added comprehensive Doxygen documentation for timezone parsing
- Extended TAP test cases with new timezone formats

Note: Bare words like 'SYSTEM' and 'UTC' were already supported via
other patterns in the parser (vp2 pattern for word matching).

Fixes: #4993
Related: gemini-code-assist review comments

Rahim Kanji

f9232ae50d

Merge remote-tracking branch 'Master/v3.0' into v3.0_session_parameter_tracking

Rahim Kanji

a2b28383cf

Added missing files

3 Commits (e4f4dc95cef878de7b2b7cfdfeb8e9ee8aeb0c46)