proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	045ff26068	Address review feedback on protocol unit tests (PR #5488 ) - test_decode_length_3byte: pad buffer to 5 bytes (CPY3 reads 4 bytes via uint32_t* cast from buf+1, causing OOB read with 4-byte buffer) - test_cpy3: use 4-byte buffers with padding to avoid OOB read - test_encode_decode_roundtrip: initialize prefix[0]=0 each iteration to avoid UB when mysql_encode_length doesn't write for 1-byte values - test_mysql_query_digest: free first_comment between calls to prevent memory leak (malloc'd by digest function when comment present) - test_pgsql_query_digest: use strlen() instead of hardcoded q_len to avoid off-by-one, free first_comment after use - test_escape_single_quotes: fix misleading comment — function returns original pointer (not copy) when no quotes are present	2 months ago
René Cannaò	a7424f0abe	Add protocol encoding/decoding and utility unit tests (Phase 2.5, #5477 ) Unit tests for standalone protocol functions and utility routines covering 43 test cases across 11 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - MySQL length-encoded integer decoding: 1-byte (0-250), 2-byte (0xFC prefix), 3-byte (0xFD prefix), 8-byte (0xFE prefix) - MySQL length-encoded integer encoding: boundary values at each encoding tier (251, 65535, 65536, 16777216) - Encode/decode roundtrip: 10 values across all encoding ranges survive write_encoded_length() → mysql_decode_length_ll() - mysql_hdr packet header: structure size (4 bytes), field packing, 24-bit max length - CPY3/CPY8 byte copy helpers: little-endian semantics, boundary values - MySQL query digest: normalization via mysql_query_digest_and_first_ comment_2(), whitespace collapsing, comment handling, empty query - PgSQL query digest: normalization via pgsql_query_digest_and_first_ comment_2(), whitespace collapsing - escape_string_single_quotes: no-op on clean strings, single quote doubling, multiple quotes - mywildcmp wildcard matching: exact match, % prefix/suffix/both, _ single char, non-match cases, empty string edge cases	2 months ago

Author

SHA1

Message

Date

René Cannaò

045ff26068

Address review feedback on protocol unit tests (PR #5488 )

- test_decode_length_3byte: pad buffer to 5 bytes (CPY3 reads 4 bytes
  via uint32_t* cast from buf+1, causing OOB read with 4-byte buffer)
- test_cpy3: use 4-byte buffers with padding to avoid OOB read
- test_encode_decode_roundtrip: initialize prefix[0]=0 each iteration
  to avoid UB when mysql_encode_length doesn't write for 1-byte values
- test_mysql_query_digest: free first_comment between calls to prevent
  memory leak (malloc'd by digest function when comment present)
- test_pgsql_query_digest: use strlen() instead of hardcoded q_len
  to avoid off-by-one, free first_comment after use
- test_escape_single_quotes: fix misleading comment — function returns
  original pointer (not copy) when no quotes are present

René Cannaò

a7424f0abe

Add protocol encoding/decoding and utility unit tests (Phase 2.5, #5477 )

Unit tests for standalone protocol functions and utility routines
covering 43 test cases across 11 test functions. Runs in <0.01s with
no infrastructure dependencies.

Test coverage:
- MySQL length-encoded integer decoding: 1-byte (0-250), 2-byte
  (0xFC prefix), 3-byte (0xFD prefix), 8-byte (0xFE prefix)
- MySQL length-encoded integer encoding: boundary values at each
  encoding tier (251, 65535, 65536, 16777216)
- Encode/decode roundtrip: 10 values across all encoding ranges
  survive write_encoded_length() → mysql_decode_length_ll()
- mysql_hdr packet header: structure size (4 bytes), field packing,
  24-bit max length
- CPY3/CPY8 byte copy helpers: little-endian semantics, boundary values
- MySQL query digest: normalization via mysql_query_digest_and_first_
  comment_2(), whitespace collapsing, comment handling, empty query
- PgSQL query digest: normalization via pgsql_query_digest_and_first_
  comment_2(), whitespace collapsing
- escape_string_single_quotes: no-op on clean strings, single quote
  doubling, multiple quotes
- mywildcmp wildcard matching: exact match, % prefix/suffix/both,
  _ single char, non-match cases, empty string edge cases

2 Commits (dbb40a30baec7d23568ebe2d2b228737d31dfcba)