proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	c72cdd9768	Merge remote-tracking branch 'origin/v3.0' into lint-tap-tests-static-analysis # Conflicts: # test/tap/tests/set_testing-240-t.cpp	1 month ago
Rene Cannao	12ae1a1c7d	fix(tests): rewrite test_binlog_reader_uses_previous_hostgroup-t The test was calling test_binlog_reader-t as a subprocess, but that test only validates GTID consistency — it never sends COM_BINLOG_DUMP or COM_REGISTER_SLAVE, so the "uses previous hostgroup" assertion (ConnOk-ConnFree for HG 2) could never work. Rewritten to directly test what the test claims: 1. Route all traffic to HG 2 via query rule (apply=1) 2. Connect, send a COM_QUERY (routed to HG 2) 3. On the same connection, send COM_BINLOG_DUMP via mariadb_rpl_open (triggers fast_forward using HG 2 — the previous query's hostgroup) 4. Close connection, verify ConnOk-ConnFree for HG 2 increased Also: test_binlog_reader-t uses rule_ids 100-102 to avoid conflicts with rules set by other tests calling it as a subprocess.	1 month ago
Rene Cannao	ab1be459ba	fix(tests): resolve rule_id conflict in test_binlog_reader-t Delete query rules by rule_id IN (1,2,3) before inserting, not just by username='sbtest8'. When test_binlog_reader_uses_previous_hostgroup-t runs first, it inserts rule_id=1 with no username, which the old DELETE missed.	1 month ago
Rene Cannao	98083cdf0f	fix: resolve 4 TAP test failures in multi-group runs - set_testing-240-t: Fix crash (json type_error.302) when MySQL returns NULL variable values or fails the session_variables query. Add null guards in parseResult() and all implicit std::string conversions. - Add show_compatibility_56=ON to MySQL 5.7 configs so querying performance_schema.session_variables works reliably. - test_gtid_forwarding-t: Move from legacy-g5 to legacy-binlog-g1 (requires infra with session_track_gtids=OWN_GTID configured). - test_binlog_reader-t: Create own GTID query rules for sbtest8 instead of relying on pre-existing infra rules that may be deleted. - test_ffto_pgsql_error_stats-t: Remove from mysql84-g4 group (no PostgreSQL backend available in mysql84 infrastructure).	1 month ago
Rene Cannao	d8e4a607de	fix(test/tap): real bugs from static analysis - fix uninitialized loop var (UB) in test_digest_umap_aux-t.cpp - fix dead stores and unused vars in test_binlog_reader-t.cpp - rename reserved identifiers (__timer, _mysql_hdr, th_args__in_t, etc.) - fix narrowing conversions (ssize_t->int, uint32_t->int, size_t->int) - fix implicit widening of multiplication (overflow risk) - consolidate duplicated conditional branch in reg_test_4556 - pass modname by const ref in test_cluster1-t.cpp - fix narrowing in test_default_conn_collation-t.cpp	1 month ago
Rene Cannao	15fc367c72	fix(test/tap): leaks and NULL derefs in two more TAP tests test_binlog_reader-t.cpp: - Fix four leak paths in main(): when mysql_init of proxysql_mysql or proxysql_admin failed, or when mysql_real_connect of either failed, the other (already-initialized/connected) handle was leaked. Cannot use goto cleanup because C++ forbids jumping past the non-trivial std::vector<> initializations farther down; use explicit mysql_close on each error path instead. - Fix two leaks in perform_rnd_selects(): select_conn was leaked on mysql_real_connect failure and on mysql_query failure inside the loop. - Remove dead mysql_store_result(proxysql_admin)/extract_mysql_rows block in the main loop: the result of the previous admin query had already been consumed upstream, so store_result returned NULL and the extracted 'pre_select_rows' vector was written but never read. - Add guard for out-of-bounds res_row[0][1] access: previously unchecked even though an empty or short result would UB. test_ssl_fast_forward-1-t.cpp: - Fix massive leak pattern: main() had 22 'return exit_status()' early exits, none of which closed the 5 per-iteration mysqls[] handles or mysqladmin. The happy path also leaked all 5 mysqls[] (only mysqladmin was closed at the end). - Restructure main() to declare mysqladmin, mysqls[5], and a close_all lambda at the top so every exit path can uniformly release every non-NULL handle. Each close_all() call NULLs the slot, so repeated calls are no-ops and no double-free risk. - Wrap braceless 'if (cond) return exit_status();' bodies in braces where the scripted edit would otherwise put close_all() inside the if body while leaving 'return' unconditional. - NULL mysqls[i] in the inter-iteration close loop so a later close_all() on a failing iteration doesn't double-close stale pointers. No behavioral changes to assertions; compile-verified with -fsyntax-only on both files.	1 month ago
Rahim Kanji	b719b70e78	Add MySQL 8.4 binlog reader CI test infrastructure Add infra-mysql84-binlog Docker Compose environment with 3 MySQL 8.4 servers, 3 proxysql_binlog_reader v2.3 sidecars (with SHOW BINARY LOG STATUS patch for 8.4 compatibility), and 3 Percona Orchestrator nodes. Key adaptations from legacy mysql57-binlog: - MySQL 8.4 config (log-replica-updates, innodb_redo_log_capacity) - MySQL 8.4 replication syntax (CHANGE REPLICATION SOURCE TO, RESET BINARY LOGS AND GTIDS) - Plain mysql:8.4 image + separate reader containers using proxysql-mysqlbinlog v2.3 - SSL auto-generated by MySQL 8.4 (mysql_ssl_rsa_setup removed) - Percona Orchestrator with MySQLTopologySSLSkipVerify Create mysql84-binlog test group (PREFIX=14, hostgroups 1400-1403) and make test_binlog_reader-t hostgroups configurable via WHG/RHG environment variables for multi-infra support.	2 months ago
Rene Cannao	7c7def55e9	Add debugging to test_binlog_reader-t and add missing sbtest users - Add extensive debugging output to test_binlog_reader-t.cpp including: - Test description and purpose - Connection settings and credentials - Environment variable values - Detailed error diagnostics with troubleshooting steps - Additional logging in create_testing_tables() and perform_rnd_selects() - Add missing sbtest7 and sbtest8 users to infra-mysql57 proxysql config These users are required by test_binlog_reader-t and were present in the old CI infra-mysql57-binlog but missing in the new infra.	2 months ago
Rene Cannao	b4687daa74	Rollback test_binlog_reader-t.cpp to tag v3.0.5 The test_binlog_reader-t.cpp test was previously modified to attempt fixing issues in the new CI infrastructure. However, these fixes depended on the 'proxysql_mysqlbinlog' tool which is currently missing or not correctly provisioned in the new environment. As the previous attempts to workaround the missing tool by dynamically detecting hostgroups and enabling GTID ports did not lead to a passing test, we are rolling back this file to its known stable state from tag v3.0.5. This aligns with the requirement to maintain test integrity while the infrastructure provisioning for the binlog reader tool is addressed.	3 months ago
Rene Cannao	0cd6fea331	Fix COM_REGISTER_SLAVE test and enhance binlog reader diagnostics This commit addresses failure in test_com_register_slave_enables_fast_forward-t by ensuring the required test user exists and increasing verbosity. Key changes: - In test_binlog_reader-t.cpp: - Added explicit ProxySQL Admin commands to create/replace the 'sbtest8' user with 'fast_forward=0' before the test begins. This ensures the user exists regardless of pre-existing database state. - Added logic to verify user existence in 'runtime_mysql_users' if initial connection fails, providing better debugging context. - Integrated detailed diag() messages across all major steps: table creation, data insertion, and GTID tracking checks. - Fixed a printf format warning by using %llu for my_ulonglong. - In test_com_register_slave_enables_fast_forward-t.cpp: - Added initial diagnostic messages to explain test intent. - Improved error reporting when the sub-test (test_binlog_reader-t) fails.	3 months ago
Rene Cannao	582c22333f	test: Migration to new testing infrastructure and cleanup - Update CommandLine to support TAP_CLUSTER_NODES, TAP_WORKDIR, and other env vars. - Update default admin credentials to 'radmin' in CommandLine to match CI standards. - Enforce connections via ProxySQL in fast-forward and binlog tests. - Replace hardcoded credentials and hosts with CommandLine variables in cluster tests. - Improve portability of tests by using dynamic host/port and TEST_DEPS. - Ensure strict equality checks for query counts in binlog reader tests.	3 months ago
Miro Stauder	cb3952e7df	use local includes - json	2 years ago
Miro Stauder	803510fa5e	fix mysql includes	3 years ago
Miro Stauder	c78819bda9	use inludes from our deps intead of system	3 years ago
Miro Stauder	c545f51509	various connection related fixes	3 years ago
Miro Stauder	ba87de8037	fix database names	3 years ago
Javier Jaramago Fernández	8804d134d7	Fix 'test_binlog_reader-t' silent failure when no infra is present	4 years ago
Javier Jaramago Fernández	01fa5da353	Increase dirty read max failure rate for 'test_binlog_reader-t'	4 years ago
Javier Jaramago Fernández	0d19b3c4c2	Add functionality test for 'proxysql_mysqlbinlog'	4 years ago

19 Commits (dbb40a30baec7d23568ebe2d2b228737d31dfcba)