10 Commits (dbb40a30baec7d23568ebe2d2b228737d31dfcba)

Author	SHA1	Message	Date
Rene Cannao	2b1a4262b1	tap/utils: add wait_for_log_match() to fix log-scrape races ... check_logs_for_command() in pgsql-copy_from_test-t did a single-shot call to get_matching_lines() right after the SQL that was expected to cause the "Switching to Fast Forward" / "Switching back to Normal" log line. Because ProxySQL writes that line asynchronously with respect to the query's reply, the scan occasionally reached EOF before the producer had flushed the line, turning the assertion into a flake. The failure that originally surfaced this was legacy-g1, test 85/327 of pgsql-copy_from_test-t: 1 of 236 assertions (not ok 126 - "Switching back to Normal mode"). It never reproduced under three targeted reruns, which is consistent with a timing race rather than a logic bug. Two changes: 1. Add wait_for_log_match() in test/tap/tap/utils.{h,cpp}: retry get_matching_lines() up to a timeout, clearing both eofbit and failbit between iterations so successive getline() calls pick up lines appended since the last scan. (Clearing only failbit, as get_matching_lines does internally, is not enough — once a stream has hit EOF its sticky eofbit keeps getline() from reading new bytes.) Defaults: 2000 ms total budget, 100 ms between polls — matching the idiom already used in admin_set_credentials_logging-t. 2. Rewrite check_logs_for_command() in pgsql-copy_from_test-t.cpp to call the new helper. Positive assertions still return as soon as the line appears (no added latency in the common case). Negative assertions (check_logs_for_command(...) == false) now wait up to the full timeout to confirm absence, closing the symmetrical race where a line would have arrived a few hundred ms later than the single-shot scan. Verified: 3/3 reruns of pgsql-copy_from_test-t in legacy-g1 post-fix all pass 236/236, runtime ~40 s per run (single-shot version was slightly faster because it short-circuited on negative assertions without waiting).	1 month ago
Rene Cannao	c72cdd9768	Merge remote-tracking branch 'origin/v3.0' into lint-tap-tests-static-analysis ... # Conflicts: # test/tap/tests/set_testing-240-t.cpp	1 month ago
Rene Cannao	da655099ee	fix(test/tap): batch 2 of static analysis real-bug fixes ... Batch 1 - dead stores/unused vars (11 files): - remove dead test_count assignments in genai_module/async/embedding_rerank/mcp_module - remove unused result strings in ai_llm_retry_scenarios - remove dead jitter_ms in ai_llm_retry_scenarios - remove unused row assignments in mysql-fast_forward/mysql-mirror1 - remove dead rc, sock, num_rows in mysql-protocol_compression/malformed/ssl_CA Batch 2 - narrowing conversions (~100 fixes): - pgsql-extended_query_protocol_test: uint8_t->char, ssize_t->int casts - genai_module/async/embedding_rerank: recv()/mysql_num_rows() casts - mysql-protocol_compression_level: various narrowing casts - max_connections_ff: timeout/duration casts - mysql_query_logging_memory: errno/plan() casts - pgsql-connection_parameters: htonl/ntohl casts - multiple_prepared_statements, mysql-reg_test_4716, nl2sql_internal, etc. Batch 3 - macros + branch clone: - fix macro parens in mysql-reg_test_4867_query_rules - fix macro parens in proxysql_debug.h - fix branch clone in pgsql-connection_parameters_test - fix branch clone in pgsql-copy_to_test - fix narrowing in pgsql-copy_from_test Batch 4 - value params + widening + reserved IDs: - pass string params by const ref in admin_various_commands2, mysql_hostgroup_attributes-servers_defaults, mysql-protocol_compression_level - fix implicit widening overflow in mcp_mysql_concurrency_stress - fix widening in mysql_stmt_send_long_data_large - rename reserved identifiers (__1, _PtrSize_t) - fix narrowing in pg_lite_client.h	1 month ago
Rahim Kanji	77ce7d4b4c	Extend pgsql-copy_from_test-t for CopyCmdMatcher changes ... Add two tests: - testCopyWithLeadingComments: COPY prefixed with a /* comment */ - testSelectWithCopyInStringLiteral: SELECT 'COPY x FROM STDIN' execute_tests() takes a query_digests parameter and main() runs 4 iterations (SSL x digest on/off). Fix fnResultType helper to skip leading whitespace and comments before matching the first keyword.	1 month ago
Rene Cannao	06a067baff	test: expand noise injection to more PostgreSQL tests ... - Injected 'internal_noise_mysql_traffic_v2', 'internal_noise_prometheus_poller', and 'internal_noise_rest_prometheus_poller' into: - pgsql-notice_test-t - pgsql-copy_to_test-t - pgsql-copy_from_test-t - Updated 'test_noise_injection-t' to verify the new MySQL v2 noise routine.	3 months ago
Rahim Kanji	45eadce110	Fixed TAP test	1 year ago
Rahim Kanji	f9232ae50d	Merge remote-tracking branch 'Master/v3.0' into v3.0_session_parameter_tracking	1 year ago
Javier Jaramago Fernández	a247d13d76	Several fixes for 'test_query_rules_fast_routing_algorithm-t.cpp' ... - Fixed issue with SQLite3 helper functions. Invalid use of 'sqlite3_step' lead to fixing issue in ProxySQL itself. - Fixed logic issues on tests checking duplicated conditions. - Improved waiting logic checking for new entries in debug database. - Added new utility functions for SQLite3 databases access (debug database) following MySQL utilities conventions. - Simplified interface in several utilities functions with new, and more explicit naming convention.	1 year ago
Rahim Kanji	f23d839418	Updated pgsql-copy_from_test-t TAP test	1 year ago
Rahim Kanji	58db40e305	Added TAP test	1 year ago