proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	0ce8693c29	ci: disable CI-taptests-groups auto-trigger (same 403 on jenkins-build-scripts) All four matrices (tests, tests/unit, tests_with_deps/*) of CI-taptests-groups fail at the 'Checkout jenkins_build_scripts' step with: fatal: unable to access 'https://github.com/proxysql/jenkins-build-scripts/': The requested URL returned error: 403 Same root cause as the CI-repltests / CI-shuntest disabling in the previous commit: GH_TOKEN_PROXYSQL no longer has access to the proxysql/jenkins-build-scripts repo. Comment out the workflow_run trigger so the workflow stops firing automatically on every push; workflow_dispatch is preserved for manual re-runs once the secret is refreshed.	1 month ago
Rene Cannao	feed404031	ci: disable repltests/shuntest auto-trigger and fix 'make unit_tests' Two test-infrastructure fixes on this branch. 1) CI-repltests / CI-shuntest: every run since the upstream proxysql/jenkins-build-scripts access broke has been failing at the Checkout step with HTTP 403. Comment out the workflow_run trigger so they no longer auto-fire on every push; keep workflow_dispatch so they can still be manually re-run once the token/repo-access is fixed. Same root cause affects CI-taptests-groups as well — that needs the GH_TOKEN_PROXYSQL secret refreshed, not a code change. 2) test/tap/tests/unit/Makefile: 'make unit_tests' (invoked from test/tap/Makefile via $(MAKECMDGOALS)) failed with make[1]: *** No rule to make target 'unit_tests' because the unit Makefile only exposed 'all' and 'debug'. Commit `16e94131f` intentionally forwards MAKECMDGOALS so 'make build_tap_test_debug' propagates 'debug' to the submake, which is what CI-unit-tests-asan-coverage relies on for -DDEBUG-guarded __thread stubs like mysql_thread___session_debug. Add a phony 'unit_tests: all' alias so the same pass-through also works when the goal name is 'unit_tests'. 'debug' is unchanged.	1 month ago
Rene Cannao	92949a9404	ci: add CI-unit-tests-asan-coverage workflow Builds ProxySQL with PROXYSQLGENAI=1 + WITHASAN=1 + WITHGCOV=1 (and the NOJEMALLOC=1 that ASAN forces), then builds and runs every unit test under test/tap/tests/unit/ and publishes an LCOV coverage report. Self-contained design: unlike the existing CI-taptests-asan workflow this one runs entirely on the GitHub runner. It does not depend on the private proxysql/jenkins-build-scripts repo or any backend MySQL/Docker infrastructure because unit tests link against libproxysql.a via the stub test_globals.o and run as standalone binaries. Full job definition lives in this file rather than being delegated to a reusable workflow on the GH-Actions branch. Key points: - Deps are built with 'make build_deps' (optimized, with debug symbols) rather than build_deps_debug: third-party code is not what we want to instrument, and a non-debug deps build is significantly faster. - lib + src are built with 'make debug' so ASAN / gcov instrument ProxySQL's own code only. - Only test/tap/tests/unit/ is built via 'make unit_tests'; the integration TAP tests under test/tap/tests/ are intentionally skipped because they require running backends. - ASAN_OPTIONS starts with detect_leaks=0 because the existing unit tests were not written leak-free. Flipping this to =1 once those leaks are cleaned up will immediately turn this workflow into a leak regression guard. - vm.mmap_rnd_bits is lowered to 28 at the start of the job to satisfy ASAN's shadow-memory requirement on modern kernels (include/makefiles_vars.mk explicitly warns about this). - Trigger uses the same workflow_run: [CI-trigger] pattern as the rest of the CI-* files in this directory, plus workflow_dispatch for manual runs. Artifacts on every run (pass or fail): - unit-tests-coverage-lcov-<sha>: the merged lcov .info file - unit-tests-coverage-html-<sha>: genhtml output directory - unit-tests-logs-<sha>: per-test stdout/stderr captures Security: every 'run:' step only consumes values from env: (SHA, ASAN_OPTIONS, etc.) or GitHub-provided variables like \$GITHUB_WORKSPACE. No untrusted user input (PR titles, issue bodies, commit messages, fork branch names, etc.) is interpolated into shell commands, so there is no command-injection surface.	1 month ago
Rene Cannao	818481a62d	ci: disable CI-unittests caller temporarily (remove workflow_run trigger) CI-unittests cannot run in the normal CI cascade right now because the companion PR on GH-Actions (#5603) strips unit test binaries from the _test cache payload to keep it under GitHub's 10 GB per-repo quota. The unit tests are still COMPILED in ci-builds.yml (a sanity check enforces UNIT_COUNT > 0 before stripping, so compile errors in unit tests still fail the build) but their binaries don't ship in the cache, so CI-unittests would fail on "Cache restore test" or on the safety net in proxysql-tester.py that detects zero discovered test binaries. Rather than leave CI-unittests producing confusing red failures on every cascade, remove the workflow_run trigger so it stops firing automatically. The workflow_dispatch trigger is kept so it can still be invoked manually from the Actions tab (e.g. to test a re-enablement branch). This is intentionally the minimum surgical change: - No file deletion (preserves the caller for easy re-enable). - No change to the reusable on GH-Actions (ci-unittests.yml is dormant when no caller invokes it). - An inline comment block at the top of the caller explains the situation and lists the options for re-enabling (docker rebuild, expanded _src cache with incremental make, or artifact plumbing). Re-enabling CI-unittests is a separate follow-up effort. The goal for now is to unblock CI-legacy-g* and CI-mysql84-g* by getting the _test cache under quota; unit tests will come back later with a proper rebuild strategy. Companion PR: sysown/proxysql#5603	1 month ago
Rene Cannao	5aad576125	ci: rewire group callers to dedicated reusables; add CI-unittests; document CI architecture Rewiring -------- Following the landing of sysown/proxysql#5597 on the GH-Actions branch (which adds the nine dedicated reusable workflows), point each of the eight existing group callers at its dedicated reusable instead of the broken generic ci-taptests-groups.yml: CI-legacy-g1.yml → ci-legacy-g1.yml@GH-Actions CI-legacy-g3.yml → ci-legacy-g3.yml@GH-Actions CI-legacy-g5.yml → ci-legacy-g5.yml@GH-Actions CI-mysql84-g1.yml → ci-mysql84-g1.yml@GH-Actions CI-mysql84-g2.yml → ci-mysql84-g2.yml@GH-Actions CI-mysql84-g3.yml → ci-mysql84-g3.yml@GH-Actions CI-mysql84-g4.yml → ci-mysql84-g4.yml@GH-Actions CI-mysql84-g5.yml → ci-mysql84-g5.yml@GH-Actions Each edit also drops the now-useless `testgroup: '["<group>"]'` input that the new dedicated reusables do not accept (and the old generic reusable silently ignored). This is the other half of the fix started in #5597. Before this change, the eight group workflows were routed to ci-taptests-groups.yml, whose tests job strategy evaluates from a cached proxysql/tap-matrix.json that CI-builds has been populating as "[ ]". With an empty matrix vector GitHub Actions rejects the strategy with "Matrix vector 'testgroup' does not contain any values" and the tests job never instantiates -- visible for example in run 24240099115. With this PR merged (after #5597), these eight workflows will route to their own dedicated reusables and start running real tests on the next push. CI-unittests caller ------------------- Adds a new v3.0 caller CI-unittests.yml targeting ci-unittests.yml@GH-Actions (also added in #5597). This runs the 42 unit-tests-g1 binaries listed in test/tap/groups/groups.json directly on the runner, via the SKIP_PROXYSQL=1 host-only branch in run-tests-isolated.bash -- no Docker, no backends. Documentation ------------- Replaces doc/GH-Actions/README.md with an expanded, current CI architecture reference (~800 lines). Covers: * The two-branch caller/reusable split and the workflow_run default-branch rule that forces it * The CI-trigger / CI-builds babysitter pattern and why test workflows chain on CI-trigger completion (and not on CI-builds directly -- see `78b8f5ac6` for the incident that taught us why) * The dedicated-reusable pattern, with ci-legacy-g4.yml walked through step by step as the canonical template * Build cache layout (_bin / _src / _test / _matrix) * The TAP groups system: groups.json, BASE_GROUP stripping, infras.lst, env.sh, SKIP_PROXYSQL mode for unit tests * Full workflow catalogue as of 2026-04-11 with status per file * End-to-end walkthrough for adding a new test group * Common pitfalls: merge ordering, workflow_run head_sha propagation, the empty-matrix wedge, the LouisBrunner/checks-action false-positive permissions hotspot * Debugging guide: how to trace a failing run through CI-trigger → CI-builds → test workflow, and how to reproduce locally * Glossary Adds a Mermaid sequence diagram for the execution flow and inline ASCII diagrams throughout. Also updates CLAUDE.md to point agents at doc/GH-Actions/README.md before they touch anything under .github/workflows/.	1 month ago
Rene Cannao	78b8f5ac62	ci: revert test workflows to listen on CI-trigger completion Commit `9671a414a3` changed 32 test workflows to trigger on CI-builds completion instead of CI-trigger completion. This broke PR CI runs: workflow_run-triggered workflows receive the head_sha of the workflow that triggered them, and CI-builds (itself workflow_run-triggered) runs on the default branch with head_sha pointing at v3.0 HEAD rather than the PR commit. As a result, all chained test workflows were checking out and testing v3.0 code instead of PR code. Revert to the original design where test workflows listen on CI-trigger (which is pull_request-triggered and carries the PR head_sha). CI-trigger already contains a babysitter step (gh run watch on CI-builds) that blocks until the build artifacts are ready, so gating on CI-trigger completion still waits for builds. Affects 32 workflow files — only the workflow_run.workflows entry is changed, no other logic touched.	2 months ago
Rene Cannao	9671a414a3	ci: comprehensive CI workflow and infrastructure fixes Workflow trigger chain fix: - All 24 test workflows now trigger on CI-builds completion instead of CI-trigger completion, ensuring build artifacts are available before tests start New test group workflows: - Add CI-legacy-g1, CI-legacy-g3, CI-legacy-g5 - Add CI-mysql84-g1 through CI-mysql84-g5 - All use the generic ci-taptests-groups.yml reusable workflow groups.json linter: - Add lint_groups_json.py enforcing compact one-line-per-entry format - Add CI-lint-groups-json.yml workflow triggered on groups.json changes - Reformat groups.json to comply with documented format Makefile fixes: - Fix $(error) call with unescaped ')' that broke all docker-compose builds since Release 3.0.8 - Fix CURVER extraction regex to handle 'v' prefix from git describe CI-taptests-pgsql-cluster rewrite: - Replace old jenkins-build-scripts with Unified CI infrastructure - Use ensure-infras.bash + run-tests-isolated.bash Infrastructure improvements: - Add --hostname test-runner to test-runner container for cross-container DNS resolution - Pass TAP_PGSQL_SYNC_REPLICA_PORT through to test container - Default TAP_PGSQL_SYNC_REPLICA_PORT=6042 when cluster nodes active	2 months ago
Rene Cannao	73a561450d	Fix race condition in CI-legacy-* workflow triggers All 4 CI-legacy workflows used `types: [ in_progress ]` which fired them before CI-builds finished, causing cache-miss failures on the build artifacts. Change to `types: [ completed ]` and add success guard, matching the pattern used by CI-taptests-groups. Affected workflows: - CI-legacy-clickhouse-g1 - CI-legacy-g2 - CI-legacy-g2-genai - CI-legacy-g4	2 months ago
Rene Cannao	cde4cc78eb	ci: add CI workflows for legacy-g4 and legacy-clickhouse-g1 Add dispatcher workflows that trigger on CI-trigger: - CI-legacy-g4.yml — runs legacy-g4 TAP test group - CI-legacy-clickhouse-g1.yml — runs legacy-clickhouse-g1 TAP tests Both use in_progress trigger type (start immediately with CI-trigger) matching the pattern of CI-legacy-g2.yml. Also includes draft reusable workflows in gh-actions-reusable/ that need to be pushed to the GH-Actions branch: - ci-legacy-g4.yml — adapted from ci-legacy-g2.yml - ci-legacy-clickhouse-g1.yml — adapted with clickhouse23 infra To activate: 1. Push ci-legacy-g4.yml and ci-legacy-clickhouse-g1.yml to sysown/proxysql GH-Actions branch under .github/workflows/ 2. The dispatcher workflows on feature branches will then find them Already active (no changes needed): - CI-legacy-g2.yml — already exists - CI-basictests.yml — already exists	2 months ago
Rene Cannao	c1eb55d39d	Add CI-legacy-g2 and CI-legacy-g2-genai caller workflows Two new CI workflows for the legacy-g2 TAP test group: - CI-legacy-g2: runs against ubuntu22-tap build (standard) - CI-legacy-g2-genai: runs against ubuntu24-tap-genai-gcov build (PROXYSQLGENAI=1, WITHGCOV=1, with coverage report upload) Both use SKIP_CLUSTER_START=1 and TAP_USE_NOISE=1. Reusable workflows are on the GH-Actions branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2 months ago
René Cannaò	a902a9ccfd	"Claude Code Review workflow"	2 months ago
René Cannaò	8792cf35b6	"Claude PR Assistant workflow"	2 months ago
Miro Stauder	62b8103bae	update GH-Actions triggers	8 months ago
Miro Stauder	3c5e052eb8	add action php_pdo_pgsql testing	9 months ago
Miro Stauder	ae96637af9	add GH Actions trigger for pgJDBC testing	9 months ago
Miro Stauder	4cbfb3d83a	fix GH actions run name	1 year ago
Miro Stauder	fdd744adbd	Create CI-3p-aiomysql.yml Signed-off-by: Miro Stauder <miro@proxysql.com>	1 year ago
René Cannaò	a9a3583957	Update issue templates	1 year ago
Miro Stauder	30b05fd72d	Update CI-trigger.yml	1 year ago
Miro Stauder	e3a239a6c4	rephrase run-pgsql condition	1 year ago
Miro Stauder	1fa73aacc5	add workflow_dispatch inputs add run-mariadb where missing make run-pgsql conditional	1 year ago
Miro Stauder	4ada062b89	add CI-3p-postgresql	2 years ago
Miro Stauder	5704e3dc36	use correct matrix vars	2 years ago
Miro Stauder	839802087f	pass specific matrix for mysq/mariadb/pgsql	2 years ago
Miro Stauder	0715a9519d	opdate actions to use CI-trigger	2 years ago
Miro Stauder	e9c89c28cb	add CI-trigger	2 years ago
Miro Stauder	784be9459a	show correct run-name set correct concurrency group execute on dependency success	2 years ago
Miro Stauder	db198c808f	pass github context to scripts	2 years ago
Miro Stauder	a235d823e5	update triggers	2 years ago
Miro Stauder	4247a890e8	update GH actions triggers	2 years ago
Miro Stauder	1a6200860e	Update CI-builds.yml	2 years ago
Miro Stauder	a9a21da2ad	Update CI-builds.yml	2 years ago
Miro Stauder	3316c8ffe1	change gh actions conurency	2 years ago
Miro Stauder	035ad4a511	simplify gh actions	2 years ago
Miro Stauder	82f5ff202a	Create CI-taptests-asan.yml	2 years ago
Miro Stauder	a941bf3ceb	Create CI-3p-laravel-framework.yml	2 years ago
Miro Stauder	050e2d372b	Create CI-3p-django-framework.yml	2 years ago
Miro Stauder	3c36711f7f	Update CI-codeql.yml	2 years ago
Miro Stauder	635f07556a	Update CI-codeql.yml	2 years ago
Miro Stauder	587f49e150	remove 'if: always()' from top level action jobs 'run'	2 years ago
Miro Stauder	da78fd0a2b	GH actions - add mariadb-connector-c tests	2 years ago
Miro Stauder	747c6b3970	HG actions - always run tests, even if builds fail, required cache might be available	2 years ago
Miro Stauder	e6981f2f00	Update CI-basictests.yml	2 years ago
Miro Stauder	2aa6d506ee	Create CI-3p-sqlalchemy.yml	3 years ago
Miro Stauder	4fa4809324	Update CI-3p-mysql-connector-j.yml	3 years ago
Miro Stauder	a4116bd214	Create CI-3p-php-pdo-mysql.yml	3 years ago
Miro Stauder	e3b6b3923b	Update CI-basictests.yml	3 years ago
Miro Stauder	751620bff8	Update CI-basictests.yml	3 years ago
Miro Stauder	d79fc84550	Update CI-shuntest.yml	3 years ago
Miro Stauder	17ec0f0140	Update CI-repltests.yml	3 years ago

1 2 3 4 5

234 Commits (dbb40a30baec7d23568ebe2d2b228737d31dfcba)