890 Commits (cd623ec33b718f300bf5668a6b4e2d518bb8db2b)

Author	SHA1	Message	Date
René Cannaò	83ffb729bb	Merge pull request #3946 from sysown/v2.x-3923 ... WIP: Fix 'mysql-auto_increment_delay_multiplex_timeout_ms' - Closes #3923	4 years ago
Javier Jaramago Fernández	b7ecc2d268	Fix multiplexing not being disable by cached stmt during 'STMT_EXECUTE' ... This forces the re-evaluation of the query digest for each 'STMT_EXECUTE' for impossing the required flags over the current backend 'MySQL_Connection'.	4 years ago
Javier Jaramago Fernández	ee48d11b46	Remove comment and call with unused result to 'std::stack::top()'	4 years ago
Javier Jaramago Fernández	990edf0fb7	Fix timeout for 'fast_forward' sessions when 'max_connections' is reached	4 years ago
Javier Jaramago Fernández	4fd3023f9e	Default initialize all members of 'CurrentQuery' in 'MySQL_Session' ctor	4 years ago
Javier Jaramago Fernández	96de2329d7	Fix behavior for 'ldap-max_db_connections' failing to decrease current used connections	4 years ago
Javier Jaramago Fernández	bcc6532d66	Modify previous impl for 'auto_increment_delay_multiplex_timeout_ms' and fix 'connection_delay_multiplex_ms' ... This commit contains an implementation rework and a fix: - Impl for 'auto_increment_delay_multiplex_timeout_ms' has been reworked in favor of reusing 'wait_until' to share logic with previous 'connection_delay_multiplex_ms' variable. - Fix previous 'connection_delay_multiplex_ms' behavior preventing connection retaining when traffic unrelated to target hostgroup is being received by the session.	4 years ago
Javier Jaramago Fernández	dbdfec3494	Add 'ASYNC_IDLE' precondition for connections considered for expiring ... If any scenario is found in which we may want to consider a non 'ASYNC_IDLE' connection for expiring, this precondition shall be removed, and checks should be responsible for ensuring 'ASYNC_IDLE' state in the connection.	4 years ago
Javier Jaramago Fernández	a67db17709	Fix current 'auto_increment_delay_multiplex_timeout_ms' behavior #3923	4 years ago
René Cannaò	cbeece8d4c	Do not generate entries for empty hostgroups in generate_proxysql_internal_session_json()	4 years ago
René Cannaò	f960a4d9b7	Merge pull request #3903 from sysown/v2.x-tests_220619 ... V2.x tests 220619	4 years ago
René Cannaò	61c6819cca	Merge pull request #3939 from sysown/v2.x-3926 ... Wrong value of NO_BACKSLASH_ESCAPES was sent to client	4 years ago
René Cannaò	4b26dad975	Wrong value of NO_BACKSLASH_ESCAPES was sent to client ... This is an enhancement of PR #3926 , fixing the typo and adding the testing for it.	4 years ago
René Cannaò	622b748fdf	Switching autocommit from 0 to 1 drops SAVEPOINTs ... Another edge case due to MySQL bug https://bugs.mysql.com/bug.php?id=107875 related to autocommit=0 and SAVEPOINT	4 years ago
René Cannaò	f7d8824379	Trying to work around MySQL bug 107875 ... Because of MySQL bug https://bugs.mysql.com/bug.php?id=107875 , autocommit=0 can "create a transaction" even if SERVER_STATUS_IN_TRANS is not set. This means that a SAVEPOINT can be created in a "transaction" created with autocommit=0 but without SERVER_STATUS_IN_TRANS . This commit takes also care of scenarios when autocommit=0 was switched back to autocommit=1 when a SELECT was executed while variable mysql-enforce_autocommit_on_reads was false. MySQL_Session::NumActiveTransactions() now accepts a flag to check for savepoints.	4 years ago
René Cannaò	0a49b11fef	Emulate SET autocommit in SQLite3 Server ... SQLite3 Server now also returns the right autocommit flag	4 years ago
René Cannaò	227e045aa4	Improved mysql-init_connect-t.cpp for PMC-10003 ... PMC-10003: Retrieved a resultset while running a simple command using async_send_simple_command() . async_send_simple_command() is used by ProxySQL to configure the connection, thus it shouldn't retrieve any resultset. A common issue for triggering this error is to have configure mysql-init_connect to run a statement that returns a resultset.	4 years ago
René Cannaò	cad2d6b113	Removing handler___status_CHANGING_USER_CLIENT___STATE_CLIENT_HANDSHAKE ... It seems dead code.	4 years ago
René Cannaò	c0fdf02b78	Fixed various compiler warnings	4 years ago
René Cannaò	7a441834dc	Merge pull request #3866 from sysown/v2.x-tokenizer_valgrind_issues ... Fix valgrind found issues for tokenizer during testing	4 years ago
--global	5a83b943a3	Fix leak in handling of command 'PROXYSQL INTERNAL SESSION'	4 years ago
René Cannaò	9abb82c2a4	Fixed various bugs detected using valgrind ... * uninitialized variables variables.read_only in Clickhouse * generate_proxysql_internal_session_json() may try to access variables not set This commit also prevents watchdog to restart ProxySQL if running under valgrind. In debug build, the spinning loops also have a minor usleep. This to prevent valgrind to loop for long time	4 years ago
René Cannaò	d23a531e00	Minor sanity checks	4 years ago
René Cannaò	ea721ff31b	Merge pull request #3754 from sysown/v2.x-group_replication_consistency ... Add support for more session variables #3731 #3761 #2702	4 years ago
René Cannaò	8d2a88a746	Merge pull request #3856 from sysown/v2.x-rm_duplicate_mysql_err_counts ... Fix duplicate counting of MySQL errors for client conns	4 years ago
René Cannaò	f9b6f16beb	Merge pull request #3824 from sysown/v2.x-proxy_msg_stats ... Add stats capabilities for log messages	4 years ago
René Cannaò	a1246f3348	Merge pull request #3851 from sysown/v2.x-fix-clang-build ... fix clang builds	4 years ago
René Cannaò	9275e2858d	Track NO_BACKSLASH_ESCAPES ... Track NO_BACKSLASH_ESCAPES in case it is changed: - using SET sql_mode by the client - directly on the backend (for example default sql_mode, or an sql_mode set from another variable)	4 years ago
Miro Stauder	d0f51dbe15	fix void pointer arithmetic	4 years ago
Javier Jaramago Fernández	68baa871be	Fix duplicate counting of MySQL errors for client conns	4 years ago
René Cannaò	20446ebae7	Merge pull request #3826 from bpmdoty/v2.x ... Don't intercept SELECT CONNECTION_ID() as COM_STMT_PREPARE	4 years ago
Mike Doty	565799b92b	Update conditional to check speifically for COM_QUERY instead of specifically ignoring COM_STMT_PREPARE. Add conditional to SELECT LAST_INSERT_ID(), SELECT LAST_INSERT_ID() LIMIT 1, SELECT @@IDENTITY, SELECT @@IDENTITY LIMIT 1 intercepts.	4 years ago
Javier Jaramago Fernández	fd968f4b02	Create new message code 'PCM-10002' for 'Unable to parse query' error	4 years ago
Javier Jaramago Fernández	ca7f5ea91f	Create new message code 'PCM-10001' for 'Unexpected packet from client' error	4 years ago
Mike Doty	a5b020a5b2	Do not intercept COM_STMT_PREPARE packets for SELECT CONNECTION_ID() ... Hopefully this fixes issue #2564.	4 years ago
Javier Jaramago Fernández	4452faa037	Add missing newline char at end of 'SSL is required' error message	4 years ago
René Cannaò	b5bdb47dae	Add support for wsrep_osu_method	4 years ago
René Cannaò	25fc1def8e	Fixed a buffer overflow in new variables	4 years ago
René Cannaò	fd05b37762	Added support for more session variables: ... - aurora_read_replica_read_committed - group_replication_consistency - query_cache_type	4 years ago
Javier Jaramago Fernández	3a19f717ac	Fix 'mysql-connect_retries_delay' not being honored	4 years ago
René Cannaò	43c6acb218	Merge branch 'v2.x' into v2.1.2-cluster	4 years ago
René Cannaò	db8275a66d	Merge branch 'v2.x' into v2.x-3504	4 years ago
Javier Jaramago Fernández	c51d78c10b	Fix 'create_new_connection' annotation failure due to thread-local connection pool ... A thread local connection should be retrieved only if 'fast_forward' is disabled AND 'create_new_connection' wasn't present in the query.	4 years ago
René Cannaò	d20683c589	Merge pull request #3702 from sysown/v2.x-variables ... Improvements on how MySQL variables are processed	4 years ago
René Cannaò	8d83bd3562	Merge branch 'v2.x' into v2.1.2-cluster	4 years ago
René Cannaò	e983fc6827	Adding support for more MySQL variables ... New variables supported: - lc_messages - lc_time_names - long_query_time - max_execution_time - max_heap_table_size - max_sort_length - optimizer_prune_level - optimizer_search_depth - optimizer_switch - sort_buffer_size - sql_big_selects - timestamp - tmp_table_size Note: sql_big_selects is still not fully supported when combined with max_join_size. In set testing TAP ,set large max_execution_time. If max_execution_time is too small, the TAP test may fails because the queries will timeout.	4 years ago
René Cannaò	2ba9c401f1	Bug fixes in the new implementation of tracking mysql variables ... Better parsing of SET SQL_LOG_BIN . SQL_LOG_BIN is now managed by the same functions that handle boolean variables instead of the now deprecated MySQL_Session::handler_WCD_SS_MCQ_qpo_Parse_SQL_LOG_BIN() For naming convention, enum value SQL_LOG_BIN was renamed to SQL_SQL_LOG_BIN In MySQL_Thread we also deprecated match_regexes[0] , previously used to parse `set sql_log_bin`. Functions Variable::fill_server_internal_session() and Variable::fill_client_internal_session() seems to handle sql_log_bin as a special value. This exception was removed. Fixed a bug in MySQL_Session::generate_proxysql_internal_session_json() where when backend variables needed to be generated, fill_client_internal_session() was incorrectly called instead of fill_server_internal_session() , leading to incorrect values reported by `PROXYSQL INTERNAL SESSION`	4 years ago
René Cannaò	e0e149d9b2	Merge pull request #3710 from sysown/v2.x-3690 ... Fixed invalid handling of large packets for Admin - Closes #3690	4 years ago
Javier Jaramago Fernández	8cd505bde6	Added support for 'COM_RESET_CONNECTION' #2021	4 years ago
Javier Jaramago Fernández	bcb009fc24	Revert "Merge pull request #3645 from sysown/v2.x-2021" ... This reverts commit 9561cb3ef2, reversing changes made to 7edfec6f3f.	4 years ago
Javier Jaramago Fernández	88dc295781	Fixed invalid handling of large packets in 'SQLite3_to_MySQL' function #3690 ... - Provided a new function to partially initialize 'MySQL_ResultSet'. - Replaced 'generate_pkt_row' in favor of 'generate_pkt_row3' for resulset writing.	4 years ago
René Cannaò	497ef76478	Merge branch 'v2.x' into v2.x-variables	4 years ago
René Cannaò	d335bfb899	Improvements on how MySQL variables are processed ... Deprecated variables: - net_write_timeout Renamed set_testing-t.csv to set_testing-t.csv.obsolete , and removed net_write_timeout from set_testing-t.csv Variables added to ignore list: - net_write_timeout - net_buffer_length - read_buffer_size - read_rnd_buffer_size Added support for quoting with backtick Renamed `enum variable_name` into `enum mysql_variable_name` for better readibility `enum mysql_variable_name` has variable names alphabetically ordered after SQL_NAME_LAST_LOW_WM `mysql_tracked_variables` has variable names alphabetically ordered after SQL_NAME_LAST_LOW_WM A lot of new variables added in `mysql_tracked_variables` , although not all tracked yet (TODO) In `MySQL_Variables::MySQL_Variables()`: - if `internal_variable_name` in `mysql_tracked_variables` is NULL , it will be automatically initialized - it performs some sanity check between `enum mysql_variable_name` and `mysql_tracked_variables` Testing: - refactored code in set_testing-t.cpp and set_testing-multi-t.cpp - added set_testing-240-t.cpp to test improvements in 2.4.0 - generate_set_session_csv to automatically create set_testing-240.csv used by set_testing-240-t	4 years ago
René Cannaò	e892413d1a	Merge branch 'v2.x' into v2.x-2021	4 years ago
René Cannaò	aed1f205d4	Merge branch 'v2.x' into v2.x-3655	4 years ago
René Cannaò	a6edd02a9b	Revert "Merge branch 'v2.x' into v2.x-2021" ... This reverts commit 3a3931f2d4, reversing changes made to 4694ab775e.	4 years ago
René Cannaò	3a3931f2d4	Merge branch 'v2.x' into v2.x-2021	4 years ago
René Cannaò	22ed00e2f7	Merge pull request #3652 from sysown/v2.x-3606 ... Fixes MySQL warnings are returned as results of the next executed query - Closes #3606	4 years ago
Javier Jaramago Fernández	dc4bf3ccce	Added 'schemaname' to userinfo for 'PROXYSQL INTERNAL SESSION' command #3655	4 years ago
Javier Jaramago Fernández	86e5caf6ea	Fixed handling of splitted packets during 'CONNECTING_SERVER' state for 'FAST_FORWARD' mode	4 years ago
Javier Jaramago Fernández	062381efd4	Fixed crashes in 'MySQL_Session::get_pkts_from_client' when 'mysql-query_digests' are disabled #3655	4 years ago
Javier Jaramago Fernández	a49433cc91	Manually set 'POLLOUT' event for 'SHOW_WARNINGS' session status to ensure sending by 'MySQL_Connection' #3606	5 years ago
Javier Jaramago Fernández	4312cd9a72	Moved session cleanup after error report for 'SHOW_WARNINGS' #3606	5 years ago
Javier Jaramago Fernández	c3d0ecd84f	Improved implementation of 'mysql-log_mysql_warnings_enabled' #3606	5 years ago
Javier Jaramago Fernández	e76882c2f9	Added support for 'COM_RESET_CONNECTION' #2021	5 years ago
Javier Jaramago Fernández	d7bef92b57	Added missing new-line character for access denied 'proxy_error' for 'COM_CHANGE_USER' #3504	5 years ago
Javier Jaramago Fernández	8e97f5a19c	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-3504	5 years ago
Javier Jaramago Fernández	b4c7b9323d	Merge pull request #3621 from sysown/v2.x-3620 ... Fixes memory leaks detected during testing - Closes #3620	5 years ago
Javier Jaramago Fernández	c268259bde	Fixed memory leak of client received packet when SSL connection is initiated #3620	5 years ago
Javier Jaramago Fernández	36abd62314	Fixed memory leak for 'client_addr' in case of wrong credentials for frontend connection #3620	5 years ago
Javier Jaramago Fernández	6e533cb5d9	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-client_err_limit	5 years ago
René Cannaò	3a481ecb89	Removing some printf	5 years ago
René Cannaò	b485623d6f	Reimplemented the handling of comments in 'USE' statements #3493 ... This commits partially revert 0dde4adb21 It also improve the TAP test reg_test_3493-USE_with_comment-t.cpp with a variety of combinations, that helped find a bug in the tokenizer mysql_query_digest_and_first_comment()	5 years ago
René Cannaò	48562faaf1	Merge branch 'v2.x' into v2.1.2-cluster	5 years ago
René Cannaò	aceeaf79ed	Disabled prometheus metrics dump , see #3571 ... This commit also fixes some minor memory corruptions	5 years ago
René Cannaò	0da250ec8d	Merge pull request #3491 from csoulios/ldap-auth-changes ... Clean up LDAP authenticator	5 years ago
René Cannaò	08ea308033	Merge pull request #3552 from sysown/v2.x-ssl_no-rsa ... Allows SSL privake keys other than RSA , and implement PROXYSQL RELOAD TLS	5 years ago
René Cannaò	ebbd9845bd	Merge branch 'v2.x' into v2.1.2-cluster	5 years ago
René Cannaò	228c0bfd79	Merge branch 'v2.x' into v2.x-3504	5 years ago
Javier Jaramago Fernández	25df228960	Fixed double-free memory corruption due to unitialized memory in prepared statements bind buffers #3546	5 years ago
René Cannaò	148264cd8b	Disabled prometheus metrics dump , see #3571 ... This commit also fixes some minor memory corruptions	5 years ago
René Cannaò	af27c0b108	Merge branch 'v2.x' into v2.1.2-cluster	5 years ago
René Cannaò	3de13665e8	Merge pull request #3557 from sysown/v2.x-ccov2 ... More code coverage	5 years ago
René Cannaò	2145507c22	If a session is locked on hostgroup , autocommit is copied from backend connection ... Closes #3459	5 years ago
Javier Jaramago Fernández	e2dd0a30cd	Initial implementation for 'client_error_limit' ... Add initial support for FR limiting the number of connection errors that can be initiated from a particular address before deniying future connections from that address. Feature is controlled by new introduced variables: - mysql-client_host_error_counts - mysql-client_host_cache_size	5 years ago
René Cannaò	194243503a	Adding LCOV_EXCL_START around assert(0) ... LCOV_EXCL_START and LCOV_EXCL_STOP around assert(0) will improve code coverage	5 years ago
René Cannaò	b912d978b0	Removing or commenting legacy/unused code	5 years ago
René Cannaò	241a5e54d7	Draft to reimplement how session variables are handled	5 years ago
René Cannaò	fd7b5f8f50	Implemented PROXYSQL RELOAD TLS ... Command PROXYSQL RELOAD TLS is able to load new key/cert files and create a new SSL context. Loading of SSL can happens in two stages: * during bootstrap: if it fails, proxysql dies * running PROXYSQL RELOAD TLS: if it fails, proxysql will keep the old SSL context This new method should successfully handle errors like missing or corrupted files. We are also adding two buffers used to store the key/cert, to be used by the web interface.	5 years ago
René Cannaò	e38562df40	Merge branch 'v2.x' into v2.x-PS-err3024	5 years ago
René Cannaò	fce7a0204c	Handle binary protocol resultset with ERR #3547 ... This commit add the support of ERR packet in binary protocol resultset, for example due to MAX_EXECUTION_TIME while running a prepared statement. It also changes how EOF packets are added: instead of writing the EOF in the resultset buffer, the EOF packet is written in its own packet. This allows to easily remove it if needed. It also fix what seems (not sure) a bug in MariaDB client library, where if a prepared statement is interrupted it cannot be executed again	5 years ago
Christos Soulios	6030677258	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Christos Soulios	8136a6f4d0	Addressed reviewer comments	5 years ago
Javier Jaramago Fernández	1c319c021d	Fixed check for 'enable_load_data_local_infile' placement and added conditional extra verbosity to warning message #3500	5 years ago
Christos Soulios	9d19c70e8c	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Javier Jaramago Fernández	1f4f86d5ce	Added mysql variable to enable unsupported query 'LOAD DATA LOCAL INFILE' issuing warning message #3500	5 years ago
Christos Soulios	21803220e1	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Christos Soulios	4359b1f72f	Count connections for frontend user, not backend	5 years ago
Javier Jaramago Fernández	5e0dc81e5e	Added support for 'Auth Switch Request' for 'COM_CHANGE_USER' #3504	5 years ago
René Cannaò	1ee232bf85	Removed dead code from MySQL_Session	5 years ago