proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	573a3fd256	Address AI code review feedback on PgSQL FFTO tests (#5517 ) Fixes from Copilot and CodeRabbit reviews on PR #5526: 1. Buffer overflow risk in mysql_real_escape_string: All 7 PgSQL test files used fixed 256-byte buffers for escaped credentials. Changed to VLAs sized from strlen() (2*len+1), matching the safe pattern used in the existing test_ffto_pgsql-t.cpp. 2. NULL dereference in polling loops: mysql_store_result() can return NULL, and calling mysql_fetch_row(NULL) is undefined behavior. Added NULL checks in all verify_pg_digest(), poll_pg_digest_count(), verify_digest(), and poll_digest_count() polling loops across both PgSQL and MySQL test files. In loop contexts, uses continue; in non-loop contexts, uses conditional fetch (res ? fetch(res) : NULL). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	3 months ago
Rene Cannao	fd7ac876e2	Fix build issues in PgSQL FFTO E2E tests (#5517 ) Two build issues fixed across all 7 PgSQL FFTO test files: 1. PROTOCOL_VERSION macro conflict: pg_lite_client.h defines PROTOCOL_VERSION as a static const int, but mariadb_version.h (included via mysql.h) defines it as a preprocessor macro (#define PROTOCOL_VERSION 10). Fixed by including pg_lite_client.h before mysql.h in the two tests that use it. 2. MYSQL_QUERY in void function: The clear_pg_stats() helper is a void function, but MYSQL_QUERY macro expands to "return EXIT_FAILURE" on error, which doesn't compile in a void context. Fixed by using mysql_query() directly instead of the MYSQL_QUERY macro in all clear_pg_stats() definitions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	3 months ago
Rene Cannao	fc8fbc463a	FFTO E2E TAP test: PostgreSQL error handling (#5517 ) Add test_ffto_pgsql_errors-t.cpp covering FFTO recovery after PostgreSQL ErrorResponse messages. Part of issue #5517. Test scenarios (10 TAP assertions): 1. Syntax error recovery — sends invalid SQL, then valid SELECT. Verifies FFTO resets state after ErrorResponse ('E') and correctly tracks the subsequent query. 2. Constraint violation — duplicate key INSERT fails, followed by successful INSERT. Verifies rows_affected only counts the successful operation. 3. Transaction error — BEGIN, failing INSERT, ROLLBACK. Verifies ROLLBACK is tracked as a successful query despite the preceding error putting the transaction in aborted state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	3 months ago

Author

SHA1

Message

Date

Rene Cannao

573a3fd256

Address AI code review feedback on PgSQL FFTO tests (#5517 )

Fixes from Copilot and CodeRabbit reviews on PR #5526:

1. Buffer overflow risk in mysql_real_escape_string: All 7 PgSQL test
   files used fixed 256-byte buffers for escaped credentials. Changed
   to VLAs sized from strlen() (2*len+1), matching the safe pattern
   used in the existing test_ffto_pgsql-t.cpp.

2. NULL dereference in polling loops: mysql_store_result() can return
   NULL, and calling mysql_fetch_row(NULL) is undefined behavior.
   Added NULL checks in all verify_pg_digest(), poll_pg_digest_count(),
   verify_digest(), and poll_digest_count() polling loops across both
   PgSQL and MySQL test files. In loop contexts, uses continue; in
   non-loop contexts, uses conditional fetch (res ? fetch(res) : NULL).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Rene Cannao

fd7ac876e2

Fix build issues in PgSQL FFTO E2E tests (#5517 )

Two build issues fixed across all 7 PgSQL FFTO test files:

1. PROTOCOL_VERSION macro conflict: pg_lite_client.h defines
   PROTOCOL_VERSION as a static const int, but mariadb_version.h
   (included via mysql.h) defines it as a preprocessor macro (#define
   PROTOCOL_VERSION 10). Fixed by including pg_lite_client.h before
   mysql.h in the two tests that use it.

2. MYSQL_QUERY in void function: The clear_pg_stats() helper is a
   void function, but MYSQL_QUERY macro expands to
   "return EXIT_FAILURE" on error, which doesn't compile in a void
   context. Fixed by using mysql_query() directly instead of the
   MYSQL_QUERY macro in all clear_pg_stats() definitions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Rene Cannao

fc8fbc463a

FFTO E2E TAP test: PostgreSQL error handling (#5517 )

Add test_ffto_pgsql_errors-t.cpp covering FFTO recovery after
PostgreSQL ErrorResponse messages. Part of issue #5517.

Test scenarios (10 TAP assertions):
1. Syntax error recovery — sends invalid SQL, then valid SELECT.
   Verifies FFTO resets state after ErrorResponse ('E') and
   correctly tracks the subsequent query.
2. Constraint violation — duplicate key INSERT fails, followed by
   successful INSERT. Verifies rows_affected only counts the
   successful operation.
3. Transaction error — BEGIN, failing INSERT, ROLLBACK. Verifies
   ROLLBACK is tracked as a successful query despite the preceding
   error putting the transaction in aborted state.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

3 Commits (c06ee510a0199e2df6d02ee83180be1eec238b68)