428 Commits (9ffc3f8d711d2f1d3373c91a135d40cbea202841)

Author	SHA1	Message	Date
René Cannaò	5de836a4c1	Merge pull request #5373 from sysown/v3.0_improve_mysql_monitoring_5256 ... Improve MySQL Monitor connection management	7 days ago
Rene Cannao	85952373d9	Fix uninitialized mondb pointer in MySQL_Monitor_State_Data constructor ... Add mondb = NULL initialization to prevent Valgrind errors when monitor threads access the pointer before it's properly set.	1 week ago
Rene Cannao	200fdecb8d	Apply AI agent review fixes to PR #5374 ... Critical Fixes: - Fix NULL pointer dereferences in MySQL_Logger.cpp: * Add null checks for myds->myconn->parent in log_audit_entry() * Fix cleanup code in log_request() and log_audit_entry() * Change sprintf to snprintf for buffer safety - Remove redundant pthread_rwlock_init in debug.cpp: * filters_rwlock already initialized with PTHREAD_RWLOCK_INITIALIZER * Re-initialization caused undefined behavior per POSIX Major Improvements: - Add bounded wait helper wait_for_glo_mth() in proxysql_utils.h: * Replaces indefinite while loops with 10s timeout * Applied to 26 locations across 4 files Build System: - Require C++17 in Makefile (remove C++11 fallback): * Code uses C++17 structured bindings extensively * Cleanest solution vs adding fallback guards to 27+ locations Compilation fixes: - Add unistd.h include for usleep - Remove conflicting GloMyMon extern declaration Files changed: - Makefile - include/proxysql_utils.h - lib/MySQL_Logger.cpp - lib/debug.cpp - lib/MySQL_Monitor.cpp - lib/ProxySQL_Admin.cpp - lib/ClickHouse_Server.cpp - src/SQLite3_Server.cpp	1 week ago
Rahim Kanji	1cccfb3220	Fix connection cleanup in failure paths	1 week ago
Rene Cannao	3c85c593cf	Add GloMTH initialization wait to all monitor and server threads ... Fix race condition where threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int() and related functions. Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to ensure GloMTH is fully initialized before use: In lib/MySQL_Monitor.cpp: - monitor_connect(), monitor_ping(), monitor_read_only() - monitor_group_replication(), monitor_galera(), monitor_replication_lag() - monitor_AWS_Aurora_thread_HG(), monitor_aws_aurora() - init_mysql_thread_struct() In src/SQLite3_Server.cpp: - SQLite3_Server_session_handler In lib/ProxySQL_Admin.cpp: - admin_session_handler In lib/ClickHouse_Server.cpp: - ClickHouse_Server_session_handler The pattern ensures threads wait for GloMTH initialization during startup, then check for NULL during shutdown to exit cleanly.	1 week ago
Rene Cannao	aa53d990ed	Add GloMTH initialization wait to all monitor threads ... Fix race condition where monitor threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int(). Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to: - monitor_ping_thread - monitor_read_only_thread - monitor_replication_lag_thread - monitor_group_replication_thread (also moved check before MySQL_Thread creation) - monitor_galera_thread (also moved check before MySQL_Thread creation) This matches the existing pattern in monitor_connect_thread.	1 week ago
Rene Cannao	f4cd34be5c	Fix race condition in monitor_connect_thread ... Add wait loop for GloMTH initialization before accessing variables. Other monitor threads (MonitorPing, MonitorReadOnly, etc.) already had this pattern, but monitor_connect_thread was missing it. This fixes Valgrind errors about uninitialized values in get_variable_uint16() when strcasecmp reads from memory that hasn't been fully initialized yet.	1 week ago
Rahim Kanji	9eac5f6420	Improve async ping mmsd ownership tracking and pool validation	1 week ago
Rahim Kanji	bed851471a	Fix MySQL Monitor assertion failure in DEBUG builds ... Introduce destroy_mysql_connection() helper to centralize the pattern of unregistering, closing, and nullifying MySQL connections in monitor threads.	1 week ago
Rene Cannao	f779a6059a	refactor: migrate remaining prepare_v2 SIMPLE cases in MySQL_Monitor ... Migrated the following functions: - populate_monitor_mysql_server_aws_aurora_log() - populate_monitor_mysql_server_aws_aurora_check_status() - monitor_ping_process_ready_task_thread() - monitor_read_only_process_ready_tasks() (with if/else branches for replication_lag) All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	2 weeks ago
Rene Cannao	bdba0b44a0	refactor: migrate all prepare_v2 SIMPLE cases to RAII API in MySQL_Monitor ... Migrated the following functions: - update_monitor_mysql_servers() - update_monitor_proxysql_servers() - monitor_connect_thread() - monitor_ping_thread() - monitor_read_only_thread() - monitor_replication_lag_thread() - monitor_connect() cleanup - monitor_ping() cleanup - monitor_read_only() cleanup - monitor_replication_lag() cleanup - populate_monitor_mysql_server_group_replication_log() - populate_monitor_mysql_server_galera_log() All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	2 weeks ago
Rene Cannao	df1c4e7928	fix: medium priority warnings - write-strings and unused variables ... 1. Fix write-strings warnings (12 occurrences): - MySQL_HostGroups_Manager.cpp: Change char* to const char* for src_status and dst_status variables - MySQL_Monitor.cpp: Change ConsumerThread constructor parameter from char thread_name[16] to const char *thread_name 2. Fix unused-but-set-variable warnings (6 occurrences) by wrapping PROXYSQLGENAI-specific variables in #ifdef blocks: - stats_mcp_query_tools_counters - stats_mcp_query_tools_counters_reset - stats_mcp_query_digest - stats_mcp_query_digest_reset - stats_mcp_query_rules - runtime_mcp_query_rules These variables were assigned values but appeared unused when PROXYSQLGENAI was not defined. Now they are only defined and assigned when PROXYSQLGENAI is enabled. This eliminates 18 compiler warnings: 12 write-strings and 6 unused-but-set-variable warnings. Found during compiler warning analysis with 'make debug'.	2 weeks ago
René Cannaò	27f13ca18d	Merge pull request #5096 from Gonlo2/fix-close-ssl-con ... Avoid send close in ssl connections	3 weeks ago
Rahim Kanji	01a5b23b22	refactor connection pool put_connection to use mmsd and improve debug handling ... * Change MySQL_Monitor_Connection_Pool::put_connection signature to accept MySQL_Monitor_State_Data* instead of raw MYSQL*/port. * Centralize access to mysql and port via mmsd, reducing parameter mismatch and misuse. * Improve DEBUG bookkeeping: ensure connections are properly unregistered from the global debug registry with clearer assertions and logs. * Add consistent proxy_debug messages for connection register/unregister events. * Simplify server lookup/creation logic when returning connections to the pool. * Fix ordering of error handling to always unregister before closing connections. * Minor cleanup: remove unused labels/variables and modernize casts. * This refactor improves correctness, debuggability, and safety of monitor connection lifecycle management.	2 months ago
René Cannaò	0f7ff1f374	Merge branch 'v3.0' into v3.0_pgsql-query-digest-gen-5253 ... Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rahim Kanji	5e75264bb3	Updated TAP test	2 months ago
Rahim Kanji	24e02e95d5	Changing monitor ping poll() timeout to 10ms	3 months ago
Rahim Kanji	6a80c3f288	Implemented explicit task memory ownership management in Monitor_Poll.	3 months ago
Rahim Kanji	50fae0b02a	Current check on file descriptors (fd) is not reliable or necessary	4 months ago
Rahim Kanji	1c3c42959c	Improve ping accuracy ... - Introduced batching for ping task dispatch (default: 30 servers per batch) - Moved mysql_server_ping_log writes to a thread pool	4 months ago
Juan Manuel Fernández García-Minguillán	8554742131	Avoid send close in ssl connections	6 months ago
René Cannaò	7490af1783	Group Replication support for MySQL 8.4 and 9.x ... Closes #4954	9 months ago
René Cannaò	f9575b7ee9	Addressing minor issue on Readyset Monitoring ... - Renamed ReadySet to Readyset - fixed incorrect status variable - added missing newlines	10 months ago
René Cannaò	d641ca89be	First POC for integration with ReadySet ... Monitor is able to detect if a backend is a ReadySet server, and it enables special monitoring. The special monitoring hacks replication lag checks: a ReadySet server is "monitored for replication lag" , but it has a special query and a special handler. The query for check is "SHOW READYSET STATUS" , and the `Status` line is processed: * Online: the backend is configured as ONLINE * Maintenance* : the backend is configured as OFFLINE_SOFT * anything else, or failed check: SHUNNED A new monitor table is also added: `readyset_status_log` . It has a similar structure of `mysql_server_replication_lag_log` , but instead of storing `repl_lag` (replication lag) the full output of `SHOW READYSET STATUS` is saved as a JSON (that can be queried using `JSON_EXTRACT()`	10 months ago
Javier Jaramago Fernández	7955dd21a8	Fix MySQL 8.4 replication lag monitoring - Closes #4727 ... Added support for new syntax to simulator.	11 months ago
René Cannaò	b53b5b24cc	Merge pull request #4810 from sysown/v3.0-SetThreadName_optional ... Make set_thread_name() optional	1 year ago
René Cannaò	2d797a55ba	Merge pull request #4809 from sysown/v3.0-fix_ssl_params_leak ... Fix memory leak on `ssl_params` fetch in Monitor - Port of #4795	1 year ago
René Cannaò	c2f1871adf	Make set_thread_name() optional	1 year ago
Javier Jaramago Fernández	ac3e75244c	Fix leak of SSL caches for auxiliary threads ... Whenever a thread creates MySQL connections using SSL params the thread-local caches are populated. These thread-local resources need to be free on thread exit via 'mysql_thread_end', otherwise these objects will be leak. This is not relevant for the fixed size thread-pools, but it's for workloads making use of temporary/auxiliary threads.	1 year ago
Javier Jaramago Fernández	9a08a12204	Fix memory leak on 'ssl_params' fetch in Monitor	1 year ago
Rahim Kanji	bd6674c383	* Introduced a 5% jitter to cache_ttl to increase the likelihood of distributing DNS resolution across multiple intervals, reducing the chance of simultaneous expiry times. ... * Added a small delay after queuing DNS records, allowing DNS resolver thread time to process as many hostnames as possible before assessing the need for additional helper threads. This helps prevent 'DNS resolver queue too big' warnings in the logs.	1 year ago
René Cannaò	04abd43a57	Initial commit with PostgreSQL support	1 year ago
René Cannaò	2726c27710	Merge pull request #4662 from sysown/v2.7_dns_cache_fixes ... DNS record will be removed if MySQL connection fails or times out for a specific hostname [v2.7]	1 year ago
Rahim Kanji	c5bc9ed2c6	DNS Cache Fixes ... * If a MySQL connection fails or times out for a specific hostname, the corresponding DNS record will be removed from DNS Cache. This ensures that outdated DNS records are not retained. (Rest of the DNS resolution process remains unchanged) * DNS cache functionality will automatically be disabled when ProxySQL is run with the -M or --no-monitor option.	1 year ago
René Cannaò	cf9d5fe21a	Merge pull request #4574 from sysown/set-thread-names ... Set thread names	1 year ago
Niels Vogell	89a3247959	Adding a null-check on a MySQL query result and avoiding redundant string initialization	2 years ago
Andriy Utkin	af2e223349	ConsumerThread: parametrize thread name	2 years ago
Niels Vogell	1b2982f5ab	Adding additional checks to only process discovered servers from an AWS RDS Multi-AZ DB Cluster	2 years ago
Niels Vogell	8154f4b330	Disable AWS RDS topology discovery by default with 0 as special value for the discovery interval	2 years ago
Andriy Utkin	5e79afa8e0	Set thread names	2 years ago
Miro Stauder	8394fd444e	use local includes - prometheus	2 years ago
René Cannaò	cdfcfdce94	Merge pull request #4528 from sysown/v2.x_monitor_slave_lag_when_null_4521 ... Introduced new HG attribute 'monitor_slave_lag_when_null' which takes precedence over 'mysql_thread_monitor_slave_lag_when_null'	2 years ago
Javier Jaramago Fernández	19e4ac2ead	Mitigate invalid memory accesses from Monitor GR on 'SHUTDOWN SLOW'	2 years ago
Rahim Kanji	648c3ab61d	* Improved handling for cases where seconds_behind_master is null or negative	2 years ago
Rahim Kanji	40068b122a	Addeda new attribute called 'monitor_slave_lag_when_null' in hostgroup settings, which takes precedence over 'mysql_thread_monitor_slave_lag_when_null' if both are configured.	2 years ago
Javier Jaramago Fernández	8d8f2eac8b	Improve error message for 'process_discovered_topology'	2 years ago
Javier Jaramago Fernández	06bd34b48b	Fix error message format on 'process_discovered_topology'	2 years ago
Javier Jaramago Fernández	5d7e5d9e00	Merge pull request #4406 from anphucbui/v2.x ... Add support for AWS RDS MySQL Multi-AZ Cluster auto-discovery	2 years ago
anphucbui	bbb6176ebf	Remove redundant exception guards, remove parseLong, add checksum computation after adding a new server, and other small changes based on feedback	2 years ago
René Cannaò	68da6dd29d	Use of ssl_params in MySQL_Monitor	2 years ago