proxysql

Commit Graph

Author	SHA1	Message	Date
Javier Jaramago Fernández	e73ba2b64c	Fix changing server defaults for 'reg_test_unexp_ping_pkt' - Fixed was changing server defaults ('max_allowed_packet') in the same connection as the subsequent INSERT. - Use direct MySQL connection for table/data preparation. - ProxySQL connection pool required cleanup 'connection_pool' to ensure defaults reload.	4 months ago
Javier Jaramago Fernández	7efc85cee3	Fix TAP 'groups.json' file syntax	4 months ago
Javier Jaramago Fernández	5c8a32a0b0	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-handle_unexp_ping	4 months ago
Javier Jaramago Fernández	b9cf5b1689	Remove empty spaces at end of lines for TAP tests 'groups.json'	4 months ago
Javier Jaramago Fernández	54e2b3e6dc	Add new test 'reg_test_unexp_ping_pkt-t' to TAP groups	4 months ago
René Cannaò	0f7ff1f374	Merge branch 'v3.0' into v3.0_pgsql-query-digest-gen-5253 Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
René Cannaò	2667540fcc	Merge pull request #5237 from sysown/v3.0_pgsql-monitor-sslsupport-5205 Add SSL support for backend connections in PGSQL monitor	4 months ago
Javier Jaramago Fernández	503b0975c6	Add new TAP test exercising unexpected COM_PING packets logic Also fixes 'random_string' utility function for large strings, avoiding the previous shuffle repetition from the dictionary.	4 months ago
Rahim Kanji	febb650abb	Added Multiple Keep Comments test	4 months ago
Rahim Kanji	5e75264bb3	Updated TAP test	4 months ago
Rahim Kanji	e70fcbf021	* Add dedicated handling for double-quoted PostgreSQL identifiers * Added crash payload testing * Fixed unterminated comments handling	4 months ago
Rahim Kanji	fd53642f12	Added pgsql-query_digests_stages_test-t to groups.json	4 months ago
Rahim Kanji	f9b9ede64c	Fixed TAP test	4 months ago
Rahim Kanji	1b16a3938b	Added TAP test	4 months ago
Rene Cannao	66119b74fb	Add comments to select @@version queries to bypass ProxySQL interception ProxySQL now responds directly to `select @@version` queries, which prevents these queries from reaching the backend MySQL server. This commit adds `/* set_testing */` comments to these queries in test files to prevent perfect match interception and allow them to run on the backend. Modified files: - test/tap/tap/utils.cpp - test/tap/tests/set_testing-240.h - test/tap/tests/set_testing.h - test/tap/tests/test_firewall-t.cpp	4 months ago
René Cannaò	5a314d2364	Merge pull request #4889 from sysown/v3.0_get_server_version Added handling of SELECT @@version and SELECT VERSION() without backend	4 months ago
Rahim Kanji	d1b003a0e4	Added TAP test to groups.json	4 months ago
Rahim Kanji	0e7b5e2ba8	Added TAP test	4 months ago
Rene Cannao	a206828609	Add test_load_from_config_prefix_stripping-t to test groups Adds the new prefix stripping validation test to the default-g4 test group along with mysql-auto_increment_delay_multiplex=0-g4, mysql-multiplexing=false-g4, mysql-query_digests=0-g4, and mysql-query_digests_keep_comment=1-g4 groups. This ensures the test is run as part of the regular test suite.	4 months ago
Rene Cannao	7ebdf561ca	Fix automatic prefix stripping to work with libconfig lookup The previous implementation stripped the prefix before calling group.lookupValue(), which would fail because the config file contains the prefixed name (e.g., "mysql-log_unhealthy_connections"). The lookup must use the original name from the config file. This commit moves the prefix stripping logic to after the value lookup but before constructing the SQL query, ensuring both: 1. The correct value is retrieved from the config using the original prefixed name 2. The variable is stored in the database with a single prefix Also includes a test to verify the fix works for mysql_variables, pgsql_variables, and admin_variables sections.	4 months ago
René Cannaò	b73160ef5f	Merge pull request #4901 from sysown/v3.0_wait_timeout [WIP] Setting client side wait_timeout	4 months ago
René Cannaò	0d55ab5ea2	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	2b900b3465	Update test groups configuration	4 months ago
Rene Cannao	dc4694d656	Refactor idle session scanning and improve test precision Code improvements: - Extract SESS_TO_SCAN_idle_thread constant to header file for better maintainability - Replace magic number 128 with named constant in idle_thread_to_kill_idle_sessions() - Improve code readability and consistency in session scanning logic Test enhancements: - Add mysql-poll_timeout configuration for more precise timeout testing - Reduce test sleep times to 13 seconds for faster test execution - Add diagnostic messages to clearly show timeout configurations in test output - Ensure tests properly validate timeout enforcement with precise timing The changes improve code maintainability and make tests more reliable and faster while maintaining accurate timeout validation.	4 months ago
Rene Cannao	0c5e75a064	Fix wait_timeout timeout calculations and add proper newline characters Key improvements: - Fix timeout comparison in MySQL_Thread::idle_thread_to_kill_idle_sessions() to prevent underflow - Use effective wait_timeout (minimum of global and session values) for idle timeout calculations - Add proper newline characters to proxy_warning messages for consistent log formatting - Increase test sleep times to account for global timeout enforcement - Fix session timeout test durations to properly test timeout behavior Technical changes: - Replace broken min_idle calculation with proper effective wait_timeout logic - Add std::min() usage to determine effective timeout from global and session values - Ensure warning messages end with newline characters for proper log formatting - Update test sleep durations to ensure proper timeout testing Resolves potential timeout calculation bugs and ensures consistent timeout enforcement behavior.	4 months ago
René Cannaò	6534a152b2	Merge pull request #5241 from sysown/v3.0-5062_2 Add fast forward replication deprecate EOF test and update test infrastructure (closes #5062)	4 months ago
Rene Cannao	0c9c938d66	Fix mysql-set_wait_timeout-t.cpp compilation and JSON testing - Replace <json/json.h> include with <json.hpp> and proper nlohmann namespace - Replace manual JSON parsing with fetch_internal_session() utility function - Replace fail() calls with ok(false, ...) to follow TAP framework standards - Add comprehensive JSON validation test for various wait_timeout values - Include edge case testing: zero values, maximum values, and clamping behavior Resolves compilation issues and enables proper testing of wait_timeout JSON output.	4 months ago
Rene Cannao	6539587c9a	test: Add comprehensive wait_timeout JSON validation tests - Add JSON parsing helper for PROXYSQL INTERNAL SESSION responses - Add test_wait_timeout_json_values() function with 8 test cases: * Zero value (should clamp to 1 second) * Valid values (1s, 10s, 5min, 1hr, 24hr, 20 days) * Value exceeding 20 days (should clamp to maximum) - Validate that wait_timeout appears in session JSON output - Test plan increased from 4 to 12 tests total - Provides comprehensive validation of wait_timeout clamping behavior	4 months ago
Rene Cannao	9df7407ff2	Add fast forward replication deprecate EOF test and update test infrastructure - Add comprehensive test `fast_forward_switch_replication_deprecate_eof.cpp` that validates all combinations of mysql-enable_client_deprecate_eof and mysql-enable_server_deprecate_eof settings during replication - Update test Makefile to include the new test in the test suite - Update test groups configuration to include the new test The test validates fast forward replication behavior across all 4 deprecate EOF combinations: - true/true, true/false, false/true, false/false - Ensures proper binary log fetching at full speed without throttling - Provides comprehensive coverage for CLIENT_DEPRECATE_EOF validation improvements Complements the existing fast_forward_grace_close test by focusing on EOF variable combinations rather than timing scenarios. Closes #5062	4 months ago
René Cannaò	b641c0d627	Merge pull request #5232 from sysown/fix/issue-4855 Fix issue 4855: Incorrect affected rows reporting for DDL queries	4 months ago
René Cannaò	3c4e09fec0	Merge pull request #5225 from sysown/v3.0_refactor_prepared_statement_cache_design_5211 Refactored Prepared-Statement Cache Design (Lock-Free Hot Path) - Part 2	4 months ago
René Cannaò	d188715a7d	Merge branch 'v3.0' into fix/issue-4855 Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
Rene Cannao	644174a348	Add reg_test_4855_affected_rows_ddl to TAP test groups Include the regression test for issue 4855 in the g1 test group configuration to ensure it runs as part of the standard test suite.	5 months ago
René Cannaò	ae30eea64e	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
René Cannaò	3810922340	Merge pull request #5198 from sysown/v3.0_add_delay_tap_test Add delay to let ProxySQL process mysql_stmt_close()	5 months ago
Rene Cannao	f5128d76d9	Fix TAP test for issue 4855 affected rows DDL bug Improve the TAP test to be SQLite-compatible and comprehensive: - Remove TRUNCATE operations (not supported by SQLite) - Use individual DROP TABLE statements instead of multi-table DROP - Add VACUUM test to verify DDL affected rows are 0 - Update test plan to match actual number of assertions (14) - Use temporary tables instead of configuration tables - Test all major DDL operations: CREATE, DROP, ALTER, VACUUM - Test all major DML operations: INSERT, UPDATE, DELETE - Verify affected rows are correctly calculated for all query types - Add test for commented DDL queries - Include comprehensive cleanup with proper error handling The test now accurately verifies that the sqlite3_total_changes64() difference approach correctly fixes the affected rows calculation for both DDL and DML operations.	5 months ago
Rene Cannao	a54a0ad88e	Fix TAP test to use correct TAP framework functions - Replace made-up fail()/pass() functions with ok() and diag() - Follow proper TAP test structure from ProxySQL TAP guide - Use plan(N), ok(condition, description), diag(), and return exit_status() - Maintain proper error handling and test organization	5 months ago
Rene Cannao	9df1e4751f	Clean up: Remove incorrect standalone test file	5 months ago
Rene Cannao	19c635b785	Fix TAP test to use proper ProxySQL connection patterns - Use CommandLine cl object with getEnv() for configuration - Remove hardcoded IP, ports, and credentials - Connect to both Admin interface and SQLite3 Server - Test DDL queries returning 0 affected rows after DML operations - Follow ProxySQL TAP test conventions and patterns	5 months ago
Rene Cannao	b6b60e1a46	Add proper TAP test for issue 4855 fix - TAP test connects to ProxySQL Admin interface on port 6032 - Tests INSERT, CREATE TABLE, DROP TABLE, UPDATE, DELETE operations - Verifies that DDL queries return 0 affected rows after DML operations - Confirms the sqlite3_total_changes64 fix works correctly in Admin interface - This directly tests the issue reported in #4855	5 months ago
Rene Cannao	bf4b1d920a	Update TAP test for issue 4855 with standalone version - Updated main TAP test to remove proxy_sqlite3 wrapper dependency - Added standalone TAP test using raw SQLite functions - Both tests verify the sqlite3_total_changes64 difference approach works correctly - Main ProxySQL build confirms the fix is functional	5 months ago
Rene Cannao	a577491f42	Refactor issue 4855 fix: Use sqlite3_total_changes64 difference approach PROBLEM: The initial fix used a DDL detection approach which required maintaining a list of query types that should return 0 affected rows. This approach was brittle and could miss edge cases like commented queries or complex statements. SOLUTION: Instead of detecting DDL queries, use sqlite3_total_changes64() to measure the actual change count before and after each query execution. The difference between total_changes before and after represents the true affected rows count for the current query, regardless of query type. CHANGES: - Added proxy_sqlite3_total_changes64 function pointer and initialization - Rewrote execute_statement() and execute_statement_raw() to use total_changes difference approach - This automatically handles all query types (DDL, DML, comments, etc.) - Added comprehensive TAP test covering INSERT, CREATE, DROP, VACUUM, UPDATE, and BEGIN operations BENEFITS: - More robust and accurate than DDL detection approach - Handles edge cases like commented queries automatically - No maintenance overhead for new query types - Simpler and cleaner implementation - Still fixes both Admin interface and SQLite3 Server This approach is mathematically sound: affected_rows = total_changes_after - total_changes_before, which gives the exact number of rows changed by the current query execution. Fixes #4855	5 months ago
Rene Cannao	d0ef691882	Add mysql-select_version_without_backend-t to TAP group	5 months ago
René Cannaò	588b0a0ae6	Merge branch 'v3.0' into v3.0_wait_timeout Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
Rene Cannao	0c3582f107	Add TCP keepalive warnings test to TAP test groups Added reg_test_5212_tcp_keepalive_warnings-t to the default test group to ensure the new TCP keepalive warnings test is included in automated testing.	5 months ago
René Cannaò	199d8bb7f0	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
Rene Cannao	6a700cd5be	Add comprehensive Doxygen documentation to get_matching_lines_from_filename() - Document purpose, parameters, return values, and behavior - Include practical example with TCP keepalive warnings - Explain memory-efficient queue-based approach - Note stream sharing benefits and I/O limitations - Provide clear contract for function usage and expectations	5 months ago
Rene Cannao	19176909d1	Rename TAP test file to remove mysql- prefix - Rename mysql-reg_test_5212_tcp_keepalive_warnings-t.cpp to reg_test_5212_tcp_keepalive_warnings-t.cpp - Test covers both MySQL and PostgreSQL TCP keepalive warnings, so mysql- prefix is misleading	5 months ago
Rene Cannao	b1a1930e1c	Add working TAP test for TCP keepalive warnings (issue #5212 ) - Implement get_matching_lines_from_filename() with efficient queue-based processing - Use standard C++ regex instead of RE2 for reliable pattern matching - Add filename-based function to avoid stream sharing conflicts - Remove problematic stream-based function with max_lines parameter - Fix regex pattern to match actual log warning format - Add comprehensive debugging output (disabled with #if 0) - Test both MySQL and PostgreSQL TCP keepalive warnings - Search only last 10 lines for efficiency and relevance The test now correctly verifies that TCP keepalive warnings are logged when mysql-use_tcp_keepalive or pgsql-use_tcp_keepalive is set to false.	5 months ago
Rene Cannao	e54e3c8df3	Add TAP test for TCP keepalive warnings with line-limited get_matching_lines() - Add TAP test mysql-reg_test_5212_tcp_keepalive_warnings-t.cpp to verify TCP keepalive warnings - Add overload of get_matching_lines() with max_lines parameter to scan only last N lines - Current implementation reads entire file into memory (inefficient) - needs optimization - Test reports finding 4 MySQL warnings in 50 lines (impossible) - indicates bug - Add debugging output to show lines read vs lines examined WIP: get_matching_lines() optimization needed using queue instead of vector WIP: Test logic debugging needed for impossible warning counts Resolves: #5212	5 months ago

1 2 3 4 5 ...

1530 Commits (9f30d85e10c5db24c041cb50584fdb856479e26e)