proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	03e58146ea	fix: Re-enable SQLite3DB::LoadPlugin() with allow_load_plugin flag This addresses an issue from PR #22 where LoadPlugin() was completely disabled. The function performs necessary initialization even when no plugin is loaded (initializes built-in sqlite3 function pointers). Changes: - Added `const bool allow_load_plugin = false` flag in LoadPlugin() - Modified `if (plugin_name)` to `if (plugin_name && allow_load_plugin == true)` - Re-enabled the LoadPlugin() call in LoadPlugins() The plugin loading code remains disabled (allow_load_plugin=false) while the function pointer initialization from built-in SQLite3 now works correctly. TODO: Revisit plugin loading safety mechanism to allow actual plugin loading.	1 month ago
Rene Cannao	5dd5dbe6b7	fix: Add missing assert(proxy_sqlite3_bind_blob) in sqlite3db.cpp Add assert(proxy_sqlite3_bind_blob) to the assertion block in SQLite3DB::LoadPlugin to ensure the symbol is provided by plugins. Without this, if a plugin fails to provide the symbol, the code will crash at runtime with no safety check. proxy_sqlite3_bind_blob is actively used in Anomaly_Detector.cpp:765 to bind embeddings. Addresses coderabbitai review comment.	1 month ago
Rene Cannao	b4f521c634	Merge v3.1-MCP2 into v3.1-vec Conflict resolution summary: Features preserved from v3.1-vec: - mcp_use_ssl variable (HTTP/HTTPS mode support) - RAG tool handler support - FTS (Full Text Search) functionality in MySQL_Tool_Handler Changes accepted from v3.1-MCP2: - Schema isolation for catalog (removed mcp_catalog_path/fts_path variables) - Schema parameter added to catalog functions - Comprehensive query rewriting improvements in Query_Tool_Handler - Format string fixes in vector_db_performance-t.cpp Key decisions: - catalog_path/fts_path: Removed per v3.1-MCP2 commit `35b0b224` (intentional) - MySQL_Catalog.cpp: Accepted v3.1-MCP2 version (schema isolation improvements) - Query_Tool_Handler.cpp: Accepted v3.1-MCP2 version (significant improvements) - Makefile: Kept v3.1-vec's EXCLUDE_TRACKING_VARIABLES (correct spelling) Build notes: - MySQL_Tool_Handler now requires schema parameter for catalog operations - Catalog path is hardcoded to datadir/mcp_catalog.db - FTS functionality preserved but may need updates for schema isolation	1 month ago
Rene Cannao	0db022a179	Apply fixes	1 month ago
Rene Cannao	2dfd61a958	Replace remaining direct sqlite3_* calls with proxy_sqlite3_* equivalents (address code-review)	1 month ago
Rene Cannao	8dc4246bdc	Introduce canonical proxy_sqlite3 symbol TU; update lib Makefile; remove MAIN_PROXY_SQLITE3 from main.cpp	1 month ago
Rahim Kanji	79df69332d	Refactor find_script() to use parameterized prepared statements (via execute_prepared()) for safer SQL execution.	2 months ago
Rahim Kanji	14aef13827	Add method to execute already prepared SQLite3 statements, supporting both non-SELECT and SELECT queries.	2 months ago
Rene Cannao	a577491f42	Refactor issue 4855 fix: Use sqlite3_total_changes64 difference approach PROBLEM: The initial fix used a DDL detection approach which required maintaining a list of query types that should return 0 affected rows. This approach was brittle and could miss edge cases like commented queries or complex statements. SOLUTION: Instead of detecting DDL queries, use sqlite3_total_changes64() to measure the actual change count before and after each query execution. The difference between total_changes before and after represents the true affected rows count for the current query, regardless of query type. CHANGES: - Added proxy_sqlite3_total_changes64 function pointer and initialization - Rewrote execute_statement() and execute_statement_raw() to use total_changes difference approach - This automatically handles all query types (DDL, DML, comments, etc.) - Added comprehensive TAP test covering INSERT, CREATE, DROP, VACUUM, UPDATE, and BEGIN operations BENEFITS: - More robust and accurate than DDL detection approach - Handles edge cases like commented queries automatically - No maintenance overhead for new query types - Simpler and cleaner implementation - Still fixes both Admin interface and SQLite3 Server This approach is mathematically sound: affected_rows = total_changes_after - total_changes_before, which gives the exact number of rows changed by the current query execution. Fixes #4855	3 months ago
Rene Cannao	05960b5ddb	Fix issue 4855: Reset affected_rows to 0 for DDL queries in Admin interface Problem: When executing DDL queries (CREATE TABLE, DROP TABLE, VACUUM, etc.) in the ProxySQL Admin interface after DML operations, the affected rows count from the previous DML operation was incorrectly reported instead of 0. This is because SQLite's sqlite3_changes() function doesn't reset the counter for DDL statements. Root Cause: SQLite's sqlite3_changes() returns the number of rows affected by the most recent INSERT, UPDATE, or DELETE statement. For DDL statements that don't modify rows, SQLite doesn't reset this counter, so it continues to return the value from the last DML operation. Solution: - Added is_ddl_query_without_row_changes() function to identify DDL queries that don't affect row counts - Modified both execute_statement() and execute_statement_raw() in SQLite3DB to return 0 for affected_rows when executing DDL queries - The fix ensures that affected_rows is reset to 0 for: CREATE, DROP, ALTER, TRUNCATE, VACUUM, REINDEX, ANALYZE, CHECKPOINT, PRAGMA, BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, EXPLAIN Testing: - Created and ran comprehensive tests for DDL detection function - Verified build completes successfully - Confirmed the fix correctly identifies DDL vs DML queries Impact: This fix resolves the issue where Admin interface incorrectly shows affected rows for DDL operations, improving the accuracy and reliability of the ProxySQL Admin interface. Fixes #4855	3 months ago
Javier Jaramago Fernández	25d5681c61	Fix potential overflow for 'sqlite3_status' memory metrics The previous call have been replaced by 'sqlite3_status64' when querying 'SQLITE_STATUS_MEMORY_USED' to avoid potential integer overflows.	8 months ago
Javier Jaramago Fernández	6f2798abe0	Fix memory leak in 'ProxySQL_Admin::stats___mysql_global' - Closes #4976 The resource leak was associated to prepared statements (sqlite3_stmt). Since the detection of these leaks is tricky, because the resources held by 'SQLite3' never lose their references, a helper type ('stmt_unique_ptr') and a safer variation for 'prepare_v2' have been introduced. This helper type should automatically handle the lifetime of the statements, avoiding these kind of leaks in the future. The non-safe alternative has been flagged as 'deprecated', so it can be easily identified in later refactors or slowly removed during development.	8 months ago
Javier Jaramago Fernández	b27d1a92b1	Fix missing error handling for 'sqlite3_step' on 'SQLite3_result' Error handling for 'sqlite3_step' should be performed in a similar fashion as for 'sqlite3_exec'. Not handling these potential errors could result in invalid empty/incomplete resultsets when reading from the internal SQLite3 databases.	1 year ago
René Cannaò	e35f927364	Removed valgrind and sqlite3 from include files This seems to speedup compile time	2 years ago
René Cannaò	1bc9d9e5f4	Several code documentation	2 years ago
René Cannaò	71e2510ef6	Code cleanup on MySQL_HostGroups_Manager Some rework to try to reduce duplicated code	3 years ago
Javier Jaramago Fernández	ea7868d59b	Fix buffer overrun when computing 'SQLite3DB' plugin SHA1	4 years ago
René Cannaò	e41d498b2b	Initialize enabled_mutex in SQLite3_result Variable was not set in various constructors. Detected using valgrind.	5 years ago
Javier Jaramago Fernández	76b64bed95	Added extra logging reporting all galera nodes status when ProxySQL moves a node from hostgroup	5 years ago
René Cannaò	35c851b9fa	Moved LoadPlugin_sqlite3_plugin into SQLite3DB In this way we can initialize it from other applications, for example TAP tests	6 years ago
René Cannaò	2bbd84d2c9	Support for SQLite3 plugin This commit prepares proxysql for further development related to SQLite3. Specifically, it allows to either use built-in SQLite3 library, or to load it from a plugin.	6 years ago
val	f457624758	edge case : offset==0 and limit==0	6 years ago
René Cannaò	cec0404cba	Support for LIMIT/OFFSET in SQLite3_result()	6 years ago
Valentin Rakush	d5a7836011	Overload execute_statement method in sqlite3db	6 years ago
René Cannaò	9afe6824ff	Merge pull request #2407 from sysown/v2.0.9-libmicrohttpd-0.9.68 V2.0.9 libmicrohttpd 0.9.68	6 years ago
René Cannaò	c967bc179b	Several improvements to SQLite3 Server module: - ability to handle transactions - in OK packets and resultsets, SERVER_STATUS_IN_TRANS flag is set if a transaction is running - a persistent database file in datadir is used instead of in-memory database - database file uses WAL (Write-Ahead Logging) - WAL journal size is set to 64MB - monitor user can always login to SQLite3 Server - in case of database lock within a transaction, an error is immediately returned to client	6 years ago
René Cannaò	27284444dd	Optimization on SQLite3 internal library	6 years ago
René Cannaò	ee5b54d983	Create a wrapper around sqlite3_prepare_v2 This should fix several crashes if the internal db is locked or busy	7 years ago
René Cannaò	7895c841ee	Solve locking issue on SQLite3	7 years ago
ts-shigeha.hashimoto	97229a7799	Implement retries in case of SQLite3 database is locked	7 years ago
yuta-oxo	dd0981bf95	Fix memory leaks	8 years ago
René Cannaò	380523d392	Several fixed to graceful shutdown if proxysql_stats.db is not writable #1431	8 years ago
René Cannaò	d8c927227b	Code cleanup	8 years ago
René Cannaò	4fb9e3f88b	Dump in error log status of mysql_servers during reconfiguration Close issue #1255	8 years ago
René Cannaò	ee8110a515	Enhancement on Cluster solution This commit introduces: 2 new tables: * `runtime_checksums_values` : stores checksums of configurations in runtime. For now for `mysql_query_rules`, `mysql_servers` and `mysql_users` * `stats_proxysql_servers_checksums` : when clustering is enabled, it collects all metrics from `runtime_checksums_values` from all its peers 3 new global variables that defines it checksum needs to be generated during `LOAD ... TO RUNTIME` * `admin-checksum_mysql_query_rules` * `admin-checksum_mysql_servers` * `admin-checksum_mysql_users` ProxySQL Cluster connections now have timeouts: * 1 second timeout for CONNECT and WRITE * 60 seconds timeout for READ (useful for long poll)	9 years ago
René Cannaò	aa8f0c5c43	Remove spinlock from class SQLite3DB #977	9 years ago
René Cannaò	f550cf1340	Speeding up user management LOAD MYSQL USERS TO RUNTIME is not faster Introduced LOAD MYSQL USER username TO RUNTIME	9 years ago
René Cannaò	1fbafadccd	More reliable shutdown() and close() on mysql connections Related to #586	10 years ago
René Cannaò	84606e2410	Implement retries in execute() in case of SQLite3 is busy Fix issue #549	10 years ago
ethanblackburn	2ab4833498	Add checksum function to SQLite3_result	10 years ago
ethanblackburn	01420e5e26	Remove old code	10 years ago
ethanblackburn	26235f9c56	Add CHECKSUM command	10 years ago
René Cannaò	e6067a953d	External locking for SQLite3DB() Closes #368	11 years ago
René Cannaò	ba16850d2d	Adding function SQLite3DB::return_one_int()	11 years ago
René Cannaò	1e4abb99f9	Fixing locking issue on sqlite3	11 years ago
René Cannaò	68d6786320	first commit	11 years ago

46 Commits (9ba3df0ce7bf8514dae010fd899b6cd537bb3746)