644 Commits (976d7c2310c109cf477a730edb254591ef5c0502)

Author	SHA1	Message	Date
Wazir Ahmed	fc12e9a6ab	Add protocol label to connpool Prometheus metrics ... MySQL and PgSQL share the same metric family names for connection pool metrics. Since they have independent hostgroup ID namespaces, add a protocol label to distinguish metrics from each module. **Affected metrics:** - `proxysql_connpool_conns` - `proxysql_connpool_conns_total` - `proxysql_connpool_conns_queries_total` - `proxysql_connpool_conns_latency_us` - `proxysql_connpool_conns_status` - `proxysql_connpool_data_bytes_total` Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	3 months ago
Rene Cannao	cc53ddca23	Merge branch 'v3.0-openssl-fix' into v3.0-test0213	4 months ago
René Cannaò	fa35bda62b	Merge pull request #5069 from evkuzin/v3.0-fix-prometheus-metrics-dumplication ... add protocol labels for shared metrics between mysql and psql	4 months ago
Rene Cannao	4161372da7	refactor: migrate simple prepare_v2 cases to RAII-based API ... Migrate 11 functions in MySQL_HostGroups_Manager.cpp from the deprecated prepare_v2() API to the new RAII-based API. Uses raw pointer aliases to avoid .get() verbosity throughout the code. Changes per function: - servers_add() - All mysql_* table generation functions - Group replication, Galera, AWS Aurora hostgroups functions Pattern used: auto [rc, statement_unique] = mydb->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly, no .get() needed ... // No manual finalize - RAII handles it Benefits: - Automatic cleanup via RAII (no manual finalize needed) - Exception-safe cleanup on early returns - Reduced memory leak risk This addresses ~11 of the ~150 deprecated prepare_v2 warnings. Found during compiler warning analysis with 'make debug'.	4 months ago
Rene Cannao	df1c4e7928	fix: medium priority warnings - write-strings and unused variables ... 1. Fix write-strings warnings (12 occurrences): - MySQL_HostGroups_Manager.cpp: Change char* to const char* for src_status and dst_status variables - MySQL_Monitor.cpp: Change ConsumerThread constructor parameter from char thread_name[16] to const char *thread_name 2. Fix unused-but-set-variable warnings (6 occurrences) by wrapping PROXYSQLGENAI-specific variables in #ifdef blocks: - stats_mcp_query_tools_counters - stats_mcp_query_tools_counters_reset - stats_mcp_query_digest - stats_mcp_query_digest_reset - stats_mcp_query_rules - runtime_mcp_query_rules These variables were assigned values but appeared unused when PROXYSQLGENAI was not defined. Now they are only defined and assigned when PROXYSQLGENAI is enabled. This eliminates 18 compiler warnings: 12 write-strings and 6 unused-but-set-variable warnings. Found during compiler warning analysis with 'make debug'.	4 months ago
Rene Cannao	4c788dcbb3	fix: signed/unsigned comparison warnings (-Wsign-compare) ... Fix two HIGH priority signed/unsigned comparison warnings: 1. MySQL_HostGroups_Manager.cpp:1792 - Change loop variable from 'int j' to 'unsigned int j' to match the unsigned comparison with servers->len. 2. MySQL_Thread.cpp:4357 - Cast int to size_t when comparing with getBufferSize() which returns size_t. These changes prevent potential logic errors from negative values being interpreted as large unsigned values. Found during compiler warning analysis with 'make debug'.	4 months ago
René Cannaò	48f1b3cfef	Merge pull request #5095 from Gonlo2/fix-overflow-if-first-server-is-invalid ... Fix int overflow if the first server is invalid	4 months ago
Rene Cannao	e3026cbc6f	Fix wrong index in connection cleanup loops (MySQL and PgSQL) ... This commit fixes a bug where connection cleanup loops were removing the wrong connection from the pool. The loops checked each connection by index (i), but when an expired connection was found, they removed index 0 instead of index i. This caused: - Fresh connections at index 0 to be incorrectly deleted - Expired connections to remain in the pool Fixed files: - lib/Base_HostGroups_Manager.cpp:2603 (MySQL) - lib/MySQL_HostGroups_Manager.cpp:2939 (MySQL) - lib/PgSQL_HostGroups_Manager.cpp:2782 (PgSQL) The fix changes `remove(0)` to `remove(i)` to remove the correct connection. Related: #5094 (fixes similar issue in drop_all_idle_connections)	4 months ago
Rene Cannao	4aedacd83b	[skip-ci] Remove deprecated read_only_action implementations from MySQL and PgSQL HostGroups managers ... The old read_only_action() implementations were marked for deletion after 2025-07-14. These were replaced with new implementation that doesn't depend on the admin table. This change removes the deprecated code paths to clean up the codebase.	5 months ago
Rene Cannao	9a55e97429	docs: Add comprehensive Doxygen documentation for GTID refactoring ... - Document addGtidInterval() function with parameter details and reconnection behavior - Add documentation for readall() method explaining robust error handling - Document connect_cb() and reader_cb() callbacks with resource management details - Document generate_mysql_gtid_executed_tables() with multi-phase process explanation - Focus on functionality, thread safety, and performance improvements - Provide clear parameter descriptions and return value semantics	7 months ago
Wazir Ahmed	50c60284e6	gtid: Refactor reconnect logic & prevent `events_count` reset ... - This patch was originally added by commit 0a70fd5 and reverted by 8d1b5b5, prior to the release of `v3.0.3`. - The following issues are addressed in this update, - Fix for `use-after-free` issue which occured during CI test. - Fix for deadlock issue between `GTID_syncer` and `MySQL_Worker`. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	7 months ago
Wazir Ahmed	8d1b5b597c	Revert "gtid: Refactor reconnect logic & prevent events_count reset" ... This reverts commit 0a70fd515f.	8 months ago
Wazir Ahmed	0a70fd515f	gtid: Refactor reconnect logic & prevent `events_count` reset ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	9 months ago
Juan Manuel Fernández García-Minguillán	172bf9f48d	Fix int overflow if the first server is invalid	10 months ago
Evgeny Kuzin	2b44aaa58c	add protocol labels for shared metrics between mysql and psql	10 months ago
René Cannaò	b888cb89b9	Readyset: always use proxy_warning() when changing status	1 year ago
René Cannaò	f9575b7ee9	Addressing minor issue on Readyset Monitoring ... - Renamed ReadySet to Readyset - fixed incorrect status variable - added missing newlines	1 year ago
René Cannaò	e5b30282b7	Adding info/warning message when ReadySet server change status ... INFO: if status is changed to ONLINE WARNING : if status is changed to anything else	1 year ago
René Cannaò	d641ca89be	First POC for integration with ReadySet ... Monitor is able to detect if a backend is a ReadySet server, and it enables special monitoring. The special monitoring hacks replication lag checks: a ReadySet server is "monitored for replication lag" , but it has a special query and a special handler. The query for check is "SHOW READYSET STATUS" , and the `Status` line is processed: * Online: the backend is configured as ONLINE * Maintenance* : the backend is configured as OFFLINE_SOFT * anything else, or failed check: SHUNNED A new monitor table is also added: `readyset_status_log` . It has a similar structure of `mysql_server_replication_lag_log` , but instead of storing `repl_lag` (replication lag) the full output of `SHOW READYSET STATUS` is saved as a JSON (that can be queried using `JSON_EXTRACT()`	1 year ago
René Cannaò	e88692c172	Deprecate read_only_action() ... This function is not in used anymore	1 year ago
René Cannaò	c2f1871adf	Make set_thread_name() optional	1 year ago
René Cannaò	cbf4628ea3	Merge remote-tracking branch 'proxysql27/v2.7' into v2.x_postgres_merge27_20240917	2 years ago
René Cannaò	cf9d5fe21a	Merge pull request #4574 from sysown/set-thread-names ... Set thread names	2 years ago
Javier Jaramago Fernández	bbda0a86eb	Add initial impl for dual-password support	2 years ago
René Cannaò	a52fd0b859	Merge pull request #4620 from sysown/v2.x-fix_connpool_metrics_init_val ... Fix value on first fetch for connpool prometheus metrics	2 years ago
Javier Jaramago Fernández	50a95d4080	Fix value on first fetch for connpool prometheus metrics ... The initial value for metrics using 'p_update_connection_pool_update_*' helpers were missing. This only affects to the first metrics fetch, during the metric creation on the internal maps, subsequent fetches will find the already created metric and updated the value properly. As real counters are internal, this doesn't affect the correctness of the value in subsequent fetches.	2 years ago
Javier Jaramago Fernández	e1f99e8bea	Make logging of Galera nodes status conditional to 'mysql-hostgroup_manager_verbose' - Closes #4612	2 years ago
Chrysanthemum Swingler	87711456a5	Update Prometheus HELP statement for proxysql_connpool_conns_status	2 years ago
Rene Cannao	7fe013fac2	Merge branch 'proxysql_v2.x_240813' into v2.x_postgres_merge_v2.x_240813 ... This merges ProxySQL v2.x up to 2024-08-13	2 years ago
Javier Jaramago Fernández	f3ea2e613e	Fix SSL error queue cleanup for backend conns ... The SSL error queue wasn't cleanup after an SSL related error took place in a backend connection. This would result in the propagation of the error to other conns handled by the thread, which could result in: - Incorrect destruction of connections in conn-pool. - Invalid error propagation to clients. This is a consequence of 'libmariadbclient' not performing a cleanup of this queue by itself. The situation got mitigated since the library **does** perform a cleanup of such queue during connect phase ('auth_caching_sha2_client|auth_sha256_client'), and ProxySQL does a cleanup of this queue during frontend SSL traffic.	2 years ago
Rene Cannao	e642a78e48	Just code cleanup ... Removed dead code	2 years ago
Rene Cannao	404c5e70f3	More template for Hostgroup Managers	2 years ago
Rene Cannao	4236d20ed6	Initial work on template for HostGroups_Manager	2 years ago
Rene Cannao	e2362a9ed1	Removed reference to MHM_PTHREAD_MUTEX	2 years ago
René Cannaò	2eb1d0d1c1	Merge pull request #20 from sysown/v2.x_postgres_backend ... Added generic error handling, transaction detection and handling	2 years ago
Andriy Utkin	5e79afa8e0	Set thread names	2 years ago
Rahim Kanji	d3e9c9c85a	Merge remote-tracking branch 'remotes/Master/v2.x' into v2.x_proxysql_postgres_merge	2 years ago
Rahim Kanji	c8ce94c85b	Merge remote-tracking branch 'Master_POSTGRES/v2.x_postgres' into v2.x_postgres_backend	2 years ago
Rahim Kanji	27e1e4fb7a	Many improvements and bug fixes ... * Fixed OpenSSL includes and linking for LibPQ building. * Handled Empty query response. * Improve transaction status detection. * Implemented detection for unusable connections and fixed query retry mechanism. * Resolved Heap overflow issue. * Forward non-FATAL errors to client. * Added duplicate error detection to avoid adding multiple error packets in query result.	2 years ago
Miro Stauder	565848c4a0	use local includes - prometheus	2 years ago
Miro Stauder	8394fd444e	use local includes - prometheus	2 years ago
René Cannaò	cdfcfdce94	Merge pull request #4528 from sysown/v2.x_monitor_slave_lag_when_null_4521 ... Introduced new HG attribute 'monitor_slave_lag_when_null' which takes precedence over 'mysql_thread_monitor_slave_lag_when_null'	2 years ago
René Cannaò	fde8ace076	Removed json.hpp from include files ... This seems to speedup compile time, and also lead to smaller binary	2 years ago
Rahim Kanji	ca93da5857	Resolved conflicts	2 years ago
René Cannaò	c9326564c0	Minor changes to try to optimize compiling	2 years ago
René Cannaò	de345ecaed	Merge remote-tracking branch 'public/v2.x' into v2.x_postgres_240422	2 years ago
René Cannaò	9283cd2e9b	Code cleanup in MySQL_Thread::refresh_variables() ... Use macros to avoid repeating variable name and strings with the variable name. Because this commit avoids duplications of name and literals, this commit also renames: mysql_thread___monitor_groupreplication_max_transaction_behind_for_read_only to: mysql_thread___monitor_groupreplication_max_transactions_behind_for_read_only	2 years ago
Rahim Kanji	3ef9c5ed55	negative replication lag value will bring server back online	2 years ago
Rahim Kanji	648c3ab61d	* Improved handling for cases where seconds_behind_master is null or negative	2 years ago
Rahim Kanji	c7cf5ba344	Removed MySrvStatus class	2 years ago