proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	5d4318b547	fix: Address coderabbitai review concerns for PR #27 - Fix Discovery_Schema.cpp fingerprint output JSON consistency - Quote placeholders (e.g., "?" instead of ?) for valid JSON - Fix test_mcp_query_rules_block.sh exec_admin_silent function - Add -B and -N flags for batch mode with no headers - Remove unused YELLOW variable from test_phase1_crud.sh - Fix test_phase2_load_save.sh runtime DELETE to be non-fatal - Remove unused INITIAL_COUNT from test_phase3_runtime.sh - Fix test_phase3_runtime.sh to verify exact ID ordering - Fix test_phase4_stats.sh read-only test assertion - Make INSERT/DELETE non-fatal and fix assertion logic - Remove unused DIGEST_TEXT_CHECK from test_phase5_digest.sh - Fix test_phase8_eval_timeout.sh non-timeout response handling - Return failure for non-timeout responses - Remove stray exit 1 from test_phase8_eval_timeout.sh	3 months ago
Javier Jaramago Fernández	52142c4648	fix: Multiple issues with MCP query_(rules/digests) - Fixed invalid memory accesses for tables: + mcp_query_rules + stats_mcp_query_rules + stats_mcp_query_digests - Fixed inactive 'mcp_query_rules' being loaded to runtime. - Fixed hash computation in 'compute_mcp_digest'. - Fixed invalid escaping during 'stats_mcp_query_digests' gen. - Fixed digest generation for MCP arguments: + SQL queries are now preserved using 'mysql_query_digest_and_first_comment'. + TODO: Options for the tokenizer are right now hardcoded. - Added initial testing and testing plan for MCP query_(rules/digests). + TODO: Test finished on phase8. Timeouts destroy the MCP connection, leaving it unusable for subsequent queries this should be fixed for continuing testing. - TODO: There are several limitations to fix in 'validate_readonly_query'. This reflect in some query hacks in the testing. + 'SELECT' starting with comments (--) gets flagged as non-read. + 'SELECT' must have a 'SELECT .* FROM' structure. While common, simple testing queries many times lack this form.	3 months ago

Author

SHA1

Message

Date

Rene Cannao

5d4318b547

fix: Address coderabbitai review concerns for PR #27

- Fix Discovery_Schema.cpp fingerprint output JSON consistency
  - Quote placeholders (e.g., "?" instead of ?) for valid JSON
- Fix test_mcp_query_rules_block.sh exec_admin_silent function
  - Add -B and -N flags for batch mode with no headers
- Remove unused YELLOW variable from test_phase1_crud.sh
- Fix test_phase2_load_save.sh runtime DELETE to be non-fatal
- Remove unused INITIAL_COUNT from test_phase3_runtime.sh
- Fix test_phase3_runtime.sh to verify exact ID ordering
- Fix test_phase4_stats.sh read-only test assertion
  - Make INSERT/DELETE non-fatal and fix assertion logic
- Remove unused DIGEST_TEXT_CHECK from test_phase5_digest.sh
- Fix test_phase8_eval_timeout.sh non-timeout response handling
  - Return failure for non-timeout responses
- Remove stray exit 1 from test_phase8_eval_timeout.sh

Javier Jaramago Fernández

52142c4648

fix: Multiple issues with MCP query_(rules/digests)

- Fixed invalid memory accesses for tables:
    + mcp_query_rules
    + stats_mcp_query_rules
    + stats_mcp_query_digests
- Fixed inactive 'mcp_query_rules' being loaded to runtime.
- Fixed hash computation in 'compute_mcp_digest'.
- Fixed invalid escaping during 'stats_mcp_query_digests' gen.
- Fixed digest generation for MCP arguments:
    + SQL queries are now preserved using
      'mysql_query_digest_and_first_comment'.
    + TODO: Options for the tokenizer are right now hardcoded.
- Added initial testing and testing plan for MCP query_(rules/digests).
    + TODO: Test finished on phase8. Timeouts destroy the MCP
      connection, leaving it unusable for subsequent queries this should
      be fixed for continuing testing.
- TODO: There are several limitations to fix in
  'validate_readonly_query'. This reflect in some query hacks in the
  testing.
    + 'SELECT' starting with comments (--) gets flagged as non-read.
    + 'SELECT' must have a 'SELECT .* FROM' structure. While common,
      simple testing queries many times lack this form.

2 Commits (950f163bfb15c080736fd67aa67a8977cd8e9ff8)