proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	93eabfc7bc	fix: address code review issues in PostgreSQL cluster sync - Fix fetch_and_store incrementing success counter on failure - Fix sqlite3_stmt leak in pull_pgsql_variables_from_peer (use RAII) - Convert get_peer_to_sync_pgsql_query_rules and _servers_v2 to unified framework delegates (fixes atomic data race on .load()) - Merge dual scan loops in set_checksums to respect enabled_check - Remove spurious "deprecated" label from new checksum_pgsql_variables - Replace sprintf with snprintf in pgsql diffs_before_sync getters - Fix indentation on cluster_pgsql_variables blocks - Fix TAP plan mismatch: replace MYSQL_QUERY with inline mysql_query - Fix trivially-true table accessibility assertions - Add mysql_close on failed connect in test - Move test_cluster_sync_pgsql-t to legacy-g5 group	2 months ago
Rene Cannao	3f87479225	revert: remove unnecessary SYNC_TIMEOUT increase and legacy-g5 override The SYNC_TIMEOUT increase (10→30) and PROXYSQL_CLUSTER_NODES=1 override were based on wrong diagnosis. The actual root cause of the cluster isolation timeout was a GITVERSION mismatch in the binary from incremental builds — different .o files had different version strings, causing the cluster monitor to refuse syncing. With a clean build (as in CI), the default SYNC_TIMEOUT=10 and default cluster node count work fine.	2 months ago
Rene Cannao	94de63dbb7	fix: correct log message variable name for V2 modules and reduce cluster interference 1. Fix DIFFS_BEFORE_SYNC_FORMAT log message: mysql_servers_v2 and pgsql_servers_v2 modules logged non-existent variable names like 'admin-cluster_mysql_servers_v2_diffs_before_sync'. Added sync_var_suffix field to ChecksumModuleInfo so V2 modules use the correct variable name (e.g. 'mysql_servers'). 2. Increase SYNC_TIMEOUT from 10 to 30 seconds in test_cluster_sync-t to handle slower sync propagation with multiple cluster nodes. 3. Add legacy-g5 group env.sh with PROXYSQL_CLUSTER_NODES=1 to reduce cluster node interference during cluster isolation steps. These tests manage their own replicas and multi-node sync creates race conditions where removed proxysql_servers entries get re-added.	2 months ago
Rene Cannao	1c5e03f354	fix: use dynamic MySQL host/port in test_cluster_sync_mysql_servers The test hardcoded 127.0.0.1:13306-13309 as MySQL backend addresses. In the Unified CI, MySQL backends run in separate containers reachable by hostname (e.g. mysql1.infra-mysql57:3306), not on localhost ports. Use cl.mysql_host and cl.mysql_port from environment variables instead of hardcoded addresses. Non-ONLINE servers use offset ports as dummy entries since they're only sync test data and never connected to. Results: 44/44 tests pass (was 4/44 with immediate replica shutdown).	2 months ago
Rene Cannao	1232948fcb	fix: resolve cross-container networking for cluster sync tests The cluster sync tests spawn ProxySQL replicas inside the test-runner container. In the Unified CI, the primary ProxySQL runs in a separate container. The primary could not reach replicas registered as 127.0.0.1 because that resolves to the primary's own loopback. Fix: - Add --hostname test-runner to test-runner container so it has a stable DNS name on the Docker network - Add get_cluster_visible_host() to both cluster sync tests that returns the container hostname (resolvable by other containers) - Use this hostname for replica connection opts so proxysql_servers registrations and stats_proxysql_servers_checksums lookups work cross-container Results: - test_cluster_sync-t: 397/399 pass (was 21/399) - test_cluster_sync_mysql_servers-t: replicas now start and connect correctly, but further investigation needed for cluster node interference causing premature SHUTDOWN	2 months ago
Rene Cannao	69437751fd	fix: prevent cluster sync tests from hanging on replica shutdown failure Both test_cluster_sync-t and test_cluster_sync_mysql_servers-t launch ProxySQL replicas via system() in threads. If PROXYSQL SHUTDOWN fails or the admin connection is NULL, the process never exits and thread.join() hangs forever. Fix: replace system() with fork()/exec() to track the child PID. Before join(), wait up to 5 seconds for the process to exit, then SIGKILL it as a fallback. This guarantees the test always terminates.	2 months ago
Rene Cannao	faa1054674	Merge remote-tracking branch 'origin/v3.0' into fix/postgresql-cluster-sync_2	2 months ago
Rene Cannao	7e94ff904e	test: remove unnecessary fresh_connection workaround from pgsql cluster sync test The test was opening a new admin connection for every replica query, working around a supposed visibility issue where persistent sessions could not see synced pgsql data. Live testing confirms both persistent and fresh connections see identical data on the replica for all three modules (servers, users, query rules). The workaround is unnecessary.	2 months ago
Rene Cannao	ccf797a8c4	ci: rewrite pgsql cluster sync workflow to use Unified CI infra Replace the old jenkins-build-scripts based CI-taptests-pgsql-cluster workflow with the Unified CI infrastructure (test/infra/). This aligns it with all other test workflows. Changes: - Use ensure-infras.bash + run-tests-isolated.bash instead of jenkins-build-scripts cluster_start/cluster_init - Build proxysql-ci-base Docker image in the workflow - Pass TAP_PGSQL_SYNC_REPLICA_PORT through to the test container so the full cluster sync validation runs (not just checksums) - Set TAP_PGSQL_SYNC_REPLICA_PORT=6042 by default in env-isolated when cluster nodes are active - Proper cleanup with destroy-infras.bash on failure	2 months ago
Rene Cannao	2588630faf	ci: add groups.json format linter and GitHub Actions workflow Add lint_groups_json.py that enforces the compact one-line-per-entry format documented in test/tap/groups/README.md: valid JSON, sorted keys, no multi-line arrays. The CI workflow triggers on push/PR when groups.json is modified.	2 months ago
Rene Cannao	f2ed9436ce	fix: reformat groups.json to compact one-line-per-entry style The merge resolution used json.dump with indent=4 which broke the required format (one entry per line, compact arrays). Reformat to match the convention documented in test/tap/groups/README.md.	2 months ago
Rene Cannao	47758a468d	merge: resolve groups.json conflict with v3.0 Take v3.0's groups.json as base (legacy-gN naming, mysql84-gN groups, new test entries) and add test_cluster_sync_pgsql-t from this branch. Drop duplicate pgsql_admin_metacmds-t (already exists as pgsql-admin_metacmds-t in v3.0).	2 months ago
Wazir Ahmed	fa772c40b0	CI: Fix `infra-mysql57-binlog` setup - Fix infra-mysql57-binlog setup - Rework `docker-orchestrator-post.bash` based on infra-mysql57 orchestrator script - Add `testuser` to ProxySQL infra config - Fix multi-group cleanup - Rename the `GROUPS` variable in `destroy-multi-group.bash` to avoid the Bash special variable collision - Stop tracking CI-generated artifacts - Remove `test_cluster_sync.cnf` and `test-scripts/deps/mysqlbinlog` from git index - Ignore `test-scripts/deps/` directory Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rene Cannao	78c8a3d5e3	Fail fast in purge-trigger setup if connection or stmt fails Address review feedback: instead of silently continuing when the purge-trigger reconnect/prepare/deallocate fails, return false immediately with a diagnostic message.	2 months ago
Rene Cannao	3296ed5a07	Moving test_cluster_sync_mysql_servers-t from legacy-g3 to legacy-g5	2 months ago
Rene Cannao	26c5a25724	Fix read_only test assuming default_hostgroup=0 The test configures mysql_servers with writer_hostgroup=0 and reader_hostgroup=1, but the CI infrastructure sets users' default_hostgroup to 1300. When the test opens a proxy connection and runs BEGIN, ProxySQL routes to hostgroup 1300 which has no servers, causing a 10s timeout. Fix by setting default_hostgroup=0 for the test user at the start of each scenario.	2 months ago
Rene Cannao	1261d18a95	Fix SHOW WARNINGS test to work with MySQL 5.7 CAST('abc' AS DOUBLE) is MySQL 8.0+ syntax and fails on the legacy test group which uses MySQL 5.7. Use CAST('abc' AS SIGNED) instead, which produces a truncation warning on all MySQL versions. Fixes regression from PR #5548.	2 months ago
Rene Cannao	9098992f82	Fix timing issue in PgSQL prepared statement purge test The purge verification in test 1 was checking the statement count immediately after creating statements. The purge mechanism has a 1-second minimum interval between attempts and only removes statements with ref_count_client == 0. Fix by closing the connection (dropping refcounts), waiting 3 seconds, then triggering a new refcount change to invoke the purge before checking.	2 months ago
Rene Cannao	fe5a819051	Add 3 missing tests to groups.json Register newly compiled test binaries that were missing from groups.json, causing check_groups.py to block CI runs: - gtid_server_data_unit-t → unit-tests-g1 - test_ffto_mysql_errors-t → legacy-g4, mysql84-g4 - test_ffto_pgsql_error_stats-t → legacy-g4, mysql84-g4	2 months ago
René Cannaò	3659ba85fb	Merge branch 'v3.0' into advisory/com-stmt-send-long-data-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	151169da9b	Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	b94c855d4c	Merge branch 'v3.0' into advisory-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	fa6ebcdcc9	Merge commit from fork Fix PROXY protocol v1 address overflow	2 months ago
René Cannaò	419cd7608b	Merge commit from fork Fix COM_STMT_CLOSE short packet handling	2 months ago
René Cannaò	7a574a537a	Merge commit from fork Validate COM_CHANGE_USER packet bounds	2 months ago
Rene Cannao	cbc50ebf8a	ci: add dedicated CI workflow and groups.json entry for pgsql cluster sync test Register test_cluster_sync_pgsql-t in groups.json (default-g3) so it is picked up by CI-taptests-groups and passes check_groups.py validation. Add CI-taptests-pgsql-cluster.yml as a standalone workflow that runs only the PostgreSQL cluster sync TAP test, triggered after CI-trigger or via workflow_dispatch.	2 months ago
Rene Cannao	499896e44b	Address PR review feedback for test_binlog_dump_multi_backend_crash - Move wait_timeout mutation after hostgroup discovery skip check so early returns don't leave backend state modified (Copilot review) - Add precondition assertion verifying connections exist in both writer and reader hostgroups before sending COM_BINLOG_DUMP, using ConnOK pool stats (CodeRabbit review)	2 months ago
Rene Cannao	b2f4b4f9a0	Fix crash when COM_BINLOG_DUMP received with idle backends from other hostgroups (#5556 ) When a session has backend connections to multiple hostgroups and receives COM_BINLOG_DUMP, GPFC_Replication_SwitchToFastForward() transitions the session to FAST_FORWARD mode but only manages the active backend. Idle backends from other hostgroups remain in the session's mybes array with async_state_machine==ASYNC_IDLE. If MySQL's wait_timeout closes one of these idle connections, the resulting POLLIN event causes handler() to be called with ASYNC_IDLE, which has no case in the switch and hits assert(0). Fix: Clean up idle backends from other hostgroups during the FAST_FORWARD transition in GPFC_Replication_SwitchToFastForward(). These connections will never be used again, so they are destroyed immediately. Includes a regression test (test_binlog_dump_multi_backend_crash-t) that: - Sets up two hostgroups with query rules routing SELECTs to reader HG - Creates backend connections to both hostgroups on one session - Sends COM_BINLOG_DUMP to enter FAST_FORWARD mode - Waits for wait_timeout to close the idle backend - Verifies ProxySQL does not crash	2 months ago
René Cannaò	d0625dc243	Merge pull request #5549 from sysown/v3.0-CodeCov0325 Add 32 unit test files (2963 assertions) and CI workflow improvements	2 months ago
Rene Cannao	6d6015a203	fix: align MCP Bearer token test with case-insensitive implementation The test expected lowercase 'bearer' to be rejected, but the implementation uses strncasecmp() per RFC 7235 (auth-scheme is case-insensitive). Update test to expect true for lowercase prefix.	2 months ago
René Cannaò	2fcc5729ee	Merge pull request #5548 from yuji-hatakeyama/5306-fix_show_warnings_with_comment Fix #5306 - SHOW WARNINGS with inline comments incorrectly sets warning_count	2 months ago
René Cannaò	e067683f4e	Merge pull request #5545 from sysown/feat/ffto-error-recording feat(ffto): record error details from fast-forward sessions	2 months ago
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	4fb7aac73f	fix: restore groups.json to compact one-line-per-entry format Previous commits inadvertently reformatted groups.json with Python's json.dump(indent=2), breaking the compact format required by test/tap/groups/README.md. The correct format is one entry per line with compact arrays so grep works for quick lookups.	2 months ago
Rene Cannao	0441d5026d	security: fix all 48 Dependabot alerts — bump Python test deps Update all vulnerable Python packages in test infrastructure: Package Old New Severity CVEs PyMySQL 0.9.2 >=1.1.1 CRITICAL CVE-2024-36039 (SQL injection) requests 2.26.0 >=2.33.0 HIGH CVE-2024-35195, CVE-2024-47081, CVE-2023-32681, CVE-2026-25645 urllib3 1.26.6 >=2.6.3 HIGH CVE-2023-43804, CVE-2023-45803, CVE-2024-37891, CVE-2025-50181, CVE-2025-66418, CVE-2025-66471, CVE-2026-21441 certifi 2021.5.30 >=2024.7.4 HIGH CVE-2022-23491, CVE-2023-37920, CVE-2024-39689 idna 2.10 >=3.7 MEDIUM CVE-2024-3651 Changes: - requirements.txt: bump all 6 packages, use >= instead of == - requirements-ubuntu24.txt: same bumps - Pipfile: bump pymysql/requests, update python_version 2.7 → 3 - Remove stale Pipfile.lock (generated for Python 2.7, all hashes outdated) API compatibility verified: - PyMySQL: pymysql.connect(), DictCursor, OperationalError, CLIENT.MULTI_STATEMENTS, defer_connect all work in 1.1.x. `passwd` kwarg is aliased to `password` internally. - requests: basic requests.post() usage unchanged - urllib3/certifi/idna: transitive deps, no direct API usage Note: CI Docker image (ubuntu:24.04) installs packages via apt-get, not pip. These requirements files are used for local dev and some CI fallback paths.	2 months ago
Rene Cannao	e806b0219c	test: register 5 new unit tests in groups.json for CI	2 months ago
Rene Cannao	c8408d76b3	test: add 6 unit test files with 588 assertions (Round 5) New test files (test/tap/tests/unit/): Core: - pgsql_tokenizer_unit-t (65 tests): PgSQL SQL digest — dollar- quoted strings, ::type casts, ARRAY literals, boolean literal replacement, E/B/X/U& prefix strings, comment handling, grouping/IN-list collapsing, edge cases - admin_disk_upgrade_unit-t (60 tests): all 6 disk_upgrade_*() schema migration functions with in-memory SQLite — scheduler v1.2.0→current, mysql_users v1.3.0→current, rest_api_routes v2.0.15→current, mysql_servers v1.1.0→current (with weight cap and compression normalization bugs), pgsql_replication_hostgroups v3.0.1→current, mysql_query_rules v1.2.2→current - gtid_utils_unit-t (37 tests): addGtid interval merging (adjacent, non-consecutive, duplicate, bridge, reverse-order, within- existing), addGtidInterval (update, duplicate, non-overlapping), gtid_executed_to_string formatting - glovars_unit-t (78 tests): GloVars constructor defaults, ProxySQL_Checksum_Value (set/replace_zeros/version/epoch), generate_global_checksum determinism, command-line parsing (--initial/--reload/--no-version-check/-D/--bootstrap/-n/-f/-M) - query_processor_unit-t (+217 tests, 259 total): EXTENDED with PgSQL-specific tests — all-fields rule creation, client_addr wildcard, flagOUT attributes JSON, command counters, stats, rule text 35-column serialization, query_parser_command_type for 100+ PgSQL commands (DML/DDL/views/sequences/functions/ triggers/policies/LISTEN/NOTIFY/VACUUM/TEXT SEARCH/etc.), fast routing hashmap, firewall whitelist, query digests GenAI/MCP (PROXYSQLGENAI=1): - genai_mysql_catalog_unit-t (89 tests): MySQL_Catalog with in-memory SQLite — upsert/get/remove, schema isolation, list with pagination, FTS search, merge, multiple kinds, special character handling Production changes for testability: - include/proxysql_admin.h: add friend class TestDiskUpgrade - test/tap/tests/unit/Makefile: add DEBUG auto-detection from libproxysql.a symbols (fixes struct layout ODR violations when library is built with -DDEBUG) Running totals: 32 test files, 2553 assertions, all passing.	2 months ago
Rene Cannao	8df688dd8a	test: register 5 new unit tests in groups.json for CI	2 months ago
Rene Cannao	a36834f968	test: add 6 unit test files with 676 assertions (Round 4) New test files (test/tap/tests/unit/): Core: - c_tokenizer_unit-t (59 tests): tokenizer/tokenize/free_tokenizer, c_split_2, mysql_query_digest_and_first_comment (literal replacement, comment stripping, NULL handling, grouping_limit, IN-clause), mysql_query_digest_first_stage, strip_comments - config_write_unit-t (111 tests): all 7 Write_*_to_configfile() functions with in-memory SQLite — MySQL users/servers/query rules, scheduler, restapi, global variables, proxysql_servers; tests field formatting, NULL handling, double-quote escaping, prefix grouping - listen_validator_unit-t (112 tests): trim_copy, split_listener_list, is_ipv4/ipv6_wildcard, parse_listener (IPv4/IPv6/Unix socket/ invalid/edge cases), sets_intersect, listeners_conflict, validate_module_listener_conflicts - ezoption_parser_unit-t (110 tests): standalone ezOptionParser — flags, string/int/float options, defaults, required/unknown, aliases, multi-value, usage layout, export/import, validators, vector getters - pgsql_txn_state_unit-t (+58 tests, 112 total): EXTENDED with PgSQL_ExplicitTxnStateMgr state machine tests — BEGIN/COMMIT/ ROLLBACK lifecycle, ROLLBACK AND CHAIN, savepoint add/release/ rollback_to, reset_state, fill_internal_session JSON, case- insensitive savepoints, END/ABORT synonyms. Uses minimal PgSQL_Session mock with variable snapshots. GenAI/MCP (PROXYSQLGENAI=1): - genai_discovery_schema_unit-t (172 tests): Discovery_Schema with in-memory SQLite — run/agent_run management, schema/object/column/ index/FK insertion, profile/LLM summary/domain/metrics/notes, list_objects pagination+ordering, get_object with columns/indexes, get_relationships FK mappings, FTS rebuild+search, fingerprint_mcp_args, compute_mcp_digest determinism, MCP_Query_Digest_Stats timing, MCP_Query_Processor_Output, MCP_Query_Rule defaults Running totals: 27 test files, 1944+ assertions, all passing.	2 months ago
Rene Cannao	a8c5432fc5	fix: remove stale proxysql.db before launching cluster sync replicas test_cluster_sync_mysql_servers-t spawns replica ProxySQL instances with a specific config file setting admin port to 96061/96062. If a proxysql.db from a previous run exists in the workdir, ProxySQL ignores the config file and loads from the DB instead, using the old admin port. The test then fails to connect on the expected port. Fix: remove proxysql.db and proxysql_stats.db before launching the replica, not just after. The post-launch cleanup is kept as well for normal operation.	2 months ago
Rene Cannao	0f76a18329	fix: resolve CI failures in charset_find and statistics unit tests charset_find_unit-t: - Fix plan count mismatch: plan(63) but only 62 ok() calls. Changed to plan(62). statistics_unit-t: - Root cause: TSDB auto-detect in Makefile searched for symbol 'ProxySQL_TSDB' which doesn't exist. Changed to 'init_tsdb_variables'. Without TSDB detection, struct layout mismatch caused statsdb_disk to appear as NULL (member offset shifted by #ifdef PROXYSQLTSDB). - Added statsdb_ok guard + skip() for test_init_creates_tables to prevent segfault if construction fails (graceful degradation). - Use TMPDIR/tmp directly instead of GloVars.datadir for statsdb path.	2 months ago
Yuji Hatakeyama	eda537ac6c	Add reg_test_5306 to test groups, excluding digest-disabled configs	2 months ago
Yuji Hatakeyama	7e1b8ac0e4	Fix #5306 : Add regression test for SHOW WARNINGS with comments	2 months ago
Rene Cannao	99dcb5b160	fix: namespace stats_utils helpers to avoid symbol collision ProxySQL_Admin_Tests2.cpp defines its own parse_int_or_zero() in an anonymous namespace. Our declaration in Stats_Tool_Handler.h (included transitively via cpp.h) created an ambiguous overload error. Fix: wrap the 4 helper functions in namespace stats_utils in both the header and implementation. A using-directive within the .cpp keeps existing call sites working without qualification.	2 months ago
Rene Cannao	99c86e5759	test: run check_groups.py at start of run-multi-group.bash Abort CI early if any compiled test binaries are missing from groups.json. This prevents silent test omissions — if a developer adds a test but forgets to register it, CI fails immediately with a clear message instead of silently skipping it.	2 months ago
Rene Cannao	093693ba06	test: add check_groups.py to verify groups.json completeness Python tool that checks consistency between groups.json and compiled TAP test binaries: - WARNING (exit 0): tests in groups.json that aren't compiled yet - ERROR (exit 1): compiled tests missing from groups.json Scans test/tap/tests/, test/tap/tests/unit/, and test/tap/tests_with_deps/ for ELF binaries matching *-t pattern. Usage: python3 test/tap/groups/check_groups.py	2 months ago
Rene Cannao	fa668d646a	test: register 21 new unit tests in groups.json for CI Add all new unit test binaries to the CI test group configuration: - 13 core tests → unit-tests-g1 - 8 GenAI tests → ai-g1 This ensures CI pipelines discover and run all new tests.	2 months ago
Rene Cannao	ece648fc16	test: add 6 more unit test files with 550 assertions (Tier 2+3) Expand coverage for firewall whitelist, statistics, config validation, logging, and GenAI thread variable management. New test files (test/tap/tests/unit/): Core: - query_processor_firewall_unit-t (44 tests): load_firewall() users/rules/sqli fingerprints, find_firewall_whitelist_user/rule, whitelisted_sqli_fingerprint, reload/clear, memory accounting, PgSQL parity, multiple digest bsearch - statistics_unit-t (20 tests, 95 with TSDB): timer functions (timetoget for MySQL threads, query cache, CPU, logger, digest), TSDB set/get/has variable with range validation, insert/query metrics, backend health, downsampling, retention - config_validation_unit-t (54 tests): addField() formatting and escaping, validate_backend_users() duplicate detection for MySQL/PgSQL, validate_backend_servers() with field aliases and default ports, validate_proxysql_servers() - log_utils_unit-t (42 tests): LogBuffer append/write/operator<< overloads, data() accessor, reset(), should_log() rate limiting, GetLogBufferThreadContext() lifecycle GenAI/MCP (PROXYSQLGENAI=1): - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler constructor defaults (26 vars), boolean/port/timeout/string variable set/get with range validation, has_variable, get_variables_list, null safety, target auth map - genai_thread_unit-t (193 tests): GenAI_Threads_Handler constructor defaults (31 vars), integer range validation for 15+ variables, double/boolean/string round-trips, has_variable, get_variables_list, overwrite and rejection persistence Note: found potential bug — llm_cache_enabled has no get/set handler despite being listed in variables array Minimal production change: - include/proxysql_config.h: add friend class for test access to private validate_backend_users/servers/proxysql_servers methods Running totals: 21 test files, 1268 assertions, all passing.	2 months ago
Rene Cannao	1d2f16b506	test: add 4 more unit test files with 198 assertions (Tier 1) Expand coverage for charset lookups, GenAI Query/LLM/MCP components. New test files (test/tap/tests/unit/): Core: - charset_find_unit-t (62 tests): all 4 proxysql_find_charset functions — edge cases for NULL returns, utf8mb3→utf8 translation, case-insensitive matching, collation preference GenAI/MCP (PROXYSQLGENAI=1): - genai_query_handler_unit-t (65 tests): validate_sql_identifier, escape_string_literal, strip_leading_comments, json_string/ json_int/json_double safe extraction, is_pgsql_protocol, is_runtime_online_status, uppercase_or_unknown - genai_llm_clients_unit-t (35 tests): is_retryable_error HTTP status codes (408/429/5xx) and CURL error codes, plus LLM_WriteCallback data accumulation - genai_mcp_endpoint_unit-t (36 tests): validate_bearer_token extraction/comparison, create_jsonrpc_response/error JSON-RPC 2.0 formatting Minimal production changes for testability: - include/Query_Tool_Handler.h: friend class + extern declarations for 8 pure helper functions - lib/Query_Tool_Handler.cpp: remove static from 8 file-local pure functions (no behavioral change) - include/MCP_Endpoint.h: friend class + new static validate_bearer_token() extracted from authenticate_request() - lib/MCP_Endpoint.cpp: extract token validation into static method - lib/LLM_Clients.cpp: remove static from is_retryable_error() and rename WriteCallback to LLM_WriteCallback (avoid collisions) Running totals: 15 test files, 718 assertions, all passing.	2 months ago
Rene Cannao	accc68c9dc	test: add 11 new unit test files with 520 assertions for lib/ coverage Add targeted unit tests for pure functions and isolated components across lib/, increasing test coverage for both core utilities and GenAI/MCP components. New test files (test/tap/tests/unit/): Core utilities: - pgsql_variables_validator_unit-t (75 tests): bool, float, string, memory size, search_path, and client_encoding validators - gen_utils_unit-t (28 tests): mywildcmp wildcard matching, escape_string_single_quotes, Proxy_file_regular - mysql_encode_unit-t (23 tests): mysql_encode_length, CPY3/CPY8, proxy_my_crypt XOR, write_encoded_length - proxysql_utils_unit-t (23 tests): hex/unhex, sql_escape, split_str, replace_str, generate_multi_rows_query, checksums - proxy_protocol_unit-t (22 tests): PROXY v1 header parsing, subnet validation, IPv4/IPv6 network matching - pgsql_error_helper_unit-t (139 tests): SQLSTATE code mapping, all 38 error class branches, severity classification, fill/reset - pgsql_txn_state_unit-t (54 tests): TxnCmdParser for BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, AND CHAIN variants - sqlite3db_unit-t (21 tests): execute, return_one_int, check_table_structure, build_table, row ops, locking GenAI/MCP (PROXYSQLGENAI=1): - genai_stats_parsing_unit-t (79 tests): parse_server_filter, parse_digest_filter, parse_ll_or_zero, get_interval_config, calculate_percentile - genai_fts_string_unit-t (32 tests): MySQL_FTS sanitize_name, escape_identifier, escape_sql, table name construction - genai_anomaly_unit-t (24 tests): normalize_query SQL normalization, check_sql_injection pattern detection Minimal production changes for GenAI testability: - include/Anomaly_Detector.h: add friend class for test access - include/Stats_Tool_Handler.h: declare 4 parsing helpers, move 2 pure computation methods (get_interval_config, calculate_percentile) to public - lib/Stats_Tool_Handler.cpp: remove static from 4 free helper functions (no behavioral change, only linkage visibility)	2 months ago

1 2 3 4 5 ...

2191 Commits (93eabfc7bc265a274a2bf9ffe37fbbcafbfda374)