738 Commits (87026c049d0449e299fa7d90168a851ec3ffa387)

Author	SHA1	Message	Date
Rene Cannao	5a7b22181f	Fix metrics collection for wait_timeout counters ... The get_status_variable() function was only scanning worker threads but ignoring auxiliary threads (idle threads) where timeout terminations are detected. This caused the timeout termination counter to show incorrect/zero values. - Added idle thread scanning to both overloaded versions of get_status_variable() function - Now properly collects metrics from both worker and idle threads - Fixes the issue where proxysql_mysql_timeout_terminated_connections_total showed zero despite actual timeout terminations Resolves the metrics reading issue identified in the previous commits.	6 months ago
Rene Cannao	dc4694d656	Refactor idle session scanning and improve test precision ... Code improvements: - Extract SESS_TO_SCAN_idle_thread constant to header file for better maintainability - Replace magic number 128 with named constant in idle_thread_to_kill_idle_sessions() - Improve code readability and consistency in session scanning logic Test enhancements: - Add mysql-poll_timeout configuration for more precise timeout testing - Reduce test sleep times to 13 seconds for faster test execution - Add diagnostic messages to clearly show timeout configurations in test output - Ensure tests properly validate timeout enforcement with precise timing The changes improve code maintainability and make tests more reliable and faster while maintaining accurate timeout validation.	6 months ago
Rene Cannao	0c5e75a064	Fix wait_timeout timeout calculations and add proper newline characters ... Key improvements: - Fix timeout comparison in MySQL_Thread::idle_thread_to_kill_idle_sessions() to prevent underflow - Use effective wait_timeout (minimum of global and session values) for idle timeout calculations - Add proper newline characters to proxy_warning messages for consistent log formatting - Increase test sleep times to account for global timeout enforcement - Fix session timeout test durations to properly test timeout behavior Technical changes: - Replace broken min_idle calculation with proper effective wait_timeout logic - Add std::min() usage to determine effective timeout from global and session values - Ensure warning messages end with newline characters for proper log formatting - Update test sleep durations to ensure proper timeout testing Resolves potential timeout calculation bugs and ensures consistent timeout enforcement behavior.	6 months ago
René Cannaò	588b0a0ae6	Merge branch 'v3.0' into v3.0_wait_timeout ... Signed-off-by: René Cannaò <rene@proxysql.com>	6 months ago
Rene Cannao	ae93966603	Add TAP test for fast forward grace close feature ... - Rename and modify test to use MySQL C API mysql_binlog_* functions - Implement throttled binlog reading with 5 iterations (no limit, 2s, 5s, 20s, 60s targets) - Add diagnostics for debugging binlog fetch issues - Set RPL options for file, position, server_id, and non-blocking flag - Update Makefile to compile with MySQL client library	7 months ago
Rene Cannao	44aa606caa	Implement fast forward grace close feature to prevent data loss ... Problem: In fast forward mode, ProxySQL forwards packets directly from client to backend without buffering them. If the backend connection closes unexpectedly (e.g., due to server crash, network failure, or other issues), ProxySQL immediately closes the client session. This can result in data loss because the client may have sent additional data that hasn't been fully transmitted yet, as ProxySQL does not wait for the output buffers to drain. Solution: Implement a configurable grace period for session closure in fast forward mode. When the backend closes unexpectedly, instead of closing the session immediately, ProxySQL waits for a configurable timeout (fast_forward_grace_close_ms, default 5000ms) to allow any pending client output data to be sent. During this grace period: - If the client output buffers become empty, the session closes gracefully. - If the timeout expires, the session closes anyway to prevent indefinite hanging. Changes: - Added global variable mysql_thread___fast_forward_grace_close_ms (0-3600000ms) - Added session flags: backend_closed_in_fast_forward, fast_forward_grace_start_time - Added data stream flag: defer_close_due_to_fast_forward - Modified MySQL_Data_Stream::read_from_net() to detect backend EOF and initiate grace close if client buffers are not empty - Modified MySQL_Session::handler() FAST_FORWARD case to implement grace close logic with timeout and buffer checks - Added extensive inline documentation explaining the feature and its mechanics This prevents data loss in fast forward scenarios while maintaining bounded session lifetime.	7 months ago
René Cannaò	dfd46fee4b	Merge pull request #5150 from proton-lisandro-pin/ignore_min_gtid ... Implement a `ignore_min_gtid_annotation` global variable, fix memory leak/overflow in `min_gtid` annotation handler.	7 months ago
René Cannaò	8be91071ef	Merge pull request #5190 from sysown/v3.0_default_interface_global_var_5189 ... Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	7 months ago
Lisandro Pin	6cb522283d	Implement a ignore_min_gtid_annotation global variable for ProxySQL ... When true, all `min_gtid` query annotations are ignored; see https://proxysql.com/documentation/query-annotations/ for details. This is useful on ProxySQL setups with multiple layers, where some layers mandate GTID-based routing while others don't.	7 months ago
Rahim Kanji	48928ce04e	Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	7 months ago
Rahim Kanji	86c17f04d7	Replace single sleep with looped delay for simulated watchdog test	7 months ago
Wazir Ahmed	5219d4be93	processlist: Prevent crash due to SQLITE_TOOBIG ... - Add new mysql/pgsql variable `processlist_max_query_length`. - Min: 1K - Max: 32M - Default: 2M - Truncate current query based on the configuration before inserting into `stats_*_processlist` tables. - Refactor/fix code related to other processlist configurations. 1. `session_idle_show_processlist` value was not updated in `ProxySQL_Admin.variables`. 2. Pass processlist config as an argument to `MySQL_Threads_Handler::SQL3_Processlist` instead of using thread-local variables. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	7 months ago
Wazir Ahmed	97eb19c0f0	fix: Close idle session based on effective timeout ... - effective_timeout = min (mysql-wait_timeout, session-wait_timeout) Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	10 months ago
Rahim Kanji	344ba25777	Add Watchdog PROXYSQLTEST covering MySQL and PgSQL threads	10 months ago
René Cannaò	2c26a42897	Merge pull request #4819 from sysown/v3.0-ff_conns_eof_caps_match ... Enforce `CLIENT_DEPRECATE_EOF` capability match for `fast-forward` sessions	1 year ago
René Cannaò	9737e0630a	Add variable mysql-eventslog_stmt_parameters #4923 ... Variable mysql-eventslog_stmt_parameters configures the logging of parameters in prepared statements: - 0 : logging disabled - 1 : logging enabled	1 year ago
Javier Jaramago Fernández	811874bad1	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-ff_conns_eof_caps_match	1 year ago
Yashwant Sahu	d7ec497afd	Now taking effective timeout taking as minimum of global timeout and session timeout	1 year ago
Yashwant Sahu	abe16e6692	Parsing and setting wait timeout for session	1 year ago
René Cannaò	d3f06c537f	Merge branch 'v3.0' into v3.0-ff_conns_eof_caps_match	1 year ago
René Cannaò	2551d350e9	Port to 3.0 of in-memory query logging ... See #4713 for further details	1 year ago
Rahim Kanji	f9232ae50d	Merge remote-tracking branch 'Master/v3.0' into v3.0_session_parameter_tracking	1 year ago
Javier Jaramago Fernández	d49a96dade	Enforce 'CLIENT_DEPRECATE_EOF' capability match for fast-forward ... - Ensures matching for 'CLIENT_DEPRECATE_EOF' capability when creating or acquiring backend conns for 'fast-forward' sessions. - Since 'CLIENT_DEPRECATE_EOF' capability isn't enforced on backend connections for regular sessions, a mismatch between client and backend capabilities is possible. A verification has been introduced when a session switches to 'fast-forward', in case of capabilities mismatch, an error is logged and client disconnected.	1 year ago
Rahim Kanji	35b2dd593d	Separate implementation of SET statement parser for MySQL and PostgreSQL	1 year ago
René Cannaò	7ef5993c35	Revert "Enforce 'CLIENT_DEPRECATE_EOF' capability match for conn-pool" ... This reverts commit 50ce205d21.	1 year ago
René Cannaò	b53b5b24cc	Merge pull request #4810 from sysown/v3.0-SetThreadName_optional ... Make set_thread_name() optional	1 year ago
René Cannaò	c2f1871adf	Make set_thread_name() optional	1 year ago
Javier Jaramago Fernández	50ce205d21	Enforce 'CLIENT_DEPRECATE_EOF' capability match for conn-pool ... Add new config option ('mysql-connpool_match_client_deprecate_eof') that allows to control whether to enforce a match between fronted and backend connections for 'CLIENT_DEPRECATE_EOF' capability. By default, this option is 'true', allowing smooth transitions from regular sessions to 'fast_forward'.	1 year ago
Rahim Kanji	b4e9060f71	Modified Set Parser	1 year ago
Yashwant Sahu	2d580746c5	changed protocol_compression_level default to (-1 to 9 )	1 year ago
Yashwant Sahu	2f3b2dacae	Merge branch 'v3.0' into v3.0_compression	1 year ago
Rahim Kanji	794ec0f48d	Merge remote-tracking branch 'Master/v3.0' into v3.0_dynamic_fast_forward	2 years ago
Yashwant Sahu	a0db6c3a1f	1. Changed name to protocol_compression_level. ... 2. Added TAP test	2 years ago
Yashwant Sahu	a846447a22	Added MySQL compression level	2 years ago
Rahim Kanji	ea059eadbf	Added SESSION_FORWARD_TYPE enum to define the type of session forwarding	2 years ago
Javier Jaramago Fernández	74c74adf5e	Prevent busy-waiting in active wait during 'listener_del' ... Since the operation of stopping each worker thread listeners is performed during 'maintenance_loops', the active wait taking place in 'listener_del' is likely to take some time. A sensible delay has been added to reduce unneccesary load.	2 years ago
Javier Jaramago Fernández	8bc60ed283	Fix worker threads stalling race condition on RESUME command ... During a RESUME operation, if a 'MySQL_Thread' is bootstrapping listeners (in `MySQL_Thread::run_BootstrapListener`) and detect that `MySQL_Threads_Handler::bootstrapping_listeners` is 'false', the thread prematurely shuts down its own bootstrapping flag from 'mypolls' (`ProxySQL_Poll::bootstrapping_listeners`). Since this thread wont ever bootstrap its corresponding listening sockets, the other working threads will be stalled waiting on it, eventually triggering the watchdog and crashing the instance. Since the bootstrapping operation is sequential, it's expected that all the threads but the one starting their listening sockets are in an active wait. A sensible delay has been introduced to reduce the overhead of such wait.	2 years ago
René Cannaò	d4bd93672e	Merge pull request #79 from sysown/v2.x_refactore_query_processor ... Refactored Query Processor [WIP]	2 years ago
Rahim Kanji	e723082a1b	Refactored Query Processor Architecture ... - Introduced separate query processors for MySQL and PostgreSQL. - Removed unnecessary GTID logic from `PgSQL_Session`. - Added a command counter for PostgreSQL queries. - Refactored `Query_Processor` to serve as a base class containing core functionalities applicable to both MySQL and PostgreSQL. Changes: - Removed GTID-related code from `PgSQL_Logger` and `PgSQL_Session`: - bool with_gtid; - char gtid_buf[128]; - int gtid_hid; - Added new PostgreSQL-specific tables: - `pgsql_query_rules`, `pgsql_firewall_whitelist_rules`, `pgsql_query_rules_fast_routing` - `runtime_pgsql_query_rules`, `runtime_pgsql_firewall_whitelist_rules`, `runtime_pgsql_query_rules_fast_routing` - Added PostgreSQL-related variables: pgsql_thread___commands_stats pgsql_thread___query_digests pgsql_thread___query_digests_lowercase pgsql_thread___query_digests_no_digits pgsql_thread___query_digests_replace_null pgsql_thread___query_digests_normalize_digest_text pgsql_thread___query_digests_track_hostname pgsql_thread___query_digests_keep_comment pgsql_thread___query_digests_max_digest_length pgsql_thread___query_digests_max_query_length pgsql_thread___query_digests_grouping_limit pgsql_thread___query_digests_groups_grouping_limit pgsql_thread___enable_load_data_local_infile pgsql_thread___auditlog_filename pgsql_thread___auditlog_filesize pgsql_thread___eventslog_filename pgsql_thread___eventslog_filesize pgsql_thread___eventslog_default_log pgsql_thread___eventslog_format pgsql_thread___firewall_whitelist_errormsg pgsql_thread___firewall_whitelist_enabled pgsql_thread___query_processor_iterations pgsql_thread___query_processor_regex	2 years ago
René Cannaò	cbf4628ea3	Merge remote-tracking branch 'proxysql27/v2.7' into v2.x_postgres_merge27_20240917	2 years ago
René Cannaò	38350292e2	Merge pull request #4600 from sysown/v2.x_proxy ... Implementation of PROXY protocol V1	2 years ago
René Cannaò	cf9d5fe21a	Merge pull request #4574 from sysown/set-thread-names ... Set thread names	2 years ago
Javier Jaramago Fernández	bbda0a86eb	Add initial impl for dual-password support	2 years ago
René Cannaò	94b0da1768	In SQL3_Processlist() use saved IP/port	2 years ago
Rene Cannao	7fe013fac2	Merge branch 'proxysql_v2.x_240813' into v2.x_postgres_merge_v2.x_240813 ... This merges ProxySQL v2.x up to 2024-08-13	2 years ago
Rene Cannao	d85430b709	Implementation of PROXY protocol V1 ... This commit introduces: - class ProxyProtocolInfo() , that: - performs parsing - validates subnet - run automated tests in DEBUG build - variable mysql-proxy_protocol_networks . Accepted values: - empty string: disables PROXY protocol - '*' : allows connections from any IP - comma separated list of subnets - automated testing in DEBUG build during start - export of PROXY protocol information in internal session, using PROXY_V1 - a TAP test to verify various connections	2 years ago
Niels Vogell	7290f0bfb2	Fix a mixup in the default value of monitoring_read_only_interval	2 years ago
Niels Vogell	8154f4b330	Disable AWS RDS topology discovery by default with 0 as special value for the discovery interval	2 years ago
Andriy Utkin	5e79afa8e0	Set thread names	2 years ago
Rahim Kanji	d3e9c9c85a	Merge remote-tracking branch 'remotes/Master/v2.x' into v2.x_proxysql_postgres_merge	2 years ago