240 Commits (7ddb3dc015d1440e8a0fb0bbafa2df9aaaa2669d)

Author	SHA1	Message	Date
Rene Cannao	2987242d4f	Fix cache_empty_result=0 not caching non-empty resultsets (issue #5248) ... The `cache_empty_result` field in query rules has three possible values: • -1: Use global setting (`query_cache_stores_empty_result`) • 0: Do NOT cache empty resultsets, but cache non-empty resultsets • 1: Always cache resultsets (both empty and non-empty) Previously, when `cache_empty_result` was set to 0, nothing was cached at all, even for non-empty resultsets. This prevented users from disabling caching for empty resultsets while still allowing caching of non-empty resultsets on a per-rule basis. Changes: 1. Modified caching logic in MySQL_Session.cpp and PgSQL_Session.cpp to add the condition `(qpo->cache_empty_result == 0 && MyRS->num_rows)` (MySQL) and `(qpo->cache_empty_result == 0 && num_rows)` (PgSQL) to allow caching when cache_empty_result=0 AND result has rows. 2. Added comprehensive Doxygen documentation in query_processor.h explaining the semantics of cache_empty_result values. 3. Updated Query_Processor.cpp with inline comments explaining the three possible values. Now when cache_empty_result is set to 0: - Empty resultsets (0 rows) are NOT cached - Non-empty resultsets (>0 rows) ARE cached - This matches the intended per-rule behavior described in issue #5248. Fixes: https://github.com/sysown/proxysql/issues/5248	7 months ago
Rahim Kanji	1a48aadf5e	Code cleanup	7 months ago
Rahim Kanji	c0f99c0e15	Refactor: Improved Prepared-Statement Cache Design (Lock-Free Hot Path) #5211 ... Concurrency and Memory Management * Lock-Free Ref Counting: Replaced global mutex-protected integer reference counts with `std::atomic<uint32_t>` within `PgSQL_STMT_Global_info`, eliminating lock contention during statement referencing. * Modern Ownership: Adopted std::shared_ptr<const PgSQL_STMT_Global_info> for global and local storage, providing automatic, thread-safe memory and lifecycle management. * Memory Optimization: Removed redundant auxiliary maps `global_id_to_stmt_names` and `map_stmt_id_to_info` from local and global statement managers respectively, reducing overall memory overhead. * Optimized Purging: Statement removal logic was simplified for efficiently identifying and cleaning up unused statements. Hot Path Performance (`BIND`, `DESCRIBE`, `EXECUTE`) * Bypassed Global Lookups: Local session maps now store the `shared_ptr` directly, removing the need to acquire the global lock and search the global map during hot path operations. * Direct Refcount Manipulation: Refcount modification functions now operate directly on the passed statement object, eliminating the overhead of searching the global map to find the object pointer based on statement id. Safety and Protocol Logic (`PARSE`) * Efficient Statement Reuse: Implemented a **local fast path** check for the unnamed statement (`""`), allowing immediate reuse of an identical query (same hash) upon re-parse, which bypasses global processing and locks. Cleanup * Cleaned up and class rename `PgSQL_STMT_Manager_v14` -> `PgSQL_STMT_Manager`.	7 months ago
Rahim Kanji	d84444724a	Replaced use of the generic write_generic() helper with direct packet construction for selected PostgreSQL protocol messages to reduce overhead and improve performance.	8 months ago
Rahim Kanji	e744c2bbb7	Optimize transaction command parsing to avoid unnecessary tokenization ... Previously, the parser always tokenized the full command, even when we only needed to check whether it was a transaction command. Now, it first extracts the first word to determine relevance and performs full tokenization only when necessary.	8 months ago
Rahim Kanji	7a3a5c71df	Optimize hot path: replace std::string with char[] to avoid heap	8 months ago
Rahim Kanji	9eb934e7f0	Buffer response until Extended Query frame completes; send early only if resultset threshold is reached.	8 months ago
René Cannaò	a44dee127d	Merge pull request #5174 from sysown/v3.0_optimise_extended_query_response ... Removed unnecessary writeout()	8 months ago
Javier Jaramago Fernández	2668de77c2	Fix compilation warning for 'strncpy' due string truncation ... As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	8 months ago
Javier Jaramago Fernández	c0978f9371	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' (PgSQL) ... Accesses by 'stats___pgsql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	8 months ago
Rahim Kanji	8291361bc1	Removed unnecessary writeout()	8 months ago
René Cannaò	360646b7d5	Merge pull request #5165 from sysown/crash-sqlite-max-len ... processlist: Prevent crash due to SQLITE_TOOBIG	8 months ago
Wazir Ahmed	5219d4be93	processlist: Prevent crash due to SQLITE_TOOBIG ... - Add new mysql/pgsql variable `processlist_max_query_length`. - Min: 1K - Max: 32M - Default: 2M - Truncate current query based on the configuration before inserting into `stats_*_processlist` tables. - Refactor/fix code related to other processlist configurations. 1. `session_idle_show_processlist` value was not updated in `ProxySQL_Admin.variables`. 2. Pass processlist config as an argument to `MySQL_Threads_Handler::SQL3_Processlist` instead of using thread-local variables. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	8 months ago
Rahim Kanji	ed20d09b8a	Replaced std::get_if with std::visit	9 months ago
René Cannaò	ecad6f9249	Merge pull request #5160 from sysown/v3.0_disable_pgsql_prometheus_5159 ... Separate Query Cache Metrics for MySQL and PostgreSQL & Disable Prometheus Metrics for PostgreSQL	9 months ago
René Cannaò	73c15ba3ef	Merge pull request #5153 from sysown/v3.0_transaction_alias_support_5152 ... Add support for PostgreSQL transaction command aliases and ROLLBACK AND CHAIN	9 months ago
René Cannaò	01862a247a	Merge pull request #5149 from sysown/v3.0_track_search_path_param_5148 ... Add search_path parameter to tracked ProxySQL variables list - PgSQL	9 months ago
René Cannaò	42f6d9d74f	Merge pull request #5144 from sysown/v3.0_datestyle-parser-tweak ... Align DateStyle parsing with PostgreSQL	9 months ago
Rahim Kanji	cb2062c1d1	Few fixes	9 months ago
Rahim Kanji	45271572ec	Add support for PostgreSQL transaction command aliases and ROLLBACK AND CHAIN	9 months ago
Rahim Kanji	83bec8d477	Refactored remove_quotes function	9 months ago
Rahim Kanji	8f8a8c29e3	Code cleanup: Removed is_select_NOT_for_update from PostgreSQL modules	9 months ago
Rahim Kanji	b005c2dd8c	Add tracking for PostgreSQL search_path parameter	9 months ago
Rahim Kanji	d4b2de9e26	Align DateStyle parsing with PostgreSQL ... Updated PgSQL_DateStyle_Util::parse_datestyle() to support prefix-based matching for known tokens (POSTGRES, EURO, NONEURO). This allows variants like "PostgreSQL", "European", to be recognized as valid inputs.	9 months ago
Rahim Kanji	4d91452fc5	Implement backend query cancellation for PostgreSQL #5136 ... Add support for PostgreSQL query cancellation and backend termination features to allow clients to cancel long-running queries and terminate connections through the standard PostgreSQL protocol. Features implemented: - Intercept pg_backend_pid() queries and return ProxySQL session thread ID - Intercept pg_terminate_backend() to terminate client connections asynchronously - Intercept pg_cancel_backend() to cancel queries on backend connections - Support Cancel Request protocol via separate connection with PID and secret key validation - Return BackendKeyData message on successful authentication with session thread ID and unique cancel secret key This enables clients to use standard PostgreSQL cancellation mechanisms (pg_cancel_backend, pg_terminate_backend, and Cancel Request protocol) while ProxySQL maintains proper session isolation and maps client requests to appropriate backend connections.	9 months ago
René Cannaò	e1b7afe282	Merge pull request #5099 from wazir-ahmed/clock-monotonic-raw ... Use `CLOCK_MONOTONIC_RAW` instead of `CLOCK_MONOTONIC`	9 months ago
René Cannaò	4639b9705a	Merge pull request #5133 from sysown/v3.0_extended_query_pgsql_query_rules_5132 ... Applying Query Rules in Extended Query Protocol	9 months ago
René Cannaò	9290a5ceec	Merge pull request #5124 from sysown/v3.0_postgres_query_logging_issue_5123 ... Added query logging support for PostgreSQL	9 months ago
Rahim Kanji	9e9fdc23c2	Modify extended query handling in ProxySQL so that query rules are applied at Parse, Describe, and Execute stages, but hostgroup selection is performed only on the first message in the message pipeline. Ensures that all subsequent messages in the same pipeline use the same backend connection, maintaining consistent routing while applying relevant query rules.	9 months ago
Rahim Kanji	9b0366a89a	Improved PostgreSQL Logger	9 months ago
Rahim Kanji	a89291c9a9	Added query logging support for PostgreSQL	9 months ago
Rahim Kanji	692109f965	Fixed typo	9 months ago
Rahim Kanji	23a764eaac	Preserve implicit transactions with pipeline + FLUSH #5118 ... Previously, each extended-query block was terminated with a SYNC, which caused implicit transactions to commit prematurely. As a result, earlier write operations (INSERT/UPDATE/DELETE) could not be rolled back if a later statement in the same sequence failed. This change switches to libpq pipeline mode and replaces intermediate SYNC messages with FLUSH, ensuring that all client query frames execute as part of the same implicit transaction. A final SYNC is still issued to resynchronize the connection and make it safe for reuse in the pool.	9 months ago
Rahim Kanji	205f970ffa	Append NoData for DESCRIBE(Portal) on SET/RESET/DISCARD/DEALLOCATE	10 months ago
Rahim Kanji	031d362aab	Add STMT prefix to ASYC DESCRIBE status	10 months ago
Rahim Kanji	7d5fe54230	Refactor: unify result handling for Parse and Describe ... Previously, Parse and Describe each had their own query result handling paths. This duplicated a lot of logic and also failed to handle some cases correctly—for example, Notice messages returned by the server during extended-protocol queries. Keeping these separate paths would be hard to maintain and prone to bugs. The simple-query result handling is already mature, optimized, and covers all the necessary cases. Reusing it for Parse and Describe makes behavior consistent across simple and extended query flows, while also reducing duplicate code.	10 months ago
Rahim Kanji	0391a8d4bb	Intercept LISTEN command and return "not supported" #5109 ... ProxySQL currently does not support PostgreSQL's LISTEN command. When clients attempt to use it, we now intercept the command and return an appropriate "not supported" response instead of passing it through. This behavior is implemented for both: - Simple query flow - Extended (prepared) query flow	10 months ago
Wazir Ahmed	8d29742e20	`QueryInfo::end_time` should always be greater than or equal to `start_time` ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	10 months ago
Wazir Ahmed	daf1570c5d	Replace `CLOCK_MONOTONIC` with `CLOCK_MONOTONIC_RAW` ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	10 months ago
Rahim Kanji	38841bf189	Remove DESCRIBE statement cache option ... Remove the `DESCRIBE` (statement) cache option and related cache code.	10 months ago
Rahim Kanji	9a5fa148c8	Inject implicit Sync if simple query arrives before extended query cycle is completed ... When a simple query arrives while extended query messages are pending, we now: - inject an implicit Sync, - process all extended query messages, - then execute the simple query, - and send ReadyForQuery only after the simple query completes.	10 months ago
Rahim Kanji	be2ae45950	Merge branch 'v3.0' into 'v3.0_extended_query_protocol_phase_2'	10 months ago
Rahim Kanji	abd19113c0	Fix RequestEnd: avoid updating internal state when query failed on backend ... RequestEnd was applying state changes (session variable restore, rollback-to-savepoint, multiplexing toggle for temp tables/sequences) even when the query failed to execute on the backend connection. This caused internal state to diverge from the actual backend state. Fix: - Add success/failure flag to RequestEnd calls. - Restrict state-changing logic to Simple Query and Prepared Execute. - Ensure logic only runs when the query executed successfully on backend. This keeps internal state aligned with the backend connection state.	10 months ago
Rahim Kanji	96c989a854	* Replaced virtual RequestEnd method with CRTP (static polymorphism) ... * Removed multi_pkt from PgSQL_session	10 months ago
Rahim Kanji	515cf12ded	Reject COPY FROM STDIN in extended query mode	10 months ago
Rahim Kanji	7a1852fb92	Skip Describe Portal results unless client explicitly requests it ... PQsendQueryPrepared always emits Bind -> Describe Portal -> Execute, which led to RowDescription being included in the result set even when the client never sent a Describe message. This caused clients to receive row descriptions they did not request. Changes: - Skip including RowDescription when the client did not send Describe. - If the client explicitly sent Describe followed by Execute, continue to skip redundant execution of Describe but include RowDescription once. This ensures RowDescription is only sent when requested, aligning behavior with protocol expectations.	10 months ago
Rahim Kanji	3dd401f81a	Queue client packets during active query execution ... Previously, any packet received while a query was still running was considered unexpected, and the session was terminated. This often occurred with pgJDBC, which pipelines commands (e.g., sending `BEGIN` immediately followed by another statement). Now, new packets are placed in a FIFO queue and processed only after the current query finishes and its response is sent. This preserves correct ordering, prevents unnecessary session termination, and improves compatibility with connectors like pgJDBC.	10 months ago
René Cannaò	b5fa8ca1ae	Merge pull request #5044 from sysown/v3.0_extended_query_protocol ... PostgreSQL's Extended Query Protocol Support in ProxySQL [WIP]	10 months ago
Rahim Kanji	9e4b76d6d1	* Refactored PgSQL_Session::handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___PGSQL_QUERY_qpo. ... * Fixed a crash occurring during session destruction. * Query rules will now apply only to the first message in an extended query frame. * OK message will apply to execute message. * Query rewrite, error messages, and large packet handling will apply to parse message. * Added query processing support for the Bind message.	10 months ago
Rahim Kanji	0bb5747291	Add Query Rewrite support for Extended Query Protocol	11 months ago
Rahim Kanji	2d569f3b95	Added support to terminate running queries on timeout	11 months ago
Rahim Kanji	58eac30ff3	Fixed SSL STATUS in PgSQL_Data_Stream	11 months ago
Rahim Kanji	f715c546fa	Added prepared statement map and connection status fields to PROXYSQL INTERNAL SESSION output	11 months ago
Rahim Kanji	27f1fed446	Handled DISCARD ALL, DISCARD PLANS, send rest of the varients to backend ... Fixed connection reset for client connection	11 months ago
Rahim Kanji	a29eaf1eb2	Moved warning_in_hg from Base_Session to MySQL_Session	11 months ago
Rahim Kanji	8021121cfa	Fixed PgSQL_Session::handler___status_NONE_or_default	11 months ago
Rahim Kanji	4d195adc89	Renamed Multiplex status from MYSQL to PGSQL ... Renamed status to ssl_status Removed STATE_SLEEP_MULTI_PACKET from PgSQL session handler	11 months ago
René Cannaò	471ddfc7aa	Merge pull request #5060 from sysown/v3.0_session_param_reset_connection ... Fix Backend Connection Reset and Parameter Handling for RESET/SET TO DEFAULT	11 months ago
Rahim Kanji	070d4ca18d	Added DEALLOCATE <stmt_name> and DEALLOCATE ALL support	11 months ago
Rahim Kanji	02eb58db79	Added SET statement tracking support	11 months ago
Rahim Kanji	ce94a7080a	Merge branch v3.0_session_param_reset_connection into v3.0_extended_query_protocol	11 months ago
Rahim Kanji	50243ef283	Corrected RESET/DEFAULT logic ... * Now will actually reset value to server default (represented by nullptr value), if that parameter is not set in startup parameter. * Default parameter values (pgsql_default_*) will now be set only for critical parameters.	11 months ago
Rahim Kanji	1bcd09044b	Refactor Connection Reset Handling ... * Introduced startup parameters in PgSQL_Connection (removed default session parameters from PgSQL_Session) * Startup parameters are populated during both frontend and backend connection creation * Parameters provided via connection options are set as startup parameters * Backend connection parameter handling updated: only critical variables are now set via connection options to prevent interference with DISCARD ALL during connection reset; remaining parameters will be applied using individual SET commands	11 months ago
Rahim Kanji	7c71fe1a05	Prevent overwrite of named statements ... Previously, issuing a PARSE with an existing statement name would silently overwrite the prepared statement. This fix ensures that named prepared statements cannot be overwritten and will raise an error if redefined. Only unnamed statements (empty name) are allowed to be replaced on reissue.	11 months ago
Rahim Kanji	0de642559d	Avoid crash when mirroring is set for PostgreSQL: show warning instead	11 months ago
Rahim Kanji	4ebff4c0cc	Added support for protocol-supplied (out-of-band) parameter typing (argument-based) ... * This parameter types will be part of hash calculation * Few refactoring and optimizations	11 months ago
Rahim Kanji	a8a2799187	Improved locks	12 months ago
Rahim Kanji	703a5f35f5	Added stats_pgsql_prepared_statements_info table	12 months ago
Rahim Kanji	06383750b3	Fixed SonarQube warnings where applicable	12 months ago
Rahim Kanji	bc87d0d901	* For a Describe Portal message, peek at the next message in the extended query frame. If it is an Execute message, indicating that client is sending a Bind/Describe/Execute sequence ... skip processing the Describe Portal. This is because libpq automatically includes a Describe Portal during execution, and sending it again would be redundant. * Removed server_capabilities from PgSQL modules	12 months ago
Rahim Kanji	87ad15b01c	* Removed autocommit_on_hostgroup from PostgreSQL modules ... * Introduced an error generator method to reduce code duplication * Added several comments for clarity * Addressed edge cases related to libpq limitations	12 months ago
Rahim Kanji	48ba491cb7	Add support for unnamed Describe Portal and improve extended query handling ... - Always send Describe Portal to the backend - Enforce check for unnamed portals in Bind, Describe, Close, and Execute; raise errors for named portals - Improve error handling for extended query flow - Introduce Extended_Query_Info struct to unify extended query-related members and reduce redundancy	12 months ago
Rahim Kanji	7cde1dcad6	Added comments	12 months ago
Rahim Kanji	d3592020ac	* Created a separate file for Extended Query messages to reduce clutter in PgSQL_Protocol. ... * Moved get_uint32be() and get_uint16be() to gen_utils.h * Split PgSQL_*_Message into distinct Message and Data components.	12 months ago
Rahim Kanji	3cff4f9dca	* Added sticky backend support for extended query frames: all messages in a single frame will now use the same backend connection. ... * Fixed few compilation warnings. * Removed AutoCommit relate code from PostgreSQL session.	12 months ago
Rahim Kanji	d5fc1fefff	Renamed pending_query to extended_query_frame ... Improved extended query frame handling	12 months ago
Rahim Kanji	f350102f72	Code cleanup	1 year ago
Rahim Kanji	8bb248cef5	Added Bind and Execute support	1 year ago
Rahim Kanji	4d0618c296	Added Close statement handling	1 year ago
Rahim Kanji	a741598a8d	Added Describe message handling	1 year ago
Rahim Kanji	97b3bb16e3	Fixed RequestEnd	1 year ago
Rahim Kanji	24fecc1f6e	Add PostgreSQL extended query (prepared statement) support in ProxySQL ... This commit lays the groundwork for handling PostgreSQL’s extended query protocol (prepared statements) by introducing parsing, it's caching and execution framework stubs. - Implement Parse handling - Implement caching of parse (reuse) - Introduce Execute framework stub for future binding and execution logic.	1 year ago
Rahim Kanji	026f458f7c	Removed last_insert_id from PostgreSQL modules	1 year ago
Rahim Kanji	c71aa550df	Added names (alias of client_encoding)	1 year ago
Rahim Kanji	979b3a81f4	Added PgSQL_ExplicitTxnStateMgr in session ... Dump transaction state in proxysql internal session output	1 year ago
Rahim Kanji	4969bd8301	PQconnectPoll can file descriptor (FD) during the connection process. We need to check whether FD has changed and, if so, update it in the thread's poll array.	1 year ago
René Cannaò	6df3d6b84b	Merge pull request #4899 from sysown/v3.0_refactor_connection_info_param ... Refactor PostgreSQL Connection-Level Parameters Handling	1 year ago
Rahim Kanji	c2f2ae5aa4	* Updated code to use pgsql_tracked_variables[idx] consistently, removing ... direct usage of pgsql_tracked_variables[idx].idx. This change improves consistency and reduces potential human error. * Fixed some warning	1 year ago
Rahim Kanji	db442ba8cf	Treat client_encoding as normal server parameter/variable. ... Optimized RESET ALL command handling. Few optimizations. Code cleanup	1 year ago
Rahim Kanji	fbb9500cb9	Refactored connection parameters ... * Accept all parameters sent by the client, mirroring PostgreSQL's permissive handling. * Validate and apply parameters only after successful authentication. This avoids wasting resources on invalid connections.	1 year ago
René Cannaò	e17477e297	Merge pull request #4871 from sysown/v3.0-4803_20250313 ... Port to 3.0 of in-memory query logging	1 year ago
Rahim Kanji	fa220398f6	Moved dynamic fast-forward logic (used for COPY ... FROM STDIN) to execute after session variables are set on the backend connection	1 year ago
René Cannaò	2551d350e9	Port to 3.0 of in-memory query logging ... See #4713 for further details	1 year ago
Rahim Kanji	055e748673	Fixed DateStyle Validator ... If the provided datestyle includes both style and order, ensure both values are valid.	1 year ago
Rahim Kanji	6603d48bb0	Optimized and simplified PostgreSQL variable Validator	1 year ago
Rahim Kanji	a5b7063cf3	Add validation for PostgreSQL patameters/variables and default PostgreSQL variables ... * Added validation checks when setting PostgreSQL variables to prevent invalid configurations. * Applied the same validation to default PostgreSQL variables to maintain consistency.	1 year ago
Rahim Kanji	41206d2ee7	Added enable_nestloop parameter	1 year ago
Rahim Kanji	e0ced2e14c	Fixed extra_float_digits variable position	1 year ago
Rahim Kanji	427f20072b	Tracking new variables ... allow_in_place_tablespaces enable_sort extra_float_digits synchronous_commit	1 year ago
Rahim Kanji	40be1158c2	Finally removed PgSQL_Connection_Placeholder class	1 year ago