2137 Commits (724ddc14eba0df30caa03d07fc66df60927002ca)

Author	SHA1	Message	Date
Valentin Rakush	5acd1a3cf6	Monitor test automation	6 years ago
René Cannaò	3d2fd599db	Merge pull request #2469 from kirs/min-gtid ... Support min_gtid annotation	6 years ago
Kir Shatrov	3b031f3518	Prevent crash on index() returning NULL ... in handler___client_DSS_QUERY_SENT___server_DSS_NOT_INITIALIZED__get_connection	6 years ago
René Cannaò	9d618714a7	Merge pull request #2457 from val214/v2.0.9-clean-proxysql-admin ... Cleanup of the proxysql_admin.cpp	6 years ago
René Cannaò	c1e8cc4861	Merge pull request #2468 from val214/v2.0.9-sqlite ... V2.0.9 sqlite	6 years ago
René Cannaò	1d2e059d9b	Add support in Admin for SHOW TABLES IN #2478	6 years ago
Kir Shatrov	2f7bb1a1cf	Validate gtid input	6 years ago
Kir Shatrov	0922949b8c	Support min_gtid comment	6 years ago
Valentin Rakush	d5a7836011	Overload execute_statement method in sqlite3db	6 years ago
Valentin Rakush	7bf773a677	Cleanup of the proxysql_admin.cpp	6 years ago
René Cannaò	5a346864de	Merge pull request #2449 from val214/v2.0.9-set-option ... MYSQL_SET_OPTION multiplexing [FR]	6 years ago
Valentin Rakush	a9b0e6648e	Return error 1290	6 years ago
Valentin Rakush	b93b5f50bf	MYSQL_SET_OPTION multiplexing	6 years ago
Valentin Rakush	c33a311412	Fix digest replace null issue	6 years ago
Valentin Rakush	f1eb04ce51	Fix flag Active for grop replication hostgroups	6 years ago
Valentin Rakush	539abc680e	Fix flag Active is not correctly working	6 years ago
René Cannaò	b59fad2d42	Merge pull request #2413 from val214/v2.0.9-select-config-file ... V2.0.9 select config file [FR]	6 years ago
René Cannaò	3070e03620	Merge pull request #2438 from bskllzh/v2.0.9 ... Fix add a mutex lock twice in the process of function call(log_audit_…	6 years ago
René Cannaò	b8ecdaa708	Removing some comments	6 years ago
René Cannaò	e9dc7a9b60	Implementation of SQLI fingerprints whitelist ... libsqlinjection generates a lot of false positives. This commit introduces a new table: mysql_firewall_whitelist_sqli_fingerprints This table can list fingerprints generated by libsqlinjection: if the fingerprint is listed in this table, proxysql will consider it as a false positive. This commit also enables SQLi algorithm only if the query is not already explicitly whitelisted.	6 years ago
peter	6bb057fbda	Fix add a mutex lock twice in the process of function call(log_audit_entry() -> write() -> write_auth()) ... Bug description: Since fix write event log and audit log coredump(#2427)， i think i left out a code that was not processed, resulting in coredump again in the program of proxysql , when i confige these parameters of auditlog_filename and auditlog_filesize in proxysql.cnf file or i set these parameters in proxysql-admin command line. the coredump contest: (gdb) bt #0 0x00002b224e9981f7 in raise () from /lib64/libc.so.6 #1 0x00002b224e9998e8 in abort () from /lib64/libc.so.6 #2 0x00002b224e991266 in __assert_fail_base () from /lib64/libc.so.6 #3 0x00002b224e991312 in __assert_fail () from /lib64/libc.so.6 #4 0x00000000005b2dc3 in main (argc=5, argv=0x7ffea714fd48) at main.cpp:1664 the proxysql.log contest: 2019-12-06 11:03:07 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:10 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:13 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:16 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:19 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:22 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:25 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:28 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:31 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:34 main.cpp:1659:main(): [ERROR] Watchdog: 8 threads missed a heartbeat 2019-12-06 11:03:34 main.cpp:1663:main(): [ERROR] Watchdog: reached 10 missed heartbeats. Aborting! proxysql: main.cpp:1664: int main(int, const char**): Assertion `0' failed. Error: signal 6: proxysql(_Z13crash_handleri+0x25)[0x5b607c] /lib64/libc.so.6(+0x35270)[0x2b224e998270] /lib64/libc.so.6(gsignal+0x37)[0x2b224e9981f7] /lib64/libc.so.6(abort+0x148)[0x2b224e9998e8] /lib64/libc.so.6(+0x2e266)[0x2b224e991266] /lib64/libc.so.6(+0x2e312)[0x2b224e991312] proxysql(main+0xe3a)[0x5b2dc3] /lib64/libc.so.6(__libc_start_main+0xf5)[0x2b224e984c05] proxysql[0x5adaa5] 2019-12-06 11:03:34 main.cpp:1396:ProxySQL_daemonize_phase3(): [ERROR] ProxySQL crashed. Restarting! 2019-12-06 11:03:34 main.cpp:1397:ProxySQL_daemonize_phase3(): [INFO] ProxySQL version _DEBUG Impact of this fix： I analyzed the call relationship of write_auth function of MySQL_Logger.cpp file in the whole project of proxysql with the source insight ide. I found write_auth function that was only called by the write function of MySQL_Logger.cpp file in the whole project of proxysql, and this write function was only called by log_audit_entry function or log_request function of MySQL_Logger.cpp file in the whole project of proxysql. However, i've added a mutex lock separately in log_audit_entry function and log_request function. And so i think it should delete the code for the wrlock function call in write_auth function, and it doesn't have impact for this time fix. Bux fix: Fix add a mutex lock twice in the process of function call(log_audit_entry() -> write() -> write_auth())	6 years ago
Valentin Rakush	6bd6c0a34b	Move config file read/write functions to separate file.	6 years ago
Valentin Rakush	9954e6b4cb	SELECT CONFIG TO: adding new columns to export (add_lag_ms, min_lag_ms, lag_num_checks)	6 years ago
Valentin Rakush	60b7fd5e9e	SELECT CONFIG TO implementation	6 years ago
Valentin Rakush	4e45f7f1d4	Fix few problems and cleanup. ... - remove unnecessary variables - change snprintf to std::stringstream - extend autotests configuration - fixing several bugs	6 years ago
Valentin Rakush	f8ea3d8c75	error logging in config file readers	6 years ago
Valentin Rakush	342f8e8782	select config file auto tests ... remove TRACE	6 years ago
Valentin Rakush	52b5ee9486	export proxysql configuration to resultset	6 years ago
Valentin Rakush	9430cabee3	SELECT CONFIG FILE implementation	6 years ago
René Cannaò	384b411732	Merge pull request #2437 from sysown/v2.0.9-aurora_offline ... Fix issue with LOAD MYSQL SERVERS TO RUNTIME and Aurora	6 years ago
René Cannaò	f87adbbe87	Merge pull request #2431 from val214/v2.0.9-tests ... V2.0.9 unsigned charset	6 years ago
René Cannaò	0d1d16cb88	Merge pull request #2422 from val214/v2.0.9-gr-fix ... Fix generation of the group replication hostgroups table	6 years ago
René Cannaò	67ec4107b7	Fix issue with LOAD MYSQL TO RUNTIME and Aurora	6 years ago
René Cannaò	e3bebae9fb	Upgrade clickhouse-cpp and support for Enums	6 years ago
René Cannaò	951483a419	Change API port from 6090 to 6070	6 years ago
Valentin Rakush	49181ac1bb	Add host:port to unknown charset log messages	6 years ago
Valentin Rakush	cfdbedeb54	unsigned int charset: add collation name in a log message	6 years ago
René Cannaò	c36a6fb491	Merge pull request #2427 from bskllzh/v2.0.9 ... Fix write event log and audit log coredump(the events.logfile&audit.…	6 years ago
bskllzh	d71d01cb63	Fix write event log and audit log coredump(the events.logfile&audit.logfile null pointer) ... Bug description: When i make a benchmark test with a sysbench(version: 1.0.17) in proxysql 2.0.8 + mysql 5.7.26, i get the follow error info: Error: signal 11: proxysql(_Z13crash_handleri+0x25)[0x5b607c] /lib64/libc.so.6(+0x35270)[0x2b673de34270] /lib64/libstdc++.so.6(_ZNSo6sentryC2ERSo+0xf)[0x2b673d67521f] /lib64/libstdc++.so.6(_ZNSo5writeEPKcl+0x31)[0x2b673d675621] proxysql(_ZN11MySQL_Event20write_query_format_1EPSt13basic_fstreamIcSt11char_traitsIcEE+0x27d)[0x6e2d81] proxysql(_ZN11MySQL_Event5writeEPSt13basic_fstreamIcSt11char_traitsIcEEP13MySQL_Session+0x79)[0x6e19e9] proxysql(_ZN12MySQL_Logger11log_requestEP13MySQL_SessionP17MySQL_Data_Stream+0x710)[0x6e5416] proxysql(_ZN13MySQL_Session8LogQueryEP17MySQL_Data_Stream+0x6d)[0x654055] proxysql(_ZN13MySQL_Session10RequestEndEP17MySQL_Data_Stream+0x35)[0x6540d7] proxysql(_ZN13MySQL_Session7handlerEv+0x4397)[0x6459ed] proxysql(_ZN12MySQL_Thread20process_all_sessionsEv+0x830)[0x623180] proxysql(_ZN12MySQL_Thread3runEv+0x2cbe)[0x62208a] proxysql(_Z24mysql_worker_thread_funcPv+0xbb)[0x5afb05] /lib64/libpthread.so.0(+0x7e25)[0x2b673cda8e25] /lib64/libc.so.6(clone+0x6d)[0x2b673def734d] 2019-12-02 09:52:26 main.cpp:1396:ProxySQL_daemonize_phase3(): [ERROR] ProxySQL crashed. Restarting! I analyze the coredump with proxysql 2.0.8 debug version very carefully, and i found the variable of events.logfile is null pointer in log_request function when it call write function(me.write(events.logfile, sess)). The following is the coredump（write (this=0x2b67402fd1f0, f=0x0, sess=0x2b67414a8c00)）: (gdb) bt #0 0x00002b673d67521f in std::ostream::sentry::sentry(std::ostream&) () from /lib64/libstdc++.so.6 #1 0x00002b673d675621 in std::ostream::write(char const*, long) () from /lib64/libstdc++.so.6 #2 0x00000000006e2d81 in MySQL_Event::write_query_format_1 (this=0x2b67402fd1f0, f=0x0) at MySQL_Logger.cpp:265 #3 0x00000000006e19e9 in MySQL_Event::write (this=0x2b67402fd1f0, f=0x0, sess=0x2b67414a8c00) at MySQL_Logger.cpp:89 #4 0x00000000006e5416 in MySQL_Logger::log_request (this=0x2b673e419680, sess=0x2b67414a8c00, myds=0x2b6741346480) at MySQL_Logger.cpp:717 #5 0x0000000000654055 in MySQL_Session::LogQuery (this=0x2b67414a8c00, myds=0x2b6741346480) at MySQL_Session.cpp:6691 #6 0x00000000006540d7 in MySQL_Session::RequestEnd (this=0x2b67414a8c00, myds=0x2b6741346480) at MySQL_Session.cpp:6711 #7 0x00000000006459ed in MySQL_Session::handler (this=0x2b67414a8c00) at MySQL_Session.cpp:4086 #8 0x0000000000623180 in MySQL_Thread::process_all_sessions (this=0x2b6741301000) at MySQL_Thread.cpp:4392 #9 0x000000000062208a in MySQL_Thread::run (this=0x2b6741301000) at MySQL_Thread.cpp:4125 #10 0x00000000005afb05 in mysql_worker_thread_func (arg=0x2b673e461f30) at main.cpp:648 #11 0x00002b673cda8e25 in start_thread () from /lib64/libpthread.so.0 #12 0x00002b673def734d in clone () from /lib64/libc.so.6 And then i add a line of code in log_request function of MySQL_Logger.cpp file to check up whether events.logfile is null pointer ，as follow: void MySQL_Logger::log_request(MySQL_Session *sess, MySQL_Data_Stream *myds) { if (events.enabled==false) return; if (events.logfile==NULL) return; proxy_info("log_request: First: events.logfile is null %d\n", (events.logfile == NULL) ? 1 : 0); MySQL_Connection_userinfo *ui=sess->client_myds->myconn->userinfo; And i make a benchmark test again with proxysql 2.0.8 debug version, the coredump of proxysql happen again, then i get the follow print info from proxysql.log [root@XXXXX proxysql]# grep -n -w 'log_request: First: events.logfile is null 1' proxysql.log 7358447:2019-12-02 09:52:26 MySQL_Logger.cpp:617:log_request(): [INFO] log_request: First: events.logfile is null 1 7358448:2019-12-02 09:52:26 MySQL_Logger.cpp:617:log_request(): [INFO] log_request: First: events.logfile is null 1 Bux fix: Fix write event log and audit log coredump, because the proxysql get the null pointer variable of events.logfile（audit.logfile）in a multithreaded environment.	6 years ago
René Cannaò	b9d155b4a5	Set variables before setting lock_hostgroup ... This commit fix the following bug: If some session variables were set by the client before proxysql turned on lock_hostgroup, these variables were not set. This commit also makes proxysql aware that this query causes lock_hostgroup: `SET SESSION information_schema_stats_expiry=0`	6 years ago
Valentin Rakush	6a2bb97964	Fix generation of the group replication hostgroups table	6 years ago
René Cannaò	a6fc967f25	Merge pull request #2419 from sysown/v2.0.9-2394 ... Fixed issues generating some queries for galera support	6 years ago
Adrián del Campo	18b20bf8fd	Fixed issues generating some queries for galera support	6 years ago
René Cannaò	8954b46a02	Error log now lists the SQL injection query ... Also added status variable automatic_detected_sql_injection to count detected SQL injection	6 years ago
René Cannaò	e12a3b2792	Support for automatic SQL injection detection ... Library libjection is being used. New variable mysql-automatic_detect_sqli defines if the feature is enabled or not. If an SQL injection is detected: - the client connection is immediately terminated - an entry in the error log is reported	6 years ago
René Cannaò	9afe6824ff	Merge pull request #2407 from sysown/v2.0.9-libmicrohttpd-0.9.68 ... V2.0.9 libmicrohttpd 0.9.68	6 years ago
René Cannaò	57e0b2eb2f	Merge pull request #2403 from sysown/v2.0.9-whitelist ... V2.0.9 whitelist	6 years ago
René Cannaò	485d313514	Further development of firewall whitelist. ... * introduced 2 new variables: - mysql-firewall_whitelist_enabled : defines if the firewall with whitelist algorithm is enabled or not - firewall_whitelist_errormsg : error message returned to the client if an error message is not already set * Query_Processor returns firewall_whitelist_mode to the calling MySQL_Session, but the logging on error log currently happens within the Query_Processor itself * if mysql-firewall_whitelist_enabled is turned on and a user it is not found in mysql_firewall_whitelist_users , the default behavior is that query is rejected * lookup on mysql_firewall_whitelist_users happens for username@ip (specific IP) and username@'' (all IPs) . Match on network subnet is currently not implemented * implemented SAVE MYSQL FIREWALL FROM RUNTIME * fixed implementation of SAVE MYSQL FIREWALL TO DISK * runtime configuration can be viewed in runtime_mysql_firewall_whitelist_rules and runtime_mysql_firewall_whitelist_users	6 years ago
René Cannaò	c967bc179b	Several improvements to SQLite3 Server module: ... - ability to handle transactions - in OK packets and resultsets, SERVER_STATUS_IN_TRANS flag is set if a transaction is running - a persistent database file in datadir is used instead of in-memory database - database file uses WAL (Write-Ahead Logging) - WAL journal size is set to 64MB - monitor user can always login to SQLite3 Server - in case of database lock within a transaction, an error is immediately returned to client	6 years ago
René Cannaò	1673249da4	Adding libhttpserver , and a simple "Hello World" ... libhttpserver will take care of REST API. The feature is currently disabled.	6 years ago