133 Commits (6d8dff293973edd1be9cc67be03aac400e85cb4c)

Author	SHA1	Message	Date
Rene Cannao	68c76eb425	fix(pgsql): mark transaction state unknown when backend connection is broken ... When a backend connection breaks with an error (e.g. postmaster SIGKILL mid-query), libpq's PQtransactionStatus() returns PQTRANS_UNKNOWN rather than PQTRANS_INTRANS, so IsActiveTransaction() reports false for a connection that was in a transaction moments earlier. The retry path in PgSQL_Session::handler_minus1_ClientLibraryError() then replays the failed statement on a fresh backend connection as autocommit, breaking transactional semantics: the client's next COMMIT lands on a connection with no open transaction and PostgreSQL emits "WARNING: there is no transaction in progress". MySQL does not have this issue because mysql->server_status caches SERVER_STATUS_IN_TRANS from the last OK packet and survives the connection breaking. Fix compute_unknown_transaction_status() to force unknown_transaction_status=true when the backend is disconnected, so the retry guard in handler_minus1_ClientLibraryError() refuses to replay statements that were running inside an explicit transaction.	1 month ago
Rahim Kanji	e68f8bb74a	refactor: simplify pgsql_servers_ssl_params schema and pre-parse TLS range ... - Drop ssl_capath and ssl_cipher columns (no libpq equivalents) - Pre-parse ssl_protocol_version_range into ssl_min/max_protocol_version at construction time instead of on every backend connection - Fix Servers_SslParams 3-arg delegating constructor - Update tests, docs, and all consumers (Connection, Monitor, Kill, Admin)	2 months ago
Rahim Kanji	6d3ce36de4	feat: apply per-server SSL params in PgSQL backend kill connections	2 months ago
Rahim Kanji	1b2df514fd	feat: apply per-server SSL params in PgSQL backend connections	2 months ago
Rahim Kanji	96bc668735	Fix pipeline mode transaction state handling and SET/RESET/DISCARD support ... Addresses issues with PostgreSQL Extended Query Protocol (Pipeline mode) in ProxySQL: Transaction State Handler Migration: - Moved handle_transaction_state() from PgSQL_Session::RequestEnd() to PgSQL_Session::handler() - Now called only for client queries (PROCESSING_QUERY/PROCESSING_STMT_EXECUTE) - Prevents internal SET commands from triggering transaction logic incorrectly - Added transaction state reset at 7 locations for clean connection pool return SET/RESET/DISCARD Pipeline Mode Support (lib/PgSQL_Session.cpp): - SET statements now execute properly in pipeline mode via RunQuery() - RESET ALL and DISCARD ALL blocked with proper error messages in pipeline mode - Added startup parameter mismatch detection for RESET with locked hostgroup	3 months ago
Rahim Kanji	742ff05ecc	Fix PostgreSQL transaction state management for pipeline mode ... Move transaction state tracking from RequestEnd to connection handler to enable proper binary pipeline mode support: - Call handle_transaction_state() at ASYNC_QUERY_END/ASYNC_STMT_EXECUTE_END in PgSQL_Connection instead of RequestEnd - Add reset_state() calls in 7 locations to prevent stale state: * Session reset * Connection detach (finishQuery) * Error handlers (4 paths) * Base session housekeeping - Refactor destructor to use reset_state() Fixes transaction state tracking in pipeline mode where connections can be returned to pool mid-transaction.	3 months ago
Rahim Kanji	8c9af56f38	Address AI review feedback	3 months ago
Rahim Kanji	7a062a3444	Add PgSQL notice handling in reset session paths ... Register the PostgreSQL notice handler during reset session operations. Previously, the handler was not set in this path, which could result in unhandled backend notices.	3 months ago
Rahim Kanji	1ffb4f13ac	Fix PostgreSQL resync error detection ... Add flush() call in resync_start() for immediate socket error detection instead of deferring to event loop	3 months ago
Rahim Kanji	1f0756b59f	Correct bytes_sent tracking for extended query protocol ... Fix missing and incorrect update_bytes_sent() calls in PgSQL_Connection async state machine.	3 months ago
Rahim Kanji	db5f1ea498	Track query count for extended query protocol executions ... The queries_sent counter in stats.stats_pgsql_connection_pool was not being incremented for prepared statement executions (ASYNC_STMT_EXECUTE_START), only for regular queries (ASYNC_QUERY_START) and statement preparation (ASYNC_STMT_PREPARE_START).	3 months ago
Rahim Kanji	5a7e7b30e7	Fix extended query Bind handling when a single parameter format is provided ... PostgreSQL allows a Bind message to specify a single parameter format (num_param_formats = 1), which applies to all parameters. libpq, however, always expects a format entry per parameter and previously sent uninitialized values for the remaining parameters when only one format was specified. This caused ProxySQL to forward malformed Bind packets to backend. ProxySQL now detects this case and propagates the single provided parameter format to all parameters, matching PostgreSQL semantics.	5 months ago
Rahim Kanji	c0f99c0e15	Refactor: Improved Prepared-Statement Cache Design (Lock-Free Hot Path) #5211 ... Concurrency and Memory Management * Lock-Free Ref Counting: Replaced global mutex-protected integer reference counts with `std::atomic<uint32_t>` within `PgSQL_STMT_Global_info`, eliminating lock contention during statement referencing. * Modern Ownership: Adopted std::shared_ptr<const PgSQL_STMT_Global_info> for global and local storage, providing automatic, thread-safe memory and lifecycle management. * Memory Optimization: Removed redundant auxiliary maps `global_id_to_stmt_names` and `map_stmt_id_to_info` from local and global statement managers respectively, reducing overall memory overhead. * Optimized Purging: Statement removal logic was simplified for efficiently identifying and cleaning up unused statements. Hot Path Performance (`BIND`, `DESCRIBE`, `EXECUTE`) * Bypassed Global Lookups: Local session maps now store the `shared_ptr` directly, removing the need to acquire the global lock and search the global map during hot path operations. * Direct Refcount Manipulation: Refcount modification functions now operate directly on the passed statement object, eliminating the overhead of searching the global map to find the object pointer based on statement id. Safety and Protocol Logic (`PARSE`) * Efficient Statement Reuse: Implemented a **local fast path** check for the unnamed statement (`""`), allowing immediate reuse of an identical query (same hash) upon re-parse, which bypasses global processing and locks. Cleanup * Cleaned up and class rename `PgSQL_STMT_Manager_v14` -> `PgSQL_STMT_Manager`.	6 months ago
Rahim Kanji	9fa3d75fb3	Backport PQsendPipelineSync from PostgreSQL 17 and update code to use it ... - Backport PQsendPipelineSync to PostgreSQL 16.3, enabling pipeline synchronization without flushing the send buffer. - Replace calls to PQPipelineSync in code with PQsendPipelineSync to use the new functionality.	7 months ago
René Cannaò	abafaccbc0	Merge pull request #5156 from sysown/v3.0_pgsql_stat_activity_issue_4682 ... Add backend_pid and backend_state to stats_pgsql_processlist and create stats_pgsql_stat_activity view	7 months ago
René Cannaò	413b0121a1	Merge pull request #5146 from sysown/v3.0_parameter_status_case_sensitive_issue_5145 ... Fix incorrect ParameterStatus key casing for DateStyle, TimeZone, and IntervalStyle	7 months ago
René Cannaò	2c9cea0014	Merge pull request #5143 from sysown/v3.0_fix-describe-portal-nodata-empty-query ... Fix: return NoData for Describe (Portal) before Execute on empty statement	7 months ago
René Cannaò	c5a0a0011f	Merge pull request #5137 from sysown/v3.0_pgsql_query_cancel_terminate_issue_5136 ... Implement Backend Query Cancellation and Backend Termination for PostgreSQL	7 months ago
Rahim Kanji	81d4c3ad74	Added get_pg_backend_state	8 months ago
Rahim Kanji	dc6db358f4	Few fixes	8 months ago
Rahim Kanji	03b63f6857	Fix ParameterStatus capitalization for DateStyle, TimeZone, and IntervalStyle ... These parameters use capitalized names in PostgreSQL for historical reasons. ProxySQL now sends them using canonical capitalization to ensure client compatibility.	8 months ago
Rahim Kanji	67842ff03c	Send NoData in response to Describe (Portal) before Execute (empty ... query) Now the server returns the expected NoData response in this case, consistent with protocol behavior.	8 months ago
Rahim Kanji	8060f98c28	Improve Parser	8 months ago
Rahim Kanji	84389b71b9	refactor(conninfo): add append_conninfo_param helper ... Centralize escaping/formatting of connection parameters (key='value'). Replace duplicate escape/append/free sequences in connect_start and PgSQL_backend_kill_thread.	8 months ago
Rahim Kanji	4d91452fc5	Implement backend query cancellation for PostgreSQL #5136 ... Add support for PostgreSQL query cancellation and backend termination features to allow clients to cancel long-running queries and terminate connections through the standard PostgreSQL protocol. Features implemented: - Intercept pg_backend_pid() queries and return ProxySQL session thread ID - Intercept pg_terminate_backend() to terminate client connections asynchronously - Intercept pg_cancel_backend() to cancel queries on backend connections - Support Cancel Request protocol via separate connection with PID and secret key validation - Return BackendKeyData message on successful authentication with session thread ID and unique cancel secret key This enables clients to use standard PostgreSQL cancellation mechanisms (pg_cancel_backend, pg_terminate_backend, and Cancel Request protocol) while ProxySQL maintains proper session isolation and maps client requests to appropriate backend connections.	8 months ago
Rahim Kanji	692109f965	Fixed typo	8 months ago
Rahim Kanji	23a764eaac	Preserve implicit transactions with pipeline + FLUSH #5118 ... Previously, each extended-query block was terminated with a SYNC, which caused implicit transactions to commit prematurely. As a result, earlier write operations (INSERT/UPDATE/DELETE) could not be rolled back if a later statement in the same sequence failed. This change switches to libpq pipeline mode and replaces intermediate SYNC messages with FLUSH, ensuring that all client query frames execute as part of the same implicit transaction. A final SYNC is still issued to resynchronize the connection and make it safe for reuse in the pool.	8 months ago
Rahim Kanji	205f970ffa	Append NoData for DESCRIBE(Portal) on SET/RESET/DISCARD/DEALLOCATE	9 months ago
Rahim Kanji	031d362aab	Add STMT prefix to ASYC DESCRIBE status	9 months ago
Rahim Kanji	7d5fe54230	Refactor: unify result handling for Parse and Describe ... Previously, Parse and Describe each had their own query result handling paths. This duplicated a lot of logic and also failed to handle some cases correctly—for example, Notice messages returned by the server during extended-protocol queries. Keeping these separate paths would be hard to maintain and prone to bugs. The simple-query result handling is already mature, optimized, and covers all the necessary cases. Reusing it for Parse and Describe makes behavior consistent across simple and extended query flows, while also reducing duplicate code.	9 months ago
Rahim Kanji	c6138656b6	Fixed multiplex disabled due to CREATE SEQUENCE	9 months ago
Rahim Kanji	1b47a1d9ea	Fixed Describe Portal returning NoData	9 months ago
Rahim Kanji	9a5fa148c8	Inject implicit Sync if simple query arrives before extended query cycle is completed ... When a simple query arrives while extended query messages are pending, we now: - inject an implicit Sync, - process all extended query messages, - then execute the simple query, - and send ReadyForQuery only after the simple query completes.	9 months ago
Rahim Kanji	abd19113c0	Fix RequestEnd: avoid updating internal state when query failed on backend ... RequestEnd was applying state changes (session variable restore, rollback-to-savepoint, multiplexing toggle for temp tables/sequences) even when the query failed to execute on the backend connection. This caused internal state to diverge from the actual backend state. Fix: - Add success/failure flag to RequestEnd calls. - Restrict state-changing logic to Simple Query and Prepared Execute. - Ensure logic only runs when the query executed successfully on backend. This keeps internal state aligned with the backend connection state.	9 months ago
Rahim Kanji	7a1852fb92	Skip Describe Portal results unless client explicitly requests it ... PQsendQueryPrepared always emits Bind -> Describe Portal -> Execute, which led to RowDescription being included in the result set even when the client never sent a Describe message. This caused clients to receive row descriptions they did not request. Changes: - Skip including RowDescription when the client did not send Describe. - If the client explicitly sent Describe followed by Execute, continue to skip redundant execution of Describe but include RowDescription once. This ensures RowDescription is only sent when requested, aligning behavior with protocol expectations.	9 months ago
Rahim Kanji	fff2a91381	Fix omission of ReadyForQuery after error with pending extended-query messages ... In extended query mode, ReadyForQuery is normally deferred when there are pending messages in the queue; it is sent only after the entire extended query frame has been processed. Edge case: if a message fails with an error while the queue still contains pending messages, the queue is cleared later in the session and those pending messages are discarded. In that case, ReadyForQuery would never be sent. Change: when a result indicates an error, send ReadyForQuery immediately. The extended-query flag will still be reset later in the session. This ensures ReadyForQuery is always emitted and prevents clients from waiting indefinitely.	9 months ago
Rahim Kanji	8a3bab5002	Ensure consistent handling of NoData packets in PQsendQueryPrepared ... The PQsendQueryPrepared function transmits the sequence BIND -> DESCRIBE(PORTAL) -> EXECUTE -> SYNC. However, libpq does not indicate whether the DESCRIBE PORTAL step produces a NoData packet for commands such as INSERT, DELETE, or UPDATE. In these cases, libpq returns PGRES_COMMAND_OK, whereas SELECT statements yield PGRES_SINGLE_TUPLE or PGRES_TUPLES_OK. This update explicitly appends a NoData packet to the result in order to provide consistent behavior across query types.	9 months ago
Rahim Kanji	9e4b76d6d1	* Refactored PgSQL_Session::handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___PGSQL_QUERY_qpo. ... * Fixed a crash occurring during session destruction. * Query rules will now apply only to the first message in an extended query frame. * OK message will apply to execute message. * Query rewrite, error messages, and large packet handling will apply to parse message. * Added query processing support for the Bind message.	9 months ago
Rahim Kanji	2d569f3b95	Added support to terminate running queries on timeout	9 months ago
Rahim Kanji	0ddc6e9b93	* Implemented status tracking for LOCK TABLE and pg_advisory_xact_lock, with automatic reset on transaction end ... * Added tracking for pg_advisory_lock, with status reset only on pg_advisory_unlock_all * Implemented support for CREATE SEQUENCE and CREATE TEMP SEQUENCE, with reset on DISCARD SEQUENCES * Added handling for CREATE TEMP TABLE, with reset triggered by DISCARD TEMP	10 months ago
Rahim Kanji	27f1fed446	Handled DISCARD ALL, DISCARD PLANS, send rest of the varients to backend ... Fixed connection reset for client connection	10 months ago
Rahim Kanji	4d195adc89	Renamed Multiplex status from MYSQL to PGSQL ... Renamed status to ssl_status Removed STATE_SLEEP_MULTI_PACKET from PgSQL session handler	10 months ago
Rahim Kanji	ce94a7080a	Merge branch v3.0_session_param_reset_connection into v3.0_extended_query_protocol	10 months ago
Rahim Kanji	249b3d8725	* Replace C-style array with std::array in PgSQL_Connection ... * Nulling startup_parameters[i] in ~PgSQL_Connection after freeing	10 months ago
Rahim Kanji	50243ef283	Corrected RESET/DEFAULT logic ... * Now will actually reset value to server default (represented by nullptr value), if that parameter is not set in startup parameter. * Default parameter values (pgsql_default_*) will now be set only for critical parameters.	10 months ago
Rahim Kanji	1bcd09044b	Refactor Connection Reset Handling ... * Introduced startup parameters in PgSQL_Connection (removed default session parameters from PgSQL_Session) * Startup parameters are populated during both frontend and backend connection creation * Parameters provided via connection options are set as startup parameters * Backend connection parameter handling updated: only critical variables are now set via connection options to prevent interference with DISCARD ALL during connection reset; remaining parameters will be applied using individual SET commands	10 months ago
Rahim Kanji	4ebff4c0cc	Added support for protocol-supplied (out-of-band) parameter typing (argument-based) ... * This parameter types will be part of hash calculation * Few refactoring and optimizations	10 months ago
Rahim Kanji	06383750b3	Fixed SonarQube warnings where applicable	10 months ago
Rahim Kanji	8655ff8e0d	Cleanup	10 months ago
Rahim Kanji	87ad15b01c	* Removed autocommit_on_hostgroup from PostgreSQL modules ... * Introduced an error generator method to reduce code duplication * Added several comments for clarity * Addressed edge cases related to libpq limitations	10 months ago