430 Commits (6d6015a2034dbee2ea4eb50d2e84381df008fa46)

Author	SHA1	Message	Date
Rahim Kanji	3865c81873	DNS Cache module has been updated so that it no longer regards the UNIX socket path as a hostname.	3 years ago
René Cannaò	069140f79e	Automatically start a transaction when running a query ... This commit also introduces 2 output for PROXYSQL INTERNAL SESSION: - active_transactions - transaction_started_at Enhanced the TAP tests to also verify the above metrics	3 years ago
René Cannaò	e487ddf8ec	Set correct backend encryption when switching to fast_forward ... When receiving MYSQL_COM_BINLOG_DUMP , MYSQL_COM_BINLOG_DUMP_GTID or MYSQL_COM_REGISTER_SLAVE , proxysql automatically switches to fast_forward . Although it is important to correctly configure "encrypted" in the backend data stream if needed. Used PMC-10005 for reference , as this is implemented similarly in many parts of the code. During the switch proxy_info() now also reports the client and the command received.	3 years ago
René Cannaò	f3c604eb84	Implemented mysql_hostgroup_attributes.multiplex ... If mysql_hostgroup_attributes.multiplex: - 0 : multiplexing is always disabled - 1 : multiplexing is enabled for the hostgroup, but other criteria can disable multiplexing (transaction, temp tables, query rules, etc)	3 years ago
René Cannaò	71e2510ef6	Code cleanup on MySQL_HostGroups_Manager ... Some rework to try to reduce duplicated code	3 years ago
René Cannaò	a2be18881a	Merge pull request #4062 from sysown/v2.x-fast_forward_ssl2 ... Support for fast_forward and SSL #1459	3 years ago
Rahim Kanji	4e44551dd2	ProxySQL crashes if client is not able to keep up with records returned and query has a warning condition ... Show Warning check is added to avoid infinite loop	3 years ago
René Cannaò	85941b4707	SSL and fast_forward ... Fixed crash when backend doesn't support SSL Added initial TAP test. Initial TAP test cause valgrind to report errors, thus the feature it is not completed yet.	3 years ago
René Cannaò	cdc8423569	Adding some details on SSL and fast_forward implementation	3 years ago
René Cannaò	9dde792c46	Merge branch 'v2.x-fast_forward_ssl' into v2.x-fast_forward_ssl2	3 years ago
Javier Jaramago Fernández	cdaa8b1764	Honor 'mysql-verbose_query_error' format for warnings #3935	3 years ago
Javier Sánchez Parra	9e01d4509b	Honor mysql-verbose_query_error for MySQL query warnings ... Also, refactor default warnings to include more information.	3 years ago
René Cannaò	ec93211d02	Merge pull request #4024 from sysown/v2.x_LocalDNSCache ... Feature: ProxySQL local DNS Cache	3 years ago
Rahim Kanji	c552fdb111	* Added DNS cache monitoring for ProxySQL servers. ... * Added forced triggering of DNS Cache Update on MySQL Servers and ProxySQL Servers table update. * Direct DNS cache update via socket (connected peer ip) if record is not available in cache. * Used strdup instead of realloc. * DNS lookup only once for ProxySQL Cluster Nodes.	3 years ago
René Cannaò	a5dfb66936	Merge pull request #4008 from rahim-kanji/v2.x-3991 ... Added @@local and optimizer_use_condition_selectivity support	3 years ago
Rahim Kanji	4885e1680d	Merge remote-tracking branch 'Master/v2.x' into v2.x_LocalDNSCache	3 years ago
Rahim Kanji	dbfb99ce71	* Added hostname and ip information in mysql_connection ... * Added multiple IP support with load balancing (Round Robin Scheduling) * Added DNS resolver request max queue size * Added AI_ADDRCONFIG flag * Exception handling	3 years ago
Rahim Kanji	eef3ddfcd6	Heap allocated host pointer for async mysql_real_connect_start function ... Few fixes	3 years ago
Rahim Kanji	7805924779	Feature: ProxySQL local DNS Cache	3 years ago
Javier Jaramago Fernández	67fac0b761	Fix 'compression' integration with 'fast_forward' sessions ... - Compression flag is now propagated from client to backend connection when the backend connection is being created for a 'fast_forward' session. In case of client trying to connect without compression, to a server configured with compression, we fallback to an uncompressed connection. - After a 'MySQL_Session' has obtained a connection for a 'fast_forward' session, i.e, the one-to-one relationship between the client and backend connection has been stablished, we completely disable the compression 'STATUS_MYSQL_CONNECTION_COMPRESSION' flag from the client 'MySQL_Connection'.	4 years ago
Rahim Kanji	8ebb990002	Resolves Issue 3991 ... * Added support for @@local * Added support for optimizer_use_condition_selectivity * Updated test cases	4 years ago
Javier Jaramago Fernández	bcc6532d66	Modify previous impl for 'auto_increment_delay_multiplex_timeout_ms' and fix 'connection_delay_multiplex_ms' ... This commit contains an implementation rework and a fix: - Impl for 'auto_increment_delay_multiplex_timeout_ms' has been reworked in favor of reusing 'wait_until' to share logic with previous 'connection_delay_multiplex_ms' variable. - Fix previous 'connection_delay_multiplex_ms' behavior preventing connection retaining when traffic unrelated to target hostgroup is being received by the session.	4 years ago
Javier Jaramago Fernández	a67db17709	Fix current 'auto_increment_delay_multiplex_timeout_ms' behavior #3923	4 years ago
René Cannaò	f960a4d9b7	Merge pull request #3903 from sysown/v2.x-tests_220619 ... V2.x tests 220619	4 years ago
René Cannaò	f7d8824379	Trying to work around MySQL bug 107875 ... Because of MySQL bug https://bugs.mysql.com/bug.php?id=107875 , autocommit=0 can "create a transaction" even if SERVER_STATUS_IN_TRANS is not set. This means that a SAVEPOINT can be created in a "transaction" created with autocommit=0 but without SERVER_STATUS_IN_TRANS . This commit takes also care of scenarios when autocommit=0 was switched back to autocommit=1 when a SELECT was executed while variable mysql-enforce_autocommit_on_reads was false. MySQL_Session::NumActiveTransactions() now accepts a flag to check for savepoints.	4 years ago
René Cannaò	61b32de42f	Solve bug #3749 and improve testing ... In MySQL_Connection::IsActiveTransaction: in the past we were incorrectly checking STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT and returning true in case there were any savepoint. Although flag STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT was not reset in case of no transaction, thus the check was incorrect. We can ignore STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT for multiplexing purpose in IsActiveTransaction() because it is also checked in MultiplexDisabled()	4 years ago
René Cannaò	227e045aa4	Improved mysql-init_connect-t.cpp for PMC-10003 ... PMC-10003: Retrieved a resultset while running a simple command using async_send_simple_command() . async_send_simple_command() is used by ProxySQL to configure the connection, thus it shouldn't retrieve any resultset. A common issue for triggering this error is to have configure mysql-init_connect to run a statement that returns a resultset.	4 years ago
René Cannaò	8d2a88a746	Merge pull request #3856 from sysown/v2.x-rm_duplicate_mysql_err_counts ... Fix duplicate counting of MySQL errors for client conns	4 years ago
René Cannaò	9275e2858d	Track NO_BACKSLASH_ESCAPES ... Track NO_BACKSLASH_ESCAPES in case it is changed: - using SET sql_mode by the client - directly on the backend (for example default sql_mode, or an sql_mode set from another variable)	4 years ago
René Cannaò	50f1c9f61a	Removed reference to STATUS_MYSQL_CONNECTION_NO_BACKSLASH_ESCAPES ... STATUS_MYSQL_CONNECTION_NO_BACKSLASH_ESCAPES was an internal status in ProxySQL , now deprecated	4 years ago
René Cannaò	99408f9ad8	Initial POC for fast_forward and SSL #1459	4 years ago
Javier Jaramago Fernández	68baa871be	Fix duplicate counting of MySQL errors for client conns	4 years ago
Javier Jaramago Fernández	a10cb49cca	Remove deprecated variable 'mysql-client_multi_statements'	4 years ago
Javier Jaramago Fernández	02915a9eae	Remove deprecated variable 'mysql-client_found_rows'	4 years ago
René Cannaò	d20683c589	Merge pull request #3702 from sysown/v2.x-variables ... Improvements on how MySQL variables are processed	4 years ago
René Cannaò	2ba9c401f1	Bug fixes in the new implementation of tracking mysql variables ... Better parsing of SET SQL_LOG_BIN . SQL_LOG_BIN is now managed by the same functions that handle boolean variables instead of the now deprecated MySQL_Session::handler_WCD_SS_MCQ_qpo_Parse_SQL_LOG_BIN() For naming convention, enum value SQL_LOG_BIN was renamed to SQL_SQL_LOG_BIN In MySQL_Thread we also deprecated match_regexes[0] , previously used to parse `set sql_log_bin`. Functions Variable::fill_server_internal_session() and Variable::fill_client_internal_session() seems to handle sql_log_bin as a special value. This exception was removed. Fixed a bug in MySQL_Session::generate_proxysql_internal_session_json() where when backend variables needed to be generated, fill_client_internal_session() was incorrectly called instead of fill_server_internal_session() , leading to incorrect values reported by `PROXYSQL INTERNAL SESSION`	4 years ago
Javier Jaramago Fernández	bcb009fc24	Revert "Merge pull request #3645 from sysown/v2.x-2021" ... This reverts commit 9561cb3ef2, reversing changes made to 7edfec6f3f.	4 years ago
René Cannaò	497ef76478	Merge branch 'v2.x' into v2.x-variables	4 years ago
René Cannaò	a6edd02a9b	Revert "Merge branch 'v2.x' into v2.x-2021" ... This reverts commit 3a3931f2d4, reversing changes made to 4694ab775e.	4 years ago
Javier Jaramago Fernández	3fd1cd3f13	Replaced non-thread safe 'strtok' function in favor of 'strtok_r' for 'IsKeepMultiplexEnabledVariables'	5 years ago
Javier Jaramago Fernández	cbe926b4f7	Fix regression introduced for 'at signs' parsing for multiplexing disabling (#3647) ... * Fixed regression introduced for 'at-signs' parsing and improved implementation * Added minimal test for checking multiplexing disabling via 'mysql-keep_multiplexing_variables' * Added missing 'plan()' to test specifying the number of test cases	5 years ago
René Cannaò	0937133b15	Merge pull request #3577 from hkdsun/capath-crls-v2.x ... SSL: Add support for certificate revocation list (CRL) and multiple certificate authorities (CA)	5 years ago
Hormoz K	7762dea993	add crl, crlpath, and capath options	5 years ago
René Cannaò	c78539c936	Merge pull request #3576 from sysown/v2.x-connect_verbo ... Add more verbosity when mysql_real_connect() fails	5 years ago
René Cannaò	05fa6c23cf	Merge pull request #3569 from sysown/v2.x-3554 ... Closes 3554: Add support for building ProxySQL with ASAN	5 years ago
René Cannaò	57f6af7132	Add more verbosity when mysql_real_connect() fails ... Error log will now shows also the hostgroup id of the server the connection failed to	5 years ago
Javier Jaramago Fernández	fd9f3f13a3	Fixed 'strcat-param-overlap' found by ASAN in 'IsKeepMultiplexEnabledVariables' #3554	5 years ago
René Cannaò	3de13665e8	Merge pull request #3557 from sysown/v2.x-ccov2 ... More code coverage	5 years ago
René Cannaò	1d5ac70e7b	Adding test to test mysql user fast_forward ... This commit also fix a bug: When the session uses fast_forward, frontend and backend connections must have the same bit for CLIENT_DEPRECATE_EOF	5 years ago
René Cannaò	194243503a	Adding LCOV_EXCL_START around assert(0) ... LCOV_EXCL_START and LCOV_EXCL_STOP around assert(0) will improve code coverage	5 years ago
René Cannaò	7f0b358ed8	Merge pull request #3544 from sysown/v2.x-3525 ... Closes #3525: Memory leak induced by 'stmts' not being closed when failed to prepare	5 years ago
René Cannaò	8ea1f16cb7	deprecating session_vars[]	5 years ago
René Cannaò	da2bf094ee	Fixed some minor but important bugs on the new implementation on how session variables are handled	5 years ago
René Cannaò	241a5e54d7	Draft to reimplement how session variables are handled	5 years ago
René Cannaò	fce7a0204c	Handle binary protocol resultset with ERR #3547 ... This commit add the support of ERR packet in binary protocol resultset, for example due to MAX_EXECUTION_TIME while running a prepared statement. It also changes how EOF packets are added: instead of writing the EOF in the resultset buffer, the EOF packet is written in its own packet. This allows to easily remove it if needed. It also fix what seems (not sure) a bug in MariaDB client library, where if a prepared statement is interrupted it cannot be executed again	5 years ago
Javier Jaramago Fernández	297bc8bae6	Refactored calls to 'mysql_stmt_close' into function holding preparation of 'MYSQL_STMT*' parameter #3525	5 years ago
Javier Jaramago Fernández	de2fd24e77	Fix leak closing 'query.stmt' in case of 'async_free_result' called for 'ASYNC_STMT_PREPARE_FAILED' state #3525	5 years ago
René Cannaò	5ede60ec9f	Merge pull request #3499 from sysown/v2.x-codecov1 ... [WIP] code cleanup and improved code coverage	5 years ago
René Cannaò	a1c232039f	Reduce length of mysql_bug_102266 #3501 ... In #3285 we increased the amount of data sent to the backend during connection time using MYSQL_OPT_CONNECT_ATTR_ADD , in order to avoid MySQL bug 102266 . See #3276 . Although this create a lot of noise in ProxySQL error log and MySQL error log, because the connection attributes are too long and they get truncated. This PR reduces the length of connection attributes	5 years ago
René Cannaò	2ce9ed9686	Disabled in MySQL_Connection code related to store results	5 years ago
René Cannaò	d53578f269	Merge pull request #3353 from sysown/v2.1.1-deprecate_forward_autocommit ... Deprecate mysql-forward_autocommit #3253	5 years ago
Javier Jaramago Fernández	228fe0640f	Closes #3357: Ported 'v1.4.14-show-warnings' and added new mysql-variable to control it	5 years ago
René Cannaò	a0fb4821cc	Deprecate mysql-forward_autocommit #3253	5 years ago
René Cannaò	d258361258	Merge pull request #3348 from sysown/v2.1.1-3339 ... Fixing an inifinite loop in case of multi-statements and closed backend connection	5 years ago
René Cannaò	bd5d882770	Fixing an inifinite loop in case of multi-statements and closed backend connection ... If a backend connection was terminated in the middle of the execution of multiple statements in a multi-statements command, the worker thread was entering an infinite loop. Furthermore, this commit disables query retry in case of multi-statements if the first one completed successfully This fixes #3339 This commit is the port to 2.1 of 90a4922ed8	5 years ago
Javier Jaramago Fernández	d0a1866cf9	Fixed 'process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT' not properly updating 'length' from copied last row after data copy	5 years ago
Javier Jaramago Fernández	abca810fbe	Fixed 'process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT' missing last row from MySQL_STMT::result	5 years ago
Javier Jaramago Fernández	4b81e21d57	Added comments, simplified 'stmt->result.data' assignment and minor cleanup for 'process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT'	5 years ago
Javier Jaramago Fernández	7718cc9395	Fixed iteration boundaries for 'stmt->result' rows reading in 'ASYNC_STMT_EXECUTE_STORE_RESULT_CONT'	5 years ago
René Cannaò	259d07c9ab	Merge pull request #3295 from sysown/v2.1.0-ps_buffer ... V2.1.0 ps buffer	5 years ago
Javier Jaramago Fernández	8141642bfc	Merge branch 'v2.1.1' into v2.1.1-3280	5 years ago
René Cannaò	fca4055b50	Merge branch 'v2.1.1' into v2.1.0-ps_buffer	5 years ago
René Cannaò	2b23bd3102	Avoid MySQL bug 102266 #3276 ... ProxySQL is sending a lot of data to MySQL server using CLIENT_CONNECT_ATTRS in order to not hit MySQL bug https://bugs.mysql.com/bug.php?id=102266 . See also https://github.com/sysown/proxysql/issues/3276	5 years ago
René Cannaò	598331cff9	When calling mysql_change_user set collation to default for the given charset if collation ID is greater or equal than 255 (utf8mb4_0900_ai_ci) ... We call mysql_options with MYSQL_SET_CHARSET_NAME if collation ID >= 255 . This to solve the problem of MySQL server returning an Access denied if the backend doesn't support a collation during mysql_change_user	5 years ago
René Cannaò	2519551cb4	Do not search charset in mysql_real_connect if already set ... In mysql_init() charset is set to NULL . In mysql_read_connect() charset is not changed if already set This allows proxysql to change it outside the library	5 years ago
Javier Jaramago Fernández	1ee832affd	Closes #3280: Add support to control 'CLIENT_DEPRECATE_EOF' in client and backend connections through global variables	5 years ago
René Cannaò	064cb1c3d2	Code cleanup	5 years ago
René Cannaò	f210af0aaf	Disabled code that change recv buffer size	5 years ago
René Cannaò	961588a29f	Removed the heartbeat from previous commit	5 years ago
René Cannaò	7921e130d2	Third commit to buffer resultsets in Prepared Statements ... * MySQL_ResultSet() stores a pointer to the PS * MySQL_ResultSet::init_with_stmt() doesn't need anymore the pointer to the PS Furthermore, it isn't anymore an "init" but an end (we will rename it) * Added MySQL_ResultSet::add_row(MYSQL_ROWS *rows) for PS only * MySQL_Protocol::generate_pkt_row3() accepts an optional row length. If passed, it will know the length of the row without computing it * MyRS initialized during ASYNC_STMT_EXECUTE_STORE_RESULT_START * Implemented throttling during ASYNC_STMT_EXECUTE_STORE_RESULT_START * MySQL_Connection::process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT() always generates a heartbeat. For now unnecessary, and we will better tune it later * test_ps_async-t.cpp tunes mysql-threshold_resultset_size to trigger buffering More testing is required	5 years ago
René Cannaò	5c0a732d8a	Second commit to buffer resultsets in Prepared Statements ... So far this seems to work, although it is dropping most of the rows. The rows are lost intentionally up to this commit.	5 years ago
René Cannaò	cfb11144d6	Partial commit to buffer resultsets in Prepared Statements	5 years ago
Javier Jaramago Fernández	632e4577f0	Fixed 'async_send_simple_command' not reporting server_status	5 years ago
Javier Jaramago Fernández	e40d57d75c	Added checks to verify that backend connection is present in several 'MySQL_Connection::async_' functions	5 years ago
René Cannaò	aaddb4e568	Port of #3001 to 2.1.0 , related to #3000 ... A client connection can use a backend connection with a session variable set by a different client	6 years ago
Javier Jaramago Fernández	5a5750de92	Fixed 'SQL_CHARACTER_SET_RESULTS' handling in 'fill_server_internal_session' and 'fill_client_internal_session'	6 years ago
René Cannaò	5ce13abc36	Merge pull request #2881 from sysown/v2.1.0-2717 ... Refactored MySQL_Connection setter/getter functions functions for 'status_flags' #2717	6 years ago
René Cannaò	d79ddad00b	Merge pull request #2844 from sysown/v2.1.0-cherrypicks_2.0.13 ... V2.1.0 cherrypicks 2.0.13	6 years ago
René Cannaò	3d74ef4828	Merge pull request #2882 from sysown/v2.1.0-2862 ... Port PR 2829 to 2.1.0 #2862	6 years ago
Javier Jaramago Fernández	d10f519e4a	Refactored 'MySQL_Session' set/get status functions ... - Added extra doc about the 'status_flags' and 'server_status'. - Added 'sql_log_bin0' and 'prepared_statement' to the 'conn.status' from PROXYSQL SESSION INFO.	6 years ago
René Cannaò	5e2f499581	Remove extra debugging	6 years ago
René Cannaò	00ce76e57e	Add support for SAVEPOINT #948	6 years ago
Javier Jaramago Fernández	8fafa66336	Removed unused variables from 'MySQL_Connection()'	6 years ago
René Cannaò	f384a9225e	Prevent crash if CHARACTER_SET_CONNECTION is not initialized yet #2863	6 years ago
René Cannaò	0a78949d98	Merge branch 'v2.1.0' into v2.0.11-prometheus	6 years ago
val	5ae3c38a14	reset hash value	6 years ago
Javier Jaramago Fernández	7f8b07a0db	Created new metric counters for registering 'mysql_errors'	6 years ago
Javier Jaramago Fernández	a53988cc90	Removed deprecated double counters metric updates in favor of callback approach	6 years ago
René Cannaò	8cc88ce58e	Migration of threads status variables as array	6 years ago
Javier Jaramago Fernández	c48b109019	Replaced 'hostgroups_manager' prometheus metrics with new array based impl	6 years ago