proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	99980ca196	Address review feedback on monitor health (PR #5507 ) - Fix integer overflow: cast shun_recovery_time_sec to int64_t before multiplying by 1000 to prevent overflow for large values (>24 days) - Add docstring note about production lag==-2 override path (issue #959) not covered by this simplified extraction - Remove trailing "fix plan" comment from test	2 weeks ago
René Cannaò	59654e48a3	Extract monitor health decision logic into pure functions (Phase 3.3, #5491 ) New files: - include/MonitorHealthDecision.h: declarations for 4 pure functions - lib/MonitorHealthDecision.cpp: implementations Extracted functions: - should_shun_on_connect_errors(): mirrors MySrvC::connect_error() threshold logic (min(shun_on_failures, connect_retries+1)) - can_unshun_server(): mirrors MyHGC recovery loop with time check, connect_timeout_max cap, min 1s floor, and kill_all drain check - should_shun_on_replication_lag(): mirrors MySQL_HostGroups_Manager lag check with consecutive count threshold - can_recover_from_replication_lag(): mirrors lag recovery check All functions are pure (no global state, no I/O) and added to libproxysql.a via lib/Makefile.	2 weeks ago

Author

SHA1

Message

Date

René Cannaò

99980ca196

Address review feedback on monitor health (PR #5507 )

- Fix integer overflow: cast shun_recovery_time_sec to int64_t before
  multiplying by 1000 to prevent overflow for large values (>24 days)
- Add docstring note about production lag==-2 override path (issue #959)
  not covered by this simplified extraction
- Remove trailing "fix plan" comment from test

René Cannaò

59654e48a3

Extract monitor health decision logic into pure functions (Phase 3.3, #5491 )

New files:
- include/MonitorHealthDecision.h: declarations for 4 pure functions
- lib/MonitorHealthDecision.cpp: implementations

Extracted functions:
- should_shun_on_connect_errors(): mirrors MySrvC::connect_error()
  threshold logic (min(shun_on_failures, connect_retries+1))
- can_unshun_server(): mirrors MyHGC recovery loop with time check,
  connect_timeout_max cap, min 1s floor, and kill_all drain check
- should_shun_on_replication_lag(): mirrors MySQL_HostGroups_Manager
  lag check with consecutive count threshold
- can_recover_from_replication_lag(): mirrors lag recovery check

All functions are pure (no global state, no I/O) and added to
libproxysql.a via lib/Makefile.

2 Commits (6d6015a2034dbee2ea4eb50d2e84381df008fa46)