proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	eba795d729	fix(pgsql-eventslog): make dump-to-memory sizing protocol-agnostic across admin ports Context: - Admin commands are exposed by one shared Admin module over two protocols: - MySQL admin endpoint (`6032`) - PostgreSQL admin endpoint (`6132`) - `DUMP PGSQL EVENTSLOG ...` must behave identically regardless of which admin protocol executes the command. Issue fixed: - PGSQL events dump path used thread-local PGSQL sizing variables when draining to memory (`stats_pgsql_query_events`). - When command execution happened from a non-PGSQL protocol admin worker, TLS values could be out of sync for PGSQL sizing decisions. Changes: - In `lib/PgSQL_Logger.cpp`, add runtime-size helper functions that read canonical values from `GloPTH->variables` with TLS fallback: - `eventslog_buffer_max_query_length` - `eventslog_table_memory_size` - Use these helpers in: - `PgSQL_Event` copy constructor (buffered query truncation) - `PgSQL_Logger::processEvents()` (in-memory retention for `stats_pgsql_query_events`) - Update internal architecture doc to explicitly state command availability from both admin protocol endpoints. Why: - Ensure `DUMP PGSQL EVENTSLOG ...` semantics remain consistent across `6032` and `6132`, matching the shared-admin-module design.	2 months ago
Rene Cannao	6f5a22f669	docs(internal): update PGSQL advanced logging architecture validation section with auto-dump E2E coverage Context: - The architecture document was rewritten as an as-built reference, but latest test coverage additions were not fully reflected. Changes: - Update validation mapping in `doc/internal/pgsql_advanced_query_logging_architecture.md` to include: - `pgsql_query_logging_autodump-t` TAP test - scheduler-driven auto-dump acceptance coverage - both relevant TAP group registrations Why: - Keep internal architecture/validation documentation aligned with implemented and wired test coverage. - Avoid stale validation references when reviewing branch readiness.	2 months ago
Rene Cannao	1edf1f8e86	Add PostgreSQL advanced logging TAP coverage and rewrite architecture doc	2 months ago

Author

SHA1

Message

Date

Rene Cannao

eba795d729

fix(pgsql-eventslog): make dump-to-memory sizing protocol-agnostic across admin ports

Context:
- Admin commands are exposed by one shared Admin module over two protocols:
  - MySQL admin endpoint (`6032`)
  - PostgreSQL admin endpoint (`6132`)
- `DUMP PGSQL EVENTSLOG ...` must behave identically regardless of which admin protocol executes the command.

Issue fixed:
- PGSQL events dump path used thread-local PGSQL sizing variables when draining to memory (`stats_pgsql_query_events`).
- When command execution happened from a non-PGSQL protocol admin worker, TLS values could be out of sync for PGSQL sizing decisions.

Changes:
- In `lib/PgSQL_Logger.cpp`, add runtime-size helper functions that read canonical values from `GloPTH->variables` with TLS fallback:
  - `eventslog_buffer_max_query_length`
  - `eventslog_table_memory_size`
- Use these helpers in:
  - `PgSQL_Event` copy constructor (buffered query truncation)
  - `PgSQL_Logger::processEvents()` (in-memory retention for `stats_pgsql_query_events`)
- Update internal architecture doc to explicitly state command availability from both admin protocol endpoints.

Why:
- Ensure `DUMP PGSQL EVENTSLOG ...` semantics remain consistent across `6032` and `6132`, matching the shared-admin-module design.

Rene Cannao

6f5a22f669

docs(internal): update PGSQL advanced logging architecture validation section with auto-dump E2E coverage

Context:
- The architecture document was rewritten as an as-built reference, but latest test coverage additions were not fully reflected.

Changes:
- Update validation mapping in `doc/internal/pgsql_advanced_query_logging_architecture.md` to include:
  - `pgsql_query_logging_autodump-t` TAP test
  - scheduler-driven auto-dump acceptance coverage
  - both relevant TAP group registrations

Why:
- Keep internal architecture/validation documentation aligned with implemented and wired test coverage.
- Avoid stale validation references when reviewing branch readiness.

Rene Cannao

1edf1f8e86

Add PostgreSQL advanced logging TAP coverage and rewrite architecture doc

3 Commits (6d6015a2034dbee2ea4eb50d2e84381df008fa46)