proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	4552236700	feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin Final file-move step in the carve-out: relocates the leaf modules that didn't depend on (and weren't depended on by) anything still in core. After this commit, the only PROXYSQLGENAI-guarded code remaining in libproxysql.a is `MCP_Tool_Handler` — the base class the plugin's AI_Tool_Handler / RAG_Tool_Handler inherit from — and that lives in core only because removing it would force pulling those derived plugin classes into core just for the inheritance edge. Step 7 deletes the PROXYSQLGENAI macro entirely. Files moved (git mv preserves history) Headers (include/ -> plugins/genai/include/) AI_Vector_Storage.h MySQL_Catalog.h Discovery_Schema.h Static_Harvester.h PgSQL_Static_Harvester.h Sources (lib/ -> plugins/genai/src/) AI_Vector_Storage.cpp MySQL_Catalog.cpp Discovery_Schema.cpp Static_Harvester.cpp PgSQL_Static_Harvester.cpp Core changes were minimal because these are leaf modules: include/proxysql.h: drop the AI_Vector_Storage.h include. include/cpp.h: drop AI_Vector_Storage / Discovery_Schema / MySQL_Catalog / Static_Harvester / PgSQL_Static_Harvester includes (replaced with a single carve-out history comment that Step 7 will delete entirely). lib/ProxySQL_Admin.cpp: drop the Discovery_Schema.h include — its only live use was via the now-#if-0'd save/load_mcp_query_rules blocks 4.C left behind for follow-up reference. lib/Makefile: drop AI_Vector_Storage.oo, MySQL_Catalog.oo, Discovery_Schema.oo, Static_Harvester.oo, PgSQL_Static_Harvester.oo from the GenAI _OBJ_CXX list. Test fixture probe update test/tap/tests/unit/Makefile: PROXYSQLGENAI auto-detect probe switched from `AI_Vector_Storage` (now plugin-only) to `MCP_Tool_Handler` (the last GenAI-tier symbol still in core). Step 7 deletes the auto-detect entirely. All three plugin unit tests pass: genai_plugin_load_unit-t : 25/25 genai_plugin_anomaly_unit-t : 6/6 genai_plugin_backend_client : 27/27 Binary size deltas: src/proxysql 159 MB -> 152 MB (-7 MB) plugins/genai/...Plugin.so 47 MB -> 55 MB (+8 MB) Net process RSS roughly neutral, as the design predicted. Carve-out scoreboard: Step 0-2 : infrastructure Step 3 : ~1.1 K LOC (Anomaly_Detector) Step 4.B : ~0.5 K LOC (backend_client) Step 4.C : ~13 K LOC (MCP subsystem + tool handlers + MySQL_FTS) Step 4.F : runtime-reconfig admin SQL routed through plugin commands Step 4.G : MCP admin / config / stats tables registered via plugin ABI Step 5 : ~7 K LOC (GenAI/LLM/AI/RAG) Step 6 : ~5 K LOC (AI_Vector_Storage + Discovery_Schema + MySQL_Catalog + Static_Harvester pair) Pending: Step 7 — delete the PROXYSQLGENAI macro from build flags and any remaining `#ifdef PROXYSQLGENAI` blocks.	2 months ago

Author

SHA1

Message

Date

Rene Cannao

4552236700

feat(plugins/genai): Step 6 — move RAG/Vector/discovery surface into the plugin

Final file-move step in the carve-out: relocates the leaf modules
that didn't depend on (and weren't depended on by) anything still in
core.  After this commit, the only PROXYSQLGENAI-guarded code
remaining in libproxysql.a is `MCP_Tool_Handler` — the base class
the plugin's AI_Tool_Handler / RAG_Tool_Handler inherit from — and
that lives in core only because removing it would force pulling
those derived plugin classes into core just for the inheritance
edge.  Step 7 deletes the PROXYSQLGENAI macro entirely.

Files moved (git mv preserves history)

  Headers (include/ -> plugins/genai/include/)
    AI_Vector_Storage.h
    MySQL_Catalog.h
    Discovery_Schema.h
    Static_Harvester.h
    PgSQL_Static_Harvester.h

  Sources (lib/ -> plugins/genai/src/)
    AI_Vector_Storage.cpp
    MySQL_Catalog.cpp
    Discovery_Schema.cpp
    Static_Harvester.cpp
    PgSQL_Static_Harvester.cpp

Core changes were minimal because these are leaf modules:

  include/proxysql.h: drop the AI_Vector_Storage.h include.
  include/cpp.h: drop AI_Vector_Storage / Discovery_Schema /
    MySQL_Catalog / Static_Harvester / PgSQL_Static_Harvester
    includes (replaced with a single carve-out history comment that
    Step 7 will delete entirely).
  lib/ProxySQL_Admin.cpp: drop the Discovery_Schema.h include — its
    only live use was via the now-#if-0'd save/load_mcp_query_rules
    blocks 4.C left behind for follow-up reference.
  lib/Makefile: drop AI_Vector_Storage.oo, MySQL_Catalog.oo,
    Discovery_Schema.oo, Static_Harvester.oo, PgSQL_Static_Harvester.oo
    from the GenAI _OBJ_CXX list.

Test fixture probe update

  test/tap/tests/unit/Makefile: PROXYSQLGENAI auto-detect probe
  switched from `AI_Vector_Storage` (now plugin-only) to
  `MCP_Tool_Handler` (the last GenAI-tier symbol still in core).
  Step 7 deletes the auto-detect entirely.

All three plugin unit tests pass:
  genai_plugin_load_unit-t       : 25/25
  genai_plugin_anomaly_unit-t    :  6/6
  genai_plugin_backend_client    : 27/27

Binary size deltas:
  src/proxysql                  159 MB -> 152 MB   (-7 MB)
  plugins/genai/...Plugin.so    47  MB ->  55 MB   (+8 MB)
  Net process RSS roughly neutral, as the design predicted.

Carve-out scoreboard:
  Step 0-2 : infrastructure
  Step 3   : ~1.1 K LOC (Anomaly_Detector)
  Step 4.B : ~0.5 K LOC (backend_client)
  Step 4.C : ~13   K LOC (MCP subsystem + tool handlers + MySQL_FTS)
  Step 4.F : runtime-reconfig admin SQL routed through plugin commands
  Step 4.G : MCP admin / config / stats tables registered via plugin ABI
  Step 5   : ~7    K LOC (GenAI/LLM/AI/RAG)
  Step 6   : ~5    K LOC (AI_Vector_Storage + Discovery_Schema +
                          MySQL_Catalog + Static_Harvester pair)

Pending: Step 7 — delete the PROXYSQLGENAI macro from build flags
and any remaining `#ifdef PROXYSQLGENAI` blocks.

1 Commits (6cdd4e697eb86982e3dfd2ceab009ead5da0efcb)