proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	80ecaa2c5d	docs(plans): Step 4 — merge 4.C/4.D/4.E (construction-site dependency) The original plan claimed the 5 "stateless" tool handlers could move in 4.C ahead of the listener moving in 4.E. Implementation analysis showed that 4 of those 5 (Admin/Cache/Config/Stats — only Observe is orphan) are constructed directly in lib/ProxySQL_MCP_Server.cpp at L84-131 with `new Admin_Tool_Handler(handler)` etc., so moving their .cpp files out of lib/ while leaving ProxySQL_MCP_Server.cpp behind breaks the lib/libproxysql.a → src/proxysql link. The transitional forwarding-header escape hatch the plan proposed addresses includes, not symbols, so it doesn't help. This commit revises the sub-step table: 4.D and 4.E are now merged into a revised 4.C — one atomic move of the entire MCP surface (8 tool handlers + base + MCP_Endpoint + MCP_Thread + ProxySQL_MCP_Server) plus the Query/MySQL backend rewires plus the GloMCPH lifecycle takeover. 4.F (register_command dispatch) and 4.G (register_table) remain separate and follow the merged 4.C. Adds a new section "4.C / 4.D / 4.E merge (revision)" that documents the construction-site dependency, the temporary admin-SQL surface gap between merged-4.C and 4.F (intentional, called out in commit messages), and the AI/RAG handlers' continued residence in lib/ (they're Steps 5/6 scope). No code changes in this commit — pure plan revision.	2 months ago
Rene Cannao	ae144cafc5	docs(plans): Step 4 — MCP subsystem move into plugins/genai/ Implementation plan for the largest remaining carve-out step: moves MCP_Thread, MCP_Endpoint, MCP_Tool_Handler, ProxySQL_MCP_Server, plus 8 tool handlers (Admin, Cache, Config, MCP, MySQL, Observe, Query, Stats) into plugins/genai/, deletes GloMCPH, and re-routes admin SQL surface through the plugin command/table registry. Resolves two open design questions from the carve-out spec: - Q-svcuser: plugin authenticates to local proxy via existing mcp_auth_profiles credentials (no new bootstrap mechanism). - Q-localhost-port: discovered via mysql-interfaces / pgsql-interfaces global vars at backend-pool-init time. Sub-step breakdown (4.A done; 4.B-4.G pending): 4.A — done in 5b936459a (now `a79a27a9e` on rebased branch) 4.B — backend_client.cpp helper (no callers yet) 4.C — move 5 stateless tool handlers 4.D — move MCP_Tool_Handler + Query + MySQL handlers; rewire to 127.0.0.1:6033 4.E — move MCP_Endpoint/Thread/Server, delete GloMCPH 4.F — register_command for mcp-* admin SQL 4.G — register_table for mcp_* admin tables Plan was drafted before this branch was rebased onto origin/plugin-chassis; references to "Step 0 ProtocolX cherry-pick" are now superseded by the plugin-chassis merge. Sub-step content remains accurate.	2 months ago
Rene Cannao	a880f1cf9d	docs(design): replace status-var registry with Prometheus access for plugins ProxySQL already has prometheus-cpp linked in deps/ and a Prometheus registry that core counters/gauges feed; scrapers already poll its /metrics endpoint. A separate plugin-private status-var sink would duplicate that machinery and target the wrong protocol surface -- SHOW MYSQL STATUS is a MySQL-protocol response that core owns and that mixes plugin metrics with wire-protocol details. Replaces the second Step 2 ABI extension: before: register_status_var(name) -> handle status_var_inc(handle, delta) -> surfaces in SHOW MYSQL STATUS after: get_prometheus_registry() -> prometheus::Registry* -> plugins use prometheus-cpp directly against the shared registry; their counters / gauges / histograms appear at the same /metrics endpoint as core's For plugin state that is naturally tabular and queryable via admin SQL, the existing ABI already covers it -- register_table(stats_db, ...). GenAI's existing stats_mcp_query_tools_counters / stats_mcp_query_digest / stats_mcp_query_rules (and their _reset siblings) currently registered in Admin_Bootstrap.cpp move to the plugin via that path during Step 4; no new ABI is required for that. Updates throughout: ABI extensions section, Step 2 description, error handling (registry overflow becomes name-collision exception), testing (test_plugin_status_var-t becomes test_plugin_prometheus-t), module layout (plugin_status_vars.cpp becomes plugin_metrics.cpp), and ProtocolX coordination note.	2 months ago
Rene Cannao	a60f8b7bc4	docs(plans): add Step 0 plan — ProtocolX plugin infra cherry-pick First of seven migration-step plans decomposing the GenAI plugin carve-out design. Covers cherry-picking 17 commits from origin/ProtocolX in five batches (ABI+loader, lifecycle wiring, table/command registry, ABI polish, mysqlx scaffold), with build verification and unit-test runs between batches, plus an end-to-end plugin-load smoke test.	2 months ago
Rene Cannao	4bc77150c3	docs: add design for GenAI plugin carve-out Extract all PROXYSQLGENAI modules into an in-tree plugin at plugins/genai/, using the ProtocolX plugin ABI (cherry-picked into this branch) extended with a pre-execution query hook and a status-variable registry. Migration is incremental (seven steps) and test isolation is an explicit motivation: plugin unit tests live with the plugin, integration tests live in-tree under a dedicated test group.	2 months ago
Rene Cannao	d4427731b7	Merge remote-tracking branch 'origin/v3.0' into plugin-chassis Picks up the v3.0 fixes that unblock plugin-chassis CI: - `5d702b12b` build(test): fix testgalera link after switch to src/SQLite3_Server.cpp — restores -Wl,--allow-multiple-definition, ClickHouse/zstd/lz4 link, and ProxySQL_Admin.cpp recompile under TEST_GALERA. Resolves CI-maketest red on plugin-chassis. - `baa5069ea` introduces test/tap/groups/mysql56-single/ which the CI-mysql56-single-g1 workflow expects. Resolves the missing-infra error. - macOS package upload + init_release race-tolerant grouping + amd64 package workflow expansion + various CI/release cleanups. CI-unit-tests-asan-coverage on plugin-chassis still depends on the v3.0 workflow YAML having libprotobuf-dev in its apt install step (workflow_run loads the YAML from the default branch). That fix is already on plugin-chassis (`47ab14148`) and will land on v3.0 via a separate small PR.	2 months ago
Rene Cannao	31d7ae9ecb	docs(mysqlx): reconcile comprehensive-testing plan against ProtocolX-rebased Audit the 14-task plan from 2026-04-09 against the actual test tree on ProtocolX-rebased and record the result inline. Findings: - Tasks 1-8, 10-14: every Tier-1 / Tier-2 / Tier-3 target file exists with a plan() at or above the assertion budget the plan called for. Tasks 5, 6, 8, 12 went well beyond their targets through interim expansion work; the others land exactly on plan. - Task 9 is obsolete: test_mysqlx_listener_smoke-t.cpp was deleted in `98aee7db2` together with the dormant MysqlxWorker path it exercised. Listener-lifecycle coverage is now provided by mysqlx_thread_unit-t and mysqlx_robustness_unit-t, which exist in the same tree but were not in scope when this plan was written. - 17 additional mysqlx/plugin unit-test files have landed beyond the plan, including the new mysqlx_compression_unit-t covering Phase 1-3 of the X Protocol compression work (zstd_stream + lz4_message capability negotiation, decompression with anti-bomb 16 MiB cap, and outbound batched compression). The plan does not enumerate these because they post-date it. Concretely this commit: - adds a "Reconciliation audit (2026-04-19)" section near the top with a per-task target/actual/status table and a pointer to the obsoleted task, - flips all 14 task-level "Commit:" checkboxes from [ ] to [x], - prepends an "(OBSOLETE)" tag and explanatory note to Task 9 so that anyone re-reading the plan understands why its sub-checkboxes are intentionally left unchecked. No code changes — this is purely a plan-status update so the plan is no longer misleading about what's left to do on the testing front.	2 months ago
Rene Cannao	6d4b9b5d58	chore: remove stale superpowers plans and designs Three agent-oriented plan/spec docs were added three weeks ago and never acted on — every one has 0 checkboxes ticked and no matching commits: - plans/2026-04-11-remove-sqlite-rembed-and-rust.md (0/52) - plans/2026-04-12-infra-dbdeployer-mysql57.md (0/29) - specs/2026-04-12-infra-dbdeployer-mysql57-design.md sqlite-rembed and the Rust toolchain are still in place, and infra-mysql57 has not been replaced by dbdeployer. If this work is still wanted, file fresh issues; carrying stale plan checklists in the tree misleads future agent-driven work.	2 months ago
Rene Cannao	c723ede0cf	Merge remote-tracking branch 'origin/plugin-chassis' into ProtocolX-rebased # Conflicts: # lib/ProxySQL_PluginManager.cpp # plugins/mysqlx/Makefile # plugins/mysqlx/include/mysqlx_plugin.h # plugins/mysqlx/include/mysqlx_session.h # test/tap/groups/groups.json # test/tap/tests/test_mysqlx_listener_smoke-t.cpp # test/tap/tests/unit/Makefile	2 months ago
Rene Cannao	b3d4de0bc8	Merge remote-tracking branch 'origin/v3.0' into plugin-chassis # Conflicts: # test/tap/groups/groups.json	2 months ago
Rene Cannao	2ab4df189d	docs(mysqlx): add route-identity design spec and implementation plan Adds two reference documents alongside the code commits so reviewers and future maintainers have design context next to implementation. - docs/superpowers/specs/2026-04-17-mysqlx-route-identity-design.md captures the problem statement, why user-driven routing was picked over listener-driven or hybrid, the three failure modes with their error codes, the architectural decision to widen the identity ABI to the existing MysqlxResolvedIdentity struct, and the explicit non-goals (listener-to-route mapping, worker-path removal, error code reconciliation, CI infrastructure). - docs/superpowers/plans/2026-04-17-mysqlx-route-identity.md captures the task breakdown (route_exists predicate, ABI refactor, resolve_backend_target method, auth-flow wiring) with exact file paths and step-by-step TDD guidance. Used to drive the five implementation commits on this branch. Out of scope: nothing — these are descriptive artifacts, not code.	2 months ago
Rene Cannao	abcc8c31f9	refactor(infra): rename infra-dbdeployer57 to infra-dbdeployer-mysql57 More explicit name since dbdeployer will also be used for MariaDB and PostgreSQL infras in the future.	2 months ago
Rene Cannao	0174ae350d	docs: add implementation plan for infra-dbdeployer57 11 tasks covering: Dockerfile, entrypoint, build script, docker-compose, init/destroy scripts, mysql-post, proxy-post, infra-config.sql, and smoke testing.	2 months ago
Rene Cannao	7b67fb8b21	docs: add design spec for infra-dbdeployer57 Design for replacing infra-mysql57 (6 containers) with a single-container infra using dbdeployer to run 3 MySQL 5.7 instances. Drops orchestrator (unused by legacy tests). Approach A: entrypoint-driven deployment.	2 months ago
Rene Cannao	5c1549dcc6	merge: resolve conflicts with v3.0 branch Merge origin/v3.0 into ProtocolX. One conflict in test/tap/tests/unit/Makefile resolved by keeping both mysqlx unit tests (ProtocolX) and pgsql_servers_ssl_params unit test + GENAI vec.o link (v3.0).	2 months ago
Rene Cannao	27daf2c21d	docs(plan): add plan for removing sqlite-rembed and Rust dep	2 months ago
Rene Cannao	dbfec4c392	docs(mysqlx): add feature gaps implementation plan 10-task plan to close all feature gaps identified in the MySQL Router X Protocol parity comparison: P0: Task 1-3: TLS infrastructure, client TLS, backend TLS P1: Task 4-5: TLS passthrough, per-message response state machines P2: Task 6-8: Backend connect timeout, notice awareness, compression error P3: Task 9-10: Session reset passthrough, TLS error messages Each task is independently testable and committable. Tasks 5-9 are independent. Tasks 1-4,10 must be sequential.	2 months ago
Rene Cannao	30477a3ea5	docs: add comprehensive testing plan for mysqlx plugin 14-task testing plan covering three tiers: - Tier 1 (pure unit): protocol frames, auth, hex, stats counters, config store logic, routing strategies - Tier 2 (integration): plugin lifecycle, admin LOAD/SAVE with aliases, DDL validation, listener lifecycle, concurrent reads/writes - Tier 3 (E2E): Docker MySQL 8.x handshake, query routing Target: 112 -> 307+ assertions across 14 test files.	2 months ago
Rene Cannao	cf867e46fd	test/docs: update admin tables test and docs for canonical MYSQLX syntax Update test_mysqlx_admin_tables-t.cpp to use canonical LOAD/SAVE MYSQLX command syntax and add SAVE roundtrip coverage. Plan count: 23 -> 42. New test coverage: - 3 SAVE command tests verifying runtime->config data copy - 7 LOAD edge cases: empty tables, double LOAD replaces (not appends), modified config reflected after LOAD, null db handle returns error, multiple rows copied correctly - 8 alias dispatch tests: case-insensitive matching and whitespace normalization for all command variants Update wrap-up doc to list canonical command names with alias patterns.	2 months ago
Rene Cannao	136b8d7bfd	plan: mysqlx canonical admin commands implementation 6-task plan to replace PLUGIN MYSQLX prefix with canonical LOAD/SAVE MYSQLX ... TO RUNTIME/FROM MEMORY syntax.	2 months ago
Rene Cannao	0b18ae09ee	spec: mysqlx canonical admin commands design Replace PLUGIN MYSQLX prefix with first-class LOAD/SAVE MYSQLX commands matching the existing MYSQL/PGSQL admin command convention.	2 months ago
Rahim Kanji	49553cfb0b	fix: support one-sided TLS version ranges and warn on malformed input parse_tls_version() silently discarded partially-specified ranges like "TLSv1.2-" or "-TLSv1.3", leaving both min and max empty. This meant the user's intent (e.g. "at least TLSv1.2") was lost without any indication. Now one-sided ranges set the specified bound and leave the other side to libpq defaults. A bare "-" logs a proxy_warning.	2 months ago
Rahim Kanji	e68f8bb74a	refactor: simplify pgsql_servers_ssl_params schema and pre-parse TLS range - Drop ssl_capath and ssl_cipher columns (no libpq equivalents) - Pre-parse ssl_protocol_version_range into ssl_min/max_protocol_version at construction time instead of on every backend connection - Fix Servers_SslParams 3-arg delegating constructor - Update tests, docs, and all consumers (Connection, Monitor, Kill, Admin)	2 months ago
Rene Cannao	d28980ddd8	docs: update mysqlx plugin wrap-up with tasks 6-9 complete	2 months ago
Rene Cannao	782e019a8c	wip: capture mysqlx task 5 scaffolding and wrap-up status	2 months ago
Rene Cannao	5392c0a6a2	Add mysqlx plugin design spec	2 months ago
Rahim Kanji	8aa3855ba8	docs: add user documentation for pgsql_servers_ssl_params Covers table schema, column reference, ssl_protocol_version_range format (range, pin, empty default), lookup hierarchy, usage examples (basic, per-user, TLS restriction, multi-server), admin commands, and prerequisites.	2 months ago

27 Commits (6cdd4e697eb86982e3dfd2ceab009ead5da0efcb)