proxysql

Commit Graph

Author	SHA1	Message	Date
Wazir Ahmed	9757835a5f	Merge branch 'v3.0' into fix-fc-parsing	2 months ago
René Cannaò	669ab91494	Merge pull request #5594 from sysown/v3.0-lint lint + static analysis: clang-tidy and cppcheck fixes	2 months ago
Rene Cannao	24e56d4dd1	fix: SonarCloud issues - explicit ctors, sprintf->snprintf	2 months ago
Rene Cannao	a82224f1ef	fix: PR review feedback - double-free, end comments, dead code - Fix double-free bug in free_account_details() (lib/MySQL_Authentication.cpp) - Fix trailing #endif comments in 5 files to match guard names - Rename __SIZE -> SIZE_ in LDAP_USER_FIELD_IDX enum - Remove dead code: Query_Processor_Output ctor now calls init()	2 months ago
Rene Cannao	5ccb715e57	fix: cppcheck fixes - printf formats, null checks, copy operators - Fix invalidPrintfArgType: %d->%u for hid, %u->%d for use_ssl - Fix nullPointerRedundantCheck: replace assert with continue - Add deleted copy ctor/operator= to KillArgs and MySQL_Session - Fix invalidFunctionArg: add query_len > 3 check before memcpy	2 months ago
Rene Cannao	a51fe19e3f	fix: delete copy operations in 4 classes (Group_Replication_Info, Galera_Info, AWS_Aurora_Info, MySQL_Errors_stats)	2 months ago
Rene Cannao	521fcf5ce7	fix: initialize all members in stmt_execute_metadata_t constructor	2 months ago
Rene Cannao	04a1487973	fix: ensure MySQL_Query_Processor_Output initializes inherited members	2 months ago
Rene Cannao	315f12d4d4	fix: initialize all members in MySQL_Protocol constructor	2 months ago
Rene Cannao	a02e87823f	fix: initialize all members in Query_Processor_Output constructor	2 months ago
Rene Cannao	500488bbdf	fix: delete copy operations in iface_info class	2 months ago
Rene Cannao	9a3f728041	perf: use initialization list in Servers_SslParams constructor	2 months ago
Rene Cannao	39b664a9f5	fix: resolve memleakOnRealloc in PtrArray::allocate	2 months ago
Rene Cannao	7e1a78fd6b	lint: fix reserved identifiers and include guards - Rename __HGM_TABLES_SIZE -> HGM_TABLES_SIZE_ (Base/MySQL/PgSQL HGM) - Rename __TYPE_SIZE -> TYPE_SIZE_ (Base/MySQL/PgSQL HGM) - Fix include guard defines: __PROXYSQL_* -> PROXYSQL_* - Fix include guard comments: __CLASS_* -> PROXYSQL_*_H (29 files) - Add uint8_t underlying type to small enums	2 months ago
Rene Cannao	5513f735e6	lint: replace NULL with nullptr in header files modernize-use-nullptr: replace NULL with nullptr for type-safe null pointer constants. This is a C++11 modernization that improves type safety. Files changed: - Base_HostGroups_Manager.h - ClickHouse_Authentication.hpp - MySQL_HostGroups_Manager.h - MySQL_LDAP_Authentication.hpp - MySQL_Monitor.hpp - MySQL_Session.h - PgSQL_Error_Helper.h - PgSQL_HostGroups_Manager.h - PgSQL_Session.h	2 months ago
Rene Cannao	f2bc1d4185	lint: fix reserved identifier in function parameter names and comments bugprone-reserved-identifier fixes: - gen_utils.h: rename __size parameter to 'sz' in PtrArray and PtrSizeArray constructors (parameter names starting with __ are reserved) - prometheus_helpers.h: update documentation comments to reference '::SIZE_' instead of '::__size' to match the actual enum values	2 months ago
Rene Cannao	9bdfb8b1cd	lint: optimize enum types and fix reserved identifiers in Query_Cache, admin, thread, debug performance-enum-size fixes: - p_qc_counter, p_qc_gauge: add uint8_t (7 and 2 values) - p_admin_counter, p_admin_gauge, p_admin_dyn_counter, p_admin_dyn_gauge: add uint8_t - p_debug_dyn_counter: add uint8_t (2 values) bugprone-reserved-identifier fixes: - Rename __size -> SIZE_ in all metric enums - Update std::array size references across multiple files - Update prometheus_helpers.h template parameter names and comments Files changed: - Query_Cache.h - proxysql_admin.h - MySQL_Thread.h - proxysql_debug.h - prometheus_helpers.h (template changes) - debug.cpp (usage update)	2 months ago
Rene Cannao	0d6c0270a4	lint: optimize enum types and fix reserved identifiers in Base/PgSQL hostgroups performance-enum-size fixes: - p_mysql_error_type: add uint8_t underlying type (2 values) - p_pgsql_error_type: add uint8_t underlying type (2 values) - p_hg_dyn_gauge: add uint8_t underlying type (5 values) - p_hg_dyn_counter: add uint8_t underlying type (9 values) - PgSQL_p_hg_dyn_gauge: add uint8_t underlying type (5 values) - PgSQL_p_hg_dyn_counter: add uint8_t underlying type (9 values) bugprone-reserved-identifier fixes: - Rename __size -> SIZE_ in all metric enums to avoid reserved identifier - Update std::array size references to use new SIZE_ enum values Applies same fixes as MySQL_HostGroups_Manager.h to: - Base_HostGroups_Manager.h (base class) - PgSQL_HostGroups_Manager.h (PostgreSQL implementation)	2 months ago
Rene Cannao	b531326c82	lint: optimize enum underlying types and fix reserved identifiers performance-enum-size fixes: - p_mysql_error_type: add uint8_t underlying type (2 values) - p_hg_dyn_gauge: add uint8_t underlying type (5 values) - p_hg_dyn_counter: add uint8_t underlying type (9 values) bugprone-reserved-identifier fixes: - Rename __size -> SIZE_ in metric enums to avoid reserved identifier (names starting with __ are reserved in C++) - Update all std::array size references using these enum values	2 months ago
Rene Cannao	f1826cf206	lint: fix reserved identifier in member variables Rename __active -> active_, __frontend -> frontend_, __backend -> backend_ in authentication and hostgroups classes to comply with C++ reserved identifier rules. Includes updates to: - MySQL_Authentication.hpp - ClickHouse_Authentication.hpp - PgSQL_Authentication.h - MySQL_HostGroups_Manager.h - Base_HostGroups_Manager.h - Corresponding .cpp files	2 months ago
Rene Cannao	54e9de7cb3	lint: fix reserved identifier in enum size sentinels Rename ROS__SIZE -> ROS_SIZE_, RLS__SIZE -> RLS_SIZE_, etc. to avoid the reserved identifier pattern (double underscore at start or in name).	2 months ago
Rene Cannao	4810f1f05b	lint: fix reserved identifier in include guards Replace __CLASS_* and ____CLASS_* patterns with PROXYSQL_*_H to comply with the C++ standard where identifiers starting with __ are reserved in the global namespace. Also fixes: - ____CLASS_STANDARD_MYSQL_THREAD_H -> PROXYSQL_STANDARD_MYSQL_THREAD_H - ____CLASS_STANDARD_PGSQL_THREAD_H -> PROXYSQL_STANDARD_PGSQL_THREAD_H - __CLASS_PROXYSQL_POLL -> PROXYSQL_POLL_H (added _H for consistency)	2 months ago
Rene Cannao	413584f0fb	lint: fix unsigned-to-signed cast in MySrvConnList::find_idx Use static_cast<int> instead of C-style cast for clarity and to avoid unsigned->signed narrowing warnings while preserving the -1 sentinel.	2 months ago
Rene Cannao	17225cf2a8	lint: fix bugprone-macro-parentheses in 6 header files - MySQL_Thread.h: wrap negative hostgroup constants in parens - PgSQL_Thread.h: wrap negative hostgroup constants in parens - proxysql_admin.h: wrap expression multipliers in parens - proxysql_debug.h: wrap macro args in ASSERT_SQLITE* macros - proxysql_macros.h: wrap macro args in strdup_null, free_null, itostr, Copy4B - proxysql_structs.h: wrap macro args in IS_PGTRACKED_VAR_OPTION_* macros	2 months ago
Rene Cannao	ac0f9304b0	fix: address code review findings for pgsql cluster sync 1. Remove dead declarations and implementations: PullOperationConfig, pull_from_peer_unified, fetch_query_with_metrics, compute__checksum, ScopedChar wrappers, and all safe_* memory helpers (-690 lines) 2. Document mutex sharing: pgsql pull functions intentionally reuse MySQL mutexes since pulls are sequential in the monitoring thread 3. Fix variable shadowing: rename local 'error' to 'exec_error' in Admin_Handler.cpp pgsql_servers_v2 fallback to avoid shadowing the outer error variable 4. Fix misleading debug message in process_component_checksum: the else branch fires when peer checksum is unchanged, not different 5. Fix indentation in ProxySQL_Admin.cpp (3 lines with double-tab) and Admin_FlushVariables.cpp (NULL-guard block with extra indent)	2 months ago
Rene Cannao	80ff2242e6	merge: resolve v3.0 conflict and add pgsql_servers_ssl_params cluster sync v3.0 added pgsql_servers_ssl_params table. Integrate into pgsql cluster sync path: - Add CLUSTER_QUERY_PGSQL_SERVERS_SSL_PARAMS to Admin_Handler interception block alongside other pgsql cluster queries - Add ssl_params fetch query to pull_pgsql_servers_v2_from_peer - Add update_pgsql_servers_ssl_params() for applying synced data - Update convert_pgsql_servers_resultsets to handle 5 result sets - Include ssl_params in v2 checksum computation (4 tables)	2 months ago
René Cannaò	7f14beedc1	Merge pull request #5583 from sysown/v3.0_pgsql_ssl_backend_5582 Per-server SSL parameters for PostgreSQL backends	2 months ago
René Cannaò	1a8e4ed918	Merge pull request #5567 from sysown/v3.0_pgsql_sslkeylog_5281 Add SSL/TLS traffic decryption for PostgreSQL backend connections	2 months ago
Rahim Kanji	49553cfb0b	fix: support one-sided TLS version ranges and warn on malformed input parse_tls_version() silently discarded partially-specified ranges like "TLSv1.2-" or "-TLSv1.3", leaving both min and max empty. This meant the user's intent (e.g. "at least TLSv1.2") was lost without any indication. Now one-sided ranges set the specified bound and leave the other side to libpq defaults. A bare "-" logs a proxy_warning.	2 months ago
Rene Cannao	0e1ea6a734	Address code review feedback for mysql-resolution_family - Add documentation comments to MySQL_Resolution.h explaining NULL fallback behavior for all three helper functions - Initialize mysql_thread___resolution_family to "system" in MySQL_Thread constructor to prevent NULL before first refresh_variables() call - Add explanatory comment in mysql_resolution_unit-t.cpp documenting the DNS cache bypass limitation for future contributors Review: #5554	2 months ago
Rahim Kanji	76acb1e3e8	feat: add cluster query support for pgsql_servers_ssl_params - Define CLUSTER_QUERY_PGSQL_SERVERS_SSL_PARAMS macro for remote node fetch - Add Admin_Handler interception so cluster peers can query the table - Add pgsql_servers_ssl_params to get_current_pgsql_table() lookup - Checksum computation was already in place via CUCFT1 in commit()	2 months ago
Rahim Kanji	e68f8bb74a	refactor: simplify pgsql_servers_ssl_params schema and pre-parse TLS range - Drop ssl_capath and ssl_cipher columns (no libpq equivalents) - Pre-parse ssl_protocol_version_range into ssl_min/max_protocol_version at construction time instead of on every backend connection - Fix Servers_SslParams 3-arg delegating constructor - Update tests, docs, and all consumers (Connection, Monitor, Kill, Admin)	2 months ago
René Cannaò	8a61232517	fix: decouple MySQL and PostgreSQL checksum/sync controls Two bugs in the PostgreSQL cluster sync admin variables: 1. Cross-protocol coupling (critical): Disabling a MySQL checksum flag (e.g. SET admin-checksum_mysql_query_rules='false') incorrectly zeroed out the corresponding PostgreSQL cluster sync threshold (cluster_pgsql_query_rules_diffs_before_sync). An operator disabling MySQL checksums would unexpectedly halt PostgreSQL cluster sync. Fix: MySQL checksum setters now only affect MySQL sync thresholds. The warning messages no longer mention pgsql side effects. 2. Single-gate for all pgsql modules (operational limitation): All four PostgreSQL cluster sync thresholds (cluster_pgsql_{query_rules,servers,users,variables}_diffs_before_sync) were gated by a single flag (checksum_pgsql_variables). This meant you could not independently control checksum computation per-module. By contrast, MySQL has per-module flags (checksum_mysql_query_rules, checksum_mysql_servers, checksum_mysql_users, checksum_mysql_variables). Fix: Add three new per-module admin variables: - admin-checksum_pgsql_query_rules - admin-checksum_pgsql_servers - admin-checksum_pgsql_users Each gates only its corresponding cluster_*_diffs_before_sync setter, mirroring the MySQL pattern. The existing admin-checksum_pgsql_variables now only gates cluster_pgsql_variables_diffs_before_sync. Disabling admin-checksum_pgsql_variables no longer cascades to zero out query_rules/servers/users sync thresholds. Files changed: - include/proxysql_admin.h: Add checksum_pgsql_query_rules, checksum_pgsql_servers, checksum_pgsql_users to checksum_variables struct. - lib/ProxySQL_Admin.cpp: Add variable names, constructor defaults, get/set handlers for new flags. Update diffs_before_sync guards to use per-module flags. Remove pgsql zeroing from MySQL checksum setters. Fix checksum_pgsql_variables setter to only affect pgsql variables sync threshold.	2 months ago
Rene Cannao	47758a468d	merge: resolve groups.json conflict with v3.0 Take v3.0's groups.json as base (legacy-gN naming, mysql84-gN groups, new test entries) and add test_cluster_sync_pgsql-t from this branch. Drop duplicate pgsql_admin_metacmds-t (already exists as pgsql-admin_metacmds-t in v3.0).	2 months ago
Wazir Ahmed	0e5fd66d46	Preserve prepared statement `min_gtid` in `first_comment_parsing` mode Issue --- When `first_comment` parsing runs before query rule processing, query rules can strip the `min_gtid` annotation during `STMT_PREPARE`. As a result, `STMT_EXECUTE` can run without the original `min_gtid` constraint. Refs --- - Commit - `1c25787b88` - https://github.com/sysown/proxysql/issues/5384#issuecomment-4137207612 Fix --- - Store `min_gtid` by frontend `client_stmt_id` in `MySQL_STMTs_local_v14` and restore it during `STMT_EXECUTE` using the client statement handle. - Add TAP test to cover the case of `[first_comment_parsing=1 + prepared_stmt + min_gtid + query_rewrite]` Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rahim Kanji	7fa0e82bd7	fix: move SSL params classes to standalone header to resolve circular includes Servers_SslParams, MySQLServers_SslParams, and PgSQLServers_SslParams are now in Servers_SslParams.h with minimal dependencies (<string> only). This avoids the circular include issue between cpp.h, mysql_connection.h, and Base_HostGroups_Manager.h that caused incomplete type errors.	2 months ago
Rahim Kanji	516fa468ba	feat: add admin load/save/dump for pgsql_servers_ssl_params	2 months ago
Rahim Kanji	5ad511568a	feat: add pgsql_servers_ssl_params table definitions and admin bootstrap	2 months ago
Rahim Kanji	05e3ed4351	feat: add PgSQLServers_SslParams class with map, generate, get, and commit integration	2 months ago
Rahim Kanji	619c084cab	refactor: MySQLServers_SslParams now derives from Servers_SslParams	2 months ago
Rahim Kanji	74d6336660	refactor: extract Servers_SslParams base class from MySQLServers_SslParams	2 months ago
Rene Cannao	c9b30f8f56	fix: handle SHUNNED status in CLUSTER_QUERY_RUNTIME_PGSQL_SERVERS The CASE expression was missing a WHEN branch for SHUNNED, causing rows with that status to get NULL instead of a valid string. This corrupted runtime pgsql server checksums during cluster sync. Add WHEN 'SHUNNED' THEN 'ONLINE' (consistent with CLUSTER_QUERY_PGSQL_SERVERS_V2) and an ELSE fallback to prevent NULL for any unexpected status values.	2 months ago
Rahim Kanji	e7ee68dda5	Add SSL/TLS traffic decryption for PostgreSQL backend connections (#5281 ) Extends the existing NSS keylog-based SSL decryption to PostgreSQL backend connections by patching libpq with a global PQsetSSLKeyLogCallback() API. When admin-ssl_keylog_file is configured, TLS secrets from all PgSQL backend SSL handshakes are written to the keylog file in NSS Key Log Format, enabling traffic decryption with Wireshark/tshark. Approach: - Patch libpq with global callback following the PQsslKeyPassHook pattern - Single startup call covers all backend paths (regular, monitor, kill, harvester) - No new admin variables — existing admin-ssl_keylog_file covers PgSQL backends - Zero changes to ProxySQL PgSQL connection code Includes 9 integration tests (pgsql-ssl_keylog-t) and user guide updates.	2 months ago
Rene Cannao	424a3664ae	Use thread-local storage for resolution_family variable Replace direct GloMTH->get_variable_string() call in monitor_dns_resolver_thread() with the proper mysql_thread___ thread-local variable pattern: - Add __thread char* mysql_thread___resolution_family in proxysql_structs.h - Add REFRESH_VARIABLE_CHAR(resolution_family) in refresh_variables() - Free the thread-local variable in MySQL_Thread destructor - Read mysql_thread___resolution_family directly in the monitor thread instead of taking a lock via get_variable_string()	2 months ago
copilot-swe-agent[bot]	4a93861c6c	feat: add mysql resolution_family setting Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/7d0ebed6-886c-4e06-add5-d74b44eced4a Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	2 months ago
René Cannaò	d0625dc243	Merge pull request #5549 from sysown/v3.0-CodeCov0325 Add 32 unit test files (2963 assertions) and CI workflow improvements	2 months ago
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	c8408d76b3	test: add 6 unit test files with 588 assertions (Round 5) New test files (test/tap/tests/unit/): Core: - pgsql_tokenizer_unit-t (65 tests): PgSQL SQL digest — dollar- quoted strings, ::type casts, ARRAY literals, boolean literal replacement, E/B/X/U& prefix strings, comment handling, grouping/IN-list collapsing, edge cases - admin_disk_upgrade_unit-t (60 tests): all 6 disk_upgrade_*() schema migration functions with in-memory SQLite — scheduler v1.2.0→current, mysql_users v1.3.0→current, rest_api_routes v2.0.15→current, mysql_servers v1.1.0→current (with weight cap and compression normalization bugs), pgsql_replication_hostgroups v3.0.1→current, mysql_query_rules v1.2.2→current - gtid_utils_unit-t (37 tests): addGtid interval merging (adjacent, non-consecutive, duplicate, bridge, reverse-order, within- existing), addGtidInterval (update, duplicate, non-overlapping), gtid_executed_to_string formatting - glovars_unit-t (78 tests): GloVars constructor defaults, ProxySQL_Checksum_Value (set/replace_zeros/version/epoch), generate_global_checksum determinism, command-line parsing (--initial/--reload/--no-version-check/-D/--bootstrap/-n/-f/-M) - query_processor_unit-t (+217 tests, 259 total): EXTENDED with PgSQL-specific tests — all-fields rule creation, client_addr wildcard, flagOUT attributes JSON, command counters, stats, rule text 35-column serialization, query_parser_command_type for 100+ PgSQL commands (DML/DDL/views/sequences/functions/ triggers/policies/LISTEN/NOTIFY/VACUUM/TEXT SEARCH/etc.), fast routing hashmap, firewall whitelist, query digests GenAI/MCP (PROXYSQLGENAI=1): - genai_mysql_catalog_unit-t (89 tests): MySQL_Catalog with in-memory SQLite — upsert/get/remove, schema isolation, list with pagination, FTS search, merge, multiple kinds, special character handling Production changes for testability: - include/proxysql_admin.h: add friend class TestDiskUpgrade - test/tap/tests/unit/Makefile: add DEBUG auto-detection from libproxysql.a symbols (fixes struct layout ODR violations when library is built with -DDEBUG) Running totals: 32 test files, 2553 assertions, all passing.	2 months ago
Rene Cannao	99dcb5b160	fix: namespace stats_utils helpers to avoid symbol collision ProxySQL_Admin_Tests2.cpp defines its own parse_int_or_zero() in an anonymous namespace. Our declaration in Stats_Tool_Handler.h (included transitively via cpp.h) created an ambiguous overload error. Fix: wrap the 4 helper functions in namespace stats_utils in both the header and implementation. A using-directive within the .cpp keeps existing call sites working without qualification.	2 months ago
Rene Cannao	ece648fc16	test: add 6 more unit test files with 550 assertions (Tier 2+3) Expand coverage for firewall whitelist, statistics, config validation, logging, and GenAI thread variable management. New test files (test/tap/tests/unit/): Core: - query_processor_firewall_unit-t (44 tests): load_firewall() users/rules/sqli fingerprints, find_firewall_whitelist_user/rule, whitelisted_sqli_fingerprint, reload/clear, memory accounting, PgSQL parity, multiple digest bsearch - statistics_unit-t (20 tests, 95 with TSDB): timer functions (timetoget for MySQL threads, query cache, CPU, logger, digest), TSDB set/get/has variable with range validation, insert/query metrics, backend health, downsampling, retention - config_validation_unit-t (54 tests): addField() formatting and escaping, validate_backend_users() duplicate detection for MySQL/PgSQL, validate_backend_servers() with field aliases and default ports, validate_proxysql_servers() - log_utils_unit-t (42 tests): LogBuffer append/write/operator<< overloads, data() accessor, reset(), should_log() rate limiting, GetLogBufferThreadContext() lifecycle GenAI/MCP (PROXYSQLGENAI=1): - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler constructor defaults (26 vars), boolean/port/timeout/string variable set/get with range validation, has_variable, get_variables_list, null safety, target auth map - genai_thread_unit-t (193 tests): GenAI_Threads_Handler constructor defaults (31 vars), integer range validation for 15+ variables, double/boolean/string round-trips, has_variable, get_variables_list, overwrite and rejection persistence Note: found potential bug — llm_cache_enabled has no get/set handler despite being listed in variables array Minimal production change: - include/proxysql_config.h: add friend class for test access to private validate_backend_users/servers/proxysql_servers methods Running totals: 21 test files, 1268 assertions, all passing.	2 months ago

1 2 3 4 5 ...

2246 Commits (6cab7bd13b06bc12bed928bfc9eddab050bb382d)