proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	faa64a570d	Merge pull request #5259 from sysown/v3.0_mysql_monitor_cur_cmd_cmnt_fix Fix: Make cur_cmd_cmnt thread-safe	4 months ago
Javier Jaramago Fernández	5c8a32a0b0	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-handle_unexp_ping	4 months ago
Rahim Kanji	91e20648f2	Fixed an issue where cur_cmd_cmnt was shared across threads	4 months ago
Javier Jaramago Fernández	6fea828e86	Improve logging in unexpected COM_PING packet handling Logging messages now include 'client address', 'session status' and 'data stream status'. Client address is also logged when OK packets are dispatched, this should help tracking if a client has received the expected packets or not.	4 months ago
René Cannaò	88edaac61b	Merge pull request #5258 from sysown/misc251219 Documentation additions and bug fix for vacuum_stats()	4 months ago
René Cannaò	0f7ff1f374	Merge branch 'v3.0' into v3.0_pgsql-query-digest-gen-5253 Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
René Cannaò	2667540fcc	Merge pull request #5237 from sysown/v3.0_pgsql-monitor-sslsupport-5205 Add SSL support for backend connections in PGSQL monitor	4 months ago
Javier Jaramago Fernández	d0e88599ee	Add special handling for unexpected COM_PING packets Implements a workaround for the handling of unexpected 'COM_PING' packets received during query processing, while a resultset is yet being streamed to the client. Received 'COM_PING' packets are queued in the form of a counter. This counter is later used to sent the corresponding number of 'OK' packets to the client after 'MySQL_Session' has finished processing the current query.	4 months ago
Rene Cannao	efe0d4fe61	Add extensive doxygen documentation for vacuum_stats and stats_pgsql_stat_activity This commit documents: 1. The vacuum_stats() function's purpose, behavior, and the reason why stats_pgsql_stat_activity is excluded from bulk deletion operations 2. The fact that stats_pgsql_stat_activity is a SQL VIEW (not a table) and attempting DELETE on it would cause SQLite error: "cannot modify stats_pgsql_stat_activity because it is a view" The documentation explains: - Why TRUNCATE stats_mysql_query_digest triggers vacuum_stats(true) - Why both MySQL and PostgreSQL tables are cleared regardless of protocol - How the view is automatically cleared via its underlying table stats_pgsql_processlist - The importance of keeping the view excluded from deletion lists	4 months ago
Rahim Kanji	5e75264bb3	Updated TAP test	4 months ago
Rahim Kanji	5b3805ad7a	Refactored comment handling * Removed is_cmd (/!) handling Proper handling of Keep Comments and First comment extraction * Proper handling for nested comments	4 months ago
Rahim Kanji	e70fcbf021	* Add dedicated handling for double-quoted PostgreSQL identifiers * Added crash payload testing * Fixed unterminated comments handling	4 months ago
René Cannaò	6ee087c73c	Merge pull request #5250 from sysown/v3.0-issue5248 Fix cache_empty_result=0 not caching non-empty resultsets (issue #5248)	4 months ago
Rahim Kanji	fd53642f12	Added pgsql-query_digests_stages_test-t to groups.json	4 months ago
Rahim Kanji	39728b2dc8	Add missing pgsql_tokenizer.cpp	4 months ago
Rahim Kanji	42864e8867	Improved Tokenizer for PostgreSQL - Added `process_pg_typecast()` to handle PostgreSQL type cast syntax (::) - Recognizes type casts in various contexts: 'value'::type, column::type, etc. - Added `process_array_literal()` for PostgreSQL array processing - Handles both ARRAY[] constructor and {} literal syntax - Processes multi-dimensional arrays and nested array structures - Added `process_literal_prefix_type()` for PostgreSQL prefixed literals - Processes E'' escape string constants with backslash escapes - Handles U&'' Unicode string literals with optional UESCAPE clauses - Supports x'' hex string literals and b'' bit string literals - Manages B'' bit strings and bytea literals (\\xDEADBEEF format) - Added `process_replace_boolean()` for boolean literal replacement - Replaces TRUE and FALSE literals with parameter placeholders - Maintains case-insensitive matching (true, True, TRUE, etc.) - Preserves boolean context in expressions and WHERE clauses	4 months ago
Rene Cannao	2987242d4f	Fix cache_empty_result=0 not caching non-empty resultsets (issue #5248 ) The `cache_empty_result` field in query rules has three possible values: • -1: Use global setting (`query_cache_stores_empty_result`) • 0: Do NOT cache empty resultsets, but cache non-empty resultsets • 1: Always cache resultsets (both empty and non-empty) Previously, when `cache_empty_result` was set to 0, nothing was cached at all, even for non-empty resultsets. This prevented users from disabling caching for empty resultsets while still allowing caching of non-empty resultsets on a per-rule basis. Changes: 1. Modified caching logic in MySQL_Session.cpp and PgSQL_Session.cpp to add the condition `(qpo->cache_empty_result == 0 && MyRS->num_rows)` (MySQL) and `(qpo->cache_empty_result == 0 && num_rows)` (PgSQL) to allow caching when cache_empty_result=0 AND result has rows. 2. Added comprehensive Doxygen documentation in query_processor.h explaining the semantics of cache_empty_result values. 3. Updated Query_Processor.cpp with inline comments explaining the three possible values. Now when cache_empty_result is set to 0: - Empty resultsets (0 rows) are NOT cached - Non-empty resultsets (>0 rows) ARE cached - This matches the intended per-rule behavior described in issue #5248. Fixes: https://github.com/sysown/proxysql/issues/5248	4 months ago
René Cannaò	5a314d2364	Merge pull request #4889 from sysown/v3.0_get_server_version Added handling of SELECT @@version and SELECT VERSION() without backend	4 months ago
René Cannaò	8cf3e59ead	Merge pull request #5247 from sysown/v3.0-issue5246 Fix: Automatic prefix stripping for mysql_variables, pgsql_variables, and admin_variables config parsing	4 months ago
Rene Cannao	0b2bc1bf22	Fix SQL injection vulnerability in Read_Global_Variables_from_configfile Replace sprintf-based SQL query construction with prepared statements using bound parameters to prevent SQL injection attacks. This addresses the security issue identified in PR #5247 review. Changes: - Use SQLite prepared statement with placeholders ?1, ?2 - Bind variable names and values securely using proxy_sqlite3_bind_text - Use ASSERT_SQLITE_OK for error handling as per ProxySQL conventions - Remove malloc/sprintf vulnerable code pattern - Add necessary includes for SQLite functions and ASSERT_SQLITE_OK macro Security: SQL injection could have occurred if configuration variable names or values contained malicious quotes. Prepared statements eliminate this risk.	4 months ago
Rahim Kanji	fae283cf7e	Add SSL and non-SSL connection OK metrics for PostgreSQL monitor connections Adds two new metrics, ssl_connections_OK and non_ssl_connections_OK, to improve visibility into PostgreSQL monitor connection status.	4 months ago
Rene Cannao	6c97d3d244	Add extensive Doxygen documentation for ProxySQL_Config and Read_Global_Variables_from_configfile This commit adds detailed Doxygen documentation for: 1. The ProxySQL_Config class - describes its role in configuration management 2. The Read_Global_Variables_from_configfile() method - documents its behavior, parameters, return value, and the automatic prefix stripping feature The documentation explains the automatic prefix stripping behavior that handles cases where users mistakenly include module prefix (e.g., "mysql-") in variable names within configuration files.	4 months ago
Rene Cannao	7ebdf561ca	Fix automatic prefix stripping to work with libconfig lookup The previous implementation stripped the prefix before calling group.lookupValue(), which would fail because the config file contains the prefixed name (e.g., "mysql-log_unhealthy_connections"). The lookup must use the original name from the config file. This commit moves the prefix stripping logic to after the value lookup but before constructing the SQL query, ensuring both: 1. The correct value is retrieved from the config using the original prefixed name 2. The variable is stored in the database with a single prefix Also includes a test to verify the fix works for mysql_variables, pgsql_variables, and admin_variables sections.	4 months ago
Rene Cannao	b4683569d6	Add automatic prefix stripping for mysql_variables, pgsql_variables, and admin_variables config parsing When users mistakenly include the module prefix (e.g., mysql-log_unhealthy_connections) in the mysql_variables section, the variable gets stored with a double prefix (e.g., mysql-mysql-log_unhealthy_connections). This fix automatically strips the prefix if present, ensuring variables are stored correctly. The same logic applies to pgsql_variables (pgsql-) and admin_variables (admin-). Fixes #5246	4 months ago
Rene Cannao	ec1247f2a9	Add Doxygen docs for MySQL_Data_Stream::check_data_flow()	4 months ago
Rene Cannao	4044a40794	Skip bidirectional data check for permanent fast-forward sessions Allow permanent fast-forward sessions (SESSION_FORWARD_TYPE_PERMANENT) to continue processing when bidirectional data flow is detected, instead of treating it as a fatal error. This prevents unnecessary session termination in these specific cases while maintaining the original strict validation for all other session types.	4 months ago
Rahim Kanji	f507903743	Added nested comments support for PostgreSQL	4 months ago
Rahim Kanji	895c814c77	Added utility functions to support pgsql query digest testing	4 months ago
Rahim Kanji	285fb1b4e1	Add PostgreSQL dialect support: dollar-quoted strings, identifier quoting, and dialect-specific comment rules This change introduces PostgreSQL-aware tokenization by adding support for dollar-quoted strings, PostgreSQL’s double-quoted identifiers, and its comment rules. The tokenizer now correctly parses $$…$$ and $tag$…$tag$, treats " as an identifier delimiter in PostgreSQL, disables MySQL-only # comments, and accepts -- as a comment starter without requiring a trailing space. All new behavior is fully isolated behind the dialect flag to avoid impacting MySQL parsing. Add PostgreSQL dollar-quoted strings * New parser state: st_dollar_quote_string. * Recognizes $$ … $$ and $tag$ … $tag$ sequences. * Tracks opening tag and searches for matching terminator. * Normalizes entire literal to ?. * Integrated into get_next_st() and stage_1_parsing().	4 months ago
René Cannaò	b73160ef5f	Merge pull request #4901 from sysown/v3.0_wait_timeout [WIP] Setting client side wait_timeout	5 months ago
René Cannaò	0d55ab5ea2	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
Rene Cannao	5a7b22181f	Fix metrics collection for wait_timeout counters The get_status_variable() function was only scanning worker threads but ignoring auxiliary threads (idle threads) where timeout terminations are detected. This caused the timeout termination counter to show incorrect/zero values. - Added idle thread scanning to both overloaded versions of get_status_variable() function - Now properly collects metrics from both worker and idle threads - Fixes the issue where proxysql_mysql_timeout_terminated_connections_total showed zero despite actual timeout terminations Resolves the metrics reading issue identified in the previous commits.	5 months ago
René Cannaò	65dbe904f0	Merge pull request #5199 from sysown/v3.0_refactor_monitoring_ping Fix artificially high ping latency in MySQL backend monitoring	5 months ago
Rene Cannao	fbf5f2d762	Improve wait_timeout warning messages with detailed connection information Enhance logging clarity: - Replace generic IP address with detailed connection info including IP and port - Use client_myds->addr.addr and client_myds->addr.port for precise identification - Improve debuggability of timeout clamping and enforcement warnings The warning messages now provide complete connection details, making it easier to identify and troubleshoot timeout-related issues in ProxySQL logs.	5 months ago
Rene Cannao	dc4694d656	Refactor idle session scanning and improve test precision Code improvements: - Extract SESS_TO_SCAN_idle_thread constant to header file for better maintainability - Replace magic number 128 with named constant in idle_thread_to_kill_idle_sessions() - Improve code readability and consistency in session scanning logic Test enhancements: - Add mysql-poll_timeout configuration for more precise timeout testing - Reduce test sleep times to 13 seconds for faster test execution - Add diagnostic messages to clearly show timeout configurations in test output - Ensure tests properly validate timeout enforcement with precise timing The changes improve code maintainability and make tests more reliable and faster while maintaining accurate timeout validation.	5 months ago
Rene Cannao	0c5e75a064	Fix wait_timeout timeout calculations and add proper newline characters Key improvements: - Fix timeout comparison in MySQL_Thread::idle_thread_to_kill_idle_sessions() to prevent underflow - Use effective wait_timeout (minimum of global and session values) for idle timeout calculations - Add proper newline characters to proxy_warning messages for consistent log formatting - Increase test sleep times to account for global timeout enforcement - Fix session timeout test durations to properly test timeout behavior Technical changes: - Replace broken min_idle calculation with proper effective wait_timeout logic - Add std::min() usage to determine effective timeout from global and session values - Ensure warning messages end with newline characters for proper log formatting - Update test sleep durations to ensure proper timeout testing Resolves potential timeout calculation bugs and ensures consistent timeout enforcement behavior.	5 months ago
Rene Cannao	df515f91fa	session: Add wait_timeout to proxysql internal session JSON - Include wait_timeout value in session JSON output for monitoring/debugging - Provides visibility into client-configured timeout values	5 months ago
Rene Cannao	0a9dc9dd29	session: Add input validation for client wait_timeout with silent clamping - Add range validation for client SET wait_timeout commands - Implement clamping between 1 second (1000ms) and 20 days (1,728,000,000ms) - Add warning messages when values are clamped due to ProxySQL limits - Maintain MySQL compatibility by accepting larger values than global config - Fix signed/unsigned comparison warning in wait_timeout assignment - Ensures client applications don't break while enforcing safety limits	5 months ago
Rene Cannao	86cc7cd3da	session: Fix wait_timeout member variable declaration and usage - Add wait_timeout member variable declaration to Base_Session class - Fix constructor initialization to use this->wait_timeout - Fix assignment in handler to properly scope member variable - Resolves compilation error for wait_timeout functionality	5 months ago
René Cannaò	b641c0d627	Merge pull request #5232 from sysown/fix/issue-4855 Fix issue 4855: Incorrect affected rows reporting for DDL queries	5 months ago
René Cannaò	0f719d3e7b	Merge pull request #5240 from sysown/v3.0-5062 Improve fast forward replication CLIENT_DEPRECATE_EOF validation (closes #5062)	5 months ago
Rene Cannao	5485bb02f4	Improve fast forward replication CLIENT_DEPRECATE_EOF validation Enhance the match_ff_req_options function to better handle CLIENT_DEPRECATE_EOF flag validation in fast forward replication scenarios. The function now performs a more robust check by examining the actual MySQL command type when the initial CLIENT_DEPRECATE_EOF flags don't match between frontend and backend connections. Key improvements: - Special handling for binlog-related commands (_MYSQL_COM_BINLOG_DUMP, _MYSQL_COM_BINLOG_DUMP_GTID, _MYSQL_COM_REGISTER_SLAVE) that should be allowed even when CLIENT_DEPRECATE_EOF flags don't match - Proper packet parsing to extract and validate MySQL command types - Enhanced compatibility for fast forward replication connections with mixed deprecate EOF configurations This change ensures that ProxySQL can handle more complex replication scenarios while maintaining proper protocol validation.	5 months ago
René Cannaò	3c4e09fec0	Merge pull request #5225 from sysown/v3.0_refactor_prepared_statement_cache_design_5211 Refactored Prepared-Statement Cache Design (Lock-Free Hot Path) - Part 2	5 months ago
Rahim Kanji	7205f424a2	Add SSL support for backend connections in PGSQL monitor	5 months ago
Rahim Kanji	9c0e14a5d1	Replace rand() with lock-free Xoshiro128++ PRNG	5 months ago
René Cannaò	d188715a7d	Merge branch 'v3.0' into fix/issue-4855 Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
René Cannaò	ae30eea64e	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
René Cannaò	27714335ab	Merge pull request #5228 from sysown/v3.0-5212 Add TCP keepalive warnings when disabled (issue #5212)	5 months ago
Rene Cannao	a577491f42	Refactor issue 4855 fix: Use sqlite3_total_changes64 difference approach PROBLEM: The initial fix used a DDL detection approach which required maintaining a list of query types that should return 0 affected rows. This approach was brittle and could miss edge cases like commented queries or complex statements. SOLUTION: Instead of detecting DDL queries, use sqlite3_total_changes64() to measure the actual change count before and after each query execution. The difference between total_changes before and after represents the true affected rows count for the current query, regardless of query type. CHANGES: - Added proxy_sqlite3_total_changes64 function pointer and initialization - Rewrote execute_statement() and execute_statement_raw() to use total_changes difference approach - This automatically handles all query types (DDL, DML, comments, etc.) - Added comprehensive TAP test covering INSERT, CREATE, DROP, VACUUM, UPDATE, and BEGIN operations BENEFITS: - More robust and accurate than DDL detection approach - Handles edge cases like commented queries automatically - No maintenance overhead for new query types - Simpler and cleaner implementation - Still fixes both Admin interface and SQLite3 Server This approach is mathematically sound: affected_rows = total_changes_after - total_changes_before, which gives the exact number of rows changed by the current query execution. Fixes #4855	5 months ago
Rene Cannao	05960b5ddb	Fix issue 4855: Reset affected_rows to 0 for DDL queries in Admin interface Problem: When executing DDL queries (CREATE TABLE, DROP TABLE, VACUUM, etc.) in the ProxySQL Admin interface after DML operations, the affected rows count from the previous DML operation was incorrectly reported instead of 0. This is because SQLite's sqlite3_changes() function doesn't reset the counter for DDL statements. Root Cause: SQLite's sqlite3_changes() returns the number of rows affected by the most recent INSERT, UPDATE, or DELETE statement. For DDL statements that don't modify rows, SQLite doesn't reset this counter, so it continues to return the value from the last DML operation. Solution: - Added is_ddl_query_without_row_changes() function to identify DDL queries that don't affect row counts - Modified both execute_statement() and execute_statement_raw() in SQLite3DB to return 0 for affected_rows when executing DDL queries - The fix ensures that affected_rows is reset to 0 for: CREATE, DROP, ALTER, TRUNCATE, VACUUM, REINDEX, ANALYZE, CHECKPOINT, PRAGMA, BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, EXPLAIN Testing: - Created and ran comprehensive tests for DDL detection function - Verified build completes successfully - Confirmed the fix correctly identifies DDL vs DML queries Impact: This fix resolves the issue where Admin interface incorrectly shows affected rows for DDL operations, improving the accuracy and reliability of the ProxySQL Admin interface. Fixes #4855	5 months ago

1 2 3 4 5 ...

4569 Commits (6c04e2d5fec4954bc7ceac0366c30b3bbbc5e89b)