proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	a7424f0abe	Add protocol encoding/decoding and utility unit tests (Phase 2.5, #5477 ) Unit tests for standalone protocol functions and utility routines covering 43 test cases across 11 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - MySQL length-encoded integer decoding: 1-byte (0-250), 2-byte (0xFC prefix), 3-byte (0xFD prefix), 8-byte (0xFE prefix) - MySQL length-encoded integer encoding: boundary values at each encoding tier (251, 65535, 65536, 16777216) - Encode/decode roundtrip: 10 values across all encoding ranges survive write_encoded_length() → mysql_decode_length_ll() - mysql_hdr packet header: structure size (4 bytes), field packing, 24-bit max length - CPY3/CPY8 byte copy helpers: little-endian semantics, boundary values - MySQL query digest: normalization via mysql_query_digest_and_first_ comment_2(), whitespace collapsing, comment handling, empty query - PgSQL query digest: normalization via pgsql_query_digest_and_first_ comment_2(), whitespace collapsing - escape_string_single_quotes: no-op on clean strings, single quote doubling, multiple quotes - mywildcmp wildcard matching: exact match, % prefix/suffix/both, _ single char, non-match cases, empty string edge cases	1 month ago
René Cannaò	89016046a6	Merge pull request #5487 from sysown/v3.0-5476 Query Processor rule management unit tests (Phase 2.4)	1 month ago
René Cannaò	b25cf6d54f	Address review feedback on query processor unit tests (PR #5487 ) - test_mysql_reset_all: remove 2 leaked mysql_simple_rule() calls whose return values were discarded (memory leak under ASAN) - test_mysql_rule_creation: fix misleading "Don't free" comment — rule is NOT inserted into QP and IS freed manually - test_init.cpp: free individual strings from get_variables_list() before freeing the array (was leaking all variable name strings) - test_init.cpp: fix misleading comment claiming GloMTH/GloPTH are cleaned up by test_cleanup_minimal() — they rely on process exit	1 month ago
René Cannaò	c57bd36e98	Add query_processor_unit-t to build and fix QP initialization - tests/unit/Makefile: Register query_processor_unit-t in build system - test_init.cpp: Create MySQL_Threads_Handler and PgSQL_Threads_Handler in test_init_query_processor() since QP constructors read variables from GloMTH/GloPTH. Trigger lazy initialization of VariablesPointers maps via get_variables_list() before constructing QP instances. Add extern declaration for GloPTH (not declared in any header).	1 month ago
René Cannaò	76f1f2f5cd	Add Query Processor rule management unit tests (Phase 2.4, #5476 ) Comprehensive unit tests for MySQL_Query_Processor and PgSQL_Query_ Processor covering 42 test cases across 10 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - Rule creation via new_query_rule() with all 35 fields verified - Rule field storage: username, schemaname, match_digest, match_pattern, destination_hostgroup, cache_ttl, timeout, retries, sticky_conn, multiplex, apply, log, client_addr, comment - Regex modifier parsing: CASELESS, GLOBAL, combined (CASELESS,GLOBAL) - Rule insertion, sorting by rule_id, and commit - Rule retrieval via get_current_query_rules() SQLite3 result - Sort verification: rules inserted in reverse order, sorted ascending - Special fields: error_msg, OK_msg, replace_pattern - flagIN/flagOUT chaining setup - Username filter rules - reset_all() clears all rules - get_stats_commands_counters() returns valid result - PgSQL rule creation, insertion, and reset Note: Full process_query() testing requires a MySQL_Session with populated connection data, which is beyond isolated unit tests. The existing E2E TAP tests cover those scenarios.	1 month ago
René Cannaò	17f9a0fb21	Merge pull request #5486 from sysown/v3.0-5475 Query Cache unit tests (Phase 2.3)	1 month ago
René Cannaò	bcba8039cd	Address review feedback on query cache unit tests (PR #5486 ) - test_pgsql_flush: flush() at start for clean state, assert == 10 - test_mysql_construction_and_flush: fix tautology (flushed == 0 \|\| flushed >= 0 is always true for uint64_t), double-flush to ensure empty cache, then assert == 0 - test_pgsql_purge_expired: use max_memory_size=1 instead of 1GB to force the purge path to actually run (3% threshold wasn't reached) - test_pgsql_many_entries: fix misleading docstring claiming hash table distribution verification	1 month ago
Rene Cannao	86e86c8ce3	Fix parallel coverage collection and improve multi-group runner - Fix code coverage race condition: Each ProxySQL instance now writes .gcda files to its own directory using GCOV_PREFIX, preventing parallel groups from overwriting each other's coverage data - Add TAP_USE_NOISE documentation for noise injection testing - Replace random stagger delay with sequential delay (STAGGER_DELAY) to guarantee proper spacing between group startups - Update README with multi-group runner, coverage, and noise injection docs	1 month ago
René Cannaò	5129d55d00	Merge pull request #5484 from sysown/v3.0-issue5483 Fix TSDB TAP tests for Docker-based CI	1 month ago
René Cannaò	2ae866b59c	Add query_cache_unit-t to build and init Prometheus registry - tests/unit/Makefile: Register query_cache_unit-t in the build system - test_init.cpp: Create a real Prometheus registry in test_init_query_ cache() since the Query_Cache constructor registers metrics via GloVars.prometheus_registry (nullptr would crash)	1 month ago
René Cannaò	96387be177	Add Query Cache unit tests (Phase 2.3, #5475 ) Comprehensive unit tests for MySQL_Query_Cache and PgSQL_Query_Cache covering 26 test cases across 11 test functions. Runs in <0.01s with no infrastructure dependencies. PgSQL_Query_Cache is used for most tests because its set()/get() API is simpler (no MySQL protocol parsing required). The underlying Query_Cache<T> template logic is identical for both protocols. Test coverage: - Basic set/get cycle with value verification - Cache miss on nonexistent key - User hash isolation (same key, different user_hash = miss) - Cache replacement (same key overwrites previous value) - Hard TTL expiration (expire_ms in the past) - Soft TTL expiration (cache_ttl parameter to get()) - flush() clears all entries and returns correct count - Set/flush cycle (entry retrievable then unretrievable) - Stats counters (SET and GET via SQL3_getStats()) - SQL3_getStats() result format (2 columns, has rows) - MySQL_Query_Cache construction, flush, and SQL3_getStats() - purgeHash() eviction of expired entries (live entries survive) - Bulk insert (100 entries) across 32 internal hash tables Key implementation note: Query_Cache constructor requires a valid Prometheus registry (GloVars.prometheus_registry). The test_init_ query_cache() helper creates one automatically.	1 month ago
Rene Cannao	ca409366cb	Address review feedback on TSDB tests - Use cl.admin_host instead of cl.host for admin HTTP endpoints - Don't log auth credentials (security issue) - Fail fast when prerequisite SET/LOAD commands fail - Assert on specific test_downsample_metric rows in hourly table	1 month ago
René Cannaò	b187f9ac96	Address review feedback on test harness (PR #5482 ) Fixes from Copilot and Greptile review comments: - test_globals.cpp: Replace fixed-size datadir_buf[256] with std::string to avoid truncation on long TMPDIR paths - test_globals.cpp: Initialize glovars.has_debug to match build type (DEBUG vs release) so component constructors that validate debug compatibility do not abort - test/tap/Makefile: Remove 'tap' dependency from unit_tests target since unit tests compile tap.o directly and don't need the full libtap.so/cpp-dotenv build chain. Also remove $(MAKECMDGOALS) pass- through which would cause failures when invoked as 'make unit_tests' - tests/unit/Makefile: Fix default goal — make 'all' the first target so 'make' without arguments builds unit tests correctly	1 month ago
Rene Cannao	809878c253	Fix TSDB TAP tests for Docker-based CI test_tsdb_variables-t: - Add verbose logging for downsampling test - Insert test data with timestamps from 2 hours ago before downsampling - The TSDB downsample logic only processes completed hours, so we need historical data for the test to succeed - Add cleanup of test data after the test test_tsdb_api-t: - Use configurable host from environment (cl.host) instead of hardcoded 127.0.0.1 - Add verbose logging for configuration and test progress - Use proper authentication credentials from command line - Increase retries for dashboard endpoint - Add detailed error messages Fixes #5483	1 month ago
Rene Cannao	4dcabbc7ec	Move test_utf8mb4_as_ci-4841-t to mysql84-g1 group only This test requires MySQL 8.0+ for utf8mb4_0900_as_ci collation support. Removed from legacy-g4 and all g4 variants since they don't have MySQL 8.	1 month ago
René Cannaò	a538532d59	Fix tap.cpp compilation on macOS: add ulong typedef The 'ulong' type is not defined on macOS/Darwin. Add a conditional typedef to enable TAP test compilation on macOS without affecting Linux builds.	1 month ago
René Cannaò	77ae235ea2	Integrate unit tests into TAP build system Adds unit_tests target to test/tap/Makefile so that unit tests are built alongside existing TAP tests via 'make build_tap_tests'. Also adds the unit test directory to clean/cleanall targets.	1 month ago
René Cannaò	43c04fb394	Add unit test Makefile and smoke test Adds the build system and initial smoke test for the unit test framework (Phase 2.1, #5473). - test/tap/tests/unit/Makefile: Compiles unit test binaries linked against libproxysql.a + test_globals.o. Compiles tap.o directly from tap.cpp to avoid the cpp-dotenv dependency chain, making unit tests buildable on both Linux and macOS. Handles platform-specific linker flags (Darwin vs Linux). - test/tap/tests/unit/smoke_test-t.cpp: Validates the test harness by exercising test_init_minimal() (GloVars setup), test_init_auth() (MySQL_Authentication add/lookup/exists cycle), and idempotency of all init/cleanup functions. Runs in <1 second with no Docker or network dependencies.	1 month ago
René Cannaò	803eb27590	Add unit test harness: Glo* stubs and component init helpers Introduces the test infrastructure foundation for Phase 2.1 (#5473) of the unit testing framework (#5472). This enables unit test binaries to link against libproxysql.a without main.cpp, allowing individual components to be tested in isolation. New files: - test/tap/test_helpers/test_globals.h/.cpp: Stub definitions for all 25 Glo* global pointers and the PROXYSQL_EXTERN-based variable definitions (GloVars, MyHGM, PgHGM, __thread vars, tracked vars). Also stubs symbols from src/ (proxy_tls, SQLite3_Server, binary_sha1) and TAP noise testing functions. - test/tap/test_helpers/test_init.h/.cpp: Component initialization helpers (test_init_minimal, test_init_auth, test_init_query_cache, test_init_query_processor) with matching cleanup functions. All are idempotent and safe to call multiple times.	1 month ago
Rene Cannao	186ce308c6	Fix test_sqlite3_pass_exts plan for MySQL version differences Move plan() call after MySQL version detection to set correct test count: - MySQL 8.0+: 2213 tests (includes BY RANDOM PASSWORD tests) - MySQL 5.7: 2012 tests (skips BY RANDOM PASSWORD tests) Previously the test always planned 2213 tests, causing TAP failures when running against MySQL 5.7 because only 2113 tests executed.	1 month ago
Rene Cannao	4a0300f844	Fix test_query_rules_routing for Docker-based CI - complete fix Two additional issues fixed: 1. Query hint hostgroup: ProxySQL query hints like /* ;hostgroup=0;... */ were hardcoded to hostgroup 0. Now dynamically replaced with the discovered writer hostgroup. 2. Also removed hardcoded TAP_MYSQLPASSWORD=root from test_sqlite3_pass_exts-t.env to allow infrastructure-provided password to be used.	1 month ago
Rene Cannao	e9a16550c6	Improve test_query_rules_routing hostgroup discovery - Query runtime_mysql_users instead of mysql_users for default_hostgroup - Use mysql_replication_hostgroups to find writer/reader hostgroup pairs - Fallback to runtime_mysql_servers if no replication hostgroups configured - Remove hardcoded TAP_MYSQLPASSWORD from test_sqlite3_pass_exts-t.env These changes allow tests to work correctly with Docker-based CI infrastructure where hostgroups may differ from hardcoded defaults.	1 month ago
René Cannaò	9b482eb076	Merge pull request #5471 from sysown/add-claude-github-actions-1774116391376 Add Claude Code GitHub Workflow	1 month ago
René Cannaò	a902a9ccfd	"Claude Code Review workflow"	1 month ago
René Cannaò	8792cf35b6	"Claude PR Assistant workflow"	1 month ago
Rene Cannao	f2db3cbb1e	Fix test_sqlite3_pass_exts for Docker-based CI infrastructure Remove hardcoded TAP_MYSQLPORT=14806 from test .env files to use the infrastructure-provided port (3306). The hardcoded port was causing connection failures when tests run inside Docker containers.	1 month ago
Rene Cannao	7bbda48f29	Fix test_query_rules_routing for Docker-based CI infrastructure - Add dynamic hostgroup discovery from mysql_servers table - Replace hardcoded hostgroups (0, 1) with discovered ones (e.g., 1300, 1301) - Add comprehensive debugging output for troubleshooting: - Current server and user configuration - Discovered hostgroups - Query execution details (before/after counts) - Routing failures with specific queries The test was failing because it used hardcoded hostgroups 0 and 1, but the Docker CI infrastructure uses dynamic hostgroups (1300, 1301, etc.) depending on the infrastructure type.	1 month ago
Rene Cannao	e3ccdb7d12	Fix test_load_from_config_validation for Docker-based CI - Use REGULAR_INFRA_DATADIR environment variable for config file path (falls back to /tmp for local mode) - Add initial diag messages describing test purpose - Add step-by-step debugging messages during test execution - Update file header comment with test description This fixes the issue where ProxySQL running in a Docker container couldn't access config files created in /tmp on the test runner host.	1 month ago
Rene Cannao	0bc75cd589	Fix test validation and coverage HTML generation - Fix false positive "missing tests" errors when processing secondary workdirs (e.g., deprecate_eof_support). The validation now only checks tests that actually exist in the current workdir rather than all tests in groups.json for the TAP_GROUP. - Add --ignore-errors negative,source --synthesize-missing flags to genhtml calls in run-tests-isolated.bash to match the multi-group runner and prevent HTML generation failures on coverage data with negative branch counts.	1 month ago
Rene Cannao	179644fed9	Fix ClickHouse test: use 0.0.0.0 interface for Docker compatibility The interface was set to 127.0.0.1 which is not accessible from another container. Changed to 0.0.0.0 which is replaced by the extract_module_host_port function with the correct hostname. Also update expected row count from 2 to 3 due to additional successful INSERT.	1 month ago
Rene Cannao	8ec472c771	Fix ClickHouse test: update expected row count after MergeTree fix After updating to new MergeTree syntax, the INSERT with NULL values now succeeds, resulting in 3 rows instead of 2.	1 month ago
Rene Cannao	3f91a44770	Fix ClickHouse tests: update MergeTree syntax and handle 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8ash - Added explicit `clickhouse-only` test group for isolated testing - Added quotes around hostname value in SET statements - Fixed 0.0.0 Docker.com doesn (including quotes around MergeTree syntax)	1 month ago
Rene Cannao	47907c2ead	Move test_client_limit_error-t to todo-g1 group This test uses network namespaces which don't work in Docker containers. Moving to todo-g1 for later review.	1 month ago
Rene Cannao	eac1adf7e1	Fix clickhouse tests for Docker-based CI infrastructure - Fix variable name: 'clickhouse-host' -> 'clickhouse-hostname' - Add quotes around hostname value in SET command - Handle 0.0.0.0 bind address: use 'proxysql' container hostname in Docker mode, or '127.0.0.1' for local execution	1 month ago
Rene Cannao	3acd6b31d6	Fix max_connections_ff-t: Use dynamic hostgroup discovery - Add discover_user_hostgroup() helper function to query default_hostgroup from mysql_users table instead of hardcoding hostgroup=0 - Update test_ff_sess_exceeds_max_conns() to use discovered hostgroup - Update test_ff_only_one_free_conn() to use discovered hostgroup - Update documentation to reflect dynamic hostgroup discovery - Add test/README.md with local CI execution instructions This allows the test to work with any infrastructure configuration (e.g., isolated CI where sbtest1 uses hostgroup 1300 instead of 0).	1 month ago
Rene Cannao	3ac0c2dd8a	Fix legacy TAP tests: clickhouse_php_conn and reg_test_3317 - clickhouse_php_conn-t.php: Fix deprecated ClickHouse MergeTree syntax Change from deprecated ENGINE=MergeTree(EventDate, (EventDate), 8192) to new syntax ENGINE=MergeTree() ORDER BY (EventDate) - reg_test_3317-lock_hostgroup_special_queries-t.cpp: Add query annotations Add /* ;hostgroup=1300 */ hints to SELECT statements to ensure proper routing when connection is locked to hostgroup 1300	1 month ago
Rene Cannao	730f77e64e	test: add summary and step-by-step reporting to TLS stats TAP test	1 month ago
Rene Cannao	7ee1332633	Add --ignore-errors source and --synthesize-missing to genhtml Fixes HTML generation errors for missing system headers like /usr/include/c++/13/bits/predefined_ops.h	1 month ago
Rene Cannao	20fc53e45c	Fix code coverage collection in multi-group test runner 1. Add set -e to run-multi-group.bash heredoc for proper error handling 2. Add EXIT trap in run-tests-isolated.bash to collect coverage on timeout/failure 3. Pass COVERAGE_MODE, COVERAGE_REPORT_DIR, and SCRIPT_DIR env vars to container 4. Fix fastcov invocation to use -e deps/ instead of restrictive -i filters 5. Add per-group HTML report generation 6. Run coverage combination in container for host without tools Coverage is now collected for: - include/ (189 header files) - lib/ (109 library files) - src/ (4 source files) The EXIT trap ensures coverage is collected even when tests timeout.	1 month ago
Rene Cannao	2e552b8ae8	fix(tls): improve SSL/TLS certificate tracking and fix memory leaks - lib/ProxySQL_GloVars.cpp: Free tls_cert_file, tls_ca_file, and tls_key_file in ProxySQL_GlobalVariables destructor. - src/proxy_tls.cpp: Added std::lock_guard during initial bootstrap of TLS variables to prevent race conditions. - src/proxy_tls.cpp: Ensure TLS file paths are updated in GloVars during PROXYSQL RELOAD TLS to keep stats table consistent with runtime configuration.	1 month ago
Rene Cannao	30620f37c4	Revert "Move coverage collection inside Docker container" This reverts commit `e571f08a45`.	1 month ago
Rene Cannao	e571f08a45	Move coverage collection inside Docker container Coverage collection now runs INSIDE the test-runner container immediately after tests complete (whether they succeed, fail, or timeout). This ensures: 1. Coverage data is collected even if the parent script times out 2. The .info file is generated inside the container before it exits 3. No dependency on external docker exec after container stops Also removes the external coverage collection code that was unreachable when timeout killed the subshell.	1 month ago
Rene Cannao	d9e9f2f059	Add coverage tools (lcov, fastcov) to proxysql-ci-base Docker image - Add lcov package for coverage report generation - Install fastcov via pip3 for faster coverage processing - Required for COVERAGE=1 mode in multi-group test runner	1 month ago
Rene Cannao	5f25df6c61	Improve test startup staggering with group-based hash	1 month ago
Rene Cannao	dcef810b99	Fix inner_exit_code unbound variable in run-multi-group.bash	1 month ago
copilot-swe-agent[bot]	bbcc67b339	fix: harden restapi config inserts Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/40d309f0-bd3d-4616-9cd6-fa7d8f1cb355	1 month ago
Rene Cannao	9256a4c2f2	Fix heredoc variable expansion in run-multi-group.bash	1 month ago
copilot-swe-agent[bot]	04c5e58e6b	fix: escape restapi config values Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/40d309f0-bd3d-4616-9cd6-fa7d8f1cb355	1 month ago
copilot-swe-agent[bot]	8d358cbfdc	feat: load restapi routes from config aliases Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/40d309f0-bd3d-4616-9cd6-fa7d8f1cb355	1 month ago
Rene Cannao	5004d827b1	Fix proxysql-tester.py to fail when expected tests don't run	1 month ago

... 2 3 4 5 6 ...

9172 Commits (61fc7a129cd90cef3fcbb40b4ef786462e2de651) All Branches Search

9172 Commits (61fc7a129cd90cef3fcbb40b4ef786462e2de651)

All Branches