proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	700459f67b	tsdb: address AI code review feedback, fix memory safety and logic bugs Summary of changes: - Fixed allocator mismatches (sqlite3_free vs free) across multiple files. - Converted manual SQL construction to prepared statements for TSDB variables. - Resolved memory leaks in statistics and monitoring loops. - Fixed critical 'LOAD TSDB VARIABLES FROM CONFIG' command mismatch. - Improved command parsing robustness using string searching. - Standardized SQL LIKE patterns with escaped wildcards (\%). - Switched to data-driven variable management in ProxySQL_Statistics. - Improved web dashboard security with URL encoding and const correctness. - Clarified documentation regarding configuration lifecycle and schema names. - Updated TAP tests for better reliability and correct persistence verification.	4 months ago
Rene Cannao	b8c6b4f573	tsdb: address code review comments and improve stability - Refactored variable flushing to use prepared statements for safety. - Replaced brittle command parsing with robust string searching. - Extracted TSDB dashboard HTML/JS to separate source file for maintainability. - Added NULL guards for GloProxyStats in Admin and REST API. - Implemented batched metric insertions using transactions for performance. - Refactored backend probing to use non-blocking connect() with timeout. - Fixed potential integer overflows in timer calculations. - Improved error handling and fixed memory leaks in statistics reporting. - Updated TAP tests to verify UI and REST API functionality.	4 months ago

Author

SHA1

Message

Date

Rene Cannao

700459f67b

tsdb: address AI code review feedback, fix memory safety and logic bugs

Summary of changes:
- Fixed allocator mismatches (sqlite3_free vs free) across multiple files.
- Converted manual SQL construction to prepared statements for TSDB variables.
- Resolved memory leaks in statistics and monitoring loops.
- Fixed critical 'LOAD TSDB VARIABLES FROM CONFIG' command mismatch.
- Improved command parsing robustness using string searching.
- Standardized SQL LIKE patterns with escaped wildcards (\%).
- Switched to data-driven variable management in ProxySQL_Statistics.
- Improved web dashboard security with URL encoding and const correctness.
- Clarified documentation regarding configuration lifecycle and schema names.
- Updated TAP tests for better reliability and correct persistence verification.

Rene Cannao

b8c6b4f573

tsdb: address code review comments and improve stability

- Refactored variable flushing to use prepared statements for safety.
- Replaced brittle command parsing with robust string searching.
- Extracted TSDB dashboard HTML/JS to separate source file for maintainability.
- Added NULL guards for GloProxyStats in Admin and REST API.
- Implemented batched metric insertions using transactions for performance.
- Refactored backend probing to use non-blocking connect() with timeout.
- Fixed potential integer overflows in timer calculations.
- Improved error handling and fixed memory leaks in statistics reporting.
- Updated TAP tests to verify UI and REST API functionality.

2 Commits (5b5bbfbcaf60ecee1ab502ec40a00a6f2e8a5723)