15 Commits (55556979e0851df166125107da87f43537e7fb4f)

Author	SHA1	Message	Date
Rene Cannao	55556979e0	feat(plugin-abi): Step 2.1 — pre-execution query-hook ABI + dispatch ... First half of Step 2 from the GenAI plugin carve-out design (see docs/superpowers/specs/2026-04-16-genai-plugin-carveout-design.md). Adds the query-hook ABI surface and the manager-level dispatch, but NOT yet the hot-path call sites in MySQL_Session / PgSQL_Session -- those are intentionally split into the next commit so the hot-path diff stays small and reviewable on its own. ABI extension (include/ProxySQL_Plugin.h): - ProxySQL_PluginProtocol enum {mysql, pgsql} - ProxySQL_PluginQueryHookPayload {user, client_ip, schema, query_text, query_len} - ProxySQL_PluginQueryHookAction enum {allow, deny} - ProxySQL_PluginQueryHookResult {action, message} - proxysql_plugin_query_hook_cb typedef - proxysql_plugin_register_query_hook_cb typedef - new field on ProxySQL_PluginServices: register_query_hook (additive at the end of the struct -- older plugins that were built against the previous layout don't read past it; new plugins must check non-null before calling, same convention used elsewhere) Manager (lib/ProxySQL_PluginManager.cpp + .h): - One hook per protocol per manager (nullptr means "no hook"). - register_query_hook(proto, cb): rejects null cb; rejects duplicate registration for a protocol that already has a hook; surfaces registration errors through the same note_registration_failure / init-aborts path that register_table and register_command use. - dispatch_query_hook(proto, payload, result): synchronous, returns true if a hook fired and stored its result, false otherwise. - has_query_hook(proto): cheap predicate for the hot-path predicate. Global helpers (for the hot path, next commit): - proxysql_dispatch_configured_plugin_query_hook(proto, payload, result): takes the active-manager mutex, dispatches if there is one. - proxysql_has_configured_plugin_query_hook(proto): lock-free atomic read of the manager pointer + a pointer-sized field read. Designed to be the gate the hot path checks first; the dispatch call can be elided entirely on the no-plugin path. Documented as spurious-true-tolerant -- the dispatch helper re-checks under the lock. Test plugin extension (test/tap/test_helpers/fake_plugin.cpp): - New env vars PROXYSQL_FAKE_PLUGIN[2]_REGISTER_QUERY_HOOK, REGISTER_QUERY_HOOK_PROTO ("mysql"|"pgsql"), HOOK_DENY. - fake_query_hook echoes the SQL through the result message so tests can verify the payload reached the callback intact. New unit test: plugin_query_hook_unit-t (41 assertions) - empty manager: neither protocol has a hook, dispatch returns false, result struct untouched - register MySQL allow hook → dispatch returns ALLOW with empty msg - register MySQL deny hook → dispatch returns DENY with the message - null callback rejected; duplicate registration rejected; original hook still in effect after rejected duplicate - protocols are independent (mysql allow + pgsql deny coexist) - payload threaded through (echo hook reads user/ip/schema/sql) - global dispatcher: false when no active manager, untouched result - global dispatcher with active manager: routes to the fake plugin's hook, propagates ALLOW vs DENY (env-flipped between calls), and goes back to false after stop_configured_plugins All 59 unit-test binaries pass.	1 month ago
Rene Cannao	3d107c3bed	chore: commit pre-existing plugin manager improvements ... Improvements left uncommitted at the end of Step 0: - atomic g_active_plugin_manager pointer - reject plugin descriptors with null/empty name - assert single-threaded init phase - debug-log dispatched plugin commands - propagate mysqlx_register_admin_schema failure into init - additional plugin manager unit tests (init/start/stop fail, double load) - updated ABI doc/comments for table copy semantics, command context lifetime, services availability, and status_json storage	1 month ago
Rene Cannao	04c0303ee9	fix(mysqlx): address critical code review feedback from PR #5593 ... - PluginManager: don't mark plugin stopped when stop() fails - PluginManager: add mutex to proxysql_get_plugin_manager() access - PluginManager: reject duplicate plugin paths in load() - mysqlx_thread: add listener_mutex_ for listener_fds_ synchronization - mysqlx_config_store: return tls_mode by value, not by reference - Makefile: propagate PROXYSQLGENAI/31/FFTO/TSDB flags to mysqlx builds	1 month ago
Rene Cannao	d34fb38162	refactor: remove PLUGIN prefix gate from plugin command registration ... Remove the 'PLUGIN ' prefix requirement from the plugin manager's command registration and dispatch. This allows plugins to register any canonical command string (e.g. 'LOAD MYSQLX USERS TO RUNTIME') instead of being forced into the 'PLUGIN <name> ...' namespace. Changes to lib/ProxySQL_PluginManager.cpp: - Delete kPluginCommandPrefix constant and has_plugin_command_prefix() - Remove prefix validation from register_command() - now only rejects empty canonical forms - Remove prefix check from dispatch_admin_command() - any registered command string can be dispatched Updated plugin_registry_unit-t.cpp to use canonical 'LOAD MYSQLX USERS TO RUNTIME' syntax instead of 'PLUGIN MYSQLX LOAD USERS TO RUNTIME'. The 'SELECT 1' test now succeeds (any string accepted) since the namespace restriction is gone.	2 months ago
Rene Cannao	7cc246c71f	fix: core plugin ABI safety issues ... 1. Init ordering: move LoadConfiguredPlugins() after ProxySQL_Main_init_Admin_module() so get_admindb/configdb/statsdb return valid handles during plugin init(), not nullptr. 2. Null snapshot callbacks: assign stub functions returning nullptr to get_mysql_users_snapshot, get_mysql_servers_snapshot, and get_mysql_group_replication_hostgroups_snapshot instead of leaving them as null function pointers that crash when called. 3. Lifecycle: stop_all() now only calls stop() on plugins where started=true, not merely initialized. Prevents calling stop() on plugins that were never start()ed. 4. Destructor: remove unsynchronized read of g_active_plugin_manager (callers already clear it under the mutex before destruction).	2 months ago
Rene Cannao	9b87260b70	fix: harden plugin init failures and command dispatch	2 months ago
Rene Cannao	5dd717a8f1	fix: fail fast on plugin table conflicts	2 months ago
Rene Cannao	d036ba8327	fix: canonicalize plugin command registration	2 months ago
Rene Cannao	2430516600	fix: reject conflicting plugin registrations	2 months ago
Rene Cannao	123bb7eaf0	fix: harden plugin registry ABI and ownership	2 months ago
Rene Cannao	fd5f029474	fix: expose plugin db handles during startup	2 months ago
Rene Cannao	cd15afdd1e	feat: support plugin-owned admin tables and commands	2 months ago
Rene Cannao	80fa6bee24	fix: cover configured plugin lifecycle wiring	2 months ago
Rene Cannao	da7e182719	fix: align plugin loader ABI and tests	2 months ago
Rene Cannao	7e1a12b8f7	feat: add generic plugin ABI and loader	2 months ago