245 Commits (4838d75cd3e8450029e69964c01c4fbe85f13a84)

Author	SHA1	Message	Date
Javier Jaramago Fernández	0a37981529	Added comments for the fix introduced for #3603	5 years ago
Javier Jaramago Fernández	d81af3faf5	Fixed invalid preservation of old 'NULL' values for previously executed stmt #3603	5 years ago
René Cannaò	42fad778e3	Do not copy MYSQL_TS if length is 0 ... Related to issue #3585 A prepared statement with buffer_type = MYSQL_TYPE_TIME (or similar like MYSQL_TYPE_DATE, etc) can have length = 0 if the time is 0. In this case no data needs to be copied from COM_STMT_EXECUTE packet	5 years ago
René Cannaò	0bef2e8149	Correctly bind parameters if new_params_bound_flag is not provided ... See issue #3585 . If new-params-bound-flag is not provided by the client while executing COM_STMT_EXECUTE , proxysql was incorrectly computing the length of parameters. The issue was happening only if there were null parameters. Removing comment	5 years ago
René Cannaò	0da250ec8d	Merge pull request #3491 from csoulios/ldap-auth-changes ... Clean up LDAP authenticator	5 years ago
René Cannaò	dafda29a1a	Merge pull request #3573 from sysown/v2.x-3546 ... Closes #3546: Frequent ProxySQL crashes since v2.1.x	5 years ago
René Cannaò	05fa6c23cf	Merge pull request #3569 from sysown/v2.x-3554 ... Closes 3554: Add support for building ProxySQL with ASAN	5 years ago
Javier Jaramago Fernández	25df228960	Fixed double-free memory corruption due to unitialized memory in prepared statements bind buffers #3546	5 years ago
Javier Jaramago Fernández	0f8aa299ac	Fixed memory corruption reported by ASAN due to unexpected packet by 'mysqlsh' #3554	5 years ago
René Cannaò	3de13665e8	Merge pull request #3557 from sysown/v2.x-ccov2 ... More code coverage	5 years ago
René Cannaò	194243503a	Adding LCOV_EXCL_START around assert(0) ... LCOV_EXCL_START and LCOV_EXCL_STOP around assert(0) will improve code coverage	5 years ago
René Cannaò	22f2204745	Removed unused code	5 years ago
René Cannaò	7f0b358ed8	Merge pull request #3544 from sysown/v2.x-3525 ... Closes #3525: Memory leak induced by 'stmts' not being closed when failed to prepare	5 years ago
Javier Jaramago Fernández	4ea7b750fd	Moved helper function 'proxy_mysql_stmt_close' from 'gen_utils' to 'MySQL_Protocol' #3525	5 years ago
René Cannaò	fce7a0204c	Handle binary protocol resultset with ERR #3547 ... This commit add the support of ERR packet in binary protocol resultset, for example due to MAX_EXECUTION_TIME while running a prepared statement. It also changes how EOF packets are added: instead of writing the EOF in the resultset buffer, the EOF packet is written in its own packet. This allows to easily remove it if needed. It also fix what seems (not sure) a bug in MariaDB client library, where if a prepared statement is interrupted it cannot be executed again	5 years ago
Christos Soulios	9d19c70e8c	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Christos Soulios	21803220e1	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Christos Soulios	7df71035ff	Converted strncmp to strcmp	5 years ago
René Cannaò	beddc41b1f	Cleanup of dead code in MySQL_Protocol	5 years ago
Christos Soulios	df19d16f14	Passed attributes as param to LDAP auth ... Removed ldap_ctx as ldap context is managed in the plugin itself	5 years ago
René Cannaò	52f1d0f1ec	Per-user default transaction isolation level ... See issue #3465 If a user (configurable) connects to proxysql without specifying a session transaction isolation level, proxysql will automatically assigns one to that user connection. Of course, said user can override such default session transaction isolation level running `SET SESSION TRANSACTION ISOLATION LEVEL` on a per-connection basis. This feature can be configured extending `mysql_users.attributes` , adding an object named `default-transaction_isolation` . An example of configuration could be: ``` UPDATE mysql_users SET attributes='{"default-transaction_isolation":"READ COMMITTED"}' WHERE username='sbtest'; ``` This feature also requires input validation making sure that only valid isolation levels are used. Furthermore, both dash and space can be used. If the isolation level specified is not valid, it should be automatically removed from runtime.	5 years ago
René Cannaò	2b8500aa36	Do not allow CHANGE_USER with spiffe ... If a client connection uses spiffe, CHANGE_USER is not allowed	5 years ago
René Cannaò	7c0bde5f99	Working prototype for SPIFFE	5 years ago
René Cannaò	259d07c9ab	Merge pull request #3295 from sysown/v2.1.0-ps_buffer ... V2.1.0 ps buffer	5 years ago
Javier Jaramago Fernández	8141642bfc	Merge branch 'v2.1.1' into v2.1.1-3280	5 years ago
René Cannaò	fca4055b50	Merge branch 'v2.1.1' into v2.1.0-ps_buffer	5 years ago
René Cannaò	e0bdb24ddf	Added support for charset during COM_CHANGE_USER ... When processing COM_CHANGE_USER from a client, we did not parse the charset/collation. This commit parses and processes also charset in COM_CHANGE_USER	5 years ago
Javier Jaramago Fernández	1ee832affd	Closes #3280: Add support to control 'CLIENT_DEPRECATE_EOF' in client and backend connections through global variables	5 years ago
René Cannaò	dacea25866	Implemented MySQL_Protocol::generate_pkt_field2() ... `generate_pkt_field2` is a less generic version of `generate_pkt_field` and it is meant to be used only for queries executed on backend. The function takes a `MYSQL_FIELD` as one of its arguments, thus a lot of lengths do not need to be computed	5 years ago
René Cannaò	7921e130d2	Third commit to buffer resultsets in Prepared Statements ... * MySQL_ResultSet() stores a pointer to the PS * MySQL_ResultSet::init_with_stmt() doesn't need anymore the pointer to the PS Furthermore, it isn't anymore an "init" but an end (we will rename it) * Added MySQL_ResultSet::add_row(MYSQL_ROWS *rows) for PS only * MySQL_Protocol::generate_pkt_row3() accepts an optional row length. If passed, it will know the length of the row without computing it * MyRS initialized during ASYNC_STMT_EXECUTE_STORE_RESULT_START * Implemented throttling during ASYNC_STMT_EXECUTE_STORE_RESULT_START * MySQL_Connection::process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT() always generates a heartbeat. For now unnecessary, and we will better tune it later * test_ps_async-t.cpp tunes mysql-threshold_resultset_size to trigger buffering More testing is required	5 years ago
René Cannaò	0171082448	Adding MySQL_ResultSet::init_with_stmt() ... This new function is meant to split MySQL_ResultSet::init() to later remove all code specific to prepared statements because it assumes it is pre-buffered	5 years ago
René Cannaò	7d0ac031b3	Removed a local variable	5 years ago
Javier Jaramago Fernández	3a8b1bce42	Fixed enforcing 'CLIENT_MULTI_RESULTS' for client connections specifying 'CLIENT_MULTI_STATEMENTS'	5 years ago
René Cannaò	9225edbddd	Merge branch 'v2.1.0' into v2.1.0-deprecate_eof	5 years ago
Bibek Shrestha	60f2151fe1	Fix special queries response for CLIENT_DEPRECATE_EOF ... Few special queries are handled separately in ProxySQL 1. select @@version_comment limit 1 2. SHOW WARNINGS 3. SELECT USER() 4. PROXYSQL INTERNAL SESSION 5. SELECT LAST_INSERT_ID() 6. SELECT CONNECTION_ID() 7. C code mysql_set_server_option(mysql, MYSQL_OPTION_MULTI_STATEMENTS_ON) We now remove EOF1 for these and respond with OK packets intead of EOF2	5 years ago
Bibek Shrestha	205b23acb8	Do not support CLIENT_DEPRECATE_EOF on AdminModule	5 years ago
Bibek Shrestha	81849b6141	No EOF Packet in COM_STMT_PREPARE_OK if CLIENT_DEPRECATE_EOF enabled. ... COM_STMT_PREPARE_OK contains the following packetrs 1. An OK packet with header = 0x00 2. Param Definition Block (Optional) + EOF Packet 3. Column Definition Block (Optional) + EOF Packet Both EOF Packet are no longer sent if CLIENT_DEPRECATE_EOF flag is enabled by client. Signed-off-by: Bibek Shrestha <bibekshrestha@gmail.com>	5 years ago
Bibek Shrestha	28c01e9b4d	Send OK packet after ResultSet ... When CLIENT_DEPRECATE_EOF flag is supported by client, the first EOF packet after Metadata is not sent anymore. The EOF packet after each ResultSet is replaced by an OK packet. Signed-off-by: Bibek Shrestha <bibekshrestha@gmail.com>	5 years ago
Bibek Shrestha	58b4520c0d	Add CLIENT_DEPRECATE_EOF to capabilities flag ... Note that "\x8f\x80\x15" is in reverse byte order. So the flag becomes 15808f. 15 - Authenticatin plugin length 80 - 10000000 (unused) 8f - 10001111 (the leftmost 1 is for CLIENT_SESSION_TRACK) This is changed to 15818f. 15 - Remains the same 81 - 10000001 (the last byte says CLIENT_DEPRECATE_EOF enabled) 8f - 10001111 (remains the same) Signed-off-by: Bibek Shrestha <bibekshrestha@gmail.com>	5 years ago
Javier Jaramago Fernández	9dce0d728c	Fixed typo mistaking supplied '_myds' for internal 'MySQL_Resulset::myds'	5 years ago
René Cannaò	39bc767df2	Completely remove ma_global.h from 2.1.0	6 years ago
Rene Cannao	41b173a83c	Fixing a lot of compiler warnings	6 years ago
Rene Cannao	df5bf138e4	Removed dependency from ma_global.h ... Closes #2959	6 years ago
noother	a3767fa39e	fix unquoted table name leading to sql errors	6 years ago
Javier Jaramago Fernández	c237243a2f	Fixes #2793: Update capabilities and max_allowed properly in case of 'switching_auth'	6 years ago
Javier Jaramago Fernández	7f8b07a0db	Created new metric counters for registering 'mysql_errors'	6 years ago
René Cannaò	8cc88ce58e	Migration of threads status variables as array	6 years ago
Javier Jaramago Fernández	e703178f04	Moved header colliding with <memory> to unique file that requires it	6 years ago
val	b0ca1a030f	make MySQL_Variables a global variable	6 years ago
val	3e790c9083	Polishing and cleanup ... - cleanup code - performance optimization - use default value for connection	6 years ago