proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	3f1027b7bf	fix: address code review feedback from AI reviewers (#5566 ) Critical fixes: - Admin_Handler: Gate IMPORT PGBOUNCER CONFIG to admin sessions only (stats connections can no longer mutate config) - Admin_Handler: Wrap import execution in BEGIN/ROLLBACK for atomicity (partial failures no longer leave inconsistent state) - Admin_Handler: Parse DRY RUN/IGNORE WARNINGS as trailing tokens after quoted path (paths containing those strings no longer break parsing) - ProxySQL_CLI: Never write SQL to stdout on failed conversion (prevents partial SQL from being piped to mysql in error cases) Important fixes: - ConfigParser: Add INT_MIN/INT_MAX range checking in parse_int() and UINT_MAX checking in parse_uint() to prevent overflow - ConfigParser: Detect unterminated single quotes in connection string pairs and report parse error instead of silently accepting - ConfigParser: Include <climits> for range check constants - ConfigParser: Set file field in "cannot open" error message - ConfigConverter: DELETE FROM pgsql_firewall_whitelist_rules before importing HBA rules (prevents stale entries) - ShowCommands: Fix SHOW POOLS query to avoid cross-join that produced nondeterministic results with multiple pool rows - ProxySQL_CLI: Remove duplicate semicolons in non-dry-run output - Admin_Handler: Fix admindb->execute() return type (bool not int)	5 days ago
Rene Cannao	eb0e6b0657	feat: add PgBouncer config converter, CLI tool, and SHOW commands (Stages 2+3) (#5564 , #5565 ) Stage 2 - Config Converter + CLI: - PgBouncer_ConfigConverter: Converts parsed PgBouncer config into ProxySQL SQL statements with full parameter mapping - Databases → pgsql_servers + pgsql_query_rules (auto hostgroup assignment) - Multi-host entries → multiple server rows with equal weight - Users → pgsql_users with pool mode mapping (session→fast_forward, transaction→transaction_persistent, statement→defaults) - Globals → pgsql-* variables with unit conversion (s→ms) - HBA rules → pgsql_firewall_whitelist entries - Strict mode (default): fails on unmappable parameters - Relaxed mode (--ignore-warnings): warns and continues - Dry-run output: commented SQL with summary - ProxySQL_CLI: Entry point for proxysql-cli binary (argv[0] detection) - Subcommand: import-pgbouncer <path> [--dry-run] [--ignore-warnings] - Never starts daemon, always exits after command - 39 unit tests covering: minimal conversion, multi-host, wildcard database, pool mode mapping, global settings, strict/relaxed modes, query rules, dry-run format, TLS settings Stage 3 - PgBouncer-Compatible SHOW Commands: - PgBouncer_ShowCommands: Translates PgBouncer SHOW commands to equivalent ProxySQL SQL queries with exact column output format - SHOW POOLS, STATS, SERVERS, CLIENTS, DATABASES, USERS, CONFIG, VERSION, STATE, LISTS - SHOW EXTENDED variant adds ProxySQL-specific columns - Unsupported commands (DNS_HOSTS, PEERS, etc.) return clear errors - Case-insensitive, handles trailing semicolons and extra whitespace - 39 unit tests covering: command recognition, case insensitivity, trailing semicolons, EXTENDED variant, SQL output columns, non-matching queries, unsupported commands	5 days ago

Author

SHA1

Message

Date

Rene Cannao

3f1027b7bf

fix: address code review feedback from AI reviewers (#5566 )

Critical fixes:
- Admin_Handler: Gate IMPORT PGBOUNCER CONFIG to admin sessions only
  (stats connections can no longer mutate config)
- Admin_Handler: Wrap import execution in BEGIN/ROLLBACK for atomicity
  (partial failures no longer leave inconsistent state)
- Admin_Handler: Parse DRY RUN/IGNORE WARNINGS as trailing tokens after
  quoted path (paths containing those strings no longer break parsing)
- ProxySQL_CLI: Never write SQL to stdout on failed conversion
  (prevents partial SQL from being piped to mysql in error cases)

Important fixes:
- ConfigParser: Add INT_MIN/INT_MAX range checking in parse_int()
  and UINT_MAX checking in parse_uint() to prevent overflow
- ConfigParser: Detect unterminated single quotes in connection string
  pairs and report parse error instead of silently accepting
- ConfigParser: Include <climits> for range check constants
- ConfigParser: Set file field in "cannot open" error message
- ConfigConverter: DELETE FROM pgsql_firewall_whitelist_rules before
  importing HBA rules (prevents stale entries)
- ShowCommands: Fix SHOW POOLS query to avoid cross-join that produced
  nondeterministic results with multiple pool rows
- ProxySQL_CLI: Remove duplicate semicolons in non-dry-run output
- Admin_Handler: Fix admindb->execute() return type (bool not int)

Rene Cannao

eb0e6b0657

feat: add PgBouncer config converter, CLI tool, and SHOW commands (Stages 2+3) (#5564 , #5565 )

Stage 2 - Config Converter + CLI:
- PgBouncer_ConfigConverter: Converts parsed PgBouncer config into
  ProxySQL SQL statements with full parameter mapping
  - Databases → pgsql_servers + pgsql_query_rules (auto hostgroup assignment)
  - Multi-host entries → multiple server rows with equal weight
  - Users → pgsql_users with pool mode mapping (session→fast_forward,
    transaction→transaction_persistent, statement→defaults)
  - Globals → pgsql-* variables with unit conversion (s→ms)
  - HBA rules → pgsql_firewall_whitelist entries
  - Strict mode (default): fails on unmappable parameters
  - Relaxed mode (--ignore-warnings): warns and continues
  - Dry-run output: commented SQL with summary
- ProxySQL_CLI: Entry point for proxysql-cli binary (argv[0] detection)
  - Subcommand: import-pgbouncer <path> [--dry-run] [--ignore-warnings]
  - Never starts daemon, always exits after command
- 39 unit tests covering: minimal conversion, multi-host, wildcard
  database, pool mode mapping, global settings, strict/relaxed modes,
  query rules, dry-run format, TLS settings

Stage 3 - PgBouncer-Compatible SHOW Commands:
- PgBouncer_ShowCommands: Translates PgBouncer SHOW commands to
  equivalent ProxySQL SQL queries with exact column output format
  - SHOW POOLS, STATS, SERVERS, CLIENTS, DATABASES, USERS, CONFIG,
    VERSION, STATE, LISTS
  - SHOW EXTENDED variant adds ProxySQL-specific columns
  - Unsupported commands (DNS_HOSTS, PEERS, etc.) return clear errors
  - Case-insensitive, handles trailing semicolons and extra whitespace
- 39 unit tests covering: command recognition, case insensitivity,
  trailing semicolons, EXTENDED variant, SQL output columns,
  non-matching queries, unsupported commands

2 Commits (3f1027b7bfa4c8ad233e1549cbf3230ee9a7ffdb)