13 Commits (31d7ae9ecbfcce4062dde20dfd67ff60dd0db29c)

Author	SHA1	Message	Date
Rene Cannao	201eed8925	fix(test/tap): cleanup test_warnings-t.cpp - replace NULL with nullptr, add braces, fix enum types, fix narrowing conversions	2 months ago
Rene Cannao	007484a0b0	fix(test/tap): memory/logic bugs in test_warnings-t.cpp ... WIP.md explicitly flagged this file as having 'deeper issues than formatting' and was reset to HEAD rather than touched by the prior cleanup attempt. These are the substantive bugs: - get_connection(): - Fix UB on mysql_init failure: mysql_error() was being called on a NULL MYSQL* when mysql_init returned NULL. - Fix leak of 'proxysql' handle on mysql_real_connect failure (for both kAdmin and kMySQL branches) - the function returned NULL without ever closing the successfully initialized handle. - get_warnings_count(): - Fix NULL deref: mysql_fetch_row() can return NULL (empty result or error), and the row[0] access that followed was unguarded. Now returns -1 and logs diagnostic on empty-row case. - Simplify the redundant 'if (mysql_result) { ... result = nullptr; }' since mysql_result was already checked non-NULL above. - get_warnings(): - Fix potentially-NULL mysql_use_result being passed to mysql_fetch_row in a while-loop. Added NULL check after the mysql_use_result call. - main() admin_tmp discovery block: - Fix UB: mysql_real_connect() was called on admin_tmp without first checking that mysql_init() returned non-NULL. - Fix leak of admin_tmp when mysql_real_connect fails - the whole if-body (including the mysql_close at the end) was skipped, leaking the initialized handle. Always close admin_tmp whether or not the connect succeeds. - Add row[0] NULL guard before atoi() in the hostgroup-discovery query to avoid segfault on unexpected NULL column. - main() dbg_admin debug dump block: - Same fix as above: dbg_admin handle was leaked when real_connect failed inside the compound if-condition. - main() hostgroup fixup loop: - Fix strdup() leak pattern: each rewrite strdup'd the query string into info.query_info.query with no matching free. Worse, running both rewrites on the same query overwrote the first strdup'd pointer with the second strdup'd one, leaking the first. Replaced with a std::list<std::string> that owns the rewritten strings and produces stable c_str() pointers. - Remove dead MYSQL_QUERY__ macro (zero callers, and the name uses a reserved-identifier double-underscore suffix). Compile-verified with -fsyntax-only.	2 months ago
Rene Cannao	5c9121ef40	Add hostgroup debug diagnostics and cache test tolerance ... - Add dump_hostgroup_debug() utility: dumps runtime_mysql_servers and stats_mysql_connection_pool for a given hostgroup via diag() output. Helps diagnose "hostgroup has no servers available" CI failures. - test_throttle_max_bytes_per_second_to_client-t: dump hostgroup 1300, 0, and 1 when create_table_test_sbtest1() fails. - test_warnings-t: dump target hostgroup state before running tests. - test_unsupported_queries-t: dump target hostgroup state before running tests. - test_query_cache_soft_ttl_pct-t: add tolerance of +1 to all three assertions. The soft TTL refresh race allows two threads to both see "needs refresh" simultaneously under load, producing one extra backend hit. This is a known property of the soft TTL mechanism.	2 months ago
Rene Cannao	de4340b2e2	Fix ProxySQL SQL template replacement in test_warnings-t.cpp ... - Correct character offset for VALUES (0, replacement. - Ensures valid SQL syntax when dynamically updating hostgroup IDs.	3 months ago
Javier Jaramago Fernández	d78065da88	Fix usage of tests deps MySQL connector for some tests	2 years ago
Miro Stauder	f3b90a4d5e	use local includes - mysql	2 years ago
Rahim Kanji	045d6bcaeb	* Execute all test cases with 'CLIENT_DEPRECATE_EOF' both enabled and disabled. ... * Introduced 'ps_type' enum to differentiate between preparing a statement and executing a statement * Fixed issue where the warning count fails to reset when the SET statement generates a warning. * Resolved the issue where the 'server_status' and 'warning count' were not accurately represented in the statement. * Replaced 'mysql_warning_count' with 'mysql_stmt_warning_count' for retrieving the warning count in statements. * Added 'handle_warning' field in hostgroup_attributes TAP test * Updated warnings TAP test	3 years ago
Rahim Kanji	05208e2839	* Update warning_count as soon as query is executed.	3 years ago
Rahim Kanji	b588798a08	Few fixes	3 years ago
Rahim Kanji	a47d0ef484	Remove old mysql query rule entries	3 years ago
Rahim Kanji	30f989722b	Changed digest to match_digest	3 years ago
Rahim Kanji	c28f88eb15	Added delay between query execution	3 years ago
Rahim Kanji	b668021dad	Added TAP test	3 years ago