proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	da655099ee	fix(test/tap): batch 2 of static analysis real-bug fixes Batch 1 - dead stores/unused vars (11 files): - remove dead test_count assignments in genai_module/async/embedding_rerank/mcp_module - remove unused result strings in ai_llm_retry_scenarios - remove dead jitter_ms in ai_llm_retry_scenarios - remove unused row assignments in mysql-fast_forward/mysql-mirror1 - remove dead rc, sock, num_rows in mysql-protocol_compression/malformed/ssl_CA Batch 2 - narrowing conversions (~100 fixes): - pgsql-extended_query_protocol_test: uint8_t->char, ssize_t->int casts - genai_module/async/embedding_rerank: recv()/mysql_num_rows() casts - mysql-protocol_compression_level: various narrowing casts - max_connections_ff: timeout/duration casts - mysql_query_logging_memory: errno/plan() casts - pgsql-connection_parameters: htonl/ntohl casts - multiple_prepared_statements, mysql-reg_test_4716, nl2sql_internal, etc. Batch 3 - macros + branch clone: - fix macro parens in mysql-reg_test_4867_query_rules - fix macro parens in proxysql_debug.h - fix branch clone in pgsql-connection_parameters_test - fix branch clone in pgsql-copy_to_test - fix narrowing in pgsql-copy_from_test Batch 4 - value params + widening + reserved IDs: - pass string params by const ref in admin_various_commands2, mysql_hostgroup_attributes-servers_defaults, mysql-protocol_compression_level - fix implicit widening overflow in mcp_mysql_concurrency_stress - fix widening in mysql_stmt_send_long_data_large - rename reserved identifiers (__1, _PtrSize_t) - fix narrowing in pg_lite_client.h	2 months ago
Rene Cannao	3032dffed4	test: Add NL2SQL internal functionality unit tests Add comprehensive TAP unit tests for NL2SQL internal functions: - Error code conversion (5 tests): Validate nl2sql_error_code_to_string() covers all 13 defined error codes plus UNKNOWN_ERROR - SQL validation patterns (17 tests): Test validate_and_score_sql() * Valid SELECT queries (4 tests) * Non-SELECT queries (4 tests) * Injection pattern detection (4 tests) * Edge cases (4 tests): empty, lone keyword, semicolons, complex queries - Request ID generation (12 tests): Test UUID-like ID generation * Format validation (20 assertions for 10 IDs) * Uniqueness (100 IDs checked for duplicates) * Hexadecimal character validation - Prompt building (8 tests): Test build_prompt() * Basic prompt structure (3 tests) * Schema context inclusion (3 tests) * Section ordering (1 test) * Special character handling (2 tests) Note: Tests are self-contained with standalone implementations matching the logic in NL2SQL_Converter.cpp.	4 months ago

Author

SHA1

Message

Date

Rene Cannao

da655099ee

fix(test/tap): batch 2 of static analysis real-bug fixes

Batch 1 - dead stores/unused vars (11 files):
- remove dead test_count assignments in genai_module/async/embedding_rerank/mcp_module
- remove unused result strings in ai_llm_retry_scenarios
- remove dead jitter_ms in ai_llm_retry_scenarios
- remove unused row assignments in mysql-fast_forward/mysql-mirror1
- remove dead rc, sock, num_rows in mysql-protocol_compression/malformed/ssl_CA

Batch 2 - narrowing conversions (~100 fixes):
- pgsql-extended_query_protocol_test: uint8_t->char, ssize_t->int casts
- genai_module/async/embedding_rerank: recv()/mysql_num_rows() casts
- mysql-protocol_compression_level: various narrowing casts
- max_connections_ff: timeout/duration casts
- mysql_query_logging_memory: errno/plan() casts
- pgsql-connection_parameters: htonl/ntohl casts
- multiple_prepared_statements, mysql-reg_test_4716, nl2sql_internal, etc.

Batch 3 - macros + branch clone:
- fix macro parens in mysql-reg_test_4867_query_rules
- fix macro parens in proxysql_debug.h
- fix branch clone in pgsql-connection_parameters_test
- fix branch clone in pgsql-copy_to_test
- fix narrowing in pgsql-copy_from_test

Batch 4 - value params + widening + reserved IDs:
- pass string params by const ref in admin_various_commands2,
  mysql_hostgroup_attributes-servers_defaults,
  mysql-protocol_compression_level
- fix implicit widening overflow in mcp_mysql_concurrency_stress
- fix widening in mysql_stmt_send_long_data_large
- rename reserved identifiers (__1, _PtrSize_t)
- fix narrowing in pg_lite_client.h

Rene Cannao

3032dffed4

test: Add NL2SQL internal functionality unit tests

Add comprehensive TAP unit tests for NL2SQL internal functions:

- Error code conversion (5 tests): Validate nl2sql_error_code_to_string()
  covers all 13 defined error codes plus UNKNOWN_ERROR

- SQL validation patterns (17 tests): Test validate_and_score_sql()
  * Valid SELECT queries (4 tests)
  * Non-SELECT queries (4 tests)
  * Injection pattern detection (4 tests)
  * Edge cases (4 tests): empty, lone keyword, semicolons, complex queries

- Request ID generation (12 tests): Test UUID-like ID generation
  * Format validation (20 assertions for 10 IDs)
  * Uniqueness (100 IDs checked for duplicates)
  * Hexadecimal character validation

- Prompt building (8 tests): Test build_prompt()
  * Basic prompt structure (3 tests)
  * Schema context inclusion (3 tests)
  * Section ordering (1 test)
  * Special character handling (2 tests)

Note: Tests are self-contained with standalone implementations
matching the logic in NL2SQL_Converter.cpp.

2 Commits (31d7ae9ecbfcce4062dde20dfd67ff60dd0db29c)