11 Commits (31d7ae9ecbfcce4062dde20dfd67ff60dd0db29c)

Author	SHA1	Message	Date
Rene Cannao	1c64d949ae	fix(test/tap): cleanup kill_connection3-t.cpp - nullptr, range-based loops, NOLINT for parallel-array loops	2 months ago
Rene Cannao	b66a14a39f	fix(test/tap): leaks and uninit read in kill_connection{2,3}-t.cpp ... Both kill_connection2-t.cpp and kill_connection3-t.cpp share the same structure and had the same bugs: - create_connections(): fix NULL-deref UB when mysql_init returns NULL (mysql_error was called on the NULL handle) and fix leaks on both mysql_init failure and mysql_real_connect failure. On any error the function now closes the in-flight handle and any previously-pushed conns[] slots before returning. - find_tids(): - Initialize 'tid' to 0: it was declared uninitialized and read on the ok() line below, which would read garbage if mysql_fetch_row returned NULL on the first iteration. - Check mysql_store_result for NULL before passing to mysql_fetch_row (was UB on NULL). - NULL-guard row[0] before atoll to avoid crashes on unexpected NULL columns. - main(): fix leaks at all error-return paths: - NULL-deref UB when mysql_init(proxysql_admin) returned NULL. - proxysql_admin leaked on mysql_real_connect failure. - conns[] (5 or 35 connections) leaked across every error-return. - Most importantly: after the 'wait_timeout' / 'kill' cycle kills the first batch of conns server-side, main() called create_ connections() a SECOND time, overwriting every conns[i] slot without closing the now-dead client-side MYSQL* structs. That dropped all NUM_CONNS MYSQL handles on the floor. Added an explicit close_all_conns() call between the two batches. - Happy-path exit now also runs close_all_conns() + mysql_close (proxysql_admin); previously everything leaked at normal exit. A new static helper close_all_conns() centralizes the cleanup; conns[] is file-scope and zero-initialized, so the NULL check in close_all_conns() is correct at entry and after overwrite. Compile-verified with -fsyntax-only.	2 months ago
Wazir Ahmed	8ebd7e48ae	TAP: Move init_mysql_conn() and run_q() to utils ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	9 months ago
René Cannaò	13c5ed3f96	Increase sleep time in kill_connection3-t	2 years ago
Miro Stauder	c78819bda9	use inludes from our deps intead of system	3 years ago
Miro Stauder	0546f74aa0	Update kill_connection3-t.cpp	3 years ago
Miro Stauder	4574f6d9d0	Update kill_connection3-t.cpp	3 years ago
René Cannaò	9990dac403	Adding some sleep while testing kill connections	5 years ago
René Cannaò	1d5ac70e7b	Adding test to test mysql user fast_forward ... This commit also fix a bug: When the session uses fast_forward, frontend and backend connections must have the same bit for CLIENT_DEPRECATE_EOF	5 years ago
René Cannaò	78f8821215	More code coverage mostly related to Admin	5 years ago
René Cannaò	c11a7e1467	Test to verify KILL CONNECTION on Admin ... This test verifies that client connections are dropped because of KILL CONNECTION executed on Admin It kills idle connections or connections in transaction	5 years ago