62 Commits (200fdecb8d870db39abe622f3ff875cd1abb0948)

Author	SHA1	Message	Date
René Cannaò	229b5d7d3f	Some code cleanup	2 years ago
René Cannaò	3790ce6d82	Do not print "Updating metadata for stmt" for EXPLAIN ... ProxySQL generates warnings when updating prepared statements metadatas. This commit filters these warnings for EXPLAIN statements. See #4478 It also include a TAP test for code coverage.	2 years ago
Rahim Kanji	ee3d24121e	Update MySQL_PreparedStatement.cpp ... * Fixed typo * Added comment	2 years ago
Rahim Kanji	e53cd200ab	Code cleanup	2 years ago
Rahim Kanji	1e4c108659	Fixed memory leak in querying stats_mysql_prepared_statements_info	2 years ago
Rahim Kanji	989687c68a	Implemented memory usage monitoring for the prepared statement cache with the following changes: ... * Added two new variables to the 'stats_memory_metrics' table: prepare_statement_metadata_memory prepare_statement_backend_memory * Introduced corresponding variables in the Prometheus exporter to measure memory usage of prepare statement metadata and prepare statement backend.	2 years ago
René Cannaò	e35b944ca1	Added destructor to MySQL_STMT_Manager_v14()	3 years ago
René Cannaò	71e2510ef6	Code cleanup on MySQL_HostGroups_Manager ... Some rework to try to reduce duplicated code	3 years ago
René Cannaò	3de13665e8	Merge pull request #3557 from sysown/v2.x-ccov2 ... More code coverage	5 years ago
René Cannaò	b912d978b0	Removing or commenting legacy/unused code	5 years ago
Javier Jaramago Fernández	4ea7b750fd	Moved helper function 'proxy_mysql_stmt_close' from 'gen_utils' to 'MySQL_Protocol' #3525	5 years ago
Javier Jaramago Fernández	297bc8bae6	Refactored calls to 'mysql_stmt_close' into function holding preparation of 'MYSQL_STMT*' parameter #3525	5 years ago
Javier Jaramago Fernández	9e70e3918b	Reversed adding 'first_comment' to 'compute_hash' #3427 ... Information from 'first_comment' is redundant since the comment itself is already contained in 'query' when reaching 'compute_hash'.	5 years ago
Javier Jaramago Fernández	028623c06c	Added 'first_comment' to 'MySQL_STMT_Global_info' to allow processing it during 'STMT_EXECUTE' #3427	5 years ago
Javier Jaramago Fernández	5d0a9a2087	Updated 'stats_mysql_prepared_statements_info' table definition to hold 'num_columns' and 'num_params' info for prepared statements	5 years ago
René Cannaò	7b021e027a	Do not cache routing metadata for COM_STMT_EXECUTE ... From 1.3.0 till 2.0.x , when COM_STMT_PREPARE is executed and Query Processor is executed, metadata are stored in MySQL_STMT_Global_info(). These metadata include routing information. Is a prepared statement is prepared on a specific hostgroup, it will always be executed on the same hostgroup. This causes negative consequences, like the one reported in issue #2691 . This commit: * remove hostgroup_id from MySQL_STMT_Global_info() and other metadata * Query Processor is called also during COM_STMT_EXECUTE * removes hostgroup from table stats_mysql_prepared_statements_info * Query Processor do not perform any query rewrite ruding COM_STMT_EXECUTE	6 years ago
René Cannaò	80e92b144d	[WIP] Second commit for mysql firewall whitelist ... Improved also compiling time	6 years ago
René Cannaò	9ed7094cfe	Implemeting of more locking in SELECT statements ... SELECT ... FOR SHARE SELECT ... LOCK IN SHARE MODE SELECT ... FOR (UPDATE|SHARE) [OF ...] (NOWAIT|SKIP LOCKED)	7 years ago
René Cannaò	059579f5a2	Fix some compiler warnings	7 years ago
René Cannaò	10f38d4e2f	Various code cleanup	7 years ago
Nick Vyzas	90348cd1c9	Fixes user / schema column order https://github.com/sysown/proxysql/issues/1720	7 years ago
René Cannaò	0fdd52b46d	Minor memory leak fix	8 years ago
René Cannaò	be7f687a43	Optimize when purging prepared statements	8 years ago
René Cannaò	2bb322db6f	Several fixed in Prepared statements ... * is STMT_PREPARE failed when there is a previous status (maybe STMT_EXECUTE) disconnect the client immediately. Maybe this is related to #1366 , but I can't reproduce it yet * purge prepared statements is also their server reference counter is 0 * initialize connections queue for purging connections	8 years ago
Nikolaos Vyzas	7a2e27c361	Adding minor conflict resolution fixes	8 years ago
Nikolaos Vyzas	f2d3684a49	Merge remote-tracking branch 'upstream/v2.0-lab' into v2.0-lab	8 years ago
René Cannaò	8a2ffdb7f2	MyComQueryCmd not initialized could cause crash #1370 ... This happens for prepared statements, and mysql-query_digests=false	8 years ago
René Cannaò	a8e8859b79	Add rw lock to ensure metadata aren't updated while running STMT_PREPARE_RESPONSE	8 years ago
René Cannaò	7ab67dc685	Bug fix for #1333 ... Prepared statements counters are now computed at runtime instead of on-demand. Now MySQL_STMT_Manager_v14::get_metrics() doesn't depend anymore from the number of prepared stataments cached. The old code (slow code) is still present in the DEBUG version, and used to validate the new counters. That also means that DEBUG versions are way slower than non debug versions.	8 years ago
René Cannaò	d04ee3d385	Remove all references to PS handling before 1.4 ... Handling of prepared statements changed a lot in 1.4 , as a lot of code was rewritten. Old code was still present, and was possible to toggle it on and off based on PROXYSQL_STMT_V14 . Because only the new code is maintained, all references to old code are now removed, including PROXYSQL_STMT_V14	8 years ago
René Cannaò	f87c41188f	Purge PS metadata cache only when possible #1312	8 years ago
René Cannaò	3520dbbacc	Remove all references to PS handling before 1.4 ... Handling of prepared statements changed a lot in 1.4 , as a lot of code was rewritten. Old code was still present, and was possible to toggle it on and off based on PROXYSQL_STMT_V14 . Because only the new code is maintained, all references to old code are now removed, including PROXYSQL_STMT_V14	8 years ago
René Cannaò	3ddbfd826f	Purge PS metadata cache only when possible #1312	8 years ago
René Cannaò	6302628772	Data sent with STMT_SEND_LONG_DATA was lost #1283 ... Values were incorrectly set to NULL	8 years ago
René Cannaò	ea9fa03ab1	Added table stats.stats_mysql_prepared_statements_info ... This new table exports global metrics on prepared statements	8 years ago
René Cannaò	d27327a003	Generate different stmt_id if clients ask for the same multiple times	8 years ago
René Cannaò	703ee8ef0f	Reset connections instead of dropping them when mysql-max_stmts_per_connection is reached ... Also fixed a memory leak associate with this feature. Cleaned up a bit of code.	8 years ago
René Cannaò	375f912ab0	Stmt_Cached and Stmt_Max_Stmt_id for PS #1198 ... In 1.4 the handling of prepared statements were rewritten to solve some design limitations. The code responsible for `Stmt_Cached` and `Stmt_Max_Stmt_id` wasn't migrated tho. Fixed now.	8 years ago
René Cannaò	59bac7f365	Reset PS metadata if they change ... Possible bug fix for #965	9 years ago
René Cannaò	02432b2b27	Possible fix for issue #1062 ... Forward to backend SET commands with prepared statements	9 years ago
René Cannaò	080bb3d471	Big change to imporve how prepared statements work	9 years ago
René Cannaò	de0b939e1c	clang-format on MySQL_PreparedStatement.cpp	9 years ago
René Cannaò	2f65c2e48b	Evaluate enforce_autocommit_on_reads on PS #899 ... Variable mysql-enforce_autocommit_on_reads wasn't evaluate for prepared statements.	9 years ago
René Cannaò	215473ea82	Fix bug #897 : crash with PS multiple users ... COM_CHANGE_USER could try to reset PS already invalidated from the PS manager.	9 years ago
René Cannaò	a6c53d0d12	Revert "Refactor header includes."	9 years ago
Maxim Bublis	30dbcc21a8	Refactor header includes. ... * reduce build time by 25%; * remove circular dependency on `cpp.h` and other headers. * fixes issue with `my_global.h` from mariadbclient which redefines `__attribute__`, that leads to broken STL and GCC intrinsics if `<algorithm>` wasn't included prior including this header; * fixes another issue with redefined `__attribute__` which leads to `_conn_exchange_t` not being aligned to cache line size; * removes `pthread_setstacksize` calls as `my_global.h` redefines `pthread_setstacksize` to be `pthread_dummy(0)` which led to stack size being never adjusted; * add missing include guards to some headers; * remove unused proxysql_hash.h header.	9 years ago
René Cannaò	b25239c72a	Improvements related to STMT cache ... These improvements avoid a race condition in which a prepared statement is removed from the cache before it is marked as used by the client. This race condition was noticed when running benchmark creating 7000 _unique_ prepared statements per second.	9 years ago
René Cannaò	8074e738ed	Added support for STMT_SEND_LONG_DATA #764	9 years ago
René Cannaò	9a91a40c53	Print stmt info only in DEBUG mode	10 years ago
René Cannaò	505196fd6b	Implemented recycling of stmt_id ... Once stmt_id aren't used anymore, they can be reused	10 years ago