200 Commits (09d0dcb808be361e17e0fa6a1dfcf511e3c528be)

Author	SHA1	Message	Date
Rene Cannao	af58865b06	Fix uninitialized memory in QueryParserArgs.buf ... Use memset to zero-initialize the entire QueryParserArgs struct instead of individually setting only digest_text and first_comment to NULL. This fixes Valgrind errors about use of uninitialised values in strcasestr() when reading from the uninitialized buf array. Fixes errors like: Use of uninitialised value of size 8 at tolower (ctype.c:46) by strcasestr by MySQL_Connection::ProcessQueryAndSetStatusFlags(char*)	2 weeks ago
René Cannaò	2637d28f36	Merge pull request #5299 from sysown/v3.0_pg-cancel-terminate-backend-param-support_5298 ... Add parameterized PID support for pg_cancel_backend/pg_terminate_backend in extended query protocol	1 month ago
Rahim Kanji	9ec045ca74	Fix PostgreSQL deadlock with Close Statement flood exceeding threshold_resultset_size ... Bug Description: ProxySQL would deadlock when processing extended query frames where: 1. Many Close Statement messages accumulate responses in PSarrayOUT 2. Total response size exceeds pgsql-threshold_resultset_size 3. A backend operation (Describe/Execute) follows in the same frame Root Cause: - Close Statement operations are handled locally by ProxySQL (no backend routing) - Their CloseComplete responses accumulate in PSarrayOUT - When threshold_resultset_size is exceeded, ProxySQL stops reading from backend - Subsequent backend operations (Describe/Execute) need backend responses to complete - This creates a deadlock: ProxySQL won't read, backend operation can't complete - Extended query frame never finishes, query times out The Fix: When PSarrayOUT exceeds threshold_resultset_size and a backend operation is pending, ProxySQL now flushes all accumulated data in PSarrayOUT to the client first, then continues processing backend operations. This breaks the deadlock by clearing the buffer before attempting to read more data from the backend.	1 month ago
Rahim Kanji	67cbe46450	Simplify PID extraction ... Using bind message to obtain parameter information, rather than determining whether the query is parameterized from the query itself. Multiple parameters are not possible in this case, as PostgreSQL itself rejects multi-parameter pg_cancel_backend() and pg_terminate_backend() and only accepts a single parameter for these functions.	1 month ago
Rahim Kanji	5066ddd181	Removed isdigit	1 month ago
Rahim Kanji	ce42c188f5	Improvements	1 month ago
Rahim Kanji	a1e10e3055	Add parameterized PID support for pg_cancel_backend/pg_terminate_backend ... This commit extends the existing pg_cancel_backend() and pg_terminate_backend() support to work with parameterized queries in the extended query protocol. While literal PID values were already supported in both simple and extended query protocols, this enhancement adds support for parameterized queries like SELECT pg_cancel_backend($1).	1 month ago
Rahim Kanji	556b1023c4	Removed change_user_auth_switch flag	2 months ago
René Cannaò	0f7ff1f374	Merge branch 'v3.0' into v3.0_pgsql-query-digest-gen-5253 ... Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rahim Kanji	42864e8867	Improved Tokenizer for PostgreSQL ... - Added `process_pg_typecast()` to handle PostgreSQL type cast syntax (::) - Recognizes type casts in various contexts: 'value'::type, column::type, etc. - Added `process_array_literal()` for PostgreSQL array processing - Handles both ARRAY[] constructor and {} literal syntax - Processes multi-dimensional arrays and nested array structures - Added `process_literal_prefix_type()` for PostgreSQL prefixed literals - Processes E'' escape string constants with backslash escapes - Handles U&'' Unicode string literals with optional UESCAPE clauses - Supports x'' hex string literals and b'' bit string literals - Manages B'' bit strings and bytea literals (\\xDEADBEEF format) - Added `process_replace_boolean()` for boolean literal replacement - Replaces TRUE and FALSE literals with parameter placeholders - Maintains case-insensitive matching (true, True, TRUE, etc.) - Preserves boolean context in expressions and WHERE clauses	2 months ago
Rene Cannao	2987242d4f	Fix cache_empty_result=0 not caching non-empty resultsets (issue #5248) ... The `cache_empty_result` field in query rules has three possible values: • -1: Use global setting (`query_cache_stores_empty_result`) • 0: Do NOT cache empty resultsets, but cache non-empty resultsets • 1: Always cache resultsets (both empty and non-empty) Previously, when `cache_empty_result` was set to 0, nothing was cached at all, even for non-empty resultsets. This prevented users from disabling caching for empty resultsets while still allowing caching of non-empty resultsets on a per-rule basis. Changes: 1. Modified caching logic in MySQL_Session.cpp and PgSQL_Session.cpp to add the condition `(qpo->cache_empty_result == 0 && MyRS->num_rows)` (MySQL) and `(qpo->cache_empty_result == 0 && num_rows)` (PgSQL) to allow caching when cache_empty_result=0 AND result has rows. 2. Added comprehensive Doxygen documentation in query_processor.h explaining the semantics of cache_empty_result values. 3. Updated Query_Processor.cpp with inline comments explaining the three possible values. Now when cache_empty_result is set to 0: - Empty resultsets (0 rows) are NOT cached - Non-empty resultsets (>0 rows) ARE cached - This matches the intended per-rule behavior described in issue #5248. Fixes: https://github.com/sysown/proxysql/issues/5248	2 months ago
Rahim Kanji	1a48aadf5e	Code cleanup	3 months ago
Rahim Kanji	c0f99c0e15	Refactor: Improved Prepared-Statement Cache Design (Lock-Free Hot Path) #5211 ... Concurrency and Memory Management * Lock-Free Ref Counting: Replaced global mutex-protected integer reference counts with `std::atomic<uint32_t>` within `PgSQL_STMT_Global_info`, eliminating lock contention during statement referencing. * Modern Ownership: Adopted std::shared_ptr<const PgSQL_STMT_Global_info> for global and local storage, providing automatic, thread-safe memory and lifecycle management. * Memory Optimization: Removed redundant auxiliary maps `global_id_to_stmt_names` and `map_stmt_id_to_info` from local and global statement managers respectively, reducing overall memory overhead. * Optimized Purging: Statement removal logic was simplified for efficiently identifying and cleaning up unused statements. Hot Path Performance (`BIND`, `DESCRIBE`, `EXECUTE`) * Bypassed Global Lookups: Local session maps now store the `shared_ptr` directly, removing the need to acquire the global lock and search the global map during hot path operations. * Direct Refcount Manipulation: Refcount modification functions now operate directly on the passed statement object, eliminating the overhead of searching the global map to find the object pointer based on statement id. Safety and Protocol Logic (`PARSE`) * Efficient Statement Reuse: Implemented a **local fast path** check for the unnamed statement (`""`), allowing immediate reuse of an identical query (same hash) upon re-parse, which bypasses global processing and locks. Cleanup * Cleaned up and class rename `PgSQL_STMT_Manager_v14` -> `PgSQL_STMT_Manager`.	3 months ago
Rahim Kanji	d84444724a	Replaced use of the generic write_generic() helper with direct packet construction for selected PostgreSQL protocol messages to reduce overhead and improve performance.	4 months ago
Rahim Kanji	e744c2bbb7	Optimize transaction command parsing to avoid unnecessary tokenization ... Previously, the parser always tokenized the full command, even when we only needed to check whether it was a transaction command. Now, it first extracts the first word to determine relevance and performs full tokenization only when necessary.	4 months ago
Rahim Kanji	7a3a5c71df	Optimize hot path: replace std::string with char[] to avoid heap	4 months ago
Rahim Kanji	9eb934e7f0	Buffer response until Extended Query frame completes; send early only if resultset threshold is reached.	4 months ago
René Cannaò	a44dee127d	Merge pull request #5174 from sysown/v3.0_optimise_extended_query_response ... Removed unnecessary writeout()	4 months ago
Javier Jaramago Fernández	2668de77c2	Fix compilation warning for 'strncpy' due string truncation ... As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	4 months ago
Javier Jaramago Fernández	c0978f9371	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' (PgSQL) ... Accesses by 'stats___pgsql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	4 months ago
Rahim Kanji	8291361bc1	Removed unnecessary writeout()	4 months ago
René Cannaò	360646b7d5	Merge pull request #5165 from sysown/crash-sqlite-max-len ... processlist: Prevent crash due to SQLITE_TOOBIG	4 months ago
Wazir Ahmed	5219d4be93	processlist: Prevent crash due to SQLITE_TOOBIG ... - Add new mysql/pgsql variable `processlist_max_query_length`. - Min: 1K - Max: 32M - Default: 2M - Truncate current query based on the configuration before inserting into `stats_*_processlist` tables. - Refactor/fix code related to other processlist configurations. 1. `session_idle_show_processlist` value was not updated in `ProxySQL_Admin.variables`. 2. Pass processlist config as an argument to `MySQL_Threads_Handler::SQL3_Processlist` instead of using thread-local variables. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Rahim Kanji	ed20d09b8a	Replaced std::get_if with std::visit	4 months ago
René Cannaò	ecad6f9249	Merge pull request #5160 from sysown/v3.0_disable_pgsql_prometheus_5159 ... Separate Query Cache Metrics for MySQL and PostgreSQL & Disable Prometheus Metrics for PostgreSQL	4 months ago
René Cannaò	73c15ba3ef	Merge pull request #5153 from sysown/v3.0_transaction_alias_support_5152 ... Add support for PostgreSQL transaction command aliases and ROLLBACK AND CHAIN	4 months ago
René Cannaò	01862a247a	Merge pull request #5149 from sysown/v3.0_track_search_path_param_5148 ... Add search_path parameter to tracked ProxySQL variables list - PgSQL	4 months ago
René Cannaò	42f6d9d74f	Merge pull request #5144 from sysown/v3.0_datestyle-parser-tweak ... Align DateStyle parsing with PostgreSQL	4 months ago
Rahim Kanji	cb2062c1d1	Few fixes	4 months ago
Rahim Kanji	45271572ec	Add support for PostgreSQL transaction command aliases and ROLLBACK AND CHAIN	5 months ago
Rahim Kanji	83bec8d477	Refactored remove_quotes function	5 months ago
Rahim Kanji	8f8a8c29e3	Code cleanup: Removed is_select_NOT_for_update from PostgreSQL modules	5 months ago
Rahim Kanji	b005c2dd8c	Add tracking for PostgreSQL search_path parameter	5 months ago
Rahim Kanji	d4b2de9e26	Align DateStyle parsing with PostgreSQL ... Updated PgSQL_DateStyle_Util::parse_datestyle() to support prefix-based matching for known tokens (POSTGRES, EURO, NONEURO). This allows variants like "PostgreSQL", "European", to be recognized as valid inputs.	5 months ago
Rahim Kanji	4d91452fc5	Implement backend query cancellation for PostgreSQL #5136 ... Add support for PostgreSQL query cancellation and backend termination features to allow clients to cancel long-running queries and terminate connections through the standard PostgreSQL protocol. Features implemented: - Intercept pg_backend_pid() queries and return ProxySQL session thread ID - Intercept pg_terminate_backend() to terminate client connections asynchronously - Intercept pg_cancel_backend() to cancel queries on backend connections - Support Cancel Request protocol via separate connection with PID and secret key validation - Return BackendKeyData message on successful authentication with session thread ID and unique cancel secret key This enables clients to use standard PostgreSQL cancellation mechanisms (pg_cancel_backend, pg_terminate_backend, and Cancel Request protocol) while ProxySQL maintains proper session isolation and maps client requests to appropriate backend connections.	5 months ago
René Cannaò	e1b7afe282	Merge pull request #5099 from wazir-ahmed/clock-monotonic-raw ... Use `CLOCK_MONOTONIC_RAW` instead of `CLOCK_MONOTONIC`	5 months ago
René Cannaò	4639b9705a	Merge pull request #5133 from sysown/v3.0_extended_query_pgsql_query_rules_5132 ... Applying Query Rules in Extended Query Protocol	5 months ago
René Cannaò	9290a5ceec	Merge pull request #5124 from sysown/v3.0_postgres_query_logging_issue_5123 ... Added query logging support for PostgreSQL	5 months ago
Rahim Kanji	9e9fdc23c2	Modify extended query handling in ProxySQL so that query rules are applied at Parse, Describe, and Execute stages, but hostgroup selection is performed only on the first message in the message pipeline. Ensures that all subsequent messages in the same pipeline use the same backend connection, maintaining consistent routing while applying relevant query rules.	5 months ago
Rahim Kanji	9b0366a89a	Improved PostgreSQL Logger	5 months ago
Rahim Kanji	a89291c9a9	Added query logging support for PostgreSQL	5 months ago
Rahim Kanji	692109f965	Fixed typo	5 months ago
Rahim Kanji	23a764eaac	Preserve implicit transactions with pipeline + FLUSH #5118 ... Previously, each extended-query block was terminated with a SYNC, which caused implicit transactions to commit prematurely. As a result, earlier write operations (INSERT/UPDATE/DELETE) could not be rolled back if a later statement in the same sequence failed. This change switches to libpq pipeline mode and replaces intermediate SYNC messages with FLUSH, ensuring that all client query frames execute as part of the same implicit transaction. A final SYNC is still issued to resynchronize the connection and make it safe for reuse in the pool.	5 months ago
Rahim Kanji	205f970ffa	Append NoData for DESCRIBE(Portal) on SET/RESET/DISCARD/DEALLOCATE	6 months ago
Rahim Kanji	031d362aab	Add STMT prefix to ASYC DESCRIBE status	6 months ago
Rahim Kanji	7d5fe54230	Refactor: unify result handling for Parse and Describe ... Previously, Parse and Describe each had their own query result handling paths. This duplicated a lot of logic and also failed to handle some cases correctly—for example, Notice messages returned by the server during extended-protocol queries. Keeping these separate paths would be hard to maintain and prone to bugs. The simple-query result handling is already mature, optimized, and covers all the necessary cases. Reusing it for Parse and Describe makes behavior consistent across simple and extended query flows, while also reducing duplicate code.	6 months ago
Rahim Kanji	0391a8d4bb	Intercept LISTEN command and return "not supported" #5109 ... ProxySQL currently does not support PostgreSQL's LISTEN command. When clients attempt to use it, we now intercept the command and return an appropriate "not supported" response instead of passing it through. This behavior is implemented for both: - Simple query flow - Extended (prepared) query flow	6 months ago
Wazir Ahmed	8d29742e20	`QueryInfo::end_time` should always be greater than or equal to `start_time` ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	6 months ago
Wazir Ahmed	daf1570c5d	Replace `CLOCK_MONOTONIC` with `CLOCK_MONOTONIC_RAW` ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	6 months ago
Rahim Kanji	38841bf189	Remove DESCRIBE statement cache option ... Remove the `DESCRIBE` (statement) cache option and related cache code.	6 months ago