proxysql

Commit Graph

Author	SHA1	Message	Date
Rahim Kanji	f2bd222145	Fixed compilation issue	4 days ago
Rahim Kanji	e7ee68dda5	Add SSL/TLS traffic decryption for PostgreSQL backend connections (#5281 ) Extends the existing NSS keylog-based SSL decryption to PostgreSQL backend connections by patching libpq with a global PQsetSSLKeyLogCallback() API. When admin-ssl_keylog_file is configured, TLS secrets from all PgSQL backend SSL handshakes are written to the keylog file in NSS Key Log Format, enabling traffic decryption with Wireshark/tshark. Approach: - Patch libpq with global callback following the PQsslKeyPassHook pattern - Single startup call covers all backend paths (regular, monitor, kill, harvester) - No new admin variables — existing admin-ssl_keylog_file covers PgSQL backends - Zero changes to ProxySQL PgSQL connection code Includes 9 integration tests (pgsql-ssl_keylog-t) and user guide updates.	4 days ago
Rene Cannao	499896e44b	Address PR review feedback for test_binlog_dump_multi_backend_crash - Move wait_timeout mutation after hostgroup discovery skip check so early returns don't leave backend state modified (Copilot review) - Add precondition assertion verifying connections exist in both writer and reader hostgroups before sending COM_BINLOG_DUMP, using ConnOK pool stats (CodeRabbit review)	6 days ago
Rene Cannao	b2f4b4f9a0	Fix crash when COM_BINLOG_DUMP received with idle backends from other hostgroups (#5556 ) When a session has backend connections to multiple hostgroups and receives COM_BINLOG_DUMP, GPFC_Replication_SwitchToFastForward() transitions the session to FAST_FORWARD mode but only manages the active backend. Idle backends from other hostgroups remain in the session's mybes array with async_state_machine==ASYNC_IDLE. If MySQL's wait_timeout closes one of these idle connections, the resulting POLLIN event causes handler() to be called with ASYNC_IDLE, which has no case in the switch and hits assert(0). Fix: Clean up idle backends from other hostgroups during the FAST_FORWARD transition in GPFC_Replication_SwitchToFastForward(). These connections will never be used again, so they are destroyed immediately. Includes a regression test (test_binlog_dump_multi_backend_crash-t) that: - Sets up two hostgroups with query rules routing SELECTs to reader HG - Creates backend connections to both hostgroups on one session - Sends COM_BINLOG_DUMP to enter FAST_FORWARD mode - Waits for wait_timeout to close the idle backend - Verifies ProxySQL does not crash	6 days ago
René Cannaò	d0625dc243	Merge pull request #5549 from sysown/v3.0-CodeCov0325 Add 32 unit test files (2963 assertions) and CI workflow improvements	1 week ago
Rene Cannao	6d6015a203	fix: align MCP Bearer token test with case-insensitive implementation The test expected lowercase 'bearer' to be rejected, but the implementation uses strncasecmp() per RFC 7235 (auth-scheme is case-insensitive). Update test to expect true for lowercase prefix.	1 week ago
René Cannaò	2fcc5729ee	Merge pull request #5548 from yuji-hatakeyama/5306-fix_show_warnings_with_comment Fix #5306 - SHOW WARNINGS with inline comments incorrectly sets warning_count	1 week ago
René Cannaò	e067683f4e	Merge pull request #5545 from sysown/feat/ffto-error-recording feat(ffto): record error details from fast-forward sessions	1 week ago
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	1 week ago
Rene Cannao	4fb7aac73f	fix: restore groups.json to compact one-line-per-entry format Previous commits inadvertently reformatted groups.json with Python's json.dump(indent=2), breaking the compact format required by test/tap/groups/README.md. The correct format is one entry per line with compact arrays so grep works for quick lookups.	1 week ago
Rene Cannao	0441d5026d	security: fix all 48 Dependabot alerts — bump Python test deps Update all vulnerable Python packages in test infrastructure: Package Old New Severity CVEs PyMySQL 0.9.2 >=1.1.1 CRITICAL CVE-2024-36039 (SQL injection) requests 2.26.0 >=2.33.0 HIGH CVE-2024-35195, CVE-2024-47081, CVE-2023-32681, CVE-2026-25645 urllib3 1.26.6 >=2.6.3 HIGH CVE-2023-43804, CVE-2023-45803, CVE-2024-37891, CVE-2025-50181, CVE-2025-66418, CVE-2025-66471, CVE-2026-21441 certifi 2021.5.30 >=2024.7.4 HIGH CVE-2022-23491, CVE-2023-37920, CVE-2024-39689 idna 2.10 >=3.7 MEDIUM CVE-2024-3651 Changes: - requirements.txt: bump all 6 packages, use >= instead of == - requirements-ubuntu24.txt: same bumps - Pipfile: bump pymysql/requests, update python_version 2.7 → 3 - Remove stale Pipfile.lock (generated for Python 2.7, all hashes outdated) API compatibility verified: - PyMySQL: pymysql.connect(), DictCursor, OperationalError, CLIENT.MULTI_STATEMENTS, defer_connect all work in 1.1.x. `passwd` kwarg is aliased to `password` internally. - requests: basic requests.post() usage unchanged - urllib3/certifi/idna: transitive deps, no direct API usage Note: CI Docker image (ubuntu:24.04) installs packages via apt-get, not pip. These requirements files are used for local dev and some CI fallback paths.	2 weeks ago
Rene Cannao	e806b0219c	test: register 5 new unit tests in groups.json for CI	2 weeks ago
Rene Cannao	c8408d76b3	test: add 6 unit test files with 588 assertions (Round 5) New test files (test/tap/tests/unit/): Core: - pgsql_tokenizer_unit-t (65 tests): PgSQL SQL digest — dollar- quoted strings, ::type casts, ARRAY literals, boolean literal replacement, E/B/X/U& prefix strings, comment handling, grouping/IN-list collapsing, edge cases - admin_disk_upgrade_unit-t (60 tests): all 6 disk_upgrade_*() schema migration functions with in-memory SQLite — scheduler v1.2.0→current, mysql_users v1.3.0→current, rest_api_routes v2.0.15→current, mysql_servers v1.1.0→current (with weight cap and compression normalization bugs), pgsql_replication_hostgroups v3.0.1→current, mysql_query_rules v1.2.2→current - gtid_utils_unit-t (37 tests): addGtid interval merging (adjacent, non-consecutive, duplicate, bridge, reverse-order, within- existing), addGtidInterval (update, duplicate, non-overlapping), gtid_executed_to_string formatting - glovars_unit-t (78 tests): GloVars constructor defaults, ProxySQL_Checksum_Value (set/replace_zeros/version/epoch), generate_global_checksum determinism, command-line parsing (--initial/--reload/--no-version-check/-D/--bootstrap/-n/-f/-M) - query_processor_unit-t (+217 tests, 259 total): EXTENDED with PgSQL-specific tests — all-fields rule creation, client_addr wildcard, flagOUT attributes JSON, command counters, stats, rule text 35-column serialization, query_parser_command_type for 100+ PgSQL commands (DML/DDL/views/sequences/functions/ triggers/policies/LISTEN/NOTIFY/VACUUM/TEXT SEARCH/etc.), fast routing hashmap, firewall whitelist, query digests GenAI/MCP (PROXYSQLGENAI=1): - genai_mysql_catalog_unit-t (89 tests): MySQL_Catalog with in-memory SQLite — upsert/get/remove, schema isolation, list with pagination, FTS search, merge, multiple kinds, special character handling Production changes for testability: - include/proxysql_admin.h: add friend class TestDiskUpgrade - test/tap/tests/unit/Makefile: add DEBUG auto-detection from libproxysql.a symbols (fixes struct layout ODR violations when library is built with -DDEBUG) Running totals: 32 test files, 2553 assertions, all passing.	2 weeks ago
Rene Cannao	8df688dd8a	test: register 5 new unit tests in groups.json for CI	2 weeks ago
Rene Cannao	a36834f968	test: add 6 unit test files with 676 assertions (Round 4) New test files (test/tap/tests/unit/): Core: - c_tokenizer_unit-t (59 tests): tokenizer/tokenize/free_tokenizer, c_split_2, mysql_query_digest_and_first_comment (literal replacement, comment stripping, NULL handling, grouping_limit, IN-clause), mysql_query_digest_first_stage, strip_comments - config_write_unit-t (111 tests): all 7 Write_*_to_configfile() functions with in-memory SQLite — MySQL users/servers/query rules, scheduler, restapi, global variables, proxysql_servers; tests field formatting, NULL handling, double-quote escaping, prefix grouping - listen_validator_unit-t (112 tests): trim_copy, split_listener_list, is_ipv4/ipv6_wildcard, parse_listener (IPv4/IPv6/Unix socket/ invalid/edge cases), sets_intersect, listeners_conflict, validate_module_listener_conflicts - ezoption_parser_unit-t (110 tests): standalone ezOptionParser — flags, string/int/float options, defaults, required/unknown, aliases, multi-value, usage layout, export/import, validators, vector getters - pgsql_txn_state_unit-t (+58 tests, 112 total): EXTENDED with PgSQL_ExplicitTxnStateMgr state machine tests — BEGIN/COMMIT/ ROLLBACK lifecycle, ROLLBACK AND CHAIN, savepoint add/release/ rollback_to, reset_state, fill_internal_session JSON, case- insensitive savepoints, END/ABORT synonyms. Uses minimal PgSQL_Session mock with variable snapshots. GenAI/MCP (PROXYSQLGENAI=1): - genai_discovery_schema_unit-t (172 tests): Discovery_Schema with in-memory SQLite — run/agent_run management, schema/object/column/ index/FK insertion, profile/LLM summary/domain/metrics/notes, list_objects pagination+ordering, get_object with columns/indexes, get_relationships FK mappings, FTS rebuild+search, fingerprint_mcp_args, compute_mcp_digest determinism, MCP_Query_Digest_Stats timing, MCP_Query_Processor_Output, MCP_Query_Rule defaults Running totals: 27 test files, 1944+ assertions, all passing.	2 weeks ago
Rene Cannao	a8c5432fc5	fix: remove stale proxysql.db before launching cluster sync replicas test_cluster_sync_mysql_servers-t spawns replica ProxySQL instances with a specific config file setting admin port to 96061/96062. If a proxysql.db from a previous run exists in the workdir, ProxySQL ignores the config file and loads from the DB instead, using the old admin port. The test then fails to connect on the expected port. Fix: remove proxysql.db and proxysql_stats.db before launching the replica, not just after. The post-launch cleanup is kept as well for normal operation.	2 weeks ago
Rene Cannao	0f76a18329	fix: resolve CI failures in charset_find and statistics unit tests charset_find_unit-t: - Fix plan count mismatch: plan(63) but only 62 ok() calls. Changed to plan(62). statistics_unit-t: - Root cause: TSDB auto-detect in Makefile searched for symbol 'ProxySQL_TSDB' which doesn't exist. Changed to 'init_tsdb_variables'. Without TSDB detection, struct layout mismatch caused statsdb_disk to appear as NULL (member offset shifted by #ifdef PROXYSQLTSDB). - Added statsdb_ok guard + skip() for test_init_creates_tables to prevent segfault if construction fails (graceful degradation). - Use TMPDIR/tmp directly instead of GloVars.datadir for statsdb path.	2 weeks ago
Yuji Hatakeyama	eda537ac6c	Add reg_test_5306 to test groups, excluding digest-disabled configs	2 weeks ago
Yuji Hatakeyama	7e1b8ac0e4	Fix #5306 : Add regression test for SHOW WARNINGS with comments	2 weeks ago
Rene Cannao	99dcb5b160	fix: namespace stats_utils helpers to avoid symbol collision ProxySQL_Admin_Tests2.cpp defines its own parse_int_or_zero() in an anonymous namespace. Our declaration in Stats_Tool_Handler.h (included transitively via cpp.h) created an ambiguous overload error. Fix: wrap the 4 helper functions in namespace stats_utils in both the header and implementation. A using-directive within the .cpp keeps existing call sites working without qualification.	2 weeks ago
Rene Cannao	99c86e5759	test: run check_groups.py at start of run-multi-group.bash Abort CI early if any compiled test binaries are missing from groups.json. This prevents silent test omissions — if a developer adds a test but forgets to register it, CI fails immediately with a clear message instead of silently skipping it.	2 weeks ago
Rene Cannao	093693ba06	test: add check_groups.py to verify groups.json completeness Python tool that checks consistency between groups.json and compiled TAP test binaries: - WARNING (exit 0): tests in groups.json that aren't compiled yet - ERROR (exit 1): compiled tests missing from groups.json Scans test/tap/tests/, test/tap/tests/unit/, and test/tap/tests_with_deps/ for ELF binaries matching *-t pattern. Usage: python3 test/tap/groups/check_groups.py	2 weeks ago
Rene Cannao	fa668d646a	test: register 21 new unit tests in groups.json for CI Add all new unit test binaries to the CI test group configuration: - 13 core tests → unit-tests-g1 - 8 GenAI tests → ai-g1 This ensures CI pipelines discover and run all new tests.	2 weeks ago
Rene Cannao	ece648fc16	test: add 6 more unit test files with 550 assertions (Tier 2+3) Expand coverage for firewall whitelist, statistics, config validation, logging, and GenAI thread variable management. New test files (test/tap/tests/unit/): Core: - query_processor_firewall_unit-t (44 tests): load_firewall() users/rules/sqli fingerprints, find_firewall_whitelist_user/rule, whitelisted_sqli_fingerprint, reload/clear, memory accounting, PgSQL parity, multiple digest bsearch - statistics_unit-t (20 tests, 95 with TSDB): timer functions (timetoget for MySQL threads, query cache, CPU, logger, digest), TSDB set/get/has variable with range validation, insert/query metrics, backend health, downsampling, retention - config_validation_unit-t (54 tests): addField() formatting and escaping, validate_backend_users() duplicate detection for MySQL/PgSQL, validate_backend_servers() with field aliases and default ports, validate_proxysql_servers() - log_utils_unit-t (42 tests): LogBuffer append/write/operator<< overloads, data() accessor, reset(), should_log() rate limiting, GetLogBufferThreadContext() lifecycle GenAI/MCP (PROXYSQLGENAI=1): - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler constructor defaults (26 vars), boolean/port/timeout/string variable set/get with range validation, has_variable, get_variables_list, null safety, target auth map - genai_thread_unit-t (193 tests): GenAI_Threads_Handler constructor defaults (31 vars), integer range validation for 15+ variables, double/boolean/string round-trips, has_variable, get_variables_list, overwrite and rejection persistence Note: found potential bug — llm_cache_enabled has no get/set handler despite being listed in variables array Minimal production change: - include/proxysql_config.h: add friend class for test access to private validate_backend_users/servers/proxysql_servers methods Running totals: 21 test files, 1268 assertions, all passing.	2 weeks ago
Rene Cannao	1d2f16b506	test: add 4 more unit test files with 198 assertions (Tier 1) Expand coverage for charset lookups, GenAI Query/LLM/MCP components. New test files (test/tap/tests/unit/): Core: - charset_find_unit-t (62 tests): all 4 proxysql_find_charset functions — edge cases for NULL returns, utf8mb3→utf8 translation, case-insensitive matching, collation preference GenAI/MCP (PROXYSQLGENAI=1): - genai_query_handler_unit-t (65 tests): validate_sql_identifier, escape_string_literal, strip_leading_comments, json_string/ json_int/json_double safe extraction, is_pgsql_protocol, is_runtime_online_status, uppercase_or_unknown - genai_llm_clients_unit-t (35 tests): is_retryable_error HTTP status codes (408/429/5xx) and CURL error codes, plus LLM_WriteCallback data accumulation - genai_mcp_endpoint_unit-t (36 tests): validate_bearer_token extraction/comparison, create_jsonrpc_response/error JSON-RPC 2.0 formatting Minimal production changes for testability: - include/Query_Tool_Handler.h: friend class + extern declarations for 8 pure helper functions - lib/Query_Tool_Handler.cpp: remove static from 8 file-local pure functions (no behavioral change) - include/MCP_Endpoint.h: friend class + new static validate_bearer_token() extracted from authenticate_request() - lib/MCP_Endpoint.cpp: extract token validation into static method - lib/LLM_Clients.cpp: remove static from is_retryable_error() and rename WriteCallback to LLM_WriteCallback (avoid collisions) Running totals: 15 test files, 718 assertions, all passing.	2 weeks ago
Rene Cannao	accc68c9dc	test: add 11 new unit test files with 520 assertions for lib/ coverage Add targeted unit tests for pure functions and isolated components across lib/, increasing test coverage for both core utilities and GenAI/MCP components. New test files (test/tap/tests/unit/): Core utilities: - pgsql_variables_validator_unit-t (75 tests): bool, float, string, memory size, search_path, and client_encoding validators - gen_utils_unit-t (28 tests): mywildcmp wildcard matching, escape_string_single_quotes, Proxy_file_regular - mysql_encode_unit-t (23 tests): mysql_encode_length, CPY3/CPY8, proxy_my_crypt XOR, write_encoded_length - proxysql_utils_unit-t (23 tests): hex/unhex, sql_escape, split_str, replace_str, generate_multi_rows_query, checksums - proxy_protocol_unit-t (22 tests): PROXY v1 header parsing, subnet validation, IPv4/IPv6 network matching - pgsql_error_helper_unit-t (139 tests): SQLSTATE code mapping, all 38 error class branches, severity classification, fill/reset - pgsql_txn_state_unit-t (54 tests): TxnCmdParser for BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, AND CHAIN variants - sqlite3db_unit-t (21 tests): execute, return_one_int, check_table_structure, build_table, row ops, locking GenAI/MCP (PROXYSQLGENAI=1): - genai_stats_parsing_unit-t (79 tests): parse_server_filter, parse_digest_filter, parse_ll_or_zero, get_interval_config, calculate_percentile - genai_fts_string_unit-t (32 tests): MySQL_FTS sanitize_name, escape_identifier, escape_sql, table name construction - genai_anomaly_unit-t (24 tests): normalize_query SQL normalization, check_sql_injection pattern detection Minimal production changes for GenAI testability: - include/Anomaly_Detector.h: add friend class for test access - include/Stats_Tool_Handler.h: declare 4 parsing helpers, move 2 pure computation methods (get_interval_config, calculate_percentile) to public - lib/Stats_Tool_Handler.cpp: remove static from 4 free helper functions (no behavioral change, only linkage visibility)	2 weeks ago
Rene Cannao	1ebe4de9b7	Fix mysql84 pre-proxysql hook, basictests setup, and move flaky tests - mysql84 pre-proxysql.bash: use docker exec for all ProxySQL admin commands (was using mysql -h127.0.0.1 which can't reach the container) - basictests setup-infras.bash: use INSERT OR REPLACE when remapping hostgroups 1300/1301 -> 0/1 to avoid UNIQUE constraint violation when target hostgroups already have entries - proxysql-tester.py: skip per-stage coverage generation when MULTI_GROUP=1 (was spawning 32 gcov processes on 35k .gcno files) - Move test_cluster_sync-t and test_read_only_actions_offline_hard_servers-t to legacy-g5 pending investigation of cluster sync algorithm issues. Move reg_test_3765_ssl_pollout-t from legacy-g5 to legacy-g4.	2 weeks ago
Rene Cannao	39840b5393	Exclude /usr and deps from coverage reports fastcov was including system headers (/usr/include/c++/...) and vendored dependencies (deps/json/json.hpp) in coverage output. Use --exclude instead of --include since project source files have bare filenames in gcov output (no path prefix to match against), while system/deps paths are always absolute.	2 weeks ago
Rene Cannao	5a8b6e9a89	Fix gcov coverage collection for multi-group CI runs Three problems caused machine stalls and 0% coverage in multi-group runs: 1. All test-runner containers wrote TAP test .gcda files to the shared ${WORKSPACE}, causing concurrent corruption and memory bloat when multiple gcov processes fought over the same files. 2. Each container independently ran fastcov -j$(nproc) in its EXIT trap, spawning hundreds of concurrent gcov processes across all containers. 3. GCOV_PREFIX_STRIP=3 placed .gcda at proxysql/lib/obj/ but .gcno was copied to lib/obj/ — path mismatch meant gcov couldn't correlate them. Additionally, the --include filter expected full workspace paths but gcov records bare filenames, so all results were filtered out. Changes: - Set GCOV_PREFIX=/gcov/tap on test-runner containers so TAP .gcda files go to per-INFRA_ID /gcov/tap/ instead of shared workspace. - Pass MULTI_GROUP=1 from run-multi-group.bash to test-runners. When set, the EXIT trap copies .gcno adjacent to .gcda (handling path offset from GCOV_PREFIX_STRIP) but skips fastcov/genhtml. - Add centralized coverage collection in run-multi-group.bash: processes each group's /gcov directory sequentially with fastcov -j4 after all groups finish, then combines the .info files. - Remove --include filter from fastcov (source paths are bare filenames, not full paths, so the filter rejected everything). - Standalone mode (no MULTI_GROUP) is unchanged.	2 weeks ago
Rene Cannao	83c3e76506	Fix libparser.so loading for CI test binaries TAP test binaries link libcpp_dotenv.so which transitively needs libparser.so. The RUNPATH baked into libcpp_dotenv.so contains stale paths from the original build, so the dynamic linker can't find it. - Add LD_LIBRARY_PATH for the SKIP_PROXYSQL (unit test) host path - Add TAP_DEPS_PATH to env-isolated.bash so proxysql-tester.py constructs the correct LD_LIBRARY_PATH inside Docker containers	2 weeks ago
Rene Cannao	f8c64142cb	Fix cluster CI: remove duplicate primary INSERT and add sync_algorithm=3 - Remove redundant INSERT of primary into proxysql_servers on nodes. Commit `b02147b92` added the primary to the shared PROXYSQL_SERVERS_SQL but didn't remove the pre-existing per-node INSERT, causing a UNIQUE constraint violation that broke all multi-node CI groups. - Add cluster_mysql_servers_sync_algorithm=3 to test_cluster_sync config files and update hardcoded datadir paths to match current workspace.	2 weeks ago
Rene Cannao	bd51ff4f37	test(ffto): E2E test for PostgreSQL FF error recording in stats_pgsql_errors	2 weeks ago
Rene Cannao	11e37e7e5f	test(ffto): E2E test for MySQL FF error recording in stats_mysql_errors	2 weeks ago
Rene Cannao	c7647c7387	Fix coverage: generate separate reports and combine with fastcov -C Coverage data comes from two sources that may overlap: /gcov — ProxySQL daemon execution (via GCOV_PREFIX) WORKSPACE — TAP test execution (.gcda next to binaries) Both may cover the same code (e.g. libproxysql.a exercised by both ProxySQL runtime and TAP test harness). Previously we copied .gcda files between directories, which either overwrote (cp -f) or kept only the first version (cp -n) instead of combining counters. Now generates two separate .info files (proxysql.info + tap_tests.info) and combines them with fastcov -C, which correctly sums execution counters for overlapping source files.	2 weeks ago
Rene Cannao	fe701d29aa	feat(ffto): add pgsql_parse_error_response() helper with unit tests	2 weeks ago
Rene Cannao	1c559e96d8	feat(ffto): add mysql_parse_err_packet() helper with unit tests	2 weeks ago
Rene Cannao	8ca54a9def	Fix coverage: don't overwrite ProxySQL's gcda files with stale copies The coverage collection copied ALL .gcno and .gcda files from the workspace to /gcov using cp -f. But ProxySQL's .gcda files (with real execution data from the Docker container) were already in /gcov via GCOV_PREFIX. The cp -f overwrote them with the host's stale .gcda files (zero or outdated execution counts). This caused lib/MySQLFFTO.cpp and lib/PgSQLFFTO.cpp (and likely other ProxySQL library files) to show 0% coverage despite the FFTO tests running successfully and the .gcda files having real data. Fix: copy .gcno files with cp -f (always needed for fastcov), but copy .gcda files with cp -n (no-clobber) so ProxySQL's existing execution data in /gcov is preserved. TAP test .gcda files that don't exist in /gcov yet are still copied.	2 weeks ago
Rene Cannao	b02147b92b	Include primary in its own proxysql_servers table When a cluster node syncs proxysql_servers from the primary and runs LOAD PROXYSQL SERVERS TO RUNTIME, it rebuilds the node list from the synced data. If the primary isn't in its own proxysql_servers table, the synced list won't include it. The node then destroys the cluster monitor thread for the primary and never recreates it. Evidence: node 1 log shows "Destroyed Cluster Node Entry for host proxysql:6032" followed by "closing thread for peer proxysql:6032" after syncing proxysql_servers from the primary. After that, the node never detected any further checksum changes from the primary, causing test_cluster1-t and test_unshun_algorithm-t to fail. Fixes #5542.	2 weeks ago
Rene Cannao	f98a0e85ed	Remove Query_Processor.cpp debug filter that broke fast_routing test The debug filter for Query_Processor.cpp/process_query suppressed the "Searching thread-local 'rules_fast_routing' hashmap" messages that test_query_rules_fast_routing_algorithm-t relies on to verify fast routing behavior (expects 20 log entries, gets 0).	2 weeks ago
Rene Cannao	72a1c5dd4a	Set cluster_mysql_servers_sync_algorithm=3 in test_cluster_sync replica config The replica used the default algorithm (1) which syncs runtime mysql_servers — including monitor-shunned status. The test checks the config table (mysql_servers) for status='ONLINE', but the runtime sync overwrites the config table with SHUNNED status. With auto_select (3) and monitor enabled (-M flag), the replica uses mysql_servers_v2 sync which preserves the configured status.	2 weeks ago
Rene Cannao	0fa1b53709	Fix test_cluster_sync-t: connect to spawned replica via 127.0.0.1 The test spawns its own ProxySQL replica (port 16062) inside the test-runner container, but connected to it via cl.host (TAP_ADMINHOST) which resolves to the main ProxySQL container in the Docker setup. Since port 16062 doesn't exist on the main container, the connection hung indefinitely, causing the test to stall. Now uses R_HOST="127.0.0.1" for all replica connections (R_PORT), since the replica runs locally inside the same container as the test.	2 weeks ago
Rene Cannao	3c4ebf0da7	Set cluster_mysql_servers_sync_algorithm=3 (auto_select) on all nodes The default value (1) syncs both configured AND runtime mysql_servers, including changes made by the monitor (read_only checks moving servers between writer/reader hostgroups). This caused circular sync: a cluster node's monitor modified servers, creating a newer epoch, and the primary synced this back — overwriting its correct config and saving the corrupted version to disk. With auto_select (3), the algorithm chooses mysql_servers_v2 when the monitor is enabled, which only syncs user-configured changes and ignores monitor-triggered runtime modifications. Evidence: node 6042's monitor removed MariaDB servers from hostgroup 1701 ("Setting status OFFLINE HARD"), creating checksum 0x7C0A67D5 with epoch 1774288555. Primary (epoch 1774288549) synced from node 6042 and saved to disk, losing hostgroup 1300 permanently. Fixes #5540.	2 weeks ago
Rene Cannao	fb9ff4476e	Include TAP test coverage: copy .gcda files from source tree to /gcov TAP test binaries are compiled with gcov but their .gcda files are written to the source tree (next to the binaries), not to /gcov. The coverage collection only scanned /gcov, missing all TAP test coverage data. Now copies both .gcno and .gcda files from the workspace into /gcov before running fastcov, so TAP test coverage is included in reports.	2 weeks ago
Rene Cannao	0f12f5d6f1	Fix TAP_CLUSTER_NODES: include primary (6032) as first entry test_cluster1-t expects conns[0] to be the primary ProxySQL instance. TAP_CLUSTER_NODES only listed nodes 1-9 (ports 6042-6122), so the test loop operated on nodes 1-4 instead of primary + nodes 1-3. Node 4 (port 6072) is NOT in proxysql_servers (only core nodes 1-3 are registered), so changes on node 4 were invisible to the cluster — sync could never detect them, causing the 30-second timeout. Now TAP_CLUSTER_NODES starts with proxysql:6032 (primary), matching the old cluster_ports layout where 6032 was the first entry. Fixes #5535.	2 weeks ago
Rene Cannao	a4675096b5	Fix cluster admin_variables sync: set same admin vars on primary and nodes The primary had admin-debug=false and admin-restapi_enabled=false (defaults), while cluster nodes had them set to true. Since these variables are NOT in the CLUSTER_SYNC_INTERFACES_ADMIN exclusion list, they're included in the checksum. The checksum mismatch between primary and nodes caused admin_variables sync to never converge on satellite nodes. Now the primary sets the same admin-restapi_enabled=true and admin-debug=true as all nodes, ensuring matching checksums. Fixes #5535.	2 weeks ago
Rene Cannao	5f7fb254a9	Fix pgsql transaction test and auth_methods crash-on-skip - pgsql-transaction_variable_state_tracking-t: replace superuser-only variable allow_in_place_tablespaces with user-settable enable_mergejoin. Fixes #5536. - test_auth_methods-t: call stop_internal_noise_threads() before early return on MySQL 5.7, preventing 'terminate called without an active exception' crash from joinable std::thread destructors. Fixes #5537.	2 weeks ago
Rene Cannao	7739b86745	Move test_auth_methods-t from legacy-g2 to mysql84-g2 only Test requires MySQL 8.0+ (detects 5.7 and skips, but crashes with 'terminate called without an active exception' during noise thread cleanup). The crash-on-skip is a separate test bug.	2 weeks ago
Rene Cannao	5c9121ef40	Add hostgroup debug diagnostics and cache test tolerance - Add dump_hostgroup_debug() utility: dumps runtime_mysql_servers and stats_mysql_connection_pool for a given hostgroup via diag() output. Helps diagnose "hostgroup has no servers available" CI failures. - test_throttle_max_bytes_per_second_to_client-t: dump hostgroup 1300, 0, and 1 when create_table_test_sbtest1() fails. - test_warnings-t: dump target hostgroup state before running tests. - test_unsupported_queries-t: dump target hostgroup state before running tests. - test_query_cache_soft_ttl_pct-t: add tolerance of +1 to all three assertions. The soft TTL refresh race allows two threads to both see "needs refresh" simultaneously under load, producing one extra backend hit. This is a known property of the soft TTL mechanism.	2 weeks ago
Rene Cannao	42f4507e72	Fix test_tls_stats plan count and move caching_sha2 to mysql84 - test_tls_stats-t: plan(29) -> plan(27). The test executes 27 ok() calls on the happy path; plan was miscounted during authoring. - reg_test_4935-caching_sha2-t: remove from legacy-g4 (MySQL 5.7 doesn't support caching_sha2_password). Keep in mysql84-g4.	2 weeks ago
Rene Cannao	82c112c461	Fix coverage: restore GCOV_PREFIX for primary after unsetting for cluster nodes	2 weeks ago

1 2 3 4 5 ...

2150 Commits (v3.0_pgsql_sslkeylog_5281)