35 Commits (v3.0_fix_codecov-coverage-path-prefix)

Author	SHA1	Message	Date
Rahim Kanji	6909011b67	perf(partition): promote longest-waiting B session via max_connect_time fold ... Under sustained contention ProcessAllSessions_Partition leaves the B (CONNECTING_SERVER) band unordered, so the pass can serve newer waiters ahead of older ones until they hit connect_timeout_server_max and abort. Track the oldest waiter during the classifier's is_B arm (no second pass) and swap it to running_end. Key on max_connect_time, which the is_B test already loads -- the min-compare is a register compare with no extra memory access, and the smallest value is the waiter closest to the timeout abort. Gated by |B| > PARTITION_FAIRNESS_MIN_B (=4) and partition_active.	1 month ago
Rahim Kanji	53eea80aaf	feat(partition-gate): suppress low-volume ticks via min-attempts floor ... Add PARTITION_GATE_MIN_ATTEMPTS (=4). When a tick has fewer pool acquires than this, leave both gate state and streak counter untouched. Filters the "2/2 NULL = 100% stressed" noise case without drifting the gate OFF on transient idle ticks (which would happen if low- volume ticks were treated as not-stressed). Pairs with the existing mysql_sessions->len > 3 guard at the partition call site.	1 month ago
Rahim Kanji	878ba3b1e6	refactor(partition-gate): consolidate into Base_Thread; drain every iteration; widen ratio to uint64_t ... Three closely related changes: * Move the four partition_* members and note_pool_attempt() from MySQL_Thread / PgSQL_Thread into Base_Thread. Eliminates 22 lines of duplicated gate logic across the two protocol implementations. * Run update_partition_gate() once per process_all_sessions outer iteration, before the sess_sort / len > 3 / partition_active check. Per-tick counters can no longer accumulate stale across ticks where partition is skipped (sess_sort off, IDLE_THREADS maintenance thread, or session count below threshold), which in 5b5b937 could cause spurious gate flips after sess_sort toggled back on. * Widen the ratio comparison to uint64_t so the multiplications cannot overflow unsigned int (reachable in combination with the staleness issue above). Function-local HI_NUM/HI_DEN/STREAK locals are promoted to named static constexpr class members (PARTITION_GATE_NULL_RATIO_NUM/DEN/STREAK). No new behavior introduced -- purely correctness fixes plus a behavior-preserving refactor.	1 month ago
Rene Cannao	25d9ea8c4c	perf: remove Pass 2 sort from ProcessAllSessions_Partition ... The Lomuto-style sort of the B band (sessions waiting on a backend) by max_connect_time, added on this branch, was measured to be a net loss for throughput under sustained workloads: at 1 worker thread, 500 clients, 50-conn backend pool, 4 KB rows under SSL, removing the sort gained ~12% qps and ~20% average latency. The earlier Pass 1 (3-way partition into running / waiting / idle blocks) is kept and remains net beneficial on its own (block A is processed first in the outer loop, so end-of-query conn releases become available to block B waiters in the same iteration). If the sort is reintroduced later for tail-latency-sensitive workloads, it should be gated by an explicit starvation-age signal, not run unconditionally on every outer iteration.	1 month ago
Rahim Kanji	0e09ec59e9	replace K_WAIT wait-time promotion with single-pass mct sort ... In ProcessAllSessions_Partition the two-loop K_WAIT * avg(wait_time) promotion is replaced with a single Lomuto-style sweep over the B band using max_connect_time as the ordering key. This is the same algorithm as the pre-PR ProcessAllSessions_SortingSessions, just scoped to the B band that Pass 1 has already isolated.	2 months ago
Rahim Kanji	587950de65	promote long-waiters in block B by wait-time threshold ... After the 3-way A/B/C partition, sweep block B once and promote any session whose wait_time exceeds K_WAIT * avg(wait_time) toward the front of the B band. This gives sessions that have been waiting longer than the block average a chance at the next released backend conn, reducing head-of-line starvation when many clients share few conns. - Loop 1 (partition pass) now also accumulates sum_wait and b_count over block B, where wait_time = curtime - CurrentQuery.start_time in microseconds. CurrentQuery.start_time is guaranteed non-zero for any session in B; the (st && curtime > st) guard is defensive. - Loop 2 (O(b_count)) is a one-sided in-place partition: any B session with wt > K_WAIT * avg(wt) is swapped toward running_end. The promoted group is moved together but not sorted internally; same on the non-promoted side. The next pass re-evaluates with fresh wt.	2 months ago
Rahim Kanji	ca202ceba1	Refactor: partition sessions by backend state instead of sorting ... Replace ProcessAllSessions_SortingSessions with ProcessAllSessions_Partition. The old function did an implicit one-pass swap-sort over mysql_sessions by max_connect_time; the new one explicitly partitions sessions into three contiguous blocks in pdata according to their backend state: [0, running_end) A: running a query against the backend [running_end, idle_begin) B: acquiring a backend (max_connect_time != 0) [idle_begin, len) C: idle (no backend, or holding a conn while parked in WAITING_CLIENT_DATA)	2 months ago
Rene Cannao	2c4cc0c0d4	fix(lib): eliminate compiler warnings in core library files ... - Fix sign-compare warnings in ProxySQL_RESTAPI_Server (size_t vs int) - Remove duplicate itostr macro in Base_HostGroups_Manager, MySQL_HostGroups_Manager, PgSQL_HostGroups_Manager (already in proxysql_macros.h) - Mark unused 'thr' variable in Base_Thread::run_SetAllSession_ToProcess0 - Remove redundant query_no_space_alloc_size in Admin_Handler (use query_length directly) - Fix string literal to char* assignment in MySQL_HostGroups_Manager	3 months ago
Rene Cannao	4e39297ef9	Fix more Valgrind uninitialized value errors ... 1. Base_Thread.cpp: Initialize member variables in constructor - curtime, last_move_to_idle_thread_time, epoll_thread, shutdown, mysql_sessions were not initialized, causing uninitialized value use in ProcessAllMyDS_BeforePoll and ProcessAllMyDS_AfterPoll. 2. MySQL_Logger.cpp: Initialize query_ptr, query_len, and buf in MySQL_Event constructor. These fields were used without initialization, causing Valgrind errors in JSON serialization and other operations.	5 months ago
René Cannaò	fcaa904135	fix: crash on macOS/FreeBSD when running PostgreSQL queries ... Fix NULL pointer dereference in CopyCmdMatcher that caused ProxySQL to crash immediately when running any PostgreSQL query on macOS and FreeBSD systems. Root cause: copy_cmd_matcher was guarded by #ifdef IDLE_THREADS, but IDLE_THREADS is explicitly disabled on macOS (__APPLE__) and FreeBSD in proxy_defines.h. This caused the pointer to be NULL when accessed. The fix removes #ifdef IDLE_THREADS guards from copy_cmd_matcher since COPY command detection is a fundamental PostgreSQL feature for fast- forward mode and has no dependency on idle threads. Affected systems: macOS, FreeBSD (where IDLE_THREADS is disabled) Fixes: #5359	5 months ago
René Cannaò	d43ae6e121	Surgical fixes for macOS compatibility: headers, types, and Makefile linking	5 months ago
Rahim Kanji	4d91452fc5	Implement backend query cancellation for PostgreSQL #5136 ... Add support for PostgreSQL query cancellation and backend termination features to allow clients to cancel long-running queries and terminate connections through the standard PostgreSQL protocol. Features implemented: - Intercept pg_backend_pid() queries and return ProxySQL session thread ID - Intercept pg_terminate_backend() to terminate client connections asynchronously - Intercept pg_cancel_backend() to cancel queries on backend connections - Support Cancel Request protocol via separate connection with PID and secret key validation - Return BackendKeyData message on successful authentication with session thread ID and unique cancel secret key This enables clients to use standard PostgreSQL cancellation mechanisms (pg_cancel_backend, pg_terminate_backend, and Cancel Request protocol) while ProxySQL maintains proper session isolation and maps client requests to appropriate backend connections.	9 months ago
Rahim Kanji	ce94a7080a	Merge branch v3.0_session_param_reset_connection into v3.0_extended_query_protocol	11 months ago
Rahim Kanji	1bcd09044b	Refactor Connection Reset Handling ... * Introduced startup parameters in PgSQL_Connection (removed default session parameters from PgSQL_Session) * Startup parameters are populated during both frontend and backend connection creation * Parameters provided via connection options are set as startup parameters * Backend connection parameter handling updated: only critical variables are now set via connection options to prevent interference with DISCARD ALL during connection reset; remaining parameters will be applied using individual SET commands	11 months ago
Rahim Kanji	24fecc1f6e	Add PostgreSQL extended query (prepared statement) support in ProxySQL ... This commit lays the groundwork for handling PostgreSQL’s extended query protocol (prepared statements) by introducing parsing, it's caching and execution framework stubs. - Implement Parse handling - Implement caching of parse (reuse) - Introduce Execute framework stub for future binding and execution logic.	1 year ago
Rahim Kanji	d113bcb193	Use PG_EVENT_WRITE status for PgSQL	1 year ago
René Cannaò	c6b8485d24	Avoid crash on slow shutdown	1 year ago
Rahim Kanji	99d9708eeb	Removed dead code	1 year ago
Rahim Kanji	395a977e68	Merge branch 'v3.0'	2 years ago
Rahim Kanji	f33fd02c37	Add COPY ... FROM STDIN detection regex	2 years ago
Rahim Kanji	6d614a4b99	Merge branch 'v3.0'	2 years ago
Rahim Kanji	3b5671267f	Implemented overflow-safe multiplication for mysql_thread___threshold_resultset_size and pgsql_thread___threshold_resultset_size	2 years ago
Rahim Kanji	c7f7705cde	Code cleanup	2 years ago
Rahim Kanji	720441af20	Refactored and Optimized Query Cache with PgSQL Support ... * Added Query Cache Support for PgSQL: * Introduced new variables for PgSQL Query Cache management: * pgsql-query_cache_size_MB * pgsql-query_cache_soft_ttl_pct * pgsql-query_cache_stores_empty_result * pgsql-query_cache_handle_warnings (not yet utilized) * Overwriting Transaction Status: * Sending current transaction state to the client when a result is returned from the query cache. * This currently does not differentiate between normal and error transaction states—both are treated as active transaction states. * Cache Lifetime Management: Replaced manual reference counting with std::shared_ptr to efficiently manage the lifecycle of cache entries, ensuring proper memory deallocation and reducing complexity. * Unified Purging Logic: Refactored the query cache purging logic to use a single thread for both MySQL and PgSQL cache entries. * Code Cleanup: Removed unnecessary methods and data members to streamline the codebase and improve maintainability. * Performance Optimization: Improved memory management, reducing memory footprint and enhancing performance.	2 years ago
Rahim Kanji	5bf827d8e4	Removed type selector	2 years ago
Rahim Kanji	991031c938	Increased resultset buffer size to exact 16K	2 years ago
Rahim Kanji	a2516654cf	Added PgSQL Thread variables. ... Using a few MySQL thread variables, particularly for query digest, query processor, and query cache. In the future, we plan to create a global variable for modules that are common to both MySQL and PGSQL	2 years ago
René Cannaò	2d7806c325	Moved run_SetAllSession_ToProcess0 to Base_Thread	2 years ago
René Cannaò	e0e8c125c5	Adding explicitly instantiate of template class functions	2 years ago
René Cannaò	483b8335d3	More functions moved to Base_Thread ... * move_session_to_idle_mysql_sessions * find_session_idx_in_mysql_sessions * ProcessAllMyDS_BeforePoll	2 years ago
René Cannaò	a881936cad	More functions moved to Base_Thread ... * ProcessAllMyDS_AfterPoll * read_one_byte_from_pipe * tune_timeout_for_myds_needs_pause * tune_timeout_for_session_needs_pause * configure_pollout * set_backend_to_be_skipped_if_frontend_is_slow	2 years ago
René Cannaò	db6cb93fb9	Moved ProcessAllSessions_SortingSessions to Base_Thread	2 years ago
René Cannaò	8389f76413	More functions moved to Base_Thread() ... * check_timing_out_session() * check_for_invalid_fd()	2 years ago
René Cannaò	c903a45633	Second attempt to use Base_Thread ... Moved register_session() into Base_Thread. Moved Session_Regex() from Client_Session() to Base_Session() just to fix some compiler issue. Also removed some dead code from previous commit.	2 years ago
René Cannaò	0cfab2616f	First attempt to use Base_Thread and Base_Session	2 years ago