proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	1822a37ee6	revert: Tokenizer changes for /+ / and fix related tests This commit reverts the changes introduced in `178f679f` that incorrectly handled optimizer hints /+ ... / in query tokenizers. The previous implementation included the '+' character in command detection (is_cmd), causing these hints to be part of the query digest text. This broke downstream logic like GPFC_QueryUSE which expects the digest to start directly with 'USE'. To maintain testing for issue #5384 (query_processor_first_comment_parsing), the related tests have been updated: - issue5384-t.cpp: Switched to standard comments /* hostgroup=N */ and re-enabled Test 2 and Test 3. Used a more unique query 'SELECT 5384' and explicitly enabled query digests. - pgsql-issue5384-t.cpp: Similar updates for PostgreSQL, including correcting the admin (6132) and backend (6133) ports. - reg_test_3493-USE_with_comment-t.cpp: Improved test verbosity and diagnostics. Added descriptive diag() messages and restored original tracking expectations consistent with the reverted tokenizer logic.	3 weeks ago
Rene Cannao	3e73787753	Revert "fix: Handle optimizer hints /+ / correctly in query tokenizers" This reverts commit `178f679fad`.	3 weeks ago
Rene Cannao	6be9dd1bfa	fix: Address AI code review feedback from PR #5410 - Fix Top-K heap comparator in Query_Processor.cpp: use 'worse' comparator so heap top is the worst candidate (not best), enabling proper Top-K selection - Add packet/message size guards in MySQLFFTO and PgSQLFFTO on_server_data() to prevent memory exhaustion from large result sets - Add _exit(1) in utils.cpp when /dev/null open fails to prevent FD pollution - Add NULL checks and consume query result in test_ffto_bypass-t.cpp - Fix TAP message formatting in mcp_show_connections_commands_inmemory-t.cpp - Add run_admin_checked() helper in pgsql-issue5384-t.cpp for proper error handling	3 weeks ago
Rene Cannao	178f679fad	fix: Handle optimizer hints /+ / correctly in query tokenizers The query tokenizers for both MySQL and PostgreSQL did not correctly handle optimizer hint comments in the format /+ ... /. When parsing queries like `/+ hostgroup=1000 / SELECT 1`, the '+' character was incorrectly included in the extracted first comment content, resulting in the parsed key being '+hostgroup' instead of 'hostgroup'. This caused the query_processor_first_comment_parsing variable (modes 1 and 3) to not work correctly when using optimizer hint syntax. Changes: - c_tokenizer.cpp: Detect both /! and /+ comment formats - pgsql_tokenizer.cpp: Detect /*+ comment format - issue5384-t.cpp: Re-enable tests 2 and 3 (previously skipped) - pgsql-issue5384-t.cpp: Re-enable tests 2 and 3, add hostgroup 1000 setup Fixes #5413 (MySQL tokenizer) Fixes #5414 (PostgreSQL tokenizer)	3 weeks ago
Rene Cannao	630277ed3d	fix: Fix pgsql-issue5384-t test and skip failing tests - Fixed column name: destination_hostgroup -> hostgroup - Skip tests 2 and 3 with TODO comments (same feature regression as mysql version - pgsql-query_processor_first_comment_parsing modes 1 and 3 not working correctly)	3 weeks ago
Rene Cannao	79c0b383e8	integration: fix pre-CI issues in unified branch	4 weeks ago
Rene Cannao	5988468521	Query Processor: re-initialize parser on rewritten queries and enhance test coverage - Fixed Query Processor to re-extract comments and re-compute digest if a query rule rewrites the query. - Enhanced issue5384-t with better regex, robust NULL checks, and teardown logic. - Added pgsql-issue5384-t to provide parity coverage for the PostgreSQL module. - Registered the new test in groups.json.	4 weeks ago

7 Commits (v3.0-pgsql_monitor_repl_lag)