proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	0f76a18329	fix: resolve CI failures in charset_find and statistics unit tests charset_find_unit-t: - Fix plan count mismatch: plan(63) but only 62 ok() calls. Changed to plan(62). statistics_unit-t: - Root cause: TSDB auto-detect in Makefile searched for symbol 'ProxySQL_TSDB' which doesn't exist. Changed to 'init_tsdb_variables'. Without TSDB detection, struct layout mismatch caused statsdb_disk to appear as NULL (member offset shifted by #ifdef PROXYSQLTSDB). - Added statsdb_ok guard + skip() for test_init_creates_tables to prevent segfault if construction fails (graceful degradation). - Use TMPDIR/tmp directly instead of GloVars.datadir for statsdb path.	2 months ago
Rene Cannao	ece648fc16	test: add 6 more unit test files with 550 assertions (Tier 2+3) Expand coverage for firewall whitelist, statistics, config validation, logging, and GenAI thread variable management. New test files (test/tap/tests/unit/): Core: - query_processor_firewall_unit-t (44 tests): load_firewall() users/rules/sqli fingerprints, find_firewall_whitelist_user/rule, whitelisted_sqli_fingerprint, reload/clear, memory accounting, PgSQL parity, multiple digest bsearch - statistics_unit-t (20 tests, 95 with TSDB): timer functions (timetoget for MySQL threads, query cache, CPU, logger, digest), TSDB set/get/has variable with range validation, insert/query metrics, backend health, downsampling, retention - config_validation_unit-t (54 tests): addField() formatting and escaping, validate_backend_users() duplicate detection for MySQL/PgSQL, validate_backend_servers() with field aliases and default ports, validate_proxysql_servers() - log_utils_unit-t (42 tests): LogBuffer append/write/operator<< overloads, data() accessor, reset(), should_log() rate limiting, GetLogBufferThreadContext() lifecycle GenAI/MCP (PROXYSQLGENAI=1): - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler constructor defaults (26 vars), boolean/port/timeout/string variable set/get with range validation, has_variable, get_variables_list, null safety, target auth map - genai_thread_unit-t (193 tests): GenAI_Threads_Handler constructor defaults (31 vars), integer range validation for 15+ variables, double/boolean/string round-trips, has_variable, get_variables_list, overwrite and rejection persistence Note: found potential bug — llm_cache_enabled has no get/set handler despite being listed in variables array Minimal production change: - include/proxysql_config.h: add friend class for test access to private validate_backend_users/servers/proxysql_servers methods Running totals: 21 test files, 1268 assertions, all passing.	2 months ago

Author

SHA1

Message

Date

Rene Cannao

0f76a18329

fix: resolve CI failures in charset_find and statistics unit tests

charset_find_unit-t:
- Fix plan count mismatch: plan(63) but only 62 ok() calls.
  Changed to plan(62).

statistics_unit-t:
- Root cause: TSDB auto-detect in Makefile searched for symbol
  'ProxySQL_TSDB' which doesn't exist. Changed to 'init_tsdb_variables'.
  Without TSDB detection, struct layout mismatch caused statsdb_disk
  to appear as NULL (member offset shifted by #ifdef PROXYSQLTSDB).
- Added statsdb_ok guard + skip() for test_init_creates_tables to
  prevent segfault if construction fails (graceful degradation).
- Use TMPDIR/tmp directly instead of GloVars.datadir for statsdb path.

Rene Cannao

ece648fc16

test: add 6 more unit test files with 550 assertions (Tier 2+3)

Expand coverage for firewall whitelist, statistics, config validation,
logging, and GenAI thread variable management.

New test files (test/tap/tests/unit/):

  Core:
  - query_processor_firewall_unit-t (44 tests): load_firewall()
    users/rules/sqli fingerprints, find_firewall_whitelist_user/rule,
    whitelisted_sqli_fingerprint, reload/clear, memory accounting,
    PgSQL parity, multiple digest bsearch
  - statistics_unit-t (20 tests, 95 with TSDB): timer functions
    (timetoget for MySQL threads, query cache, CPU, logger, digest),
    TSDB set/get/has variable with range validation, insert/query
    metrics, backend health, downsampling, retention
  - config_validation_unit-t (54 tests): addField() formatting and
    escaping, validate_backend_users() duplicate detection for
    MySQL/PgSQL, validate_backend_servers() with field aliases and
    default ports, validate_proxysql_servers()
  - log_utils_unit-t (42 tests): LogBuffer append/write/operator<<
    overloads, data() accessor, reset(), should_log() rate limiting,
    GetLogBufferThreadContext() lifecycle

  GenAI/MCP (PROXYSQLGENAI=1):
  - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler
    constructor defaults (26 vars), boolean/port/timeout/string
    variable set/get with range validation, has_variable,
    get_variables_list, null safety, target auth map
  - genai_thread_unit-t (193 tests): GenAI_Threads_Handler
    constructor defaults (31 vars), integer range validation for
    15+ variables, double/boolean/string round-trips, has_variable,
    get_variables_list, overwrite and rejection persistence
    Note: found potential bug — llm_cache_enabled has no get/set
    handler despite being listed in variables array

Minimal production change:
- include/proxysql_config.h: add friend class for test access to
  private validate_backend_users/servers/proxysql_servers methods

Running totals: 21 test files, 1268 assertions, all passing.

2 Commits (v3.0-CodeCov0325)