proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	accc68c9dc	test: add 11 new unit test files with 520 assertions for lib/ coverage Add targeted unit tests for pure functions and isolated components across lib/, increasing test coverage for both core utilities and GenAI/MCP components. New test files (test/tap/tests/unit/): Core utilities: - pgsql_variables_validator_unit-t (75 tests): bool, float, string, memory size, search_path, and client_encoding validators - gen_utils_unit-t (28 tests): mywildcmp wildcard matching, escape_string_single_quotes, Proxy_file_regular - mysql_encode_unit-t (23 tests): mysql_encode_length, CPY3/CPY8, proxy_my_crypt XOR, write_encoded_length - proxysql_utils_unit-t (23 tests): hex/unhex, sql_escape, split_str, replace_str, generate_multi_rows_query, checksums - proxy_protocol_unit-t (22 tests): PROXY v1 header parsing, subnet validation, IPv4/IPv6 network matching - pgsql_error_helper_unit-t (139 tests): SQLSTATE code mapping, all 38 error class branches, severity classification, fill/reset - pgsql_txn_state_unit-t (54 tests): TxnCmdParser for BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, AND CHAIN variants - sqlite3db_unit-t (21 tests): execute, return_one_int, check_table_structure, build_table, row ops, locking GenAI/MCP (PROXYSQLGENAI=1): - genai_stats_parsing_unit-t (79 tests): parse_server_filter, parse_digest_filter, parse_ll_or_zero, get_interval_config, calculate_percentile - genai_fts_string_unit-t (32 tests): MySQL_FTS sanitize_name, escape_identifier, escape_sql, table name construction - genai_anomaly_unit-t (24 tests): normalize_query SQL normalization, check_sql_injection pattern detection Minimal production changes for GenAI testability: - include/Anomaly_Detector.h: add friend class for test access - include/Stats_Tool_Handler.h: declare 4 parsing helpers, move 2 pure computation methods (get_interval_config, calculate_percentile) to public - lib/Stats_Tool_Handler.cpp: remove static from 4 free helper functions (no behavioral change, only linkage visibility)	2 months ago

Author

SHA1

Message

Date

Rene Cannao

acaa100dc8

fix: address PR review feedback from coding agents

Actionable fixes from CodeRabbit / agent reviews on PR #5549:

1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t
   used in parse_digest_filter() without direct include

2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix
   check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive.
   This is a real bug fix in production code.

3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count
   dereference with null check to avoid segfault if execute_statement
   returns null

4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset()
   calls on MCP_Threads_Handler that leaked constructor's strdup("")
   allocations for auth fields

5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded
   directory list so new test subdirectories are discovered

6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment
   documenting intentional calloc pattern (ProxySQL_Admin constructor
   has too many daemon deps for unit tests)

Rene Cannao

accc68c9dc

test: add 11 new unit test files with 520 assertions for lib/ coverage

Add targeted unit tests for pure functions and isolated components
across lib/, increasing test coverage for both core utilities and
GenAI/MCP components.

New test files (test/tap/tests/unit/):

  Core utilities:
  - pgsql_variables_validator_unit-t (75 tests): bool, float, string,
    memory size, search_path, and client_encoding validators
  - gen_utils_unit-t (28 tests): mywildcmp wildcard matching,
    escape_string_single_quotes, Proxy_file_regular
  - mysql_encode_unit-t (23 tests): mysql_encode_length, CPY3/CPY8,
    proxy_my_crypt XOR, write_encoded_length
  - proxysql_utils_unit-t (23 tests): hex/unhex, sql_escape,
    split_str, replace_str, generate_multi_rows_query, checksums
  - proxy_protocol_unit-t (22 tests): PROXY v1 header parsing,
    subnet validation, IPv4/IPv6 network matching
  - pgsql_error_helper_unit-t (139 tests): SQLSTATE code mapping,
    all 38 error class branches, severity classification, fill/reset
  - pgsql_txn_state_unit-t (54 tests): TxnCmdParser for BEGIN,
    COMMIT, ROLLBACK, SAVEPOINT, RELEASE, AND CHAIN variants
  - sqlite3db_unit-t (21 tests): execute, return_one_int,
    check_table_structure, build_table, row ops, locking

  GenAI/MCP (PROXYSQLGENAI=1):
  - genai_stats_parsing_unit-t (79 tests): parse_server_filter,
    parse_digest_filter, parse_ll_or_zero, get_interval_config,
    calculate_percentile
  - genai_fts_string_unit-t (32 tests): MySQL_FTS sanitize_name,
    escape_identifier, escape_sql, table name construction
  - genai_anomaly_unit-t (24 tests): normalize_query SQL
    normalization, check_sql_injection pattern detection

Minimal production changes for GenAI testability:
- include/Anomaly_Detector.h: add friend class for test access
- include/Stats_Tool_Handler.h: declare 4 parsing helpers, move
  2 pure computation methods (get_interval_config,
  calculate_percentile) to public
- lib/Stats_Tool_Handler.cpp: remove static from 4 free helper
  functions (no behavioral change, only linkage visibility)

2 Commits (v3.0-CodeCov0325)