proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	1d2f16b506	test: add 4 more unit test files with 198 assertions (Tier 1) Expand coverage for charset lookups, GenAI Query/LLM/MCP components. New test files (test/tap/tests/unit/): Core: - charset_find_unit-t (62 tests): all 4 proxysql_find_charset functions — edge cases for NULL returns, utf8mb3→utf8 translation, case-insensitive matching, collation preference GenAI/MCP (PROXYSQLGENAI=1): - genai_query_handler_unit-t (65 tests): validate_sql_identifier, escape_string_literal, strip_leading_comments, json_string/ json_int/json_double safe extraction, is_pgsql_protocol, is_runtime_online_status, uppercase_or_unknown - genai_llm_clients_unit-t (35 tests): is_retryable_error HTTP status codes (408/429/5xx) and CURL error codes, plus LLM_WriteCallback data accumulation - genai_mcp_endpoint_unit-t (36 tests): validate_bearer_token extraction/comparison, create_jsonrpc_response/error JSON-RPC 2.0 formatting Minimal production changes for testability: - include/Query_Tool_Handler.h: friend class + extern declarations for 8 pure helper functions - lib/Query_Tool_Handler.cpp: remove static from 8 file-local pure functions (no behavioral change) - include/MCP_Endpoint.h: friend class + new static validate_bearer_token() extracted from authenticate_request() - lib/MCP_Endpoint.cpp: extract token validation into static method - lib/LLM_Clients.cpp: remove static from is_retryable_error() and rename WriteCallback to LLM_WriteCallback (avoid collisions) Running totals: 15 test files, 718 assertions, all passing.	2 months ago

Author

SHA1

Message

Date

Rene Cannao

1d2f16b506

test: add 4 more unit test files with 198 assertions (Tier 1)

Expand coverage for charset lookups, GenAI Query/LLM/MCP components.

New test files (test/tap/tests/unit/):

  Core:
  - charset_find_unit-t (62 tests): all 4 proxysql_find_charset
    functions — edge cases for NULL returns, utf8mb3→utf8
    translation, case-insensitive matching, collation preference

  GenAI/MCP (PROXYSQLGENAI=1):
  - genai_query_handler_unit-t (65 tests): validate_sql_identifier,
    escape_string_literal, strip_leading_comments, json_string/
    json_int/json_double safe extraction, is_pgsql_protocol,
    is_runtime_online_status, uppercase_or_unknown
  - genai_llm_clients_unit-t (35 tests): is_retryable_error HTTP
    status codes (408/429/5xx) and CURL error codes, plus
    LLM_WriteCallback data accumulation
  - genai_mcp_endpoint_unit-t (36 tests): validate_bearer_token
    extraction/comparison, create_jsonrpc_response/error JSON-RPC
    2.0 formatting

Minimal production changes for testability:
- include/Query_Tool_Handler.h: friend class + extern declarations
  for 8 pure helper functions
- lib/Query_Tool_Handler.cpp: remove static from 8 file-local
  pure functions (no behavioral change)
- include/MCP_Endpoint.h: friend class + new static
  validate_bearer_token() extracted from authenticate_request()
- lib/MCP_Endpoint.cpp: extract token validation into static method
- lib/LLM_Clients.cpp: remove static from is_retryable_error() and
  rename WriteCallback to LLM_WriteCallback (avoid collisions)

Running totals: 15 test files, 718 assertions, all passing.

1 Commits (v3.0-CodeCov0325)