proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	051435f810	Address review feedback on auth unit tests (PR #5485 ) - Add null guards before strcmp() in test_mysql_add_overwrites and test_mysql_frontend_backend_separation to prevent segfaults on unexpected lookup failures - Fix misleading "skipped - null" message in SHA1 test fallback to clearly indicate an unexpected null - Free sha1 pointer in PgSQL lookup test to prevent potential memory leak if sha1_pass is ever set - Enhance test_mysql_clear_text_password to verify stored PRIMARY and ADDITIONAL passwords are actually retrievable via lookup(), not just that set_clear_text_password() returns true (2 new test cases, plan updated from 58 to 60)	2 months ago
René Cannaò	2e52deffd4	Add MySQL/PgSQL Authentication unit tests (Phase 2.2, #5474 ) Comprehensive unit tests for MySQL_Authentication and PgSQL_Authentication covering 58 test cases across 13 test functions. Runs in <0.01s with no infrastructure dependencies. MySQL_Authentication coverage: - Core CRUD: add/exists/lookup/del with frontend and backend users - Duplicate handling: add() overwrites password, hostgroup, max_connections - exists() only checks frontends (not backends) — documented quirk - lookup() returns empty struct for nonexistent users - SHA1 credential storage and retrieval via set_SHA1() - Clear-text password management (PRIMARY and ADDITIONAL slots) - Connection counting: increase/decrease with max_connections enforcement - Bulk operations: set_all_inactive + remove_inactives config reload pattern - reset() clears all frontend and backend users - Runtime checksum: zero when empty, changes on add/modify - Memory tracking: increases on add, returns to baseline on reset - Frontend/backend separation: same username, different credentials PgSQL_Authentication coverage: - Core CRUD with PgSQL-specific lookup() signature (returns char*) - del() and reset() behavior - Connection counting (no PASSWORD_TYPE parameter) - Inactive pattern (set_all_inactive + remove_inactives)	2 months ago

Author

SHA1

Message

Date

René Cannaò

051435f810

Address review feedback on auth unit tests (PR #5485 )

- Add null guards before strcmp() in test_mysql_add_overwrites and
  test_mysql_frontend_backend_separation to prevent segfaults on
  unexpected lookup failures

- Fix misleading "skipped - null" message in SHA1 test fallback to
  clearly indicate an unexpected null

- Free sha1 pointer in PgSQL lookup test to prevent potential memory
  leak if sha1_pass is ever set

- Enhance test_mysql_clear_text_password to verify stored PRIMARY and
  ADDITIONAL passwords are actually retrievable via lookup(), not just
  that set_clear_text_password() returns true (2 new test cases, plan
  updated from 58 to 60)

René Cannaò

2e52deffd4

Add MySQL/PgSQL Authentication unit tests (Phase 2.2, #5474 )

Comprehensive unit tests for MySQL_Authentication and PgSQL_Authentication
covering 58 test cases across 13 test functions. Runs in <0.01s with no
infrastructure dependencies.

MySQL_Authentication coverage:
- Core CRUD: add/exists/lookup/del with frontend and backend users
- Duplicate handling: add() overwrites password, hostgroup, max_connections
- exists() only checks frontends (not backends) — documented quirk
- lookup() returns empty struct for nonexistent users
- SHA1 credential storage and retrieval via set_SHA1()
- Clear-text password management (PRIMARY and ADDITIONAL slots)
- Connection counting: increase/decrease with max_connections enforcement
- Bulk operations: set_all_inactive + remove_inactives config reload pattern
- reset() clears all frontend and backend users
- Runtime checksum: zero when empty, changes on add/modify
- Memory tracking: increases on add, returns to baseline on reset
- Frontend/backend separation: same username, different credentials

PgSQL_Authentication coverage:
- Core CRUD with PgSQL-specific lookup() signature (returns char*)
- del() and reset() behavior
- Connection counting (no PASSWORD_TYPE parameter)
- Inactive pattern (set_all_inactive + remove_inactives)

2 Commits (v3.0-CodeCov0325)